198941 2019-06-17 16:51:23 -0700 Web Inspector: REGRESSION: Heap: subsequent snapshots taken manually don't appear in the list 2019-06-18 12:34:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1545467 0 hi 2019-06-17 16:51:23 -0700 # STEPS TO REPRODUCE: 1. inspect any page 2. go to the Timelines tab 3. enable "JavaScript Allocations" 4. take a heap snapshot => the [S] appears in the graph area and in the "Snapshot List" area 5. take another heap snapshot => the [S] appears in the graph area, but _not_ in the "Snapshot List" area 1545541 1 hi 2019-06-17 21:26:45 -0700 Interestingly, it looks like it's only an issue when the entire recording is selected (e.g. double clicking the overview graph area). 1545548 2 372323 hi 2019-06-17 21:47:54 -0700 Created attachment 372323 Patch 1545549 3 372324 hi 2019-06-17 21:49:03 -0700 Created attachment 372324 Patch webkit-patch didn't catch my last changes :( 1545696 4 372324 joepeck 2019-06-18 11:44:00 -0700 Comment on attachment 372324 Patch Nice, r=me 1545725 5 372324 commit-queue 2019-06-18 12:33:48 -0700 Comment on attachment 372324 Patch Clearing flags on attachment: 372324 Committed r246558: <https://trac.webkit.org/changeset/246558> 1545726 6 commit-queue 2019-06-18 12:33:49 -0700 All reviewed patches have been landed. Closing bug. 1545727 7 webkit-bug-importer 2019-06-18 12:34:28 -0700 <rdar://problem/51860940> 372323 2019-06-17 21:47:54 -0700 2019-06-17 21:49:02 -0700 Patch bug-198941-20190617214753.patch text/plain 2687 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA3OWNmMDFhNzc2NmZlZTM0NWMzNTdiOTQ4OTY0 MmViNWYwMWNjYmEuLjMxMDk2YjdhMTAwNWZlZDIyNjI0MjVmNTdjMTA5N2ZiYWIwMzNmZWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBIZWFwOiBzdWJzZXF1ZW50IHNuYXBzaG90cyB0YWtlbiBtYW51YWxseSBkb24n dCBhcHBlYXIgaW4gdGhlIGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5ODk0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNpbmNlIGhlYXAgc25hcHNob3QgcmVjb3JkcyBjYW4gYmUgYWRkZWQgYXQg YW55IHRpbWUsIGluY2x1ZGluZyB3aGVuIG5vdCBhY3RpdmVseSByZWNvcmRpbmcsCisgICAgICAg IHdoZW4gdGhlICJFbnRpcmUgUmVjb3JkaW5nIiByYW5nZSBpcyBzZWxlY3RlZCwgbWFrZSBzdXJl IHRvIHNldCB0aGUgYGZpbHRlckVuZFRpbWVgIHRvIGJlIGFuCisgICAgICAgIGVmZmVjdGl2ZWx5 IGluZmluaXRlIG51bWJlciBzbyB0aGF0IHJlY29yZHMgYWRkZWQgbGF0ZXIgYXJlbid0IGZpbHRl cmVkIG91dC4KKworICAgICAgICBUaGlzIGlzbid0IGRvbmUgZm9yIG90aGVyIHRpbWVsaW5lIHZp ZXdzIGFzIHRoZXkgbWF5IGhhdmUgZ3JhcGhzIHRoYXQgZG9uJ3QgZXhwZWN0IHRvIHJlbmRlcgor ICAgICAgICBmcm9tIHRpbWUgMCB0aWxsIGluZmluaXR5LCBub3QgdG8gbWVudGlvbiBiZWluZyB1 bmFibGUgdG8gYWRkIHJlY29yZHMgd2hlbiBub3QgcmVjb3JkaW5nLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzOgorICAgICAg ICAoV0kuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuX3VwZGF0ZVRpbWVs aW5lVmlld1RpbWVzKToKKwogMjAxOS0wNi0xNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2V0dGluZ3M6IHNwbGl0IHRoZSBHZW5l cmFsIHBhbmVsIGludG8gc3ViIHBhbmVscyBzbyBpdCdzIGxlc3MgY3Jvd2RlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNv cmRpbmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKaW5kZXggYTZiN2JkNjg1MjJk ZTdlMTBiNmY3ZTZkNWNjYjhmN2U4NDUzMjVkNS4uNzQ2NTEzMjU2ZTZkN2VjNjBmNjgxODUwZjc1 NWU3ZWQ2ZTdjYjgxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRl bnRWaWV3LmpzCkBAIC04MzYsOCArODM2LDEyIEBAIFdJLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuCiAg ICAgICAgIGxldCBlbmRUaW1lID0gdGhpcy5fdGltZWxpbmVPdmVydmlldy5zZWxlY3Rpb25TdGFy dFRpbWUgKyB0aGlzLl90aW1lbGluZU92ZXJ2aWV3LnNlbGVjdGlvbkR1cmF0aW9uOwogCiAgICAg ICAgIGlmIChlbnRpcmVSYW5nZVNlbGVjdGVkKSB7Ci0gICAgICAgICAgICBpZiAodGltZWxpbmVW aWV3IGluc3RhbmNlb2YgV0kuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVZpZXcpIHsKKyAgICAgICAg ICAgIGlmICh0aW1lbGluZVZpZXcgaW5zdGFuY2VvZiBXSS5SZW5kZXJpbmdGcmFtZVRpbWVsaW5l VmlldykKICAgICAgICAgICAgICAgICBlbmRUaW1lID0gdGhpcy5fcmVuZGVyaW5nRnJhbWVUaW1l bGluZS5yZWNvcmRzLmxlbmd0aDsKKyAgICAgICAgICAgIGVsc2UgaWYgKHRpbWVsaW5lVmlldyBp bnN0YW5jZW9mIFdJLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldykgeworICAgICAgICAgICAg ICAgIC8vIFNpbmNlIGhlYXAgc25hcHNob3RzIGNhbiBiZSBhZGRlZCBhdCBhbnkgdGltZSwgaW5j bHVkaW5nIHdoZW4gbm90IGFjdGl2ZWx5IHJlY29yZGluZywKKyAgICAgICAgICAgICAgICAvLyBt YWtlIHN1cmUgdG8gc2V0IHRoZSBlbmQgdGltZSB0byBhbiBlZmZlY3RpdmVseSBpbmZpbml0ZSBu dW1iZXIuCisgICAgICAgICAgICAgICAgZW5kVGltZSA9IE51bWJlci5NQVhfVkFMVUU7CiAgICAg ICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgICAgIC8vIENsYW1wIHNlbGVjdGlvbiB0byB0 aGUgZW5kIG9mIHRoZSByZWNvcmRpbmcgKHdpdGggcGFkZGluZyksCiAgICAgICAgICAgICAgICAg Ly8gc28gZ3JhcGggdmlld3Mgd2lsbCBzaG93IGFuIGF1dG8tc2l6ZWQgZ3JhcGggd2l0aG91dCBh IGxvdCBvZgo= 372324 2019-06-17 21:49:03 -0700 2019-06-18 12:33:48 -0700 Patch bug-198941-20190617214903.patch text/plain 2775 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA3OWNmMDFhNzc2NmZlZTM0NWMzNTdiOTQ4OTY0 MmViNWYwMWNjYmEuLjMxMDk2YjdhMTAwNWZlZDIyNjI0MjVmNTdjMTA5N2ZiYWIwMzNmZWEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE5LTA2LTE3ICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBS RUdSRVNTSU9OOiBIZWFwOiBzdWJzZXF1ZW50IHNuYXBzaG90cyB0YWtlbiBtYW51YWxseSBkb24n dCBhcHBlYXIgaW4gdGhlIGxpc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE5ODk0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFNpbmNlIGhlYXAgc25hcHNob3QgcmVjb3JkcyBjYW4gYmUgYWRkZWQgYXQg YW55IHRpbWUsIGluY2x1ZGluZyB3aGVuIG5vdCBhY3RpdmVseSByZWNvcmRpbmcsCisgICAgICAg IHdoZW4gdGhlICJFbnRpcmUgUmVjb3JkaW5nIiByYW5nZSBpcyBzZWxlY3RlZCwgbWFrZSBzdXJl IHRvIHNldCB0aGUgYGZpbHRlckVuZFRpbWVgIHRvIGJlIGFuCisgICAgICAgIGVmZmVjdGl2ZWx5 IGluZmluaXRlIG51bWJlciBzbyB0aGF0IHJlY29yZHMgYWRkZWQgbGF0ZXIgYXJlbid0IGZpbHRl cmVkIG91dC4KKworICAgICAgICBUaGlzIGlzbid0IGRvbmUgZm9yIG90aGVyIHRpbWVsaW5lIHZp ZXdzIGFzIHRoZXkgbWF5IGhhdmUgZ3JhcGhzIHRoYXQgZG9uJ3QgZXhwZWN0IHRvIHJlbmRlcgor ICAgICAgICBmcm9tIHRpbWUgMCB0aWxsIGluZmluaXR5LCBub3QgdG8gbWVudGlvbiBiZWluZyB1 bmFibGUgdG8gYWRkIHJlY29yZHMgd2hlbiBub3QgcmVjb3JkaW5nLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3LmpzOgorICAgICAg ICAoV0kuVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5wcm90b3R5cGUuX3VwZGF0ZVRpbWVs aW5lVmlld1RpbWVzKToKKwogMjAxOS0wNi0xNyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0BhcHBs ZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogU2V0dGluZ3M6IHNwbGl0IHRoZSBHZW5l cmFsIHBhbmVsIGludG8gc3ViIHBhbmVscyBzbyBpdCdzIGxlc3MgY3Jvd2RlZApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSZWNv cmRpbmdDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL1RpbWVsaW5lUmVjb3JkaW5nQ29udGVudFZpZXcuanMKaW5kZXggYTZiN2JkNjg1MjJk ZTdlMTBiNmY3ZTZkNWNjYjhmN2U4NDUzMjVkNS4uNDBmNmM3M2FhYzE4NDVmZmYyN2YzNzMzOWY3 YTJlODIxYTA0YWI5NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvVGltZWxpbmVSZWNvcmRpbmdDb250ZW50Vmlldy5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJlY29yZGluZ0NvbnRl bnRWaWV3LmpzCkBAIC04MzYsOCArODM2LDEzIEBAIFdJLlRpbWVsaW5lUmVjb3JkaW5nQ29udGVu dFZpZXcgPSBjbGFzcyBUaW1lbGluZVJlY29yZGluZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV0kuCiAg ICAgICAgIGxldCBlbmRUaW1lID0gdGhpcy5fdGltZWxpbmVPdmVydmlldy5zZWxlY3Rpb25TdGFy dFRpbWUgKyB0aGlzLl90aW1lbGluZU92ZXJ2aWV3LnNlbGVjdGlvbkR1cmF0aW9uOwogCiAgICAg ICAgIGlmIChlbnRpcmVSYW5nZVNlbGVjdGVkKSB7Ci0gICAgICAgICAgICBpZiAodGltZWxpbmVW aWV3IGluc3RhbmNlb2YgV0kuUmVuZGVyaW5nRnJhbWVUaW1lbGluZVZpZXcpIHsKKyAgICAgICAg ICAgIGlmICh0aW1lbGluZVZpZXcgaW5zdGFuY2VvZiBXSS5SZW5kZXJpbmdGcmFtZVRpbWVsaW5l VmlldykKICAgICAgICAgICAgICAgICBlbmRUaW1lID0gdGhpcy5fcmVuZGVyaW5nRnJhbWVUaW1l bGluZS5yZWNvcmRzLmxlbmd0aDsKKyAgICAgICAgICAgIGVsc2UgaWYgKHRpbWVsaW5lVmlldyBp bnN0YW5jZW9mIFdJLkhlYXBBbGxvY2F0aW9uc1RpbWVsaW5lVmlldykgeworICAgICAgICAgICAg ICAgIC8vIFNpbmNlIGhlYXAgc25hcHNob3RzIGNhbiBiZSBhZGRlZCBhdCBhbnkgdGltZSwgaW5j bHVkaW5nIHdoZW4gbm90IGFjdGl2ZWx5IHJlY29yZGluZywKKyAgICAgICAgICAgICAgICAvLyBt YWtlIHN1cmUgdG8gc2V0IHRoZSBlbmQgdGltZSB0byBhbiBlZmZlY3RpdmVseSBpbmZpbml0ZSBu dW1iZXIgc28gYW55IG5ldyByZWNvcmRzCisgICAgICAgICAgICAgICAgLy8gdGhhdCBhcmUgYWRk ZWQgaW4gdGhlIGZ1dHVyZSBhcmVuJ3QgZmlsdGVyZWQgb3V0LgorICAgICAgICAgICAgICAgIGVu ZFRpbWUgPSBOdW1iZXIuTUFYX1ZBTFVFOwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAg ICAgICAgICAvLyBDbGFtcCBzZWxlY3Rpb24gdG8gdGhlIGVuZCBvZiB0aGUgcmVjb3JkaW5nICh3 aXRoIHBhZGRpbmcpLAogICAgICAgICAgICAgICAgIC8vIHNvIGdyYXBoIHZpZXdzIHdpbGwgc2hv dyBhbiBhdXRvLXNpemVkIGdyYXBoIHdpdGhvdXQgYSBsb3Qgb2YK