198934 2019-06-17 15:13:44 -0700 [WHLSL] Remove backtracking from parseAttributeBlock 2019-06-17 16:08:18 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198357 1 rmorisset rmorisset commit-queue mmaxfield webkit-bug-importer oldest_to_newest 1545405 0 rmorisset 2019-06-17 15:13:44 -0700 It is one of 3 places left in the parser that use backtrackingScope, and it is by far the simplest to remove. 1545406 1 372277 rmorisset 2019-06-17 15:16:28 -0700 Created attachment 372277 Patch 1545433 2 372277 commit-queue 2019-06-17 16:07:38 -0700 Comment on attachment 372277 Patch Clearing flags on attachment: 372277 Committed r246520: <https://trac.webkit.org/changeset/246520> 1545434 3 commit-queue 2019-06-17 16:07:39 -0700 All reviewed patches have been landed. Closing bug. 1545435 4 webkit-bug-importer 2019-06-17 16:08:18 -0700 <rdar://problem/51825612> 372277 2019-06-17 15:16:28 -0700 2019-06-17 16:07:38 -0700 Patch patch198934 text/plain 1804 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5NDcxMWMyYmE3Ni4uZTY4MzE5MDdiNTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxOS0wNi0xNyAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtXSExTTF0gUmVtb3ZlIGJhY2t0cmFja2luZyBmcm9tIHBhcnNlQXR0 cmlidXRlQmxvY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE5ODkzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE5vIGZ1bmN0aW9uYWwgY2hhbmdlIGludGVuZGVkLgorCisgICAgICAgIFRlc3RlZCBieSBy dW5uaW5nIExheW91dFRlc3RzL3dlYmdwdS93aGxzbC1jb21wdXRlLmh0bWwKKworICAgICAgICAq IE1vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMUGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OldITFNMOjpQYXJzZXI6OnBhcnNlQXR0cmlidXRlQmxvY2spOgorCiAyMDE5LTA2LTE3ICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJv bGxpbmcgb3V0IHIyNDY1MDEuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmdwdS9XSExTTC9XSExTTFBhcnNlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdw dS9XSExTTC9XSExTTFBhcnNlci5jcHAKaW5kZXggNmVmMzRkYTU2YTIuLjRmYTVjNmU2NWVlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTFBhcnNl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xQYXJz ZXIuY3BwCkBAIC04NTQsMTkgKzg1NCwxMiBAQCBhdXRvIFBhcnNlcjo6cGFyc2VBdHRyaWJ1dGVC bG9jaygpIC0+IEV4cGVjdGVkPEFTVDo6QXR0cmlidXRlQmxvY2ssIEVycm9yPgogICAgIEFTVDo6 QXR0cmlidXRlQmxvY2sgcmVzdWx0OwogCiAgICAgd2hpbGUgKHRydWUpIHsKLSAgICAgICAgYXV0 byBudW1UaHJlYWRzRnVuY3Rpb25BdHRyaWJ1dGUgPSBiYWNrdHJhY2tpbmdTY29wZTxFeHBlY3Rl ZDxBU1Q6Ok51bVRocmVhZHNGdW5jdGlvbkF0dHJpYnV0ZSwgRXJyb3I+PihbJl0oKSB7Ci0gICAg ICAgICAgICByZXR1cm4gcGFyc2VOdW1UaHJlYWRzRnVuY3Rpb25BdHRyaWJ1dGUoKTsKLSAgICAg ICAgfSk7Ci0gICAgICAgIGlmIChudW1UaHJlYWRzRnVuY3Rpb25BdHRyaWJ1dGUpIHsKLSAgICAg ICAgICAgIHJlc3VsdC5hcHBlbmQoV1RGTW92ZSgqbnVtVGhyZWFkc0Z1bmN0aW9uQXR0cmlidXRl KSk7Ci0gICAgICAgICAgICBjb250aW51ZTsKLSAgICAgICAgfQotCi0gICAgICAgIGJyZWFrOwor ICAgICAgICBpZiAodHJ5VHlwZShMZXhlcjo6VG9rZW46OlR5cGU6OlJpZ2h0U3F1YXJlQnJhY2tl dCkpCisgICAgICAgICAgICBicmVhazsKKyAgICAgICAgUEFSU0UobnVtVGhyZWFkc0Z1bmN0aW9u QXR0cmlidXRlLCBOdW1UaHJlYWRzRnVuY3Rpb25BdHRyaWJ1dGUpOworICAgICAgICByZXN1bHQu YXBwZW5kKFdURk1vdmUoKm51bVRocmVhZHNGdW5jdGlvbkF0dHJpYnV0ZSkpOwogICAgIH0KIAot ICAgIENPTlNVTUVfVFlQRShyaWdodFNxdWFyZUJyYWNrZXQsIFJpZ2h0U3F1YXJlQnJhY2tldCk7 Ci0KICAgICByZXR1cm4gV1RGTW92ZShyZXN1bHQpOwogfQogCg==