198916 2019-06-17 07:53:38 -0700 [GStreamer] Identify elements with monotonically increasing counters 2019-06-18 07:49:30 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris tsaunier webkit-bug-importer oldest_to_newest 1545245 0 pnormand 2019-06-17 07:53:38 -0700 . 1545246 1 372245 pnormand 2019-06-17 07:59:24 -0700 Created attachment 372245 Patch 1545565 2 372245 calvaris 2019-06-17 23:59:35 -0700 Comment on attachment 372245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=372245&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2389 > + static Atomic<uint32_t> pipelineId = 0; I guess you don't need to initialize this because it is the only place were you do it. 1545606 3 pnormand 2019-06-18 07:48:08 -0700 Committed r246537: <https://trac.webkit.org/changeset/246537> 1545607 4 webkit-bug-importer 2019-06-18 07:49:30 -0700 <rdar://problem/51848852> 372245 2019-06-17 07:59:24 -0700 2019-06-17 23:59:35 -0700 Patch bug-198916-20190617155923.patch text/plain 5035 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGRlMDRhZDcxZmRiM2U4 NTgyM2FmZWEyZDUxZTYyYThkYmE3ZTQ0OC4uMWQ0YmY2OGYyYTU1M2VhNjhlOTkzNjMwZjlmMzEw ODBlYjBhOGU0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA2LTE3ICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBJZGVudGlmeSBlbGVtZW50cyB3aXRoIG1vbm90b25pY2FsbHkgaW5jcmVhc2luZyBjb3VudGVy cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4OTE2 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhvc2Ug aWRzIHRlbmQgdG8gYmUgc2hvcnRlciwgZWFzaWVyIHRvIHJlYWQgZm9yIGh1bWFucyBhbmQgZm9y CisgICAgICAgIGRpZmYgdG9vbHMgOikgVW5kZXJzY29yZXMgd2VyZSBhbHNvIHJlcGxhY2VkIGJ5 IGRhc2hlcywgZm9yCisgICAgICAgIGNvbnNpc3RlbmN5IHdpdGggdGhlIHVzdWFsIEdTdHJlYW1l ciBlbGVtZW50IG5hbWluZyB1bnRvbGQKKyAgICAgICAgY29udmVudGlvbnMuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bG9h ZCk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmNyZWF0 ZUdTVFBsYXlCaW4pOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9H U3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkdTdHJl YW1lclZpZGVvRW5jb2Rlcjo6bWFrZUVsZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6R1N0cmVh bWVyVmlkZW9FbmNvZGVyOjpJbml0RW5jb2RlKToKKwogMjAxOS0wNi0xNyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjI0NjQ2Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lci5jcHAKaW5kZXggMGUwODM1YjAxZjhhY2Q5ZDAzMzAwNTIwNjg2ZjA1YTI3MGUxM2Iy ZC4uZDg3YmJiYTA5YWU2MjY2YmYzNjVjMWM3MWI0MzRmNWM5MTAxZGY4OCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTQzLDcgKzQzLDYg QEAKICNpbmNsdWRlIDxnc3QvcGJ1dGlscy9taXNzaW5nLXBsdWdpbnMuaD4KICNpbmNsdWRlIDxs aW1pdHM+CiAjaW5jbHVkZSA8d3RmL0ZpbGVTeXN0ZW0uaD4KLSNpbmNsdWRlIDx3dGYvSGV4TnVt YmVyLmg+CiAjaW5jbHVkZSA8d3RmL01lZGlhVGltZS5oPgogI2luY2x1ZGUgPHd0Zi9OZXZlckRl c3Ryb3llZC5oPgogI2luY2x1ZGUgPHd0Zi9TdHJpbmdQcmludFN0cmVhbS5oPgpAQCAtMzI3LDkg KzMyNiwxMCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bG9hZChNZWRpYVN0 cmVhbVByaXZhdGUmIHN0cmVhbSkKIHsKICNpZiBHU1RfQ0hFQ0tfVkVSU0lPTigxLCAxMCwgMCkK ICAgICBtX3N0cmVhbVByaXZhdGUgPSAmc3RyZWFtOwotICAgIGF1dG8gcGlwZWxpbmVOYW1lID0g bWFrZVN0cmluZygibWVkaWFzdHJlYW1fIiwKLSAgICAgICAgKHN0cmVhbS5oYXNDYXB0dXJlVmlk ZW9Tb3VyY2UoKSB8fCBzdHJlYW0uaGFzQ2FwdHVyZUF1ZGlvU291cmNlKCkpID8gIkxvY2FsIiA6 ICJSZW1vdGUiLAotICAgICAgICAiXzB4IiwgaGV4KHJlaW50ZXJwcmV0X2Nhc3Q8dWludHB0cl90 Pih0aGlzKSwgTG93ZXJjYXNlKSk7CisgICAgc3RhdGljIEF0b21pYzx1aW50MzJfdD4gcGlwZWxp bmVJZDsKKyAgICBhdXRvIHBpcGVsaW5lTmFtZSA9IG1ha2VTdHJpbmcoIm1lZGlhc3RyZWFtLSIs CisgICAgICAgIChzdHJlYW0uaGFzQ2FwdHVyZVZpZGVvU291cmNlKCkgfHwgc3RyZWFtLmhhc0Nh cHR1cmVBdWRpb1NvdXJjZSgpKSA/ICJsb2NhbCIgOiAicmVtb3RlIiwKKyAgICAgICAgIi0iLCBw aXBlbGluZUlkLmV4Y2hhbmdlQWRkKDEpKTsKIAogICAgIGxvYWRGdWxsKFN0cmluZygibWVkaWFz dHJlYW06Ly8iKSArIHN0cmVhbS5pZCgpLCBwaXBlbGluZU5hbWUpOwogICAgIHN5bmNPbkNsb2Nr KGZhbHNlKTsKQEAgLTIzODYsOCArMjM4Niw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0 cmVhbWVyOjpjcmVhdGVHU1RQbGF5QmluKGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmCiAK ICAgICAvLyBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoKSByZXR1cm5zIGEgZmxvYXRpbmcgcmVm ZXJlbmNlIHNvCiAgICAgLy8gd2Ugc2hvdWxkIG5vdCBhZG9wdC4KKyAgICBzdGF0aWMgQXRvbWlj PHVpbnQzMl90PiBwaXBlbGluZUlkID0gMDsKICAgICBzZXRQaXBlbGluZShnc3RfZWxlbWVudF9m YWN0b3J5X21ha2UocGxheWJpbk5hbWUsCi0gICAgICAgIChwaXBlbGluZU5hbWUuaXNFbXB0eSgp ID8gbWFrZVN0cmluZygicGxheV8weCIsIGhleChyZWludGVycHJldF9jYXN0PHVpbnRwdHJfdD4o dGhpcyksIExvd2VyY2FzZSkpIDogcGlwZWxpbmVOYW1lKS51dGY4KCkuZGF0YSgpKSk7CisgICAg ICAgIChwaXBlbGluZU5hbWUuaXNFbXB0eSgpID8gbWFrZVN0cmluZygibWVkaWEtcGxheWVyLSIs IHBpcGVsaW5lSWQuZXhjaGFuZ2VBZGQoMSkpIDogcGlwZWxpbmVOYW1lKS51dGY4KCkuZGF0YSgp KSk7CiAgICAgc2V0U3RyZWFtVm9sdW1lRWxlbWVudChHU1RfU1RSRUFNX1ZPTFVNRShtX3BpcGVs aW5lLmdldCgpKSk7CiAKICAgICBHU1RfSU5GT19PQkpFQ1QocGlwZWxpbmUoKSwgIlVzaW5nIGxl Z2FjeSBwbGF5YmluIGVsZW1lbnQ6ICVzIiwgYm9vbEZvclByaW50aW5nKG1faXNMZWdhY3lQbGF5 YmluKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9s aWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNvZGVyRmFjdG9yeS5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvR1N0cmVhbWVyVmlkZW9FbmNvZGVyRmFj dG9yeS5jcHAKaW5kZXggNTlkYmZmYTcyZDc0YzI4MTY0NTgzMmMzZWE5ZDQxMjlhNDRiZTBhMS4u NzkxOWJjYzEzZjE1MjMzNTdlNmMyNzcxNTIyNWU3ODFmY2JkMzAwNyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGlid2VicnRjL0dTdHJlYW1lclZpZGVv RW5jb2RlckZhY3RvcnkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2xpYndlYnJ0Yy9HU3RyZWFtZXJWaWRlb0VuY29kZXJGYWN0b3J5LmNwcApAQCAtNDEsMTAg KzQxLDExIEBACiAjdW5kZWYgR1NUX1VTRV9VTlNUQUJMRV9BUEkKICNpbmNsdWRlIDxnc3QvcGJ1 dGlscy9lbmNvZGluZy1wcm9maWxlLmg+CiAjaW5jbHVkZSA8Z3N0L3ZpZGVvL3ZpZGVvLmg+Cisj aW5jbHVkZSA8d3RmL0F0b21pY3MuaD4KICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgotI2luY2x1 ZGUgPHd0Zi9IZXhOdW1iZXIuaD4KICNpbmNsdWRlIDx3dGYvTG9jay5oPgogI2luY2x1ZGUgPHd0 Zi9TdGRNYXAuaD4KKyNpbmNsdWRlIDx3dGYvdGV4dC9TdHJpbmdDb25jYXRlbmF0ZU51bWJlcnMu aD4KIAogLy8gUmVxdWlyZWQgZm9yIHVuaWZpZWQgYnVpbGRzCiAjaWZkZWYgR1NUX0NBVF9ERUZB VUxUCkBAIC05NSw3ICs5Niw4IEBAIHB1YmxpYzoKIAogICAgIEdzdEVsZW1lbnQqIG1ha2VFbGVt ZW50KGNvbnN0IGdjaGFyKiBmYWN0b3J5TmFtZSkKICAgICB7Ci0gICAgICAgIGF1dG8gbmFtZSA9 IG1ha2VTdHJpbmcoTmFtZSgpLCAiX2VuY18iLCBmYWN0b3J5TmFtZSwgIl8weCIsIGhleChyZWlu dGVycHJldF9jYXN0PHVpbnRwdHJfdD4odGhpcykpKTsKKyAgICAgICAgc3RhdGljIEF0b21pYzx1 aW50MzJfdD4gZWxlbWVudElkOworICAgICAgICBhdXRvIG5hbWUgPSBtYWtlU3RyaW5nKE5hbWUo KSwgIi1lbmMtIiwgZmFjdG9yeU5hbWUsICItIiwgZWxlbWVudElkLmV4Y2hhbmdlQWRkKDEpKTsK ICAgICAgICAgYXV0byBlbGVtID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKGZhY3RvcnlOYW1l LCBuYW1lLnV0ZjgoKS5kYXRhKCkpOwogCiAgICAgICAgIHJldHVybiBlbGVtOwpAQCAtMTM2LDgg KzEzOCw3IEBAIHB1YmxpYzoKICAgICAgICAgbV9zaW5rID0gbWFrZUVsZW1lbnQoImFwcHNpbmsi KTsKICAgICAgICAgZ19vYmplY3Rfc2V0KG1fc2luaywgInN5bmMiLCBGQUxTRSwgbnVsbHB0cik7 CiAKLSAgICAgICAgYXV0byBuYW1lID0gbWFrZVN0cmluZyhOYW1lKCksICJfZW5jX3Jhd2NhcHNm aWx0ZXJfMHgiLCBoZXgocmVpbnRlcnByZXRfY2FzdDx1aW50cHRyX3Q+KHRoaXMpKSk7Ci0gICAg ICAgIG1fY2Fwc0ZpbHRlciA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFrZSgiY2Fwc2ZpbHRlciIs IG5hbWUudXRmOCgpLmRhdGEoKSk7CisgICAgICAgIG1fY2Fwc0ZpbHRlciA9IG1ha2VFbGVtZW50 KCJjYXBzZmlsdGVyIik7CiAgICAgICAgIGlmIChtX3Jlc3RyaWN0aW9uQ2FwcykKICAgICAgICAg ICAgIGdfb2JqZWN0X3NldChtX2NhcHNGaWx0ZXIsICJjYXBzIiwgbV9yZXN0cmljdGlvbkNhcHMu Z2V0KCksIG51bGxwdHIpOwogCg==