198892 2019-06-15 15:34:28 -0700 [LFC][IFC] Remove Line::Content::isVisuallyEmpty 2019-06-16 12:33:01 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1545055 0 zalan 2019-06-15 15:34:28 -0700 reset the line height instead. 1545056 1 webkit-bug-importer 2019-06-15 15:34:50 -0700 <rdar://problem/51780345> 1545057 2 372200 zalan 2019-06-15 15:37:57 -0700 Created attachment 372200 Patch 1545151 3 372200 commit-queue 2019-06-16 12:33:00 -0700 Comment on attachment 372200 Patch Clearing flags on attachment: 372200 Committed r246478: <https://trac.webkit.org/changeset/246478> 1545152 4 commit-queue 2019-06-16 12:33:01 -0700 All reviewed patches have been landed. Closing bug. 372200 2019-06-15 15:37:57 -0700 2019-06-16 12:33:00 -0700 Patch bug-198892-20190615153757.patch text/plain 5460 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWU0OGFiYzJmMGQ3YjNh MGE5MDYyNTRkNDIyYjllZDA5YjAxNGI5Yi4uN2ZkYmQ1NDI2NTk3MTUzZWI1ZDNmNGRkZDljZDdi ODdiMjRhYTc5YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE5LTA2LTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBSZW1vdmUg TGluZTo6Q29udGVudDo6aXNWaXN1YWxseUVtcHR5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg4OTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUx NzgwMzQ1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEluc3RlYWQgb2Ygc2V0dGluZyB0aGUgaXNWaXN1YWxseUVtcHR5IGZsYWcsIHJlc2V0IHRoZSBs aW5lIGhlaWdodCB0byAwLiAKKworICAgICAgICAqIGxheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpM YXlvdXQ6OklubGluZUZvcm1hdHRpbmdDb250ZXh0OjpMaW5lTGF5b3V0OjpjcmVhdGVEaXNwbGF5 UnVucyBjb25zdCk6CisgICAgICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGlu ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OmNsb3NlKToKKyAgICAgICAg KiBsYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmg6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OkxpbmU6OkNvbnRlbnQ6OmlzRW1wdHkgY29uc3QpOgorICAgICAgICAoV2ViQ29y ZTo6TGF5b3V0OjpMaW5lOjpDb250ZW50OjpzZXRCYXNlbGluZSk6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OkxpbmU6OkNvbnRlbnQ6OmlzVmlzdWFsbHlFbXB0eSBjb25zdCk6IERlbGV0ZWQu CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmU6OkNvbnRlbnQ6OnNldElzVmlzdWFsbHlF bXB0eSk6IERlbGV0ZWQuCisKIDIwMTktMDYtMTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxl LmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNdIEludHJ1ZGluZyBmbG9hdCBtYXkgcHJldmVudCBh ZGRpbmcgYW55IGlubGluZSBib3gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1hdHRpbmdDb250ZXh0TGluZUxheW91dC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29u dGV4dExpbmVMYXlvdXQuY3BwCmluZGV4IGEwOGFjNDFhZjEwNTUwMGM4Y2E0YzI1YzRmOTViMjk5 Y2JmYTVmZWQuLmU3NDAwODExYmEzN2I3ZTk2MTVhZDRjOWI2MDZkNzYzYTZiOGM2NDAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUZvcm1h dHRpbmdDb250ZXh0TGluZUxheW91dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lu bGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRMaW5lTGF5b3V0LmNwcApAQCAt MzI1LDcgKzMyNSw3IEBAIHZvaWQgSW5saW5lRm9ybWF0dGluZ0NvbnRleHQ6OkxpbmVMYXlvdXQ6 OmNyZWF0ZURpc3BsYXlSdW5zKGNvbnN0IExpbmU6OkNvbnRlbnQmCiAgICAgLy8gQSBsaW5lIGJv eCBpcyBhbHdheXMgdGFsbCBlbm91Z2ggZm9yIGFsbCBvZiB0aGUgYm94ZXMgaXQgY29udGFpbnMu CiAKICAgICAvLyBJZ25vcmUgdGhlIGluaXRpYWwgc3RydXQuCi0gICAgYXV0byBsaW5lQm94ID0g RGlzcGxheTo6UmVjdCB7IGxpbmVDb250ZW50LmxvZ2ljYWxUb3AoKSwgbGluZUNvbnRlbnQubG9n aWNhbExlZnQoKSwgMCwgIWxpbmVDb250ZW50LmlzVmlzdWFsbHlFbXB0eSgpID8gbGluZUNvbnRl bnQubG9naWNhbEhlaWdodCgpIDogTGF5b3V0VW5pdCB7IH0gfTsKKyAgICBhdXRvIGxpbmVCb3gg PSBEaXNwbGF5OjpSZWN0IHsgbGluZUNvbnRlbnQubG9naWNhbFRvcCgpLCBsaW5lQ29udGVudC5s b2dpY2FsTGVmdCgpLCAwLCBsaW5lQ29udGVudC5sb2dpY2FsSGVpZ2h0KCl9OwogICAgIC8vIENy ZWF0ZSBmaW5hbCBkaXNwbGF5IHJ1bnMuCiAgICAgYXV0byYgbGluZVJ1bnMgPSBsaW5lQ29udGVu dC5ydW5zKCk7CiAgICAgZm9yICh1bnNpZ25lZCBpbmRleCA9IDA7IGluZGV4IDwgbGluZVJ1bnMu c2l6ZSgpOyArK2luZGV4KSB7CkBAIC00MDcsOCArNDA3LDcgQEAgdm9pZCBJbmxpbmVGb3JtYXR0 aW5nQ29udGV4dDo6TGluZUxheW91dDo6Y3JlYXRlRGlzcGxheVJ1bnMoY29uc3QgTGluZTo6Q29u dGVudCYKICAgICB9CiAgICAgLy8gRklYTUUgbGluZWJveCBuZWVkcyB0byBiZSBhanVzdGVkIGFm dGVyIGNvbnRlbnQgYWxpZ25tZW50LgogICAgIG1fZm9ybWF0dGluZ1N0YXRlLmFkZExpbmVCb3go eyBsaW5lQm94LCBsaW5lQ29udGVudC5iYXNlbGluZSgpIH0pOwotICAgIGlmICghbGluZUNvbnRl bnQuaXNWaXN1YWxseUVtcHR5KCkpCi0gICAgICAgIGFsaWduUnVucyhtX2Zvcm1hdHRpbmdSb290 LnN0eWxlKCkudGV4dEFsaWduKCksIHByZXZpb3VzTGluZUxhc3RSdW5JbmRleC52YWx1ZU9yKC0x KSArIDEsIHdpZHRoQ29uc3RyYWludCAtIGxpbmVDb250ZW50LmxvZ2ljYWxXaWR0aCgpKTsKKyAg ICBhbGlnblJ1bnMobV9mb3JtYXR0aW5nUm9vdC5zdHlsZSgpLnRleHRBbGlnbigpLCBwcmV2aW91 c0xpbmVMYXN0UnVuSW5kZXgudmFsdWVPcigtMSkgKyAxLCB3aWR0aENvbnN0cmFpbnQgLSBsaW5l Q29udGVudC5sb2dpY2FsV2lkdGgoKSk7CiB9CiAKIHN0YXRpYyBPcHRpb25hbDxMYXlvdXRVbml0 PiBob3Jpem9udGFsQWRqdXN0bWVudEZvckFsaWdubWVudChUZXh0QWxpZ25Nb2RlIGFsaWduLCBM YXlvdXRVbml0IHJlbWFpbmluZ1dpZHRoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlv dXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmNwcAppbmRleCAxOTFmMTUzYzMxOTMwNDRh NTE3YzA5YWZlZTQ1MDRhOTBlMjcwYTE4Li41OGY5NGM2YTA5MTM4MTVjZTYyMDA0NjExYTYzZTky ZWZjYTc3ZWRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0 dGluZy9JbmxpbmVMaW5lLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9y bWF0dGluZy9JbmxpbmVMaW5lLmNwcApAQCAtODYsNiArODYsMTEgQEAgc3RkOjp1bmlxdWVfcHRy PExpbmU6OkNvbnRlbnQ+IExpbmU6OmNsb3NlKCkKIHsKICAgICByZW1vdmVUcmFpbGluZ1RyaW1t YWJsZUNvbnRlbnQoKTsKICAgICBpZiAoIW1fc2tpcFZlcnRpY2FsQWxpZ21lbnQpIHsKKyAgICAg ICAgaWYgKGlzVmlzdWFsbHlFbXB0eSgpKSB7CisgICAgICAgICAgICBtX2Jhc2VsaW5lID0geyB9 OworICAgICAgICAgICAgbV9jb250ZW50TG9naWNhbEhlaWdodCA9IHsgfTsKKyAgICAgICAgfQor CiAgICAgICAgIGZvciAoYXV0byYgcnVuIDogbV9jb250ZW50LT5ydW5zKCkpIHsKICAgICAgICAg ICAgIExheW91dFVuaXQgbG9naWNhbFRvcDsKICAgICAgICAgICAgIGF1dG8mIGlubGluZUl0ZW0g PSBydW4tPmlubGluZUl0ZW07CkBAIC0xMjEsNyArMTI2LDYgQEAgc3RkOjp1bmlxdWVfcHRyPExp bmU6OkNvbnRlbnQ+IExpbmU6OmNsb3NlKCkKICAgICAgICAgICAgIHJ1bi0+bG9naWNhbFJlY3Qu c2V0VG9wKGxvZ2ljYWxUb3ApOwogICAgICAgICB9CiAgICAgfQotICAgIG1fY29udGVudC0+c2V0 SXNWaXN1YWxseUVtcHR5KGlzVmlzdWFsbHlFbXB0eSgpKTsKICAgICBtX2NvbnRlbnQtPnNldExv Z2ljYWxSZWN0KHsgbG9naWNhbFRvcCgpLCBsb2dpY2FsTGVmdCgpLCBjb250ZW50TG9naWNhbFdp ZHRoKCksIGxvZ2ljYWxIZWlnaHQoKSB9KTsKICAgICBtX2NvbnRlbnQtPnNldEJhc2VsaW5lKG1f YmFzZWxpbmUpOwogICAgIHJldHVybiBXVEZNb3ZlKG1fY29udGVudCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmggYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lLmgKaW5kZXggOTVk MjU2Njk2MmMyMjY1MTZjZTdlMjVlMTBiZjJlMzk2NzhhMmY4NC4uN2JiNjVmMjMzMGQ0NTdmYzI5 YTcxOTY5MmQ4YmJjM2E1NzczNzYwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmUuaApAQCAtNjAsOCArNjAsNiBAQCBwdWJsaWM6 CiAgICAgICAgIHVzaW5nIFJ1bnMgPSBWZWN0b3I8c3RkOjp1bmlxdWVfcHRyPFJ1bj4+OwogICAg ICAgICBjb25zdCBSdW5zJiBydW5zKCkgY29uc3QgeyByZXR1cm4gbV9ydW5zOyB9CiAgICAgICAg IGJvb2wgaXNFbXB0eSgpIGNvbnN0IHsgcmV0dXJuIG1fcnVucy5pc0VtcHR5KCk7IH0KLSAgICAg ICAgLy8gTm90IGluIHBhaW50aW5nIHNlbnNlIHRob3VnaC4KLSAgICAgICAgYm9vbCBpc1Zpc3Vh bGx5RW1wdHkoKSBjb25zdCB7IHJldHVybiBtX2lzVmlzdWFsbHlFbXB0eTsgfQogCiAgICAgICAg IExheW91dFVuaXQgbG9naWNhbFRvcCgpIGNvbnN0IHsgcmV0dXJuIG1fbG9naWNhbFJlY3QudG9w KCk7IH0KICAgICAgICAgTGF5b3V0VW5pdCBsb2dpY2FsTGVmdCgpIGNvbnN0IHsgcmV0dXJuIG1f bG9naWNhbFJlY3QubGVmdCgpOyB9CkBAIC03NiwxMyArNzQsMTEgQEAgcHVibGljOgogCiAgICAg ICAgIHZvaWQgc2V0TG9naWNhbFJlY3QoY29uc3QgRGlzcGxheTo6UmVjdCYgbG9naWNhbFJlY3Qp IHsgbV9sb2dpY2FsUmVjdCA9IGxvZ2ljYWxSZWN0OyB9CiAgICAgICAgIHZvaWQgc2V0QmFzZWxp bmUoTGluZUJveDo6QmFzZWxpbmUgYmFzZWxpbmUpIHsgbV9iYXNlbGluZSA9IGJhc2VsaW5lOyB9 Ci0gICAgICAgIHZvaWQgc2V0SXNWaXN1YWxseUVtcHR5KGJvb2wgaXNWaXN1YWxseUVtcHR5KSB7 IG1faXNWaXN1YWxseUVtcHR5ID0gaXNWaXN1YWxseUVtcHR5OyB9CiAgICAgICAgIFJ1bnMmIHJ1 bnMoKSB7IHJldHVybiBtX3J1bnM7IH0KIAogICAgICAgICBEaXNwbGF5OjpSZWN0IG1fbG9naWNh bFJlY3Q7CiAgICAgICAgIExpbmVCb3g6OkJhc2VsaW5lIG1fYmFzZWxpbmU7CiAgICAgICAgIFJ1 bnMgbV9ydW5zOwotICAgICAgICBib29sIG1faXNWaXN1YWxseUVtcHR5IHsgdHJ1ZSB9OwogICAg IH07CiAgICAgc3RkOjp1bmlxdWVfcHRyPENvbnRlbnQ+IGNsb3NlKCk7CiAK