198883 2019-06-15 00:45:13 -0700 [LFC][MarginCollapsing] Add check for computed height value in MarginCollapse::marginsCollapseThrough 2019-06-15 07:11:44 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1544979 0 zalan 2019-06-15 00:45:13 -0700 replace FIXME 1544980 1 webkit-bug-importer 2019-06-15 00:45:36 -0700 <rdar://problem/51773395> 1544981 2 372183 zalan 2019-06-15 00:50:50 -0700 Created attachment 372183 Patch 1544983 3 372185 zalan 2019-06-15 00:56:55 -0700 Created attachment 372185 Patch 1545018 4 372185 commit-queue 2019-06-15 07:11:42 -0700 Comment on attachment 372185 Patch Clearing flags on attachment: 372185 Committed r246461: <https://trac.webkit.org/changeset/246461> 1545019 5 commit-queue 2019-06-15 07:11:44 -0700 All reviewed patches have been landed. Closing bug. 372183 2019-06-15 00:50:50 -0700 2019-06-15 00:56:53 -0700 Patch bug-198883-20190615005047.patch text/plain 2190 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjEwMWFhNDllNjkxOTc2 NDQwZjlkOTBlNTE3YTQ4YjA0MDg5OWM0ZS4uZGNlZjM2NTQwNjM3MmMyMzRlY2Y1OGZlMDZiNmZh MjUzNjkxN2U5NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA2LTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRzXSBBZGQg Y2hlY2sgZm9yIGNvbXB1dGVkIGhlaWdodCB2YWx1ZSBpbiBNYXJnaW5Db2xsYXBzZTo6bWFyZ2lu c0NvbGxhcHNlVGhyb3VnaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk4ODgzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTc3MzM5NT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAiQSBib3gncyBvd24g bWFyZ2lucyBjb2xsYXBzZSBpZi4uLiAuLi5hbmQgaXQgaGFzIGEgJ2hlaWdodCcgb2YgZWl0aGVy IDAgb3IgJ2F1dG8iCisgICAgICAgIGh0dHBzOi8vd3d3LnczLm9yZy9UUi9DU1MyMi9ib3guaHRt bCNjb2xsYXBzaW5nLW1hcmdpbnMKKworICAgICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcv QmxvY2tNYXJnaW5Db2xsYXBzZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2Nr Rm9ybWF0dGluZ0NvbnRleHQ6Ok1hcmdpbkNvbGxhcHNlOjptYXJnaW5zQ29sbGFwc2VUaHJvdWdo KToKKwogMjAxOS0wNi0xNSAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAg ICAgIFtMRkNdW0Zsb2F0c10gUmVtb3ZlIHJlZHVuZGFudCBjaGVja3MgaW4gTWFyZ2luQ29sbGFw c2U6Om1hcmdpbkJlZm9yZS9BZnRlckNvbGxhcHNlc1dpdGgqCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwIGIv U291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNl LmNwcAppbmRleCAwMGFlNWI2ODAxMzQ5M2RiNDBhZDVlMzZjOWJhMzFkMjEzZTNkMWYyLi43MTVk M2RmNzExMTM3YzgzZWM3YmJhZjQ1MThmZDA1MWExOGY1MWZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xs YXBzZS5jcHAKQEAgLTM2OCwxMiArMzY4LDEzIEBAIGJvb2wgQmxvY2tGb3JtYXR0aW5nQ29udGV4 dDo6TWFyZ2luQ29sbGFwc2U6Om1hcmdpbnNDb2xsYXBzZVRocm91Z2goY29uc3QgTGF5b3V0CiAg ICAgaWYgKGhhc1BhZGRpbmdCZWZvcmUobGF5b3V0Qm94KSB8fCBoYXNQYWRkaW5nQWZ0ZXIobGF5 b3V0Qm94KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgLy8gRklYTUU6IENoZWNrIGZv ciBjb21wdXRlZCAwIGhlaWdodC4KLSAgICBpZiAoIWxheW91dEJveC5zdHlsZSgpLmhlaWdodCgp LmlzQXV0bygpKQorICAgIGF1dG8mIHN0eWxlID0gbGF5b3V0Qm94LnN0eWxlKCk7CisgICAgYXV0 byBjb21wdXRlZEhlaWdodFZhbHVlSXNaZXJvID0gc3R5bGUuaGVpZ2h0KCkuaXNGaXhlZCgpICYm ICFzdHlsZS5oZWlnaHQoKS52YWx1ZSgpOworICAgIGlmICghKHN0eWxlLmhlaWdodCgpLmlzQXV0 bygpIHx8IGNvbXB1dGVkSGVpZ2h0VmFsdWVJc1plcm8pKQogICAgICAgICByZXR1cm4gZmFsc2U7 CiAKICAgICAvLyBGSVhNRTogQ2hlY2sgZm9yIGNvbXB1dGVkIDAgaGVpZ2h0LgotICAgIGlmICgh bGF5b3V0Qm94LnN0eWxlKCkubWluSGVpZ2h0KCkuaXNBdXRvKCkpCisgICAgaWYgKCFzdHlsZS5t aW5IZWlnaHQoKS5pc0F1dG8oKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgLy8gRklY TUU6IEJsb2NrIHJlcGxhY2VkIGJveGVzIGNsZWFybHkgZG9uJ3QgY29sbGFwc2UgdGhyb3VnaCB0 aGVpciBtYXJnaW5zLCBidXQgSSBjb3VsZG4ndCBmaW5kIGl0IGluIHRoZSBzcGVjIHlldCAoYW5k IG5vLCBpdCdzIG5vdCBhIHF1aXJrKS4K 372185 2019-06-15 00:56:55 -0700 2019-06-15 07:11:42 -0700 Patch bug-198883-20190615005652.patch text/plain 2210 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWNjN2I5Yzc5Y2RhM2Qx ZDBmNWE0YmQ1NTUyYmQzM2NkODgzOWNiOS4uNWI4NzQyNzRhODcxNmRjYzYzYzk4NTdjMTNlYWYy MTM0NmE2ZTc1ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA2LTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bTWFyZ2luQ29sbGFw c2luZ10gQWRkIGNoZWNrIGZvciBjb21wdXRlZCBoZWlnaHQgdmFsdWUgaW4gTWFyZ2luQ29sbGFw c2U6Om1hcmdpbnNDb2xsYXBzZVRocm91Z2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE5ODg4MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE3NzMz OTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgIkEg Ym94J3Mgb3duIG1hcmdpbnMgY29sbGFwc2UgaWYuLi4gLi4uYW5kIGl0IGhhcyBhICdoZWlnaHQn IG9mIGVpdGhlciAwIG9yICdhdXRvIgorICAgICAgICBodHRwczovL3d3dy53My5vcmcvVFIvQ1NT MjIvYm94Lmh0bWwjY29sbGFwc2luZy1tYXJnaW5zCisKKyAgICAgICAgKiBsYXlvdXQvYmxvY2tm b3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5 b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpNYXJnaW5Db2xsYXBzZTo6bWFyZ2luc0NvbGxh cHNlVGhyb3VnaCk6CisKIDIwMTktMDYtMTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXVtNYXJnaW5Db2xsYXBzaW5nXSBSZW1vdmUgcmVkdW5kYW50IGNo ZWNrcyBpbiBNYXJnaW5Db2xsYXBzZTo6bWFyZ2luQmVmb3JlL0FmdGVyQ29sbGFwc2VzV2l0aCoK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tN YXJnaW5Db2xsYXBzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0aW5n L0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwCmluZGV4IDAwYWU1YjY4MDEzNDkzZGI0MGFkNWUzNmM5 YmEzMWQyMTNlM2QxZjIuLjcxNWQzZGY3MTExMzdjODNlYzdiYmFmNDUxOGZkMDUxYTE4ZjUxZmEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tN YXJnaW5Db2xsYXBzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9ybWF0 dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcApAQCAtMzY4LDEyICszNjgsMTMgQEAgYm9vbCBC bG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpNYXJnaW5Db2xsYXBzZTo6bWFyZ2luc0NvbGxhcHNlVGhy b3VnaChjb25zdCBMYXlvdXQKICAgICBpZiAoaGFzUGFkZGluZ0JlZm9yZShsYXlvdXRCb3gpIHx8 IGhhc1BhZGRpbmdBZnRlcihsYXlvdXRCb3gpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAg ICAvLyBGSVhNRTogQ2hlY2sgZm9yIGNvbXB1dGVkIDAgaGVpZ2h0LgotICAgIGlmICghbGF5b3V0 Qm94LnN0eWxlKCkuaGVpZ2h0KCkuaXNBdXRvKCkpCisgICAgYXV0byYgc3R5bGUgPSBsYXlvdXRC b3guc3R5bGUoKTsKKyAgICBhdXRvIGNvbXB1dGVkSGVpZ2h0VmFsdWVJc1plcm8gPSBzdHlsZS5o ZWlnaHQoKS5pc0ZpeGVkKCkgJiYgIXN0eWxlLmhlaWdodCgpLnZhbHVlKCk7CisgICAgaWYgKCEo c3R5bGUuaGVpZ2h0KCkuaXNBdXRvKCkgfHwgY29tcHV0ZWRIZWlnaHRWYWx1ZUlzWmVybykpCiAg ICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIC8vIEZJWE1FOiBDaGVjayBmb3IgY29tcHV0ZWQg MCBoZWlnaHQuCi0gICAgaWYgKCFsYXlvdXRCb3guc3R5bGUoKS5taW5IZWlnaHQoKS5pc0F1dG8o KSkKKyAgICBpZiAoIXN0eWxlLm1pbkhlaWdodCgpLmlzQXV0bygpKQogICAgICAgICByZXR1cm4g ZmFsc2U7CiAKICAgICAvLyBGSVhNRTogQmxvY2sgcmVwbGFjZWQgYm94ZXMgY2xlYXJseSBkb24n dCBjb2xsYXBzZSB0aHJvdWdoIHRoZWlyIG1hcmdpbnMsIGJ1dCBJIGNvdWxkbid0IGZpbmQgaXQg aW4gdGhlIHNwZWMgeWV0IChhbmQgbm8sIGl0J3Mgbm90IGEgcXVpcmspLgo=