198882 2019-06-15 00:40:11 -0700 [LFC][MarginCollapsing] Remove redundant checks in MarginCollapse::marginBefore/AfterCollapsesWith* 2019-06-15 07:36:48 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan webkit-unassigned bfulgham commit-queue koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1544976 0 zalan 2019-06-15 00:40:11 -0700 ssia. 1544977 1 webkit-bug-importer 2019-06-15 00:40:46 -0700 <rdar://problem/51773334> 1544978 2 372182 zalan 2019-06-15 00:44:03 -0700 Created attachment 372182 Patch 1544982 3 372184 zalan 2019-06-15 00:55:28 -0700 Created attachment 372184 Patch 1544985 4 webkit-bug-importer 2019-06-15 00:58:33 -0700 <rdar://problem/51773501> 1545027 5 372184 commit-queue 2019-06-15 07:36:47 -0700 Comment on attachment 372184 Patch Clearing flags on attachment: 372184 Committed r246464: <https://trac.webkit.org/changeset/246464> 1545028 6 commit-queue 2019-06-15 07:36:48 -0700 All reviewed patches have been landed. Closing bug. 372182 2019-06-15 00:44:03 -0700 2019-06-15 00:55:27 -0700 Patch bug-198882-20190615004400.patch text/plain 2663 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk4MjhhNTQwYzgyOThi YzZiYTFjNDFhYzE4YzQ2Y2U2MGJmN2EyZS4uMjEwMWFhNDllNjkxOTc2NDQwZjlkOTBlNTE3YTQ4 YjA0MDg5OWM0ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA2LTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRzXSBSZW1v dmUgcmVkdW5kYW50IGNoZWNrcyBpbiBNYXJnaW5Db2xsYXBzZTo6bWFyZ2luQmVmb3JlL0FmdGVy Q29sbGFwc2VzV2l0aCoKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5ODg4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE3NzMzMzQ+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4tZmxvdyBjaGlsZCBj YW4gbmVpdGhlciBiZSBmbG9hdGluZyBub3Igb3V0LW9mLWZsb3cgcG9zaXRpb25lZC4KKworICAg ICAgICAqIGxheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Ok1hcmdpbkNv bGxhcHNlOjptYXJnaW5CZWZvcmVDb2xsYXBzZXNXaXRoRmlyc3RJbkZsb3dDaGlsZE1hcmdpbkJl Zm9yZSk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6 Ok1hcmdpbkNvbGxhcHNlOjptYXJnaW5BZnRlckNvbGxhcHNlc1dpdGhMYXN0SW5GbG93Q2hpbGRN YXJnaW5BZnRlcik6CisKIDIwMTktMDYtMTUgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNv bT4KIAogICAgICAgICBbTEZDXSBBZGQgbGltaXRlZCBxdWlya3MgbW9kZSB0byBMYXlvdXRTdGF0 ZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxv Y2tNYXJnaW5Db2xsYXBzZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3JtYXR0 aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwCmluZGV4IDAwZTBhMGY0NGFkZTgyZGEyMWQzNjU2 MDAwYTBjNmQyMWZjNTZlZjIuLjAwYWU1YjY4MDEzNDkzZGI0MGFkNWUzNmM5YmEzMWQyMTNlM2Qx ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9ibG9ja2Zvcm1hdHRpbmcvQmxv Y2tNYXJnaW5Db2xsYXBzZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Jsb2NrZm9y bWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcApAQCAtMjA5LDE0ICsyMDksNiBAQCBib29s IEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6Ok1hcmdpbkNvbGxhcHNlOjptYXJnaW5CZWZvcmVDb2xs YXBzZXNXaXRoRmlyc3RJbkZsbwogICAgIGlmIChoYXNDbGVhcmFuY2UobGF5b3V0U3RhdGUsIGZp cnN0SW5GbG93Q2hpbGQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICAvLyBNYXJnaW5z IGJldHdlZW4gYSBmbG9hdGVkIGJveCBhbmQgYW55IG90aGVyIGJveCBkbyBub3QgY29sbGFwc2Uu Ci0gICAgaWYgKGZpcnN0SW5GbG93Q2hpbGQuaXNGbG9hdGluZ1Bvc2l0aW9uZWQoKSkKLSAgICAg ICAgcmV0dXJuIGZhbHNlOwotCi0gICAgLy8gTWFyZ2lucyBvZiBhYnNvbHV0ZWx5IHBvc2l0aW9u ZWQgYm94ZXMgZG8gbm90IGNvbGxhcHNlLgotICAgIGlmIChmaXJzdEluRmxvd0NoaWxkLmlzT3V0 T2ZGbG93UG9zaXRpb25lZCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICAvLyBNYXJn aW5zIG9mIGlubGluZS1ibG9jayBib3hlcyBkbyBub3QgY29sbGFwc2UuCiAgICAgaWYgKGZpcnN0 SW5GbG93Q2hpbGQuaXNJbmxpbmVCbG9ja0JveCgpKQogICAgICAgICByZXR1cm4gZmFsc2U7CkBA IC0zNDcsMTQgKzMzOSw2IEBAIGJvb2wgQmxvY2tGb3JtYXR0aW5nQ29udGV4dDo6TWFyZ2luQ29s bGFwc2U6Om1hcmdpbkFmdGVyQ29sbGFwc2VzV2l0aExhc3RJbkZsb3dDCiAgICAgICAgICYmICht YXJnaW5BZnRlckNvbGxhcHNlc1dpdGhQYXJlbnRNYXJnaW5CZWZvcmUobGF5b3V0U3RhdGUsIGxh c3RJbkZsb3dDaGlsZCkgfHwgaGFzQ2xlYXJhbmNlKGxheW91dFN0YXRlLCBsYXN0SW5GbG93Q2hp bGQpKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgLy8gTWFyZ2lucyBiZXR3ZWVuIGEg ZmxvYXRlZCBib3ggYW5kIGFueSBvdGhlciBib3ggZG8gbm90IGNvbGxhcHNlLgotICAgIGlmIChs YXN0SW5GbG93Q2hpbGQuaXNGbG9hdGluZ1Bvc2l0aW9uZWQoKSkKLSAgICAgICAgcmV0dXJuIGZh bHNlOwotCi0gICAgLy8gTWFyZ2lucyBvZiBhYnNvbHV0ZWx5IHBvc2l0aW9uZWQgYm94ZXMgZG8g bm90IGNvbGxhcHNlLgotICAgIGlmIChsYXN0SW5GbG93Q2hpbGQuaXNPdXRPZkZsb3dQb3NpdGlv bmVkKCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQogICAgIC8vIE1hcmdpbnMgb2YgaW5saW5l LWJsb2NrIGJveGVzIGRvIG5vdCBjb2xsYXBzZS4KICAgICBpZiAobGFzdEluRmxvd0NoaWxkLmlz SW5saW5lQmxvY2tCb3goKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwo= 372184 2019-06-15 00:55:28 -0700 2019-06-15 07:36:47 -0700 Patch bug-198882-20190615005526.patch text/plain 2673 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NDU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTk4MjhhNTQwYzgyOThi YzZiYTFjNDFhYzE4YzQ2Y2U2MGJmN2EyZS4uNWNjN2I5Yzc5Y2RhM2QxZDBmNWE0YmQ1NTUyYmQz M2NkODgzOWNiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA2LTE1ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bTWFyZ2luQ29sbGFw c2luZ10gUmVtb3ZlIHJlZHVuZGFudCBjaGVja3MgaW4gTWFyZ2luQ29sbGFwc2U6Om1hcmdpbkJl Zm9yZS9BZnRlckNvbGxhcHNlc1dpdGgqCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTg4ODIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxNzczMzM0 PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluLWZs b3cgY2hpbGQgY2FuIG5laXRoZXIgYmUgZmxvYXRpbmcgbm9yIG91dC1vZi1mbG93IHBvc2l0aW9u ZWQuCisKKyAgICAgICAgKiBsYXlvdXQvYmxvY2tmb3JtYXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFw c2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRpbmdDb250ZXh0 OjpNYXJnaW5Db2xsYXBzZTo6bWFyZ2luQmVmb3JlQ29sbGFwc2VzV2l0aEZpcnN0SW5GbG93Q2hp bGRNYXJnaW5CZWZvcmUpOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpCbG9ja0Zvcm1hdHRp bmdDb250ZXh0OjpNYXJnaW5Db2xsYXBzZTo6bWFyZ2luQWZ0ZXJDb2xsYXBzZXNXaXRoTGFzdElu Rmxvd0NoaWxkTWFyZ2luQWZ0ZXIpOgorCiAyMDE5LTA2LTE1ICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ10gQWRkIGxpbWl0ZWQgcXVpcmtzIG1vZGUgdG8g TGF5b3V0U3RhdGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3Jt YXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L2Js b2NrZm9ybWF0dGluZy9CbG9ja01hcmdpbkNvbGxhcHNlLmNwcAppbmRleCAwMGUwYTBmNDRhZGU4 MmRhMjFkMzY1NjAwMGEwYzZkMjFmYzU2ZWYyLi4wMGFlNWI2ODAxMzQ5M2RiNDBhZDVlMzZjOWJh MzFkMjEzZTNkMWYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvYmxvY2tmb3Jt YXR0aW5nL0Jsb2NrTWFyZ2luQ29sbGFwc2UuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9ibG9ja2Zvcm1hdHRpbmcvQmxvY2tNYXJnaW5Db2xsYXBzZS5jcHAKQEAgLTIwOSwxNCArMjA5 LDYgQEAgYm9vbCBCbG9ja0Zvcm1hdHRpbmdDb250ZXh0OjpNYXJnaW5Db2xsYXBzZTo6bWFyZ2lu QmVmb3JlQ29sbGFwc2VzV2l0aEZpcnN0SW5GbG8KICAgICBpZiAoaGFzQ2xlYXJhbmNlKGxheW91 dFN0YXRlLCBmaXJzdEluRmxvd0NoaWxkKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAg Ly8gTWFyZ2lucyBiZXR3ZWVuIGEgZmxvYXRlZCBib3ggYW5kIGFueSBvdGhlciBib3ggZG8gbm90 IGNvbGxhcHNlLgotICAgIGlmIChmaXJzdEluRmxvd0NoaWxkLmlzRmxvYXRpbmdQb3NpdGlvbmVk KCkpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLQotICAgIC8vIE1hcmdpbnMgb2YgYWJzb2x1dGVs eSBwb3NpdGlvbmVkIGJveGVzIGRvIG5vdCBjb2xsYXBzZS4KLSAgICBpZiAoZmlyc3RJbkZsb3dD aGlsZC5pc091dE9mRmxvd1Bvc2l0aW9uZWQoKSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOwotCiAg ICAgLy8gTWFyZ2lucyBvZiBpbmxpbmUtYmxvY2sgYm94ZXMgZG8gbm90IGNvbGxhcHNlLgogICAg IGlmIChmaXJzdEluRmxvd0NoaWxkLmlzSW5saW5lQmxvY2tCb3goKSkKICAgICAgICAgcmV0dXJu IGZhbHNlOwpAQCAtMzQ3LDE0ICszMzksNiBAQCBib29sIEJsb2NrRm9ybWF0dGluZ0NvbnRleHQ6 Ok1hcmdpbkNvbGxhcHNlOjptYXJnaW5BZnRlckNvbGxhcHNlc1dpdGhMYXN0SW5GbG93QwogICAg ICAgICAmJiAobWFyZ2luQWZ0ZXJDb2xsYXBzZXNXaXRoUGFyZW50TWFyZ2luQmVmb3JlKGxheW91 dFN0YXRlLCBsYXN0SW5GbG93Q2hpbGQpIHx8IGhhc0NsZWFyYW5jZShsYXlvdXRTdGF0ZSwgbGFz dEluRmxvd0NoaWxkKSkpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIC8vIE1hcmdpbnMg YmV0d2VlbiBhIGZsb2F0ZWQgYm94IGFuZCBhbnkgb3RoZXIgYm94IGRvIG5vdCBjb2xsYXBzZS4K LSAgICBpZiAobGFzdEluRmxvd0NoaWxkLmlzRmxvYXRpbmdQb3NpdGlvbmVkKCkpCi0gICAgICAg IHJldHVybiBmYWxzZTsKLQotICAgIC8vIE1hcmdpbnMgb2YgYWJzb2x1dGVseSBwb3NpdGlvbmVk IGJveGVzIGRvIG5vdCBjb2xsYXBzZS4KLSAgICBpZiAobGFzdEluRmxvd0NoaWxkLmlzT3V0T2ZG bG93UG9zaXRpb25lZCgpKQotICAgICAgICByZXR1cm4gZmFsc2U7Ci0KICAgICAvLyBNYXJnaW5z IG9mIGlubGluZS1ibG9jayBib3hlcyBkbyBub3QgY29sbGFwc2UuCiAgICAgaWYgKGxhc3RJbkZs b3dDaGlsZC5pc0lubGluZUJsb2NrQm94KCkpCiAgICAgICAgIHJldHVybiBmYWxzZTsK