198871 2019-06-14 14:59:08 -0700 [Cocoa] NSFileWrapper associated with _WKAttachment is leaking 2019-06-14 17:06:58 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue darin joepeck mitz thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1544858 0 joepeck 2019-06-14 14:59:08 -0700 NSFileWrapper associated with _WKAttachment is leaking, along with other properties specifically in API::Attachment: STACK OF 2 INSTANCES OF 'ROOT LEAK: malloc<32>': 18 libdyld.dylib 0x1d82dde7c start + 4 17 com.apple.mobilemail 0x104cbfff0 0x104cb8000 + 32752 16 com.apple.UIKitCore 0x106fb4db8 UIApplicationMain + 1936 15 com.apple.GraphicsServices 0x1d6f84180 GSEventRunModal + 104 14 com.apple.CoreFoundation 0x1d7d877ac CFRunLoopRunSpecific + 464 13 com.apple.CoreFoundation 0x1d7d882a8 __CFRunLoopRun + 2004 12 com.apple.CoreFoundation 0x1d7d8d2a0 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12 11 libdispatch.dylib 0x1d85ea1f8 _dispatch_main_queue_callback_4CF$VARIANT$mp + 1044 10 libdispatch.dylib 0x1d86381ec _dispatch_client_callout + 16 9 libdispatch.dylib 0x1d8637678 _dispatch_call_block_and_release + 24 8 ??? 0x105960044 ??? 7 ??? 0x10654c5cc ??? 6 com.apple.WebKit 0x1d10a0f00 -[_WKAttachment setFileWrapper:contentType:completion:] + 200 5 com.apple.WebKit 0x1d10717cc API::Attachment::setFileWrapperAndUpdateContentType(NSFileWrapper*, NSString*) + 356 4 JavaScriptCore 0x1dbd792dc WTF::String::String(NSString*) + 12 3 JavaScriptCore 0x1dbd79048 WTF::String::String(NSString*) + 204 2 JavaScriptCore 0x1dbd7998c WTF::StringImpl::create(unsigned char const*, unsigned int) + 56 1 JavaScriptCore 0x1dbdc2194 bmalloc::DebugHeap::malloc(unsigned long, bool) + 24 0 libsystem_malloc.dylib 0x1d867177c malloc_zone_malloc + 200 ==== 2 (64 bytes) << TOTAL >> 1 (32 bytes) ROOT LEAK: 0x114e01ae0 [32] 1 (32 bytes) ROOT LEAK: 0x114f00fc0 [32] 1544860 1 joepeck 2019-06-14 14:59:38 -0700 <rdar://problem/51760625> 1544861 2 372145 joepeck 2019-06-14 15:00:46 -0700 Created attachment 372145 [PATCH] Proposed Fix 1544875 3 372145 commit-queue 2019-06-14 15:52:30 -0700 Comment on attachment 372145 [PATCH] Proposed Fix Clearing flags on attachment: 372145 Committed r246448: <https://trac.webkit.org/changeset/246448> 1544876 4 commit-queue 2019-06-14 15:52:32 -0700 All reviewed patches have been landed. Closing bug. 1544892 5 372145 mitz 2019-06-14 16:28:37 -0700 Comment on attachment 372145 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=372145&action=review > Source/WebKit/ChangeLog:3 > + [Cocoa] NSFileWrapper associated with _WKAttachment is leaking 1544895 6 372145 joepeck 2019-06-14 17:06:58 -0700 Comment on attachment 372145 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=372145&action=review >> Source/WebKit/ChangeLog:3 >> + [Cocoa] NSFileWrapper associated with _WKAttachment > > is leaking Doh, thanks. 372145 2019-06-14 15:00:46 -0700 2019-06-14 15:52:30 -0700 [PATCH] Proposed Fix attachment-1.patch text/plain 1165 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYmUxMDJmZDZmNTIuLmJkYjJhYTQwN2ZjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDE5LTA2LTE0ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+ CisKKyAgICAgICAgW0NvY29hXSBOU0ZpbGVXcmFwcGVyIGFzc29jaWF0ZWQgd2l0aCBfV0tBdHRh Y2htZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTg4NzEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxNzYwNjI1PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2NvYS9f V0tBdHRhY2htZW50Lm1tOgorICAgICAgICAoLVtfV0tBdHRhY2htZW50IGRlYWxsb2NdKToKKyAg ICAgICAgRW5zdXJlIHdlIGRlc3RydWN0IHRoZSBBUEk6Ok9iamVjdCBhc3NvY2lhdGVkIHdpdGgg dGhpcyBzbyBSZXRhaW5QdHJzIGNhbiByZWxlYXNlLgorCiAyMDE5LTA2LTEzICBNZWdhbiBHYXJk bmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHNlbGVjdGlvbiBo YW5nIGluIE1haWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tBdHRhY2htZW50Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19X S0F0dGFjaG1lbnQubW0KaW5kZXggNDU0OTYwNTU3NmEuLjAwZDk2NGZjYzE3IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXR0YWNobWVudC5tbQorKysg Yi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLQXR0YWNobWVudC5tbQpAQCAt MTAyLDYgKzEwMiwxMyBAQCBAZW5kCiAKIEBpbXBsZW1lbnRhdGlvbiBfV0tBdHRhY2htZW50CiAK Ky0gKHZvaWQpZGVhbGxvYworeworICAgIF9hdHRhY2htZW50LT5+QXR0YWNobWVudCgpOworCisg ICAgW3N1cGVyIGRlYWxsb2NdOworfQorCiAtIChBUEk6Ok9iamVjdCYpX2FwaU9iamVjdAogewog ICAgIHJldHVybiAqX2F0dGFjaG1lbnQ7Cg==