198867 2019-06-14 13:57:13 -0700 REGRESSION: Layout Test webgl/many-contexts.html is a flaky timeout on Mojave+ 2022-04-22 00:22:02 -0700 1 1 1 Unclassified WebKit WebGL WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 239640 1 ryanhaddad webkit-unassigned ap dino jbedard justin_fan rniwa simon.fraser tsavell webkit-bot-watchers-bugzilla webkit-bug-importer youennf oldest_to_newest 1544831 0 ryanhaddad 2019-06-14 13:57:13 -0700 The following layout test is a flaky timeout on Mojave webgl/many-contexts.html Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2Fmany-contexts.html --- /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/webgl/many-contexts-expected.txt +++ /Volumes/Data/slave/mojave-release-tests-wk1/build/layout-test-results/webgl/many-contexts-actual.txt @@ -982,4 +982,5 @@ CONSOLE MESSAGE: line 12: There are too many active WebGL contexts on this page, the oldest context will be lost. CONSOLE MESSAGE: line 12: There are too many active WebGL contexts on this page, the oldest context will be lost. CONSOLE MESSAGE: line 12: There are too many active WebGL contexts on this page, the oldest context will be lost. +FAIL: Timed out waiting for notifyDone to be called PASS if this test did not crash. 1544835 1 ryanhaddad 2019-06-14 14:00:32 -0700 This test had been taking about 20 seconds to run until Jun 8, 2019 ~r246232, and now it waffles between the high 20s and timeouts. 1545274 2 tsavell 2019-06-17 09:45:52 -0700 When I try to reproduce this all I am getting locally is crashes. 1545282 3 webkit-bug-importer 2019-06-17 10:19:10 -0700 <rdar://problem/51810342> 1546140 4 tsavell 2019-06-19 11:07:36 -0700 Ryan found that when he rebooted the leaks bot this test stopped timing out there and began slowly ticking back up in its time. it went from 35 second to 8 on restart and is back up to 10 seconds now. The output of this test has more CONSOLE MESSAGE: lines dependent on how long it takes to timeout. 1552431 5 jbedard 2019-07-12 09:08:57 -0700 This sounds like we're leaking something at the os level resource. This can probably effect other tests too. 1581432 6 tsavell 2019-10-18 09:28:41 -0700 Marked this test as skip for Mojave+ while this is being investigated: https://trac.webkit.org/changeset/251286/webkit 1585792 7 rniwa 2019-10-30 22:49:55 -0700 This appears to be always passing now. We probably need to just get rid of the test expectation. 1585809 8 ap 2019-10-30 23:50:23 -0700 It's skipped, so we don't have any history on flakiness dashboard. LayoutTests/platform/mac/TestExpectations:2018:webkit.org/b/198867 [ Mojave+ ] webgl/many-contexts.html [ Skip ] > This sounds like we're leaking something at the os level resource. This can probably effect other tests too. Removing the expectation may be necessary to check if this is still happening, but it's also very dangerous as it can destabilize other tests. 1587584 9 tsavell 2019-11-05 16:26:01 -0800 I found another webgl test that is timing out and resets to 1 sec to pass after a restart of the bot. webgl/1.0.2/conformance/uniforms/out-of-bounds-uniform-array-access.html History: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=webgl%2F1.0.2%2Fconformance%2Funiforms%2Fout-of-bounds-uniform-array-access.html I rebooted the bot on 11/5 at 4pm 1587780 10 tsavell 2019-11-06 08:01:48 -0800 *** Bug 203856 has been marked as a duplicate of this bug. *** 1588026 11 ap 2019-11-06 17:39:52 -0800 So something in our tests makes WebGL slower with time, even as all of our processes get restarted. And the culprit may well be some other test or tests, not the ones listed here. It seems like it may still be a problem on Catalina, as run times seem to be increasing - although they haven't reached 30 seconds yet. I think that this has to be a GPU driver issue, but hopefully we can isolate and maybe work around it.