198853 2019-06-14 00:34:45 -0700 [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects 2019-06-19 08:07:39 -0700 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii commit-queue don.olmstead oldest_to_newest 1544703 0 fujii 2019-06-14 00:34:45 -0700 [CMake][Win] CombinedDomains.json is generated twice in JavaScriptCore_CopyPrivateHeaders and JavaScriptCore projects Here is the excerpt from build log: > 8>------ Build started: Project: JavaScriptCore_CopyPrivateHeaders, Configuration: Debug x64 ------ > 8>Generating ../../JavaScriptCore/DerivedSources/CombinedDomains.json > 25>------ Build started: Project: JavaScriptCore (JavaScriptCore\JavaScriptCore), Configuration: Debug x64 ------ > 25>Generating ../../JavaScriptCore/DerivedSources/CombinedDomains.json This causes unnecessary re-invoking generate-inspector-protocol-bindings.py in incremental builds because generated InspectorBackendDispatchers.cpp file becomes older than input CombinedDomains.json file. 1544704 1 fujii 2019-06-14 00:36:39 -0700 Uploaded full build log: https://gist.github.com/fujii/f5b9c0875f50de7f3e1fe244f65fa200 1544706 2 372111 fujii 2019-06-14 00:51:02 -0700 Created attachment 372111 WIP Patch The fundamental issue of this bug was fixed in CMake side. https://gitlab.kitware.com/cmake/cmake/issues/16767 However, JavaScriptCore_CopyPrivateHeaders needs to have a direct or indirect dependency of JavaScriptCore for CMake eliminating duplicated custom commands. 1544768 3 don.olmstead 2019-06-14 10:19:21 -0700 Patch is fine I'm just thinking maybe you should put a comment on why its there. Seems like any WEBKIT_COPY_FILES needs to have a direct dependency if any of the headers contain derived sources. 1546001 4 fujii 2019-06-19 01:53:22 -0700 I don't see any other issues. 1546003 5 372445 fujii 2019-06-19 02:15:37 -0700 Created attachment 372445 Patch 1546059 6 372445 commit-queue 2019-06-19 08:07:37 -0700 Comment on attachment 372445 Patch Clearing flags on attachment: 372445 Committed r246587: <https://trac.webkit.org/changeset/246587> 1546060 7 commit-queue 2019-06-19 08:07:39 -0700 All reviewed patches have been landed. Closing bug. 372111 2019-06-14 00:51:02 -0700 2019-06-19 02:15:28 -0700 WIP Patch wip.diff text/plain 532 fujii ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCBkOGYzNjQwMGZkOC4uZDMyZjMz YmVmZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01ha2VMaXN0cy50eHQKQEAgLTEyOTQsNiArMTI5 NCw3IEBAIFdFQktJVF9DT1BZX0ZJTEVTKEphdmFTY3JpcHRDb3JlX0NvcHlQcml2YXRlSGVhZGVy cwogICAgIEZJTEVTICR7SmF2YVNjcmlwdENvcmVfUFJJVkFURV9GUkFNRVdPUktfSEVBREVSU30K ICAgICBGTEFUVEVORUQKICkKK2FkZF9kZXBlbmRlbmNpZXMoSmF2YVNjcmlwdENvcmVfQ29weVBy aXZhdGVIZWFkZXJzIEphdmFTY3JpcHRDb3JlKQogCiB0YXJnZXRfaW5jbHVkZV9kaXJlY3Rvcmll cyhMTEludFNldHRpbmdzRXh0cmFjdG9yIFBSSVZBVEUKICAgICAke0phdmFTY3JpcHRDb3JlX0lO Q0xVREVfRElSRUNUT1JJRVN9Cg== 372445 2019-06-19 02:15:37 -0700 2019-06-19 08:07:37 -0700 Patch bug-198853-20190619181536.patch text/plain 1839 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBi NzNkNGU0YjA1YWQ5Y2JiNzVjOWI1YWM3NWQ4YjEzMjI1ZGY0OGIzLi4zYTg4MWM3ZDI4NTRlYTVj YmU0OGFhYzgwYzUxYTM3NzlkOTViMjVlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNi0xOSAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBz b255LmNvbT4KKworICAgICAgICBbQ01ha2VdW1dpbl0gQ29tYmluZWREb21haW5zLmpzb24gaXMg Z2VuZXJhdGVkIHR3aWNlIGluIEphdmFTY3JpcHRDb3JlX0NvcHlQcml2YXRlSGVhZGVycyBhbmQg SmF2YVNjcmlwdENvcmUgcHJvamVjdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5ODg1MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEphdmFTY3JpcHRDb3JlX0NvcHlQcml2YXRlSGVhZGVycyB0YXJnZXQg bmVlZHMgdG8gaGF2ZSBhIGRpcmVjdCBvcgorICAgICAgICBpbmRpcmVjdCBkZXBlbmRlbmN5IG9m IEphdmFTY3JpcHRDb3JlIHRhcmdldCBmb3IgQ01ha2UgVmlzdWFsCisgICAgICAgIFN0dWRpbyBn ZW5lcmF0b3IgdG8gZWxpbWluYXRlIGR1cGxpY2F0ZWQgY3VzdG9tIGNvbW1hbmRzLgorCisgICAg ICAgICogQ01ha2VMaXN0cy50eHQ6IEFkZGVkIEphdmFTY3JpcHRDb3JlIGFzIGEgZGVwZW5kZW5j eSBvZiBKYXZhU2NyaXB0Q29yZV9Db3B5UHJpdmF0ZUhlYWRlcnMuCisKIDIwMTktMDYtMTggIFl1 c3VrZSBTdXp1a2kgIDx5c3V6dWtpQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBKU0xvY2sg c2hvdWxkIGJlIFdlYlRocmVhZCBhd2FyZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRD b3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NNYWtlTGlzdHMudHh0 CmluZGV4IGQ5ODM1M2QzNWEyOTRlOTZlZjE1YjI0MzZkNzFlMmEzMmU4MTc5MjQuLjBkNDk1ZTJm MmFhNDc3OWVmYTA0MTljNjJkY2M1MzJiMTc4ZTUyMDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ01h a2VMaXN0cy50eHQKQEAgLTEyOTcsNiArMTI5NywxMSBAQCBXRUJLSVRfQ09QWV9GSUxFUyhKYXZh U2NyaXB0Q29yZV9Db3B5UHJpdmF0ZUhlYWRlcnMKICAgICBGSUxFUyAke0phdmFTY3JpcHRDb3Jl X1BSSVZBVEVfRlJBTUVXT1JLX0hFQURFUlN9CiAgICAgRkxBVFRFTkVECiApCisjIEphdmFTY3Jp cHRDb3JlX0NvcHlQcml2YXRlSGVhZGVycyBuZWVkcyB0byBoYXZlIGEgZGlyZWN0IG9yIGluZGly ZWN0CisjIGRlcGVuZGVuY3kgb2YgSmF2YVNjcmlwdENvcmUgZm9yIENNYWtlIFZpc3VhbCBTdHVk aW8gZ2VuZXJhdG9yIHRvCisjIGVsaW1pbmF0ZSBkdXBsaWNhdGVkIGN1c3RvbSBjb21tYW5kcy4g T3RoZXJ3aXNlLAorIyBDb21iaW5lZERvbWFpbnMuanNvbiB3aWxsIGJlIGdlbmVyYXRlZCBpbiBi b3RoIHByb2plY3RzLgorYWRkX2RlcGVuZGVuY2llcyhKYXZhU2NyaXB0Q29yZV9Db3B5UHJpdmF0 ZUhlYWRlcnMgSmF2YVNjcmlwdENvcmUpCiAKIHRhcmdldF9pbmNsdWRlX2RpcmVjdG9yaWVzKExM SW50U2V0dGluZ3NFeHRyYWN0b3IgUFJJVkFURQogICAgICR7SmF2YVNjcmlwdENvcmVfSU5DTFVE RV9ESVJFQ1RPUklFU30K