198835 2019-06-13 10:16:58 -0700 [iOS] Normalize test result of fast/events/ios/keyboard-event-key-attribute.html to handle possible modifier dispatch 2019-06-13 16:02:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build iPhone / iPad iOS 12 RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates bfulgham darin webkit-bug-importer oldest_to_newest 1544510 0 dbates 2019-06-13 10:16:58 -0700 In the future, modifier keys like Shift will be dispatched on iOS (just like they are on Mac). Prepare fast/events/ios/keyboard-event-key-attribute.html for this future by normalizing its results. This test types '@' which requires holding down Shift to type on a US keyboard layout, but only expects to see a keydown for '@'. Currently, we only dispatch a keydown for the '@'. In the future, we will dispatch a keydown for Shift followed by a keydown for '@'. 1544511 1 dbates 2019-06-13 10:17:01 -0700 <rdar://problem/46082708> 1544515 2 372065 dbates 2019-06-13 10:23:08 -0700 Created attachment 372065 Patch 1544615 3 372065 dbates 2019-06-13 16:02:01 -0700 Comment on attachment 372065 Patch Clearing flags on attachment: 372065 Committed r246417: <https://trac.webkit.org/changeset/246417> 1544616 4 dbates 2019-06-13 16:02:02 -0700 All reviewed patches have been landed. Closing bug. 372065 2019-06-13 10:23:08 -0700 2019-06-13 16:02:01 -0700 Patch bug-198835-20190613102307.patch text/plain 2323 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzI1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzRjOWRiMGRlYjM5YWM4YjQ2ODU0 ZThkYjQ5YmU5MzAyM2NiZTk3Zi4uYTFlN2ExNDNhMjg0ZDg2MmYwMjY0OWE1NjEyMDM0MmFjM2Y1 NjEwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA2LTEzICBEYW5pZWwgQmF0ZXMgIDxk YWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBOb3JtYWxpemUgdGVzdCByZXN1bHQg b2YgZmFzdC9ldmVudHMvaW9zL2tleWJvYXJkLWV2ZW50LWtleS1hdHRyaWJ1dGUuaHRtbCB0byBo YW5kbGUgcG9zc2libGUgbW9kaWZpZXIgZGlzcGF0Y2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODgzNQorICAgICAgICA8cmRhcjovL3Byb2JsZW0v NDYwODI3MDg+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgV2ViS2l0IG5vdyBrbm93cyBob3cgdG8gaGFuZGxlIGZsYWcgY2hhbmdlIGV2ZW50cyBvbiBp T1MgYW5kIGRpc3BhdGNoIERPTSBldmVudHMganVzdCBsaWtlIE1hYy4KKyAgICAgICAgVW50aWwg VVNFKFVJS0lUX0tFWUJPQVJEX0FERElUSU9OUykgaXMgZW5hYmxlZCBieSBkZWZhdWx0IFdlYktp dCBkb2VzIG5vdCBleHBlY3QgdG8gcmVjZWl2ZQorICAgICAgICBtb2RpZmllciBmbGFnIGNoYW5n ZXMuIEJ1dCBvbmNlIHRoaXMgY29tcGlsZSB0aW1lIGZsYWcgaXMgZW5hYmxlZCBpdCB3aWxsIGFu ZCB0aGUgdGVzdAorICAgICAgICBmYXN0L2V2ZW50cy9pb3Mva2V5Ym9hcmQtZXZlbnQta2V5LWF0 dHJpYnV0ZS5odG1sIHdpbGwgZmFpbCBiZWNhdXNlIGl0IHR5cGVzICdAJyBhbmQgb25seQorICAg ICAgICBleHBlY3RzIHRvIHNlZSBhIHNpbmdsZSBrZXlkb3duIGZvciAnQCcgZXZlbiB0aG91Z2gg aXQgYWN0dWFsbHkgcmVxdWlyZXMgdHdvIGtleSBkb3ducyB0bworICAgICAgICBnZW5lcmF0ZSBh biAnQCc6IFNoaWZ0LCBhbmQgMiAob24gYSBVUyBrZXlib2FyZCBsYXlvdXQpLiBXZSBoYXZlIGEg YnVuY2ggb2Ygb3RoZXIgdGVzdHMgdG8KKyAgICAgICAgY2hlY2sgdGhhdCBtb2RpZmllciBrZXkg cHJlc3NlcyBnZW5lcmF0ZSBET00gZXZlbnRzLiBTbywgbGV0J3MganVzdCBub3JtYWxpemUgdGhl IHJlc3VsdCBvZgorICAgICAgICB0aGlzIHRlc3QgdG8gaWdub3JlIFNoaWZ0IGtleWRvd25zLgor CisgICAgICAgICogZmFzdC9ldmVudHMvaW9zL2tleWJvYXJkLWV2ZW50LWtleS1hdHRyaWJ1dGUu aHRtbDoKKwogMjAxOS0wNi0xMyAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAK ICAgICAgICAgW2lPU10gU3BsaXQgdXAgZmFzdC9ldmVudHMvaW9zL2tleS1ldmVudHMtbWV0YS1h bHQtY29tYmluYXRpb25zLmh0bWwgYW5kIGFkZCBtb3JlIHRlc3RzCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9pb3Mva2V5Ym9hcmQtZXZlbnQta2V5LWF0dHJpYnV0ZS5odG1s IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvaW9zL2tleWJvYXJkLWV2ZW50LWtleS1hdHRyaWJ1 dGUuaHRtbAppbmRleCA3YzFhMmZjZmYyZTMzM2FkNWQ5Y2E5NWU1YWZjN2UxNTM0ZjlmNmE3Li41 ODc1MGFmZTZkNTg3ODljMzI1OWRlNjlhYzI3NDIyODFmOWE5ZDU4IDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L2V2ZW50cy9pb3Mva2V5Ym9hcmQtZXZlbnQta2V5LWF0dHJpYnV0ZS5odG1s CisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2lvcy9rZXlib2FyZC1ldmVudC1rZXktYXR0 cmlidXRlLmh0bWwKQEAgLTMwLDYgKzMwLDkgQEAgZnVuY3Rpb24gZ2V0VHlwaW5nVUlTY3JpcHQo eCwgeSkKIHZhciBpID0gMDsKIHZhciB0ZXN0SW5wdXQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgidGVzdElucHV0Iik7CiB0ZXN0SW5wdXQub25rZXlkb3duID0gZnVuY3Rpb24oZSkgeworICAg IC8vIElnbm9yZSB0aGUgU2hpZnQga2V5IHNvIGFzIHRvIG5vcm1hbGl6ZSB0aGUgdGVzdCByZXN1 bHRzIGFjcm9zcyBkaWZmZXJlbnQgaU9TIHZlcnNpb25zLgorICAgIGlmIChlLmtleSA9PSAiU2hp ZnQiKQorICAgICAgICByZXR1cm47CiAgICAgZXZlbnQgPSBlOwogICAgIHNob3VsZEJlRXF1YWxU b1N0cmluZygiZXZlbnQua2V5IiwgIiIgKyB0ZXN0c1tpXVswXSk7CiAgICAgc2hvdWxkQmVFcXVh bFRvU3RyaW5nKCJldmVudC5jb2RlIiwgIiIgKyB0ZXN0c1tpXVsxXSk7Cg==