198809 2019-06-12 15:01:05 -0700 Clicking the up/down spin buttons for a number input increments/decrements by 2 2019-07-03 15:43:43 -0700 1 1 1 Unclassified WebKit Forms WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED data:text/html,<html><body><input%20type="number"%20value="0"></body></html> InRadar P2 Normal --- 1 hi timothy cdumez commit-queue darin hi rniwa timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1544248 0 hi 2019-06-12 15:01:05 -0700 # STEPS TO REPRODUCE: 1. data:text/html,<html><body><input%20type="number" value="0"></body></html> 2. click the up/down spin button => value changes to 2/-2 NOTE: this does NOT happen if you use the up/down arrow keys. 1544250 1 wenson_hsieh 2019-06-12 15:05:21 -0700 <rdar://problem/51431402> 1547863 2 thorton 2019-06-25 16:19:32 -0700 *** Bug 199210 has been marked as a duplicate of this bug. *** 1547865 3 372873 timothy 2019-06-25 16:24:01 -0700 Created attachment 372873 Patch 1547880 4 372873 commit-queue 2019-06-25 16:42:09 -0700 Comment on attachment 372873 Patch Clearing flags on attachment: 372873 Committed r246818: <https://trac.webkit.org/changeset/246818> 1547881 5 commit-queue 2019-06-25 16:42:11 -0700 All reviewed patches have been landed. Closing bug. 1550054 6 darin 2019-07-03 15:43:20 -0700 Should we still respect the settings to match AppKit scroller behavior? The settings haven’t been removed, it’s just that the defaulting mechanism used has changed. 1550056 7 darin 2019-07-03 15:43:43 -0700 I suppose spin buttons are not scrollers, so it’s strange to respect the setting here. 372873 2019-06-25 16:24:01 -0700 2019-06-25 16:42:09 -0700 Patch bug-198809-20190625162400.patch text/plain 3789 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2NzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2E4MjM5N2VlM2EwOTQ1 MzQyNjBiOWRkNmE2NjZjZWVmZmUzNjdjMy4uZWE2N2RlOWE3MWI4ZDIxZjBjYTU4Y2UxMjZmZjk1 NmFhOGVmNDBjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE5LTA2LTI1ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBDbGlja2luZyB0aGUg dXAvZG93biBzcGluIGJ1dHRvbnMgZm9yIGEgbnVtYmVyIGlucHV0IGluY3JlbWVudHMvZGVjcmVt ZW50cyBieSAyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk4ODA5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVGltIEhvcnRvbi4KKworICAgICAgICBB cHBLaXQgbm8gbG9uZ2VyIHJlZ2lzdGVycyBOU1Njcm9sbGVyQnV0dG9uRGVsYXkgYW5kIE5TU2Ny b2xsZXJCdXR0b25QZXJpb2QgaW4gdGhlIGJhc2UKKyAgICAgICAgTlNVc2VyRGVmYXVsdHMgZm9y IGFuIGFwcC4gVGhpcyBjYXVzZWQgb3VyIHVzZSB0byBhbHdheXMgZ2V0IDBzIHdoZW4gc2V0dGlu ZyB0aGUgY2xpY2sKKyAgICAgICAgYW5kIGhvbGQgdGltZXIsIGNhdXNpbmcgdGhlIHZhbHVlIHRv IGluY3JlbWVudCBxdWlja2x5IGZvciBhIHNpbmdsZSBwcmVzcy4KKworICAgICAgICAqIHBsYXRm b3JtL21hYy9TY3JvbGxiYXJUaGVtZU1hYy5oOgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFy VGhlbWVNYWM6OmluaXRpYWxBdXRvc2Nyb2xsVGltZXJEZWxheSk6IEFkZGVkLiBIYXJkY29kZSA1 MDBtcy4KKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjphdXRvc2Nyb2xsVGlt ZXJEZWxheSk6IEFkZGVkLiBIYXJkY29kZSA1MG1zLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9T Y3JvbGxiYXJUaGVtZU1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lTWFj OjpwcmVmZXJlbmNlc0NoYW5nZWQpOiBSZW1vdmVkIHVzZSBvZiBvbGQgdXNlciBkZWZhdWx0cy4K KyAgICAgICAgKFdlYkNvcmU6OlNjcm9sbGJhclRoZW1lTWFjOjppbml0aWFsQXV0b3Njcm9sbFRp bWVyRGVsYXkpOiBEZWxldGVkLgorICAgICAgICAoV2ViQ29yZTo6U2Nyb2xsYmFyVGhlbWVNYWM6 OmF1dG9zY3JvbGxUaW1lckRlbGF5KTogRGVsZXRlZC4KKwogMjAxOS0wNi0yNCAgSmVyIE5vYmxl ICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBpT1MgMTIuMiBEcmF3aW5nIHBvcnRy YWl0IHZpZGVvIHRvIGNhbnZhcyBpcyBzaWRld2F5cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMuaAppbmRleCA3NGFhNGZkMzMzZmQ2OGFkMTNiOWIx MTRkMzI4ZWE3NmVhOTY4YjBiLi5jZjBlZWFmMmExM2Y3Y2FkOGRkMjc3MGU3NjQwNWYwYmMxN2I1 NjU1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhl bWVNYWMuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVN YWMuaApAQCAtNTIsOCArNTIsOCBAQCBwdWJsaWM6CiAgICAgdm9pZCB1c2VzT3ZlcmxheVNjcm9s bGJhcnNDaGFuZ2VkKCkgb3ZlcnJpZGU7CiAgICAgdm9pZCB1cGRhdGVTY3JvbGxiYXJPdmVybGF5 U3R5bGUoU2Nyb2xsYmFyJikgIG92ZXJyaWRlOwogCi0gICAgU2Vjb25kcyBpbml0aWFsQXV0b3Nj cm9sbFRpbWVyRGVsYXkoKSBvdmVycmlkZTsKLSAgICBTZWNvbmRzIGF1dG9zY3JvbGxUaW1lckRl bGF5KCkgb3ZlcnJpZGU7CisgICAgU2Vjb25kcyBpbml0aWFsQXV0b3Njcm9sbFRpbWVyRGVsYXko KSBvdmVycmlkZSB7IHJldHVybiA1MDBfbXM7IH0KKyAgICBTZWNvbmRzIGF1dG9zY3JvbGxUaW1l ckRlbGF5KCkgb3ZlcnJpZGUgeyByZXR1cm4gNTBfbXM7IH0KIAogICAgIFNjcm9sbGJhckJ1dHRv bnNQbGFjZW1lbnQgYnV0dG9uc1BsYWNlbWVudCgpIGNvbnN0IG92ZXJyaWRlOwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvU2Nyb2xsYmFyVGhlbWVNYWMubW0KaW5kZXggYjVk OTI2YTFiNTdiZDRjZmViOTU3NzUzMjliM2FkNTQzZTc2Njg3Ni4uMzVhMTQxYTdlNzZiODM4NzQ3 ZTc3NzljOWE0ZWU3YzdlZjBiNGNkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1Njcm9sbGJhclRoZW1lTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9TY3JvbGxiYXJUaGVtZU1hYy5tbQpAQCAtMTM2LDggKzEzNiw2IEBAIHN0YXRpYyBjb25z dCBpbnQgY0J1dHRvbkxlbmd0aFtdID0geyAxNCwgMTAgfTsKIHN0YXRpYyBjb25zdCBpbnQgY091 dGVyQnV0dG9uTGVuZ3RoW10gPSB7IDE2LCAxNCB9OyAvLyBUaGUgb3V0ZXIgYnV0dG9uIGluIGEg ZG91YmxlIGJ1dHRvbiBwYWlyIGlzIGEgYml0IGJpZ2dlci4KIHN0YXRpYyBjb25zdCBpbnQgY091 dGVyQnV0dG9uT3ZlcmxhcCA9IDI7CiAKLXN0YXRpYyBTZWNvbmRzIGdJbml0aWFsQnV0dG9uRGVs YXkgeyA1MDBfbXMgfTsKLXN0YXRpYyBTZWNvbmRzIGdBdXRvc2Nyb2xsQnV0dG9uRGVsYXkgeyA1 MF9tcyB9Owogc3RhdGljIGJvb2wgZ0p1bXBPblRyYWNrQ2xpY2sgPSBmYWxzZTsKIHN0YXRpYyBi b29sIGdVc2VzT3ZlcmxheVNjcm9sbGJhcnMgPSBmYWxzZTsKIApAQCAtMjQwLDggKzIzOCw2IEBA IHZvaWQgU2Nyb2xsYmFyVGhlbWVNYWM6OnByZWZlcmVuY2VzQ2hhbmdlZCgpCiB7CiAgICAgTlNV c2VyRGVmYXVsdHMgKmRlZmF1bHRzID0gW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1 bHRzXTsKICAgICBbZGVmYXVsdHMgc3luY2hyb25pemVdOwotICAgIGdJbml0aWFsQnV0dG9uRGVs YXkgPSBTZWNvbmRzIHsgW2RlZmF1bHRzIGZsb2F0Rm9yS2V5OkAiTlNTY3JvbGxlckJ1dHRvbkRl bGF5Il0gfTsKLSAgICBnQXV0b3Njcm9sbEJ1dHRvbkRlbGF5ID0gU2Vjb25kcyB7IFtkZWZhdWx0 cyBmbG9hdEZvcktleTpAIk5TU2Nyb2xsZXJCdXR0b25QZXJpb2QiXSB9OwogICAgIGdKdW1wT25U cmFja0NsaWNrID0gW2RlZmF1bHRzIGJvb2xGb3JLZXk6QCJBcHBsZVNjcm9sbGVyUGFnaW5nQmVo YXZpb3IiXTsKICAgICB1c2VzT3ZlcmxheVNjcm9sbGJhcnNDaGFuZ2VkKCk7CiB9CkBAIC0yODMs MTYgKzI3OSw2IEBAIHZvaWQgU2Nyb2xsYmFyVGhlbWVNYWM6OnVwZGF0ZVNjcm9sbGJhck92ZXJs YXlTdHlsZShTY3JvbGxiYXImIHNjcm9sbGJhcikKICAgICBFTkRfQkxPQ0tfT0JKQ19FWENFUFRJ T05TOwogfQogCi1TZWNvbmRzIFNjcm9sbGJhclRoZW1lTWFjOjppbml0aWFsQXV0b3Njcm9sbFRp bWVyRGVsYXkoKQotewotICAgIHJldHVybiBnSW5pdGlhbEJ1dHRvbkRlbGF5OwotfQotCi1TZWNv bmRzIFNjcm9sbGJhclRoZW1lTWFjOjphdXRvc2Nyb2xsVGltZXJEZWxheSgpCi17Ci0gICAgcmV0 dXJuIGdBdXRvc2Nyb2xsQnV0dG9uRGVsYXk7Ci19Ci0gICAgCiBTY3JvbGxiYXJCdXR0b25zUGxh Y2VtZW50IFNjcm9sbGJhclRoZW1lTWFjOjpidXR0b25zUGxhY2VtZW50KCkgY29uc3QKIHsKICAg ICByZXR1cm4gZ0J1dHRvblBsYWNlbWVudDsK