198801 2019-06-12 14:05:34 -0700 Web Inspector: artificial context menus don't work when Web Inspector is zoomed 2019-07-07 14:58:53 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1544222 0 hi 2019-06-12 14:05:34 -0700 :( 1544225 1 371985 hi 2019-06-12 14:10:19 -0700 Created attachment 371985 Patch 1544228 2 371985 joepeck 2019-06-12 14:17:32 -0700 Comment on attachment 371985 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371985&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:431 > auto& mouseEvent = downcast<MouseEvent>(event); > + > IntPoint mousePoint { mouseEvent.clientX(), mouseEvent.clientY() }; > + mousePoint.scale(zoomFactor()); Seems fine, but is there a better way to get the mouse position of zoomed content? MouseRelatedEvent.h has: // Page point in "absolute" coordinates (i.e. post-zoomed, page-relative coords, // usable with RenderObject::absoluteToLocal). const LayoutPoint& absoluteLocation() const { return m_absoluteLocation; } That ultimately uses: float FrameView::documentToAbsoluteScaleFactor(Optional<float> effectiveZoom) const { // If effectiveZoom is passed, it already factors in pageZoomFactor(). return effectiveZoom.valueOr(frame().pageZoomFactor()) * frame().frameScaleFactor(); } As opposed to the current `InspectorFrontendHost::zoomFactor()` which only does the page zoom: m_frontendPage->mainFrame().pageZoomFactor(); So, what is `frameScaleFactor` and what is that / should that be taken into account here? 1544253 3 371985 joepeck 2019-06-12 15:09:11 -0700 Comment on attachment 371985 Patch r=me though since this can't be worse then what we currently have 1544255 4 371991 hi 2019-06-12 15:12:33 -0700 Created attachment 371991 Patch 1544266 5 371991 commit-queue 2019-06-12 15:46:20 -0700 Comment on attachment 371991 Patch Clearing flags on attachment: 371991 Committed r246384: <https://trac.webkit.org/changeset/246384> 1544267 6 commit-queue 2019-06-12 15:46:22 -0700 All reviewed patches have been landed. Closing bug. 1544268 7 webkit-bug-importer 2019-06-12 15:49:58 -0700 <rdar://problem/51686539> 1550735 8 hi 2019-07-07 14:58:53 -0700 *** Bug 195759 has been marked as a duplicate of this bug. *** 371985 2019-06-12 14:10:19 -0700 2019-06-12 15:12:32 -0700 Patch bug-198801-20190612141018.patch text/plain 1599 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MGFmMDljNjYxOTdlYzU3MjQwODM2NzMyOGNkM2NiZDZhNzg4NWEzLi5j NDRiNGE3ZmUxZDg0ZDA3NWRlMzc0ZWU0MGVmMDEwZGQyOTZiMDUwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMDYtMTIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFydGlmaWNpYWwgY29udGV4dCBtZW51cyBkb24n dCB3b3JrIHdoZW4gV2ViIEluc3BlY3RvciBpcyB6b29tZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODgwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5k SG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OmRpc3Bh dGNoRXZlbnRBc0NvbnRleHRNZW51RXZlbnQpOgorICAgICAgICBJZiB0aGUgV2ViIEluc3BlY3Rv ciBpcyB6b29tZWQsIGFkanVzdCB0aGUgYGNsaWVudFhgL2BjbGllbnRZYCBieSB0aGUgem9vbSBm YWN0b3IuCisKIDIwMTktMDYtMTIgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgog CiAgICAgICAgIChBc3luYyBzY3JvbGxpbmcpIEhhbmRsZSAncG9zaXRpb246Zml4ZWQnIGluc2lk ZSAncG9zaXRpb246c3RpY2t5JyBjb3JyZWN0bHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuY3BwCmluZGV4IDY0ZDFhYmFlYzI3OGIxZmUx NDJlMjE2MTJiMTY1OTliODk0OWNiMjAuLjI4N2EyMWZiYmNlOGM0Mzk3NjlhNTAxN2Q4NTFlOWNj OGNkMTQ0NDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JG cm9udGVuZEhvc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JG cm9udGVuZEhvc3QuY3BwCkBAIC00MjYsNyArNDI2LDEwIEBAIHZvaWQgSW5zcGVjdG9yRnJvbnRl bmRIb3N0OjpkaXNwYXRjaEV2ZW50QXNDb250ZXh0TWVudUV2ZW50KEV2ZW50JiBldmVudCkKICAg ICAgICAgcmV0dXJuOwogCiAgICAgYXV0byYgbW91c2VFdmVudCA9IGRvd25jYXN0PE1vdXNlRXZl bnQ+KGV2ZW50KTsKKwogICAgIEludFBvaW50IG1vdXNlUG9pbnQgeyBtb3VzZUV2ZW50LmNsaWVu dFgoKSwgbW91c2VFdmVudC5jbGllbnRZKCkgfTsKKyAgICBtb3VzZVBvaW50LnNjYWxlKHpvb21G YWN0b3IoKSk7CisKICAgICBhdXRvJiBmcmFtZSA9ICpkb3duY2FzdDxOb2RlPihtb3VzZUV2ZW50 LnRhcmdldCgpKS0+ZG9jdW1lbnQoKS5mcmFtZSgpOwogCiAgICAgbV9mcm9udGVuZFBhZ2UtPmNv bnRleHRNZW51Q29udHJvbGxlcigpLnNob3dDb250ZXh0TWVudUF0KGZyYW1lLCBtb3VzZVBvaW50 KTsK 371991 2019-06-12 15:12:33 -0700 2019-06-12 15:46:20 -0700 Patch bug-198801-20190612151232.patch text/plain 1725 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA0MGFmMDljNjYxOTdlYzU3MjQwODM2NzMyOGNkM2NiZDZhNzg4NWEzLi4x ZDZhNTMxZWY0ZjA2NWM3YjE0OTkxZWUyM2U0MGNjNjVjNGQ3YzZkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTktMDYtMTIgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IGFydGlmaWNpYWwgY29udGV4dCBtZW51cyBkb24n dCB3b3JrIHdoZW4gV2ViIEluc3BlY3RvciBpcyB6b29tZWQKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODgwMQorCisgICAgICAgIFJldmlld2VkIGJ5 IEpvc2VwaCBQZWNvcmFyby4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVu ZEhvc3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRnJvbnRlbmRIb3N0OjpkaXNw YXRjaEV2ZW50QXNDb250ZXh0TWVudUV2ZW50KToKKyAgICAgICAgVXNlIHRoZSBgYWJzb2x1dGVM b2NhdGlvbmAgb2YgdGhlIGBNb3VzZUV2ZW50YCwgd2hpY2ggdGFrZXMgaW50byBhY2NvdW50IHpv b20gYW5kIHNjYWxlLgorCiAyMDE5LTA2LTEyICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxl LmNvbT4KIAogICAgICAgICAoQXN5bmMgc2Nyb2xsaW5nKSBIYW5kbGUgJ3Bvc2l0aW9uOmZpeGVk JyBpbnNpZGUgJ3Bvc2l0aW9uOnN0aWNreScgY29ycmVjdGx5LgpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0LmNwcAppbmRleCA2NGQxYWJhZWMy NzhiMWZlMTQyZTIxNjEyYjE2NTk5Yjg5NDljYjIwLi43MWNhNDRiZmZkNDYwYTBmZDJmMjJmZGVm OWU2NzliMzlhMWI4NzU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRnJvbnRlbmRIb3N0LmNwcApAQCAtNDI2LDEwICs0MjYsOCBAQCB2b2lkIEluc3BlY3Rv ckZyb250ZW5kSG9zdDo6ZGlzcGF0Y2hFdmVudEFzQ29udGV4dE1lbnVFdmVudChFdmVudCYgZXZl bnQpCiAgICAgICAgIHJldHVybjsKIAogICAgIGF1dG8mIG1vdXNlRXZlbnQgPSBkb3duY2FzdDxN b3VzZUV2ZW50PihldmVudCk7Ci0gICAgSW50UG9pbnQgbW91c2VQb2ludCB7IG1vdXNlRXZlbnQu Y2xpZW50WCgpLCBtb3VzZUV2ZW50LmNsaWVudFkoKSB9OwogICAgIGF1dG8mIGZyYW1lID0gKmRv d25jYXN0PE5vZGU+KG1vdXNlRXZlbnQudGFyZ2V0KCkpLT5kb2N1bWVudCgpLmZyYW1lKCk7Ci0K LSAgICBtX2Zyb250ZW5kUGFnZS0+Y29udGV4dE1lbnVDb250cm9sbGVyKCkuc2hvd0NvbnRleHRN ZW51QXQoZnJhbWUsIG1vdXNlUG9pbnQpOworICAgIG1fZnJvbnRlbmRQYWdlLT5jb250ZXh0TWVu dUNvbnRyb2xsZXIoKS5zaG93Q29udGV4dE1lbnVBdChmcmFtZSwgcm91bmRlZEludFBvaW50KG1v dXNlRXZlbnQuYWJzb2x1dGVMb2NhdGlvbigpKSk7CiAjZWxzZQogICAgIFVOVVNFRF9QQVJBTShl dmVudCk7CiAjZW5kaWYK