198795 2019-06-12 11:05:33 -0700 API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash 2020-03-03 18:28:55 -0800 1 1 1 Unclassified WebKit WebKit API WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sroberts beidson aestes beidson cdumez commit-queue jbedard keith_miller ryanhaddad saam webkit-bot-watchers-bugzilla webkit-bug-importer wenson_hsieh oldest_to_newest 1544164 0 sroberts 2019-06-12 11:05:33 -0700 The following API test is a flaky crash on Mojave+ WK2 Debug testers TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments Test was added in r235137 Test appears to have been a flaky crash for quite some time now but it appears we have not noticed it. around 6/07/2019 it started to crash more consistently and around 6/11/2019 started to crash every 3 runs or so. https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29?numbuilds=200 I can see a crash back on May 31st as well. https://build.webkit.org/builders/Apple%20Mojave%20Debug%20WK2%20%28Tests%29/builds/2836/steps/run-api-tests/logs/stdio Reproduced locally 2 ways. run-api-tests TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments --iter 200 --debug I can also reproduce it in guard malloc and it fails more consistently in that configuration. I can reproduce the crash in both modes going all the way back to r235137 and it produces the same crash. I don't know if recent jsc changes in this area may have made it more consistent. Attaching the full crash log and the guard malloc crash log to the radar. 0 com.apple.JavaScriptCore 0x000000010bc798cd bmalloc::SmallLine::deref(std::__1::unique_lock<bmalloc::Mutex>&) + 45 1 com.apple.JavaScriptCore 0x000000010bc795fc bmalloc::Heap::derefSmallLine(std::__1::unique_lock<bmalloc::Mutex>&, bmalloc::Object, std::__1::array<bmalloc::List<bmalloc::SmallPage>, 112ul>&) + 60 2 com.apple.JavaScriptCore 0x000000010bc79525 bmalloc::Deallocator::processObjectLog(std::__1::unique_lock<bmalloc::Mutex>&) + 165 3 com.apple.JavaScriptCore 0x000000010bc7976e bmalloc::Deallocator::deallocateSlowCase(void*) + 270 4 com.apple.JavaScriptCore 0x000000010bbe3244 bmalloc::Deallocator::deallocate(void*) + 68 5 com.apple.JavaScriptCore 0x000000010bbe31e5 bmalloc::Cache::deallocate(bmalloc::HeapKind, void*) + 165 6 com.apple.JavaScriptCore 0x000000010bbe277b bmalloc::api::free(void*, bmalloc::HeapKind) + 27 7 com.apple.JavaScriptCore 0x000000010bbe2757 WTF::fastFree(void*) + 23 8 com.apple.JavaScriptCore 0x000000010bc40737 WTF::StringWrapperCFAllocator::deallocate(void*, void*) + 103 1544165 1 sroberts 2019-06-12 11:06:45 -0700 Adding Wenson who created the test. Andy who made a recent change that affected Catalina, and Saam and Keith who appear to have made some changes in the past on bmalloc::SmallLine::deref and have had recent changes in this area after the test seems to have gotten more flaky? 1544166 2 webkit-bug-importer 2019-06-12 11:08:34 -0700 <rdar://problem/51674325> 1544170 3 wenson_hsieh 2019-06-12 11:22:28 -0700 (In reply to Shawn Roberts from comment #1) > Adding Wenson who created the test. Andy who made a recent change that > affected Catalina, and Saam and Keith who appear to have made some changes > in the past on bmalloc::SmallLine::deref and have had recent changes in this > area after the test seems to have gotten more flaky? I don’t think this test failure is relevant to JSC. 1547400 4 ryanhaddad 2019-06-24 10:38:25 -0700 Disabled test in https://trac.webkit.org/r246739 1615350 5 389890 beidson 2020-02-05 15:50:55 -0800 Created attachment 389890 Patch 1615367 6 jbedard 2020-02-05 16:03:31 -0800 Not against re-enabling this test, but what makes us think it's not flakey? 1615387 7 beidson 2020-02-05 16:32:09 -0800 (In reply to Jonathan Bedard from comment #6) > Not against re-enabling this test, but what makes us think it's not flakey? Ah, I'd only put it in the radar: >I cannot reproduce with today’s trunk with the referenced command: >run-api-tests TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments --iter 200 --debug >… or under guardmalloc. > >Seems like this righted itself at some point. 1625342 8 389890 ap 2020-03-03 17:30:45 -0800 Comment on attachment 389890 Patch Let's get this landed then, cq+. 1625352 9 commit-queue 2020-03-03 18:28:17 -0800 The commit-queue encountered the following flaky tests while processing attachment 389890: editing/spelling/spellcheck-async-remove-frame.html bug 158401 (authors: morrita@google.com, rniwa@webkit.org, and tony@chromium.org) The commit-queue is continuing to process your patch. 1625353 10 389890 commit-queue 2020-03-03 18:28:53 -0800 Comment on attachment 389890 Patch Clearing flags on attachment: 389890 Committed r257817: <https://trac.webkit.org/changeset/257817> 1625354 11 commit-queue 2020-03-03 18:28:55 -0800 All reviewed patches have been landed. Closing bug. 389890 2020-02-05 15:50:55 -0800 2020-03-03 18:28:53 -0800 Patch bug-198795-20200205155054.patch text/plain 1548 beidson U3VidmVyc2lvbiBSZXZpc2lvbjogMjU1ODYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYzEzNjAyNzZhOWM2Mzk4N2UzZTY3NjIwMjEyNzExYjIw YzZmZTRjNS4uY2YwZjNhMjVhOWQyNDBhNzM1MGNiMDBiYzgxODJlNmI5ODY5MDRhMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIwLTAyLTA1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KKworICAg ICAgICBBUEkgVGVzdCBbTW9qYXZlKyBXSzIgRGVidWcgXSBUZXN0V2ViS2l0QVBJLldLQXR0YWNo bWVudFRlc3RzTWFjLkluc2VydERyb3BwZWRGaWxlUHJvbWlzZXNBc0F0dGFjaG1lbnRzIGlzIGEg Zmxha3kgY3Jhc2guCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xOTg3OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIHRlc3QgYXBwZWFycyB0byBubyBsb25nZXIgYmUgZmxha3kuCisgICAgICAgIAor ICAgICAgICBMZXQncyByZS1lbmFibGUgaXQuCisgICAgICAgIAorICAgICAgICAqIFRlc3RXZWJL aXRBUEkvVGVzdHMvV2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW06CisgICAgICAgIChU ZXN0V2ViS2l0QVBJOjpURVNUKToKKwogMjAyMC0wMi0wNSAgSm9uYXRoYW4gQmVkYXJkICA8amJl ZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgcmVzdWx0cy53ZWJraXQub3JnOiBBcHBseSB0dGwg dG8gYXJjaGl2ZSBzaGFyZHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViS2l0Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYktpdENvY29hL1dLQXR0YWNobWVudFRlc3RzLm1tCmluZGV4IDE4NjBkYzM1YmU3Yzli YTQxYmU4MTgwMTY5MTQ3Yzg4ZTQ0YjgxYzEuLjk5NzUwNWJjNDBkYzA4N2EwNWU5M2M4Njk4ZTkw OGM0YjlkZGEzYzggMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0 Q29jb2EvV0tBdHRhY2htZW50VGVzdHMubW0KKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0 cy9XZWJLaXRDb2NvYS9XS0F0dGFjaG1lbnRUZXN0cy5tbQpAQCAtMTYwOCw3ICsxNjA4LDcgQEAg VEVTVChXS0F0dGFjaG1lbnRUZXN0c01hYywgSW5zZXJ0UGFzdGVkRmlsZVVSTHNBc0F0dGFjaG1l bnRzKQogICAgIH0KIH0KIAotVEVTVChXS0F0dGFjaG1lbnRUZXN0c01hYywgRElTQUJMRURfSW5z ZXJ0RHJvcHBlZEZpbGVQcm9taXNlc0FzQXR0YWNobWVudHMpCitURVNUKFdLQXR0YWNobWVudFRl c3RzTWFjLCBJbnNlcnREcm9wcGVkRmlsZVByb21pc2VzQXNBdHRhY2htZW50cykKIHsKICAgICBh dXRvIGNvbmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxv Y10gaW5pdF0pOwogICAgIFtjb25maWd1cmF0aW9uIF9zZXRBdHRhY2htZW50RWxlbWVudEVuYWJs ZWQ6WUVTXTsK