198792 2019-06-12 09:13:31 -0700 Replace double-quotes with single quotes in loadConfig.py 2019-06-12 13:39:17 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain commit-queue jbedard webkit-bug-importer oldest_to_newest 1544124 0 aakash_jain 2019-06-12 09:13:31 -0700 We prefer using single quotes as compared to double quotes in our python code. There is a mix of single and double quotes in loadConfig.py. We should replace double-quotes with single quotes. 1544126 1 371966 aakash_jain 2019-06-12 09:14:46 -0700 Created attachment 371966 Patch 1544213 2 371966 commit-queue 2019-06-12 13:38:24 -0700 Comment on attachment 371966 Patch Clearing flags on attachment: 371966 Committed r246373: <https://trac.webkit.org/changeset/246373> 1544214 3 commit-queue 2019-06-12 13:38:25 -0700 All reviewed patches have been landed. Closing bug. 1544217 4 webkit-bug-importer 2019-06-12 13:39:17 -0700 <rdar://problem/51680562> 371966 2019-06-12 09:14:46 -0700 2019-06-12 13:38:24 -0700 Patch bug-198792-20190612121445.patch text/plain 3895 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI0NjM1MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDE5LTA2LTEyICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBSZXBsYWNlIGRvdWJsZS1xdW90ZXMgd2l0aCBzaW5nbGUgcXVvdGVzIGlu IGxvYWRDb25maWcucHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE5ODc5MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHk6CisgICAg ICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5OgorCiAy MDE5LTA2LTEyICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAog ICAgICAgICBbV1BFXVtHVEtdIERlcHJlY2F0ZSBXZWJTUUwgQVBJcwpJbmRleDogVG9vbHMvQnVp bGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL2xvYWRDb25maWcucHkJKHJldmlzaW9uIDI0 NjM1MykKKysrIFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9sb2FkQ29uZmlnLnB5 CSh3b3JraW5nIGNvcHkpCkBAIC01OCwxNyArNTgsMTcgQEAgZGVmIGxvYWRCdWlsZGVyQ29uZmln KGMsIGlzX3Rlc3RfbW9kZV9lbgogICAgIGZvciBidWlsZGVyIGluIGNvbmZpZ1snYnVpbGRlcnMn XToKICAgICAgICAgYnVpbGRlclsndGFncyddID0gZ2V0VGFnc0ZvckJ1aWxkZXIoYnVpbGRlcikK ICAgICAgICAgZmFjdG9yeSA9IGdsb2JhbHMoKVtidWlsZGVyWydmYWN0b3J5J11dCi0gICAgICAg IGJ1aWxkZXJbJ2Rlc2NyaXB0aW9uJ10gPSBidWlsZGVyLnBvcCgic2hvcnRuYW1lIikKKyAgICAg ICAgYnVpbGRlclsnZGVzY3JpcHRpb24nXSA9IGJ1aWxkZXIucG9wKCdzaG9ydG5hbWUnKQogICAg ICAgICBmYWN0b3J5a3dhcmdzID0ge30KLSAgICAgICAgZm9yIGtleSBpbiBbInBsYXRmb3JtIiwg ImNvbmZpZ3VyYXRpb24iLCAiYXJjaGl0ZWN0dXJlcyIsICJ0cmlnZ2VycyIsICJhZGRpdGlvbmFs QXJndW1lbnRzIl06CisgICAgICAgIGZvciBrZXkgaW4gWydwbGF0Zm9ybScsICdjb25maWd1cmF0 aW9uJywgJ2FyY2hpdGVjdHVyZXMnLCAndHJpZ2dlcnMnLCAnYWRkaXRpb25hbEFyZ3VtZW50cydd OgogICAgICAgICAgICAgdmFsdWUgPSBidWlsZGVyLnBvcChrZXksIE5vbmUpCiAgICAgICAgICAg ICBpZiB2YWx1ZToKICAgICAgICAgICAgICAgICBmYWN0b3J5a3dhcmdzW2tleV0gPSB2YWx1ZQog Ci0gICAgICAgIGJ1aWxkZXJbImZhY3RvcnkiXSA9IGZhY3RvcnkoKipmYWN0b3J5a3dhcmdzKQor ICAgICAgICBidWlsZGVyWydmYWN0b3J5J10gPSBmYWN0b3J5KCoqZmFjdG9yeWt3YXJncykKIAog ICAgICAgICBpZiB1c2VfbG9jYWxob3N0X3dvcmtlcjoKLSAgICAgICAgICAgIGJ1aWxkZXJbJ3dv cmtlcm5hbWVzJ10uYXBwZW5kKCJsb2NhbC13b3JrZXIiKQorICAgICAgICAgICAgYnVpbGRlclsn d29ya2VybmFtZXMnXS5hcHBlbmQoJ2xvY2FsLXdvcmtlcicpCiAKICAgICAgICAgY1snYnVpbGRl cnMnXS5hcHBlbmQoYnVpbGRlcikKIApJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0J1aWxkU2xhdmVT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjQ2MzUzKQorKysg VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC00NzcsNyArNDc3LDcgQEAgY2xhc3MgVGVzdENvbXBpbGVXZWJLaXQoQnVp bGRTdGVwTWl4aW5BZAogICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywg J3JlbGVhc2UnKQogICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAg ICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAotICAgICAgICAgICAgICAgICAgICAgICAg Y29tbWFuZD1bInBlcmwiLCAiVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQiLCAnLS1yZWxlYXNl J10sCisgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncGVybCcsICdUb29scy9TY3Jp cHRzL2J1aWxkLXdlYmtpdCcsICctLXJlbGVhc2UnXSwKICAgICAgICAgICAgICAgICAgICAgICAg ICkKICAgICAgICAgICAgICsgMCwKICAgICAgICAgKQpAQCAtNDkwLDcgKzQ5MCw3IEBAIGNsYXNz IFRlc3RDb21waWxlV2ViS2l0KEJ1aWxkU3RlcE1peGluQWQKICAgICAgICAgc2VsZi5zZXRQcm9w ZXJ0eSgnY29uZmlndXJhdGlvbicsICdkZWJ1ZycpCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3Rl Q29tbWFuZHMoCiAgICAgICAgICAgICBFeHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCi0gICAg ICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsicGVybCIsICJUb29scy9TY3JpcHRzL2J1aWxk LXdlYmtpdCIsICctLWRlYnVnJ10sCisgICAgICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsn cGVybCcsICdUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdCcsICctLWRlYnVnJ10sCiAgICAgICAg ICAgICAgICAgICAgICAgICApCiAgICAgICAgICAgICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8n LCBzdGRvdXQ9JzEgZXJyb3IgZ2VuZXJhdGVkLicpCiAgICAgICAgICAgICArIDIsCkBAIC01NTks NyArNTU5LDcgQEAgY2xhc3MgVGVzdENvbXBpbGVKU0NPbmx5KEJ1aWxkU3RlcE1peGluQQogICAg ICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9uJywgJ3JlbGVhc2UnKQogICAgICAg ICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAogICAgICAgICAgICAgRXhwZWN0U2hlbGwod29y a2Rpcj0nd2tkaXInLAotICAgICAgICAgICAgICAgICAgICAgICAgY29tbWFuZD1bInBlcmwiLCAi VG9vbHMvU2NyaXB0cy9idWlsZC1qc2MiLCAnLS1yZWxlYXNlJ10sCisgICAgICAgICAgICAgICAg ICAgICAgICBjb21tYW5kPVsncGVybCcsICdUb29scy9TY3JpcHRzL2J1aWxkLWpzYycsICctLXJl bGVhc2UnXSwKICAgICAgICAgICAgICAgICAgICAgICAgICkKICAgICAgICAgICAgICsgMCwKICAg ICAgICAgKQpAQCAtNTcyLDcgKzU3Miw3IEBAIGNsYXNzIFRlc3RDb21waWxlSlNDT25seShCdWls ZFN0ZXBNaXhpbkEKICAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnY29uZmlndXJhdGlvbicsICdk ZWJ1ZycpCiAgICAgICAgIHNlbGYuZXhwZWN0UmVtb3RlQ29tbWFuZHMoCiAgICAgICAgICAgICBF eHBlY3RTaGVsbCh3b3JrZGlyPSd3a2RpcicsCi0gICAgICAgICAgICAgICAgICAgICAgICBjb21t YW5kPVsicGVybCIsICJUb29scy9TY3JpcHRzL2J1aWxkLWpzYyIsICctLWRlYnVnJ10sCisgICAg ICAgICAgICAgICAgICAgICAgICBjb21tYW5kPVsncGVybCcsICdUb29scy9TY3JpcHRzL2J1aWxk LWpzYycsICctLWRlYnVnJ10sCiAgICAgICAgICAgICAgICAgICAgICAgICApCiAgICAgICAgICAg ICArIEV4cGVjdFNoZWxsLmxvZygnc3RkaW8nLCBzdGRvdXQ9JzEgZXJyb3IgZ2VuZXJhdGVkLicp CiAgICAgICAgICAgICArIDIsCg==