198785 2019-06-12 06:14:18 -0700 [GTK] gtk_misc_set_alignment is deprecated since GTK 3.14 2019-06-12 07:09:17 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ludovico.denittis webkit-unassigned berto bugs-noreply cgarcia commit-queue ews-watchlist gustavo mcatanzaro oldest_to_newest 1544047 0 ludovico.denittis 2019-06-12 06:14:18 -0700 Since GTK 3.14 "gtk_misc_set_alignment" has been deprecated. "gtk_widget_set_halign" and "gtk_widget_set_valign" should be used instead, both available since GTK 3. I'll attach a patch. 1544048 1 371947 ludovico.denittis 2019-06-12 06:16:42 -0700 Created attachment 371947 Patch 1544049 2 ews-watchlist 2019-06-12 06:19:14 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1544063 3 371947 commit-queue 2019-06-12 07:09:15 -0700 Comment on attachment 371947 Patch Clearing flags on attachment: 371947 Committed r246351: <https://trac.webkit.org/changeset/246351> 1544064 4 commit-queue 2019-06-12 07:09:17 -0700 All reviewed patches have been landed. Closing bug. 371947 2019-06-12 06:16:42 -0700 2019-06-12 07:09:15 -0700 Patch bug-198785-20190612151640.patch text/plain 1690 ludovico.denittis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5OGRhMzI0YTEzMTUxMDg4 NGJjMDBiNWFiYzg0N2QxN2U0ZDc4MzguLmRkZDhhMTNmZDdkYzViNzJkMjE3YjM5NjYwMDhlODFi NjEwNWM2ODAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMTIgIEx1ZG92aWNv IGRlIE5pdHRpcyAgPGx1ZG92aWNvLmRlbml0dGlzQGNvbGxhYm9yYS5jb20+CisKKyAgICAgICAg W0dUS10gZ3RrX21pc2Nfc2V0X2FsaWdubWVudCBpcyBkZXByZWNhdGVkIHNpbmNlIEdUSyAzLjE0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg3ODUK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNl IHRoZSBkZXByZWNhdGVkIGd0a19taXNjX3NldF9hbGlnbm1lbnQgd2l0aCBoYWxpZ24gYW5kIHZh bGlnbi4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dGhlbnRpY2F0aW9u RGlhbG9nLmNwcDoKKyAgICAgICAgKGNyZWF0ZUxhYmVsV2l0aExpbmVXcmFwKToKKwogMjAxOS0w Ni0xMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBb aU9TXSBJZGVtcG90ZW50IHRleHQgYXV0b3NpemluZyBuZWVkcyB0byByZWFjdCBwcm9wZXJseSB0 byB2aWV3cG9ydCBjaGFuZ2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvZ3RrL1dlYktpdEF1dGhlbnRpY2F0aW9uRGlhbG9nLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cuY3BwCmluZGV4IGM3MzRk OGZlYzEyZWEwZjAyZDlhNTBmYzNhMjY0ZmJlODMwZTU4MGUuLjE2NzRlZTE0MWZhZmRlNzlhNzhi ZGZmZTk1NjFiYzgwMWNkZGNkNzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L0FQSS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cuY3BwCkBAIC03 NSw3ICs3NSw4IEBAIHN0YXRpYyB2b2lkIGF1dGhlbnRpY2F0aW9uQ2FuY2VsbGVkKFdlYktpdEF1 dGhlbnRpY2F0aW9uUmVxdWVzdCosIFdlYktpdEF1dGhlbnRpCiBzdGF0aWMgR3RrV2lkZ2V0KiBj cmVhdGVMYWJlbFdpdGhMaW5lV3JhcChjb25zdCBjaGFyKiB0ZXh0KQogewogICAgIEd0a1dpZGdl dCogbGFiZWwgPSBndGtfbGFiZWxfbmV3KHRleHQpOwotICAgIGd0a19taXNjX3NldF9hbGlnbm1l bnQoR1RLX01JU0MobGFiZWwpLCAwLCAwLjUpOworICAgIGd0a193aWRnZXRfc2V0X2hhbGlnbihs YWJlbCwgR1RLX0FMSUdOX1NUQVJUKTsKKyAgICBndGtfd2lkZ2V0X3NldF92YWxpZ24obGFiZWws IEdUS19BTElHTl9DRU5URVIpOwogICAgIGd0a19sYWJlbF9zZXRfbGluZV93cmFwKEdUS19MQUJF TChsYWJlbCksIFRSVUUpOwogICAgIGd0a19sYWJlbF9zZXRfbWF4X3dpZHRoX2NoYXJzKEdUS19M QUJFTChsYWJlbCksIDQwKTsKICAgICByZXR1cm4gbGFiZWw7Cg==