198767 2019-06-11 14:12:11 -0700 Integrate scrollbar gestures for iOS 2019-06-13 01:51:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner commit-queue thorton timothy webkit-bug-importer wenson_hsieh oldest_to_newest 1543831 0 megan_gardner 2019-06-11 14:12:11 -0700 Integrate scrollbar gestures for iOS 1543833 1 371878 megan_gardner 2019-06-11 14:13:06 -0700 Created attachment 371878 Patch 1543835 2 webkit-bug-importer 2019-06-11 14:28:50 -0700 <rdar://problem/51640249> 1543836 3 371878 wenson_hsieh 2019-06-11 14:40:40 -0700 Comment on attachment 371878 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371878&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758 > +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer) Nit - isBuiltInScrollViewGestureRecognizer()? We typically only put a WK or _WK prefix on API or SPI. 1543837 4 371878 thorton 2019-06-11 14:42:28 -0700 Comment on attachment 371878 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371878&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1758 > +static BOOL _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(UIGestureRecognizer *recognizer) drop the _WK. Probably just "isBuiltInScrollViewGestureRecognizer", even. > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1771 > + BOOL conflictsWithBuiltInGesture = _WKGestureRecognizerIsBuiltInScrollViewGestureRecognizer(preventedGestureRecognizer); I don't think "conflictsWith" is the right phrasing? 1543845 5 371883 megan_gardner 2019-06-11 15:01:33 -0700 Created attachment 371883 Patch 1543894 6 371883 commit-queue 2019-06-11 17:24:15 -0700 Comment on attachment 371883 Patch Clearing flags on attachment: 371883 Committed r246342: <https://trac.webkit.org/changeset/246342> 371878 2019-06-11 14:13:06 -0700 2019-06-11 14:40:40 -0700 Patch bug-198767-20190611141305.patch text/plain 3123 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY2YjdmMDQyNDE5MDUxODcy ZGJjZWRlOGEyMmZhNjhiNGIwYjdjMWIuLmI5ZWM2NWE0NWE3Y2M3MmVkN2NjNWU4ZTQwNTQ1YzFi NDI5Y2U2ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDYtMTEgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBJbnRlZ3JhdGUgc2Ny b2xsYmFyIGdlc3R1cmVzIGZvciBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5ODc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW06CisgICAgICAgIChfV0tHZXN0dXJlUmVjb2duaXplcklzQnVpbHRJblNjcm9sbFZpZXdHZXN0 dXJlUmVjb2duaXplcik6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgZ2VzdHVyZVJlY29nbml6 ZXI6Y2FuUHJldmVudEdlc3R1cmVSZWNvZ25pemVyOl0pOgorCiAyMDE5LTA2LTEwICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRGFzaGJvYXJkIHN1cHBv cnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCmluZGV4IGNhODdiZjNkMmU2YmFmMTI5YzNmMjE5MTU1M2Q4MzU1MWE3 ZjhhMTYuLmRmYmI5YjE4ZTk0OTYxZmJkNDk1OTkyMmQ1Y2I2NTY2MDM4MThmZWEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQpAQCAtMTc1NSwyMSArMTc1NSwyNCBAQCAtIChDR1JlY3QpX3NlbGVjdGlvbkNsaXBS ZWN0CiAgICAgcmV0dXJuIF9wYWdlLT5lZGl0b3JTdGF0ZSgpLnBvc3RMYXlvdXREYXRhKCkuZm9j dXNlZEVsZW1lbnRSZWN0OwogfQogCi0jaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykgJiYgX19o YXNfaW5jbHVkZSg8V2ViS2l0QWRkaXRpb25zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbldLSW50 ZXJhY3Rpb24ubW0+KQotI2luY2x1ZGUgPFdlYktpdEFkZGl0aW9ucy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb25XS0ludGVyYWN0aW9uLm1tPgotI2Vsc2UKK3N0YXRpYyBCT09MIF9XS0dlc3R1cmVS ZWNvZ25pemVySXNCdWlsdEluU2Nyb2xsVmlld0dlc3R1cmVSZWNvZ25pemVyKFVJR2VzdHVyZVJl Y29nbml6ZXIgKnJlY29nbml6ZXIpCit7CisgICAgcmV0dXJuIChbcmVjb2duaXplciBpc0tpbmRP ZkNsYXNzOk5TQ2xhc3NGcm9tU3RyaW5nKEAiVUlTY3JvbGxWaWV3UGFuR2VzdHVyZVJlY29nbml6 ZXIiKV0KKyAgICAgICAgfHwgW3JlY29nbml6ZXIgaXNLaW5kT2ZDbGFzczpOU0NsYXNzRnJvbVN0 cmluZyhAIlVJU2Nyb2xsVmlld1BpbmNoR2VzdHVyZVJlY29nbml6ZXIiKV0KKyAgICAgICAgfHwg W3JlY29nbml6ZXIgaXNLaW5kT2ZDbGFzczpOU0NsYXNzRnJvbVN0cmluZyhAIlVJU2Nyb2xsVmll d0tub2JMb25nUHJlc3NHZXN0dXJlUmVjb2duaXplciIpXQorICAgICAgICApOworfQogCiAtIChC T09MKWdlc3R1cmVSZWNvZ25pemVyOihVSUdlc3R1cmVSZWNvZ25pemVyICopcHJldmVudGluZ0dl c3R1cmVSZWNvZ25pemVyIGNhblByZXZlbnRHZXN0dXJlUmVjb2duaXplcjooVUlHZXN0dXJlUmVj b2duaXplciAqKXByZXZlbnRlZEdlc3R1cmVSZWNvZ25pemVyCiB7CiAgICAgLy8gQSBsb25nLXBy ZXNzIGdlc3R1cmUgY2FuIG5vdCBiZSByZWNvZ25pemVkIHdoaWxlIHBhbm5pbmcsIGJ1dCBhIHBh biBjYW4gYmUgcmVjb2duaXplZAogICAgIC8vIGR1cmluZyBhIGxvbmctcHJlc3MgZ2VzdHVyZS4K ICAgICBCT09MIHNob3VsZE5vdFByZXZlbnRTY3JvbGxWaWV3R2VzdHVyZXMgPSBwcmV2ZW50aW5n R2VzdHVyZVJlY29nbml6ZXIgPT0gX2hpZ2hsaWdodExvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVy IHx8IHByZXZlbnRpbmdHZXN0dXJlUmVjb2duaXplciA9PSBfbG9uZ1ByZXNzR2VzdHVyZVJlY29n bml6ZXI7Ci0gICAgcmV0dXJuICEoc2hvdWxkTm90UHJldmVudFNjcm9sbFZpZXdHZXN0dXJlcwot ICAgICAgICAmJiAoW3ByZXZlbnRlZEdlc3R1cmVSZWNvZ25pemVyIGlzS2luZE9mQ2xhc3M6TlND bGFzc0Zyb21TdHJpbmcoQCJVSVNjcm9sbFZpZXdQYW5HZXN0dXJlUmVjb2duaXplciIpXSB8fCBb cHJldmVudGVkR2VzdHVyZVJlY29nbml6ZXIgaXNLaW5kT2ZDbGFzczpOU0NsYXNzRnJvbVN0cmlu ZyhAIlVJU2Nyb2xsVmlld1BpbmNoR2VzdHVyZVJlY29nbml6ZXIiKV0pKTsKKyAgICBCT09MIGNv bmZsaWN0c1dpdGhCdWlsdEluR2VzdHVyZSA9IF9XS0dlc3R1cmVSZWNvZ25pemVySXNCdWlsdElu U2Nyb2xsVmlld0dlc3R1cmVSZWNvZ25pemVyKHByZXZlbnRlZEdlc3R1cmVSZWNvZ25pemVyKTsK KyAgICAKKyAgICByZXR1cm4gIShzaG91bGROb3RQcmV2ZW50U2Nyb2xsVmlld0dlc3R1cmVzICYm IGNvbmZsaWN0c1dpdGhCdWlsdEluR2VzdHVyZSk7CiB9CiAKLSNlbmRpZgotCiAtIChCT09MKWdl c3R1cmVSZWNvZ25pemVyOihVSUdlc3R1cmVSZWNvZ25pemVyICopcHJldmVudGVkR2VzdHVyZVJl Y29nbml6ZXIgY2FuQmVQcmV2ZW50ZWRCeUdlc3R1cmVSZWNvZ25pemVyOihVSUdlc3R1cmVSZWNv Z25pemVyICopcHJldmVudGluZ0dlc3R1cmVSZWNvZ25pemVyIHsKICAgICAvLyBEb24ndCBhbGxv dyB0aGUgaGlnaGxpZ2h0IHRvIGJlIHByZXZlbnRlZCBieSBhIHNlbGVjdGlvbiBnZXN0dXJlLiBQ cmVzcy1hbmQtaG9sZCBvbiBhIGxpbmsgc2hvdWxkIGhpZ2hsaWdodCB0aGUgbGluaywgbm90IHNl bGVjdCBpdC4KICAgICBib29sIGlzRm9yY2VQcmVzc0dlc3R1cmUgPSBOTzsK 371883 2019-06-11 15:01:33 -0700 2019-06-11 17:24:15 -0700 Patch bug-198767-20190611150133.patch text/plain 3014 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2Mjg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGY2YjdmMDQyNDE5MDUxODcy ZGJjZWRlOGEyMmZhNjhiNGIwYjdjMWIuLmI5ZWM2NWE0NWE3Y2M3MmVkN2NjNWU4ZTQwNTQ1YzFi NDI5Y2U2ZjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTktMDYtMTEgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBJbnRlZ3JhdGUgc2Ny b2xsYmFyIGdlc3R1cmVzIGZvciBpT1MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5ODc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW06CisgICAgICAgIChfV0tHZXN0dXJlUmVjb2duaXplcklzQnVpbHRJblNjcm9sbFZpZXdHZXN0 dXJlUmVjb2duaXplcik6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgZ2VzdHVyZVJlY29nbml6 ZXI6Y2FuUHJldmVudEdlc3R1cmVSZWNvZ25pemVyOl0pOgorCiAyMDE5LTA2LTEwICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgRGFzaGJvYXJkIHN1cHBv cnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCmluZGV4IGNhODdiZjNkMmU2YmFmMTI5YzNmMjE5MTU1M2Q4MzU1MWE3 ZjhhMTYuLmY1YzgxODM0YTQ3NGNmZDllYWFmZmY1OTFjMzRkM2ViYjllNjMyNmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQpAQCAtMTc1NSwyMSArMTc1NSwyMyBAQCAtIChDR1JlY3QpX3NlbGVjdGlvbkNsaXBS ZWN0CiAgICAgcmV0dXJuIF9wYWdlLT5lZGl0b3JTdGF0ZSgpLnBvc3RMYXlvdXREYXRhKCkuZm9j dXNlZEVsZW1lbnRSZWN0OwogfQogCi0jaWYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykgJiYgX19o YXNfaW5jbHVkZSg8V2ViS2l0QWRkaXRpb25zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbldLSW50 ZXJhY3Rpb24ubW0+KQotI2luY2x1ZGUgPFdlYktpdEFkZGl0aW9ucy9XS0NvbnRlbnRWaWV3SW50 ZXJhY3Rpb25XS0ludGVyYWN0aW9uLm1tPgotI2Vsc2UKK3N0YXRpYyBCT09MIGlzQnVpbHRJblNj cm9sbFZpZXdHZXN0dXJlUmVjb2duaXplcihVSUdlc3R1cmVSZWNvZ25pemVyICpyZWNvZ25pemVy KQoreworICAgIHJldHVybiAoW3JlY29nbml6ZXIgaXNLaW5kT2ZDbGFzczpOU0NsYXNzRnJvbVN0 cmluZyhAIlVJU2Nyb2xsVmlld1Bhbkdlc3R1cmVSZWNvZ25pemVyIildCisgICAgICAgIHx8IFty ZWNvZ25pemVyIGlzS2luZE9mQ2xhc3M6TlNDbGFzc0Zyb21TdHJpbmcoQCJVSVNjcm9sbFZpZXdQ aW5jaEdlc3R1cmVSZWNvZ25pemVyIildCisgICAgICAgIHx8IFtyZWNvZ25pemVyIGlzS2luZE9m Q2xhc3M6TlNDbGFzc0Zyb21TdHJpbmcoQCJVSVNjcm9sbFZpZXdLbm9iTG9uZ1ByZXNzR2VzdHVy ZVJlY29nbml6ZXIiKV0KKyAgICAgICAgKTsKK30KIAogLSAoQk9PTClnZXN0dXJlUmVjb2duaXpl cjooVUlHZXN0dXJlUmVjb2duaXplciAqKXByZXZlbnRpbmdHZXN0dXJlUmVjb2duaXplciBjYW5Q cmV2ZW50R2VzdHVyZVJlY29nbml6ZXI6KFVJR2VzdHVyZVJlY29nbml6ZXIgKilwcmV2ZW50ZWRH ZXN0dXJlUmVjb2duaXplcgogewogICAgIC8vIEEgbG9uZy1wcmVzcyBnZXN0dXJlIGNhbiBub3Qg YmUgcmVjb2duaXplZCB3aGlsZSBwYW5uaW5nLCBidXQgYSBwYW4gY2FuIGJlIHJlY29nbml6ZWQK ICAgICAvLyBkdXJpbmcgYSBsb25nLXByZXNzIGdlc3R1cmUuCiAgICAgQk9PTCBzaG91bGROb3RQ cmV2ZW50U2Nyb2xsVmlld0dlc3R1cmVzID0gcHJldmVudGluZ0dlc3R1cmVSZWNvZ25pemVyID09 IF9oaWdobGlnaHRMb25nUHJlc3NHZXN0dXJlUmVjb2duaXplciB8fCBwcmV2ZW50aW5nR2VzdHVy ZVJlY29nbml6ZXIgPT0gX2xvbmdQcmVzc0dlc3R1cmVSZWNvZ25pemVyOwotICAgIHJldHVybiAh KHNob3VsZE5vdFByZXZlbnRTY3JvbGxWaWV3R2VzdHVyZXMKLSAgICAgICAgJiYgKFtwcmV2ZW50 ZWRHZXN0dXJlUmVjb2duaXplciBpc0tpbmRPZkNsYXNzOk5TQ2xhc3NGcm9tU3RyaW5nKEAiVUlT Y3JvbGxWaWV3UGFuR2VzdHVyZVJlY29nbml6ZXIiKV0gfHwgW3ByZXZlbnRlZEdlc3R1cmVSZWNv Z25pemVyIGlzS2luZE9mQ2xhc3M6TlNDbGFzc0Zyb21TdHJpbmcoQCJVSVNjcm9sbFZpZXdQaW5j aEdlc3R1cmVSZWNvZ25pemVyIildKSk7CisgICAgCisgICAgcmV0dXJuICEoc2hvdWxkTm90UHJl dmVudFNjcm9sbFZpZXdHZXN0dXJlcyAmJiBpc0J1aWx0SW5TY3JvbGxWaWV3R2VzdHVyZVJlY29n bml6ZXIocHJldmVudGVkR2VzdHVyZVJlY29nbml6ZXIpKTsKIH0KIAotI2VuZGlmCi0KIC0gKEJP T0wpZ2VzdHVyZVJlY29nbml6ZXI6KFVJR2VzdHVyZVJlY29nbml6ZXIgKilwcmV2ZW50ZWRHZXN0 dXJlUmVjb2duaXplciBjYW5CZVByZXZlbnRlZEJ5R2VzdHVyZVJlY29nbml6ZXI6KFVJR2VzdHVy ZVJlY29nbml6ZXIgKilwcmV2ZW50aW5nR2VzdHVyZVJlY29nbml6ZXIgewogICAgIC8vIERvbid0 IGFsbG93IHRoZSBoaWdobGlnaHQgdG8gYmUgcHJldmVudGVkIGJ5IGEgc2VsZWN0aW9uIGdlc3R1 cmUuIFByZXNzLWFuZC1ob2xkIG9uIGEgbGluayBzaG91bGQgaGlnaGxpZ2h0IHRoZSBsaW5rLCBu b3Qgc2VsZWN0IGl0LgogICAgIGJvb2wgaXNGb3JjZVByZXNzR2VzdHVyZSA9IE5POwo=