198750 2019-06-11 02:22:26 -0700 [GTK] gdk_screen_get_monitor_geometry and gdk_screen_get_monitor_workarea are deprecated since GTK 3.22 2019-06-11 05:52:28 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ludovico.denittis webkit-unassigned bugs-noreply cgarcia commit-queue oldest_to_newest 1543654 0 ludovico.denittis 2019-06-11 02:22:26 -0700 "gdk_screen_get_monitor_geometry" and "gdk_screen_get_monitor_workarea" are still used in "PlatformScreenGtk.cpp" but they are deprecated since GTK 3.22. I'm uploading a patch to this. 1543657 1 371835 ludovico.denittis 2019-06-11 02:35:04 -0700 Created attachment 371835 Patch 1543658 2 371836 ludovico.denittis 2019-06-11 02:41:32 -0700 Created attachment 371836 Patch 1543677 3 371836 commit-queue 2019-06-11 05:52:26 -0700 Comment on attachment 371836 Patch Clearing flags on attachment: 371836 Committed r246310: <https://trac.webkit.org/changeset/246310> 1543678 4 commit-queue 2019-06-11 05:52:28 -0700 All reviewed patches have been landed. Closing bug. 371835 2019-06-11 02:35:04 -0700 2019-06-11 02:41:28 -0700 Patch bug-198750-20190611113503.patch text/plain 3714 ludovico.denittis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGFjMjJlYTUyNjY0ODNl NTEwYTNmOTgxNDYyNzllYzUyZjEzYjJkNC4uYTBmNjE4NmEwNzVkYTdkMmIwZDFkNjc3MDdmYjVh NGE5NTdmNDVkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA2LTExICBMdWRv dmljbyBkZSBOaXR0aXMgIDxsdWRvdmljby5kZW5pdHRpc0Bjb2xsYWJvcmEuY29tPgorCisgICAg ICAgIFtHVEtdIFJlcGxhY2UgZ2RrX3NjcmVlbl9nZXRfbW9uaXRvcl9nZW9tZXRyeSBhbmQgZ2Rr X3NjcmVlbl9nZXRfbW9uaXRvcl93b3JrYXJlYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2luY2UgR1RLIDMuMjIgZ2RrX3NjcmVlbl9nZXRfbW9uaXRv cl9nZW9tZXRyeSBhbmQKKyAgICAgICAgZ2RrX3NjcmVlbl9nZXRfbW9uaXRvcl93b3JrYXJlYSBo YXMgYmVlbiBkZXByZWNhdGVkLiAKKworICAgICAgICBObyBiZWhhdmlvciBjaGFuZ2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c2NyZWVuUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5BdmFpbGFibGVSZWN0 KToKKwogMjAxOS0wNi0xMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNv bT4KIAogICAgICAgICBbV2luQ2Fpcm9dW01lZGlhRm91bmRhdGlvbl0gUmVtb3ZlIHRoZSB1bnVz ZWQgdmlkZW8gd2luZG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UGxhdGZvcm1TY3JlZW5HdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1BsYXRm b3JtU2NyZWVuR3RrLmNwcAppbmRleCAxMTI5YjRiYjk0NGY2MjY5MjE5ZjcxYmU0MDZmYzFlOTM2 NWM4ZDMzLi45OThmM2E2NDdhYjA4NWIyMjAzZjRiYmVlMTRkNWFjZGViMjAxZmE0IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHAKQEAg LTE1MCwxMCArMTUwLDEyIEBAIHZvaWQgc2V0U2NyZWVuRFBJT2JzZXJ2ZXJIYW5kbGVyKEZ1bmN0 aW9uPHZvaWQoKT4mJiBoYW5kbGVyLCB2b2lkKiBjb250ZXh0KQogICAgIH0KIH0KIAorI2lmICFH VEtfQ0hFQ0tfVkVSU0lPTigzLCAyMiwgMCkKIHN0YXRpYyBHZGtTY3JlZW4qIGdldFNjcmVlbihH dGtXaWRnZXQqIHdpZGdldCkKIHsKICAgICByZXR1cm4gZ3RrX3dpZGdldF9oYXNfc2NyZWVuKHdp ZGdldCkgPyBndGtfd2lkZ2V0X2dldF9zY3JlZW4od2lkZ2V0KSA6IGdka19zY3JlZW5fZ2V0X2Rl ZmF1bHQoKTsKIH0KKyNlbmRpZgogCiBGbG9hdFJlY3Qgc2NyZWVuUmVjdChXaWRnZXQqIHdpZGdl dCkKIHsKQEAgLTE2MSwxNCArMTYzLDI0IEBAIEZsb2F0UmVjdCBzY3JlZW5SZWN0KFdpZGdldCog d2lkZ2V0KQogICAgIGlmIChjb250YWluZXIpCiAgICAgICAgIGNvbnRhaW5lciA9IGdldFRvcGxl dmVsKGNvbnRhaW5lcik7CiAKKyAgICBHZGtSZWN0YW5nbGUgZ2VvbWV0cnk7CisjaWYgR1RLX0NI RUNLX1ZFUlNJT04oMywgMjIsIDApCisgICAgR2RrRGlzcGxheSogZGlzcGxheSA9IGNvbnRhaW5l ciA/IGd0a193aWRnZXRfZ2V0X2Rpc3BsYXkoY29udGFpbmVyKSA6IGdka19kaXNwbGF5X2dldF9k ZWZhdWx0KCk7CisgICAgaWYgKCFkaXNwbGF5KQorICAgICAgICByZXR1cm4gRmxvYXRSZWN0KCk7 CisKKyAgICBHZGtNb25pdG9yKiBtb25pdG9yID0gY29udGFpbmVyID8gZ2RrX2Rpc3BsYXlfZ2V0 X21vbml0b3JfYXRfd2luZG93KGRpc3BsYXksIGd0a193aWRnZXRfZ2V0X3dpbmRvdyhjb250YWlu ZXIpKSA6IGdka19kaXNwbGF5X2dldF9tb25pdG9yKGRpc3BsYXksIDApOworCisgICAgZ2RrX21v bml0b3JfZ2V0X2dlb21ldHJ5KG1vbml0b3IsICZnZW9tZXRyeSk7CisjZWxzZQogICAgIEdka1Nj cmVlbiogc2NyZWVuID0gY29udGFpbmVyID8gZ2V0U2NyZWVuKGNvbnRhaW5lcikgOiBnZGtfc2Ny ZWVuX2dldF9kZWZhdWx0KCk7CiAgICAgaWYgKCFzY3JlZW4pCiAgICAgICAgIHJldHVybiBGbG9h dFJlY3QoKTsKIAogICAgIGdpbnQgbW9uaXRvciA9IGNvbnRhaW5lciA/IGdka19zY3JlZW5fZ2V0 X21vbml0b3JfYXRfd2luZG93KHNjcmVlbiwgZ3RrX3dpZGdldF9nZXRfd2luZG93KGNvbnRhaW5l cikpIDogMDsKIAotICAgIEdka1JlY3RhbmdsZSBnZW9tZXRyeTsKICAgICBnZGtfc2NyZWVuX2dl dF9tb25pdG9yX2dlb21ldHJ5KHNjcmVlbiwgbW9uaXRvciwgJmdlb21ldHJ5KTsKKyNlbmRpZiAv LyAhR1RLX0NIRUNLX1ZFUlNJT04oMywgMjIsIDApCiAKICAgICByZXR1cm4gRmxvYXRSZWN0KGdl b21ldHJ5LngsIGdlb21ldHJ5LnksIGdlb21ldHJ5LndpZHRoLCBnZW9tZXRyeS5oZWlnaHQpOwog fQpAQCAtMTc5LDE0ICsxOTEsMjUgQEAgRmxvYXRSZWN0IHNjcmVlbkF2YWlsYWJsZVJlY3QoV2lk Z2V0KiB3aWRnZXQpCiAgICAgaWYgKGNvbnRhaW5lciAmJiAhZ3RrX3dpZGdldF9nZXRfcmVhbGl6 ZWQoY29udGFpbmVyKSkKICAgICAgICAgcmV0dXJuIHNjcmVlblJlY3Qod2lkZ2V0KTsKIAorICAg IEdka1JlY3RhbmdsZSB3b3JrQXJlYTsKKyNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigzLCAyMiwgMCkK KyAgICBHZGtEaXNwbGF5KiBkaXNwbGF5ID0gY29udGFpbmVyID8gZ3RrX3dpZGdldF9nZXRfZGlz cGxheShjb250YWluZXIpIDogZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKTsKKyAgICBpZiAoIWRp c3BsYXkpCisgICAgICAgIHJldHVybiBGbG9hdFJlY3QoKTsKKworICAgIEdka01vbml0b3IqIG1v bml0b3IgPSBjb250YWluZXIgPyBnZGtfZGlzcGxheV9nZXRfbW9uaXRvcl9hdF93aW5kb3coZGlz cGxheSwgZ3RrX3dpZGdldF9nZXRfd2luZG93KGNvbnRhaW5lcikpIDogZ2RrX2Rpc3BsYXlfZ2V0 X21vbml0b3IoZGlzcGxheSwgMCk7CisKKyAgICBnZGtfbW9uaXRvcl9nZXRfd29ya2FyZWEobW9u aXRvciwgJndvcmtBcmVhKTsKKyAgICBHZGtNb25pdG9yKiBtb25pdG9yID0gMDsKKyNlbHNlCiAg ICAgR2RrU2NyZWVuKiBzY3JlZW4gPSBjb250YWluZXIgPyBnZXRTY3JlZW4oY29udGFpbmVyKSA6 IGdka19zY3JlZW5fZ2V0X2RlZmF1bHQoKTsKICAgICBpZiAoIXNjcmVlbikKICAgICAgICAgcmV0 dXJuIEZsb2F0UmVjdCgpOwogCiAgICAgZ2ludCBtb25pdG9yID0gY29udGFpbmVyID8gZ2RrX3Nj cmVlbl9nZXRfbW9uaXRvcl9hdF93aW5kb3coc2NyZWVuLCBndGtfd2lkZ2V0X2dldF93aW5kb3co Y29udGFpbmVyKSkgOiAwOwogCi0gICAgR2RrUmVjdGFuZ2xlIHdvcmtBcmVhOwogICAgIGdka19z Y3JlZW5fZ2V0X21vbml0b3Jfd29ya2FyZWEoc2NyZWVuLCBtb25pdG9yLCAmd29ya0FyZWEpOwor I2VuZGlmIC8vICFHVEtfQ0hFQ0tfVkVSU0lPTigzLCAyMiwgMCkKIAogICAgIHJldHVybiBGbG9h dFJlY3Qod29ya0FyZWEueCwgd29ya0FyZWEueSwgd29ya0FyZWEud2lkdGgsIHdvcmtBcmVhLmhl aWdodCk7CiAK 371836 2019-06-11 02:41:32 -0700 2019-06-11 05:52:26 -0700 Patch bug-198750-20190611114131.patch text/plain 3684 ludovico.denittis U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGFjMjJlYTUyNjY0ODNl NTEwYTNmOTgxNDYyNzllYzUyZjEzYjJkNC4uYTBmNjE4NmEwNzVkYTdkMmIwZDFkNjc3MDdmYjVh NGE5NTdmNDVkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA2LTExICBMdWRv dmljbyBkZSBOaXR0aXMgIDxsdWRvdmljby5kZW5pdHRpc0Bjb2xsYWJvcmEuY29tPgorCisgICAg ICAgIFtHVEtdIFJlcGxhY2UgZ2RrX3NjcmVlbl9nZXRfbW9uaXRvcl9nZW9tZXRyeSBhbmQgZ2Rr X3NjcmVlbl9nZXRfbW9uaXRvcl93b3JrYXJlYQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgU2luY2UgR1RLIDMuMjIgZ2RrX3NjcmVlbl9nZXRfbW9uaXRv cl9nZW9tZXRyeSBhbmQKKyAgICAgICAgZ2RrX3NjcmVlbl9nZXRfbW9uaXRvcl93b3JrYXJlYSBo YXMgYmVlbiBkZXByZWNhdGVkLiAKKworICAgICAgICBObyBiZWhhdmlvciBjaGFuZ2UuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6c2NyZWVuUmVjdCk6CisgICAgICAgIChXZWJDb3JlOjpzY3JlZW5BdmFpbGFibGVSZWN0 KToKKwogMjAxOS0wNi0xMCAgRnVqaWkgSGlyb25vcmkgIDxIaXJvbm9yaS5GdWppaUBzb255LmNv bT4KIAogICAgICAgICBbV2luQ2Fpcm9dW01lZGlhRm91bmRhdGlvbl0gUmVtb3ZlIHRoZSB1bnVz ZWQgdmlkZW8gd2luZG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv UGxhdGZvcm1TY3JlZW5HdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1BsYXRm b3JtU2NyZWVuR3RrLmNwcAppbmRleCAxMTI5YjRiYjk0NGY2MjY5MjE5ZjcxYmU0MDZmYzFlOTM2 NWM4ZDMzLi43MzFjYTdkZTY5YjIzNzJkN2NhMzYwYTJiZjBhOTA4ODcxMWFlYzZjIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGxhdGZvcm1TY3JlZW5HdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QbGF0Zm9ybVNjcmVlbkd0ay5jcHAKQEAg LTE1MCwxMCArMTUwLDEyIEBAIHZvaWQgc2V0U2NyZWVuRFBJT2JzZXJ2ZXJIYW5kbGVyKEZ1bmN0 aW9uPHZvaWQoKT4mJiBoYW5kbGVyLCB2b2lkKiBjb250ZXh0KQogICAgIH0KIH0KIAorI2lmICFH VEtfQ0hFQ0tfVkVSU0lPTigzLCAyMiwgMCkKIHN0YXRpYyBHZGtTY3JlZW4qIGdldFNjcmVlbihH dGtXaWRnZXQqIHdpZGdldCkKIHsKICAgICByZXR1cm4gZ3RrX3dpZGdldF9oYXNfc2NyZWVuKHdp ZGdldCkgPyBndGtfd2lkZ2V0X2dldF9zY3JlZW4od2lkZ2V0KSA6IGdka19zY3JlZW5fZ2V0X2Rl ZmF1bHQoKTsKIH0KKyNlbmRpZgogCiBGbG9hdFJlY3Qgc2NyZWVuUmVjdChXaWRnZXQqIHdpZGdl dCkKIHsKQEAgLTE2MSwxNCArMTYzLDI0IEBAIEZsb2F0UmVjdCBzY3JlZW5SZWN0KFdpZGdldCog d2lkZ2V0KQogICAgIGlmIChjb250YWluZXIpCiAgICAgICAgIGNvbnRhaW5lciA9IGdldFRvcGxl dmVsKGNvbnRhaW5lcik7CiAKKyAgICBHZGtSZWN0YW5nbGUgZ2VvbWV0cnk7CisjaWYgR1RLX0NI RUNLX1ZFUlNJT04oMywgMjIsIDApCisgICAgR2RrRGlzcGxheSogZGlzcGxheSA9IGNvbnRhaW5l ciA/IGd0a193aWRnZXRfZ2V0X2Rpc3BsYXkoY29udGFpbmVyKSA6IGdka19kaXNwbGF5X2dldF9k ZWZhdWx0KCk7CisgICAgaWYgKCFkaXNwbGF5KQorICAgICAgICByZXR1cm4gRmxvYXRSZWN0KCk7 CisKKyAgICBHZGtNb25pdG9yKiBtb25pdG9yID0gY29udGFpbmVyID8gZ2RrX2Rpc3BsYXlfZ2V0 X21vbml0b3JfYXRfd2luZG93KGRpc3BsYXksIGd0a193aWRnZXRfZ2V0X3dpbmRvdyhjb250YWlu ZXIpKSA6IGdka19kaXNwbGF5X2dldF9tb25pdG9yKGRpc3BsYXksIDApOworCisgICAgZ2RrX21v bml0b3JfZ2V0X2dlb21ldHJ5KG1vbml0b3IsICZnZW9tZXRyeSk7CisjZWxzZQogICAgIEdka1Nj cmVlbiogc2NyZWVuID0gY29udGFpbmVyID8gZ2V0U2NyZWVuKGNvbnRhaW5lcikgOiBnZGtfc2Ny ZWVuX2dldF9kZWZhdWx0KCk7CiAgICAgaWYgKCFzY3JlZW4pCiAgICAgICAgIHJldHVybiBGbG9h dFJlY3QoKTsKIAogICAgIGdpbnQgbW9uaXRvciA9IGNvbnRhaW5lciA/IGdka19zY3JlZW5fZ2V0 X21vbml0b3JfYXRfd2luZG93KHNjcmVlbiwgZ3RrX3dpZGdldF9nZXRfd2luZG93KGNvbnRhaW5l cikpIDogMDsKIAotICAgIEdka1JlY3RhbmdsZSBnZW9tZXRyeTsKICAgICBnZGtfc2NyZWVuX2dl dF9tb25pdG9yX2dlb21ldHJ5KHNjcmVlbiwgbW9uaXRvciwgJmdlb21ldHJ5KTsKKyNlbmRpZiAv LyAhR1RLX0NIRUNLX1ZFUlNJT04oMywgMjIsIDApCiAKICAgICByZXR1cm4gRmxvYXRSZWN0KGdl b21ldHJ5LngsIGdlb21ldHJ5LnksIGdlb21ldHJ5LndpZHRoLCBnZW9tZXRyeS5oZWlnaHQpOwog fQpAQCAtMTc5LDE0ICsxOTEsMjQgQEAgRmxvYXRSZWN0IHNjcmVlbkF2YWlsYWJsZVJlY3QoV2lk Z2V0KiB3aWRnZXQpCiAgICAgaWYgKGNvbnRhaW5lciAmJiAhZ3RrX3dpZGdldF9nZXRfcmVhbGl6 ZWQoY29udGFpbmVyKSkKICAgICAgICAgcmV0dXJuIHNjcmVlblJlY3Qod2lkZ2V0KTsKIAorICAg IEdka1JlY3RhbmdsZSB3b3JrQXJlYTsKKyNpZiBHVEtfQ0hFQ0tfVkVSU0lPTigzLCAyMiwgMCkK KyAgICBHZGtEaXNwbGF5KiBkaXNwbGF5ID0gY29udGFpbmVyID8gZ3RrX3dpZGdldF9nZXRfZGlz cGxheShjb250YWluZXIpIDogZ2RrX2Rpc3BsYXlfZ2V0X2RlZmF1bHQoKTsKKyAgICBpZiAoIWRp c3BsYXkpCisgICAgICAgIHJldHVybiBGbG9hdFJlY3QoKTsKKworICAgIEdka01vbml0b3IqIG1v bml0b3IgPSBjb250YWluZXIgPyBnZGtfZGlzcGxheV9nZXRfbW9uaXRvcl9hdF93aW5kb3coZGlz cGxheSwgZ3RrX3dpZGdldF9nZXRfd2luZG93KGNvbnRhaW5lcikpIDogZ2RrX2Rpc3BsYXlfZ2V0 X21vbml0b3IoZGlzcGxheSwgMCk7CisKKyAgICBnZGtfbW9uaXRvcl9nZXRfd29ya2FyZWEobW9u aXRvciwgJndvcmtBcmVhKTsKKyNlbHNlCiAgICAgR2RrU2NyZWVuKiBzY3JlZW4gPSBjb250YWlu ZXIgPyBnZXRTY3JlZW4oY29udGFpbmVyKSA6IGdka19zY3JlZW5fZ2V0X2RlZmF1bHQoKTsKICAg ICBpZiAoIXNjcmVlbikKICAgICAgICAgcmV0dXJuIEZsb2F0UmVjdCgpOwogCiAgICAgZ2ludCBt b25pdG9yID0gY29udGFpbmVyID8gZ2RrX3NjcmVlbl9nZXRfbW9uaXRvcl9hdF93aW5kb3coc2Ny ZWVuLCBndGtfd2lkZ2V0X2dldF93aW5kb3coY29udGFpbmVyKSkgOiAwOwogCi0gICAgR2RrUmVj dGFuZ2xlIHdvcmtBcmVhOwogICAgIGdka19zY3JlZW5fZ2V0X21vbml0b3Jfd29ya2FyZWEoc2Ny ZWVuLCBtb25pdG9yLCAmd29ya0FyZWEpOworI2VuZGlmIC8vICFHVEtfQ0hFQ0tfVkVSU0lPTigz LCAyMiwgMCkKIAogICAgIHJldHVybiBGbG9hdFJlY3Qod29ya0FyZWEueCwgd29ya0FyZWEueSwg d29ya0FyZWEud2lkdGgsIHdvcmtBcmVhLmhlaWdodCk7CiAK