198724 2019-06-10 11:16:41 -0700 [WinCairo] Remove build warning from RemoteInspector. 2019-06-10 17:40:56 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 basuke basuke basuke commit-queue darin don.olmstead ews-watchlist hi joepeck keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1543392 0 basuke 2019-06-10 11:16:41 -0700 In `inspector/remote/socket/RemoteInspectorConnectionClient.h` an interface was defined with empty implementation. It is method to be overwritten by sub classes so that parameter name is important. This empty method generates warning. The subclasses of the class are just two and one has it's own implementation. It's good to define this as an abstract method and move default implementation to that sub class. 1543398 1 371765 basuke 2019-06-10 11:32:32 -0700 Created attachment 371765 PATCH 1543452 2 371765 darin 2019-06-10 13:46:55 -0700 Comment on attachment 371765 PATCH View in context: https://bugs.webkit.org/attachment.cgi?id=371765&action=review > Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorConnectionClient.h:40 > + virtual void didAccept(ConnectionID acceptedID, ConnectionID listenerID, Socket::Domain) = 0; Alternative fix is: virtual void didAccept(ConnectionID /* acceptedID */, ConnectionID /* listenerID */, Socket::Domain) { } There’s no need to switch to pure virtual just to get rid of the unused argument warning. Your suggested change is OK if we think it’s better for other reasons. 1543473 3 basuke 2019-06-10 14:44:53 -0700 (In reply to Darin Adler from comment #2) > Alternative fix is: > > virtual void didAccept(ConnectionID /* acceptedID */, ConnectionID /* > listenerID */, Socket::Domain) { } That was also my first approach in downstream. The reason I changed my mind was I cannot be confident with that manner accepted by upstream. I will resend with commenting way. Thanks. 1543476 4 371780 basuke 2019-06-10 14:49:38 -0700 Created attachment 371780 PATCH 1543504 5 371780 joepeck 2019-06-10 15:50:12 -0700 Comment on attachment 371780 PATCH r=me, let me know I you need me to cq+ 1543530 6 371780 basuke 2019-06-10 17:09:28 -0700 Comment on attachment 371780 PATCH Thanks! 1543537 7 371780 commit-queue 2019-06-10 17:38:54 -0700 Comment on attachment 371780 PATCH Clearing flags on attachment: 371780 Committed r246299: <https://trac.webkit.org/changeset/246299> 1543538 8 commit-queue 2019-06-10 17:38:56 -0700 All reviewed patches have been landed. Closing bug. 1543539 9 webkit-bug-importer 2019-06-10 17:40:56 -0700 <rdar://problem/51605252> 371765 2019-06-10 11:32:32 -0700 2019-06-10 14:49:38 -0700 PATCH 198724.diff text/plain 2557 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI3MDhhNGJlY2QwLi45ZTEzZGVhZDhmZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDYtMTAgIEJhc3Vr ZSBTdXp1a2kgIDxCYXN1a2UuU3V6dWtpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10g UmVtb3ZlIGJ1aWxkIHdhcm5pbmcgZnJvbSBSZW1vdGVJbnNwZWN0b3IuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg3MjQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVXBzdHJlYW5dIFJlbW92ZSBidWls ZCB3YXJuaW5nLgorCisgICAgICAgIEluIGBSZW1vdGVJbnNwZWN0b3JDb25uZWN0aW9uQ2xpZW50 LmhgLCBhbiBpbnRlcmZhY2Ugd2FzIGRlZmluZWQgd2l0aCBlbXB0eSBpbXBsZW1lbnRhdGlvbi4K KyAgICAgICAgVGhpcyBtZXRob2QgaXMgdG8gYmUgb3ZlcndyaXR0ZW4gYnkgc3ViIGNsYXNzZXMg c28gdGhhdCBwYXJhbWV0ZXIgbmFtZSBpcyBpbXBvcnRhbnQuCisgICAgICAgIFRoZSBzdWJjbGFz c2VzIG9mIHRoZSBjbGFzcyBhcmUganVzdCB0d28gYW5kIG9uZSBoYXMgaXQncyBvd24gaW1wbGVt ZW50YXRpb24uCisgICAgICAgIERlZmluZSB0aGlzIG1ldGhvZCBhcyBhbiBhYnN0cmFjdCBtZXRo b2QgYW5kIG1vdmUgZGVmYXVsdCBpbXBsZW1lbnRhdGlvbiB0byB0aGF0IHN1YmNsYXNzLgorCisg ICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNwZWN0b3IuaDoKKyAgICAgICAgKiBp bnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JDb25uZWN0aW9uQ2xpZW50Lmg6 CisKIDIwMTktMDYtMTAgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNv bT4KIAogICAgICAgICBbSlNDXSBMaW5rZXIgZmFpbHMgd2hlbiB1bmlmaWVkIHNvdXJjZXMgYXJl IG5vdCBpbiB1c2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3Iv cmVtb3RlL1JlbW90ZUluc3BlY3Rvci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3BlY3Rv ci9yZW1vdGUvUmVtb3RlSW5zcGVjdG9yLmgKaW5kZXggMmI5MzE1ZTgyZGMuLjczMTZhYjgxNTA1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9SZW1v dGVJbnNwZWN0b3IuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90 ZS9SZW1vdGVJbnNwZWN0b3IuaApAQCAtMjExLDYgKzIxMSw3IEBAIHByaXZhdGU6CiAjZW5kaWYK ICNpZiBVU0UoSU5TUEVDVE9SX1NPQ0tFVF9TRVJWRVIpCiAgICAgSGFzaE1hcDxTdHJpbmcsIENh bGxIYW5kbGVyPiYgZGlzcGF0Y2hNYXAoKSBvdmVycmlkZTsKKyAgICB2b2lkIGRpZEFjY2VwdChD b25uZWN0aW9uSUQsIENvbm5lY3Rpb25JRCwgU29ja2V0OjpEb21haW4pIG92ZXJyaWRlIHsgfQog ICAgIHZvaWQgZGlkQ2xvc2UoQ29ubmVjdGlvbklEKSBvdmVycmlkZTsKIAogICAgIHZvaWQgc2Vu ZFdlYkluc3BlY3RvckV2ZW50KGNvbnN0IFN0cmluZyYpOwpkaWZmIC0tZ2l0IGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL2luc3BlY3Rvci9yZW1vdGUvc29ja2V0L1JlbW90ZUluc3BlY3RvckNvbm5l Y3Rpb25DbGllbnQuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3Nv Y2tldC9SZW1vdGVJbnNwZWN0b3JDb25uZWN0aW9uQ2xpZW50LmgKaW5kZXggYzZhNjI5NjIyMjIu LmIwMzg0ZjMzNDg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9y L3JlbW90ZS9zb2NrZXQvUmVtb3RlSW5zcGVjdG9yQ29ubmVjdGlvbkNsaWVudC5oCisrKyBiL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0 b3JDb25uZWN0aW9uQ2xpZW50LmgKQEAgLTM3LDcgKzM3LDcgQEAgbmFtZXNwYWNlIEluc3BlY3Rv ciB7CiBjbGFzcyBSZW1vdGVJbnNwZWN0b3JDb25uZWN0aW9uQ2xpZW50IDogcHVibGljIENhbk1h a2VXZWFrUHRyPFJlbW90ZUluc3BlY3RvckNvbm5lY3Rpb25DbGllbnQ+IHsKIHB1YmxpYzoKICAg ICB2b2lkIGRpZFJlY2VpdmVXZWJJbnNwZWN0b3JFdmVudChDb25uZWN0aW9uSUQsIFZlY3Rvcjx1 aW50OF90PiYmKTsKLSAgICB2aXJ0dWFsIHZvaWQgZGlkQWNjZXB0KENvbm5lY3Rpb25JRCBhY2Nl cHRlZElELCBDb25uZWN0aW9uSUQgbGlzdGVuZXJJRCwgU29ja2V0OjpEb21haW4pIHsgfQorICAg IHZpcnR1YWwgdm9pZCBkaWRBY2NlcHQoQ29ubmVjdGlvbklEIGFjY2VwdGVkSUQsIENvbm5lY3Rp b25JRCBsaXN0ZW5lcklELCBTb2NrZXQ6OkRvbWFpbikgPSAwOwogICAgIHZpcnR1YWwgdm9pZCBk aWRDbG9zZShDb25uZWN0aW9uSUQpID0gMDsKIAogICAgIHN0cnVjdCBFdmVudCB7Cg== 371780 2019-06-10 14:49:38 -0700 2019-06-10 17:38:54 -0700 PATCH 198724.diff text/plain 1755 basuke ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGI3MDhhNGJlY2QwLi40YzdhZTlkMmY0OCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDYtMTAgIEJhc3Vr ZSBTdXp1a2kgIDxCYXN1a2UuU3V6dWtpQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10g UmVtb3ZlIGJ1aWxkIHdhcm5pbmcgZnJvbSBSZW1vdGVJbnNwZWN0b3IuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg3MjQKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbiBgUmVtb3RlSW5zcGVjdG9yQ29u bmVjdGlvbkNsaWVudC5oYCwgYW4gaW50ZXJmYWNlIHdhcyBkZWZpbmVkIHdpdGggZW1wdHkgaW1w bGVtZW50YXRpb24uCisgICAgICAgIFRoaXMgbWV0aG9kIGlzIHRvIGJlIG92ZXJ3cml0dGVuIGJ5 IHN1YiBjbGFzc2VzIHNvIHRoYXQgcGFyYW1ldGVyIG5hbWUgaXMgaW1wb3J0YW50CisgICAgICAg IHNvIHRoZXkgYXJlIGNvbW1lbnRlZCBvdXQgcmF0aGVyIHRoYW4ganVzdCByZW1vdmluZyBmcm9t IHRoZSBkZWZpbml0aW9uLgorCisgICAgICAgICogaW5zcGVjdG9yL3JlbW90ZS9SZW1vdGVJbnNw ZWN0b3IuaDoKKwogMjAxOS0wNi0xMCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFwZXJlekBp Z2FsaWEuY29tPgogCiAgICAgICAgIFtKU0NdIExpbmtlciBmYWlscyB3aGVuIHVuaWZpZWQgc291 cmNlcyBhcmUgbm90IGluIHVzZQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2lu c3BlY3Rvci9yZW1vdGUvc29ja2V0L1JlbW90ZUluc3BlY3RvckNvbm5lY3Rpb25DbGllbnQuaCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNw ZWN0b3JDb25uZWN0aW9uQ2xpZW50LmgKaW5kZXggYzZhNjI5NjIyMjIuLjdiZjlkYjE4MDY3IDEw MDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3JlbW90ZS9zb2NrZXQv UmVtb3RlSW5zcGVjdG9yQ29ubmVjdGlvbkNsaWVudC5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0 Q29yZS9pbnNwZWN0b3IvcmVtb3RlL3NvY2tldC9SZW1vdGVJbnNwZWN0b3JDb25uZWN0aW9uQ2xp ZW50LmgKQEAgLTM3LDcgKzM3LDcgQEAgbmFtZXNwYWNlIEluc3BlY3RvciB7CiBjbGFzcyBSZW1v dGVJbnNwZWN0b3JDb25uZWN0aW9uQ2xpZW50IDogcHVibGljIENhbk1ha2VXZWFrUHRyPFJlbW90 ZUluc3BlY3RvckNvbm5lY3Rpb25DbGllbnQ+IHsKIHB1YmxpYzoKICAgICB2b2lkIGRpZFJlY2Vp dmVXZWJJbnNwZWN0b3JFdmVudChDb25uZWN0aW9uSUQsIFZlY3Rvcjx1aW50OF90PiYmKTsKLSAg ICB2aXJ0dWFsIHZvaWQgZGlkQWNjZXB0KENvbm5lY3Rpb25JRCBhY2NlcHRlZElELCBDb25uZWN0 aW9uSUQgbGlzdGVuZXJJRCwgU29ja2V0OjpEb21haW4pIHsgfQorICAgIHZpcnR1YWwgdm9pZCBk aWRBY2NlcHQoQ29ubmVjdGlvbklEIC8qIGFjY2VwdGVkSUQgKi8sIENvbm5lY3Rpb25JRCAvKiBs aXN0ZW5lcklEICovLCBTb2NrZXQ6OkRvbWFpbikgeyB9CiAgICAgdmlydHVhbCB2b2lkIGRpZENs b3NlKENvbm5lY3Rpb25JRCkgPSAwOwogCiAgICAgc3RydWN0IEV2ZW50IHsK