198713 2019-06-10 06:37:40 -0700 [WPE][Qt] Port to new wpe_fdo_egl_exported_image API 2019-06-10 07:12:00 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand aperez bugs-noreply cgarcia zan oldest_to_newest 1543302 0 pnormand 2019-06-10 06:37:40 -0700 Patch incoming 1543304 1 371737 pnormand 2019-06-10 06:40:25 -0700 Created attachment 371737 Patch 1543307 2 371737 cgarcia 2019-06-10 06:47:41 -0700 Comment on attachment 371737 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371737&action=review > Source/WebKit/UIProcess/API/wpe/qt/WPEQtViewBackend.cpp:212 > - RELEASE_ASSERT(m_lockedImage == EGL_NO_IMAGE_KHR); > + RELEASE_ASSERT(m_lockedImage == nullptr); !m_lockedImage > Source/cmake/OptionsWPE.cmake:175 > - pkg_check_modules(WPE_BACKEND_FDO REQUIRED wpebackend-fdo-1.0) > + pkg_check_modules(WPE_BACKEND_FDO REQUIRED "wpebackend-fdo-1.0 >= 1.3.0") Could you use find_package(WPEBackend-fdo 1.3.0) instead? You will have to change the INCLUDE_DIRS and LIBRARIES vars to WPEBACKEND_FDO_INCLUDE_DIRS and WPEBACKEND_FDO_LIBRARIES. That would make QtWPE consistent with wpe and gtk. 1543313 3 pnormand 2019-06-10 07:05:47 -0700 Committed r246257: <https://trac.webkit.org/changeset/246257> 1543316 4 aperez 2019-06-10 07:12:00 -0700 *** Bug 198716 has been marked as a duplicate of this bug. *** 371737 2019-06-10 06:40:25 -0700 2019-06-10 06:47:41 -0700 Patch bug-198713-20190610144024.patch text/plain 6787 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU5Njg0NTEzNTNhZDY5MDU3 MzZhMTIxNzYwNDZmNDQxOTlmOTk5OTQuLjc5YWI5OGJjY2UwOTQzOTYwNDNkZDVhNjI5NzQyMjY4 YTNiOGFhYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDYtMTAgIFBoaWxpcHBl IE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtXUEVdW1F0XSBQb3J0 IHRvIG5ldyB3cGVfZmRvX2VnbF9leHBvcnRlZF9pbWFnZSBBUEkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODcxMworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BF UXRWaWV3QmFja2VuZC5jcHA6CisgICAgICAgIChXUEVRdFZpZXdCYWNrZW5kOjpXUEVRdFZpZXdC YWNrZW5kKToKKyAgICAgICAgKFdQRVF0Vmlld0JhY2tlbmQ6OnRleHR1cmUpOgorICAgICAgICAo V1BFUXRWaWV3QmFja2VuZDo6ZGlzcGxheUltYWdlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJ L3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5kLmg6CisKIDIwMTktMDYtMDkgIEJyZW50IEZ1bGdoYW0g IDxiZnVsZ2hhbUBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUmVzb3VyY2VMb2FkU3RhdGlz dGljcyBzdGF0ZSBpcyBub3QgcHJvcGVybHkgcmVsYXllZCB0byB0aGUgTmV0d29ya1Byb2Nlc3MK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3 QmFja2VuZC5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL3F0L1dQRVF0Vmll d0JhY2tlbmQuY3BwCmluZGV4IDI2NmZlMjc5NDM4ZTcxZTZiZTE4MTU2NjNiMWVlMzJjN2U0NzFl NmUuLjk3YmExNDlkYjQ5NzY0NzUzZWMyOGViYjUyOWM3YTE0YmEwMDk1NmMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3QmFja2VuZC5jcHAK KysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9xdC9XUEVRdFZpZXdCYWNrZW5k LmNwcApAQCAtMTEzLDEzICsxMTMsMTQgQEAgV1BFUXRWaWV3QmFja2VuZDo6V1BFUXRWaWV3QmFj a2VuZChjb25zdCBRU2l6ZUYmIHNpemUsIEVHTERpc3BsYXkgZGlzcGxheSwgRUdMQ28KICAgICBt X3RleHR1cmVVbmlmb3JtID0gZ2xGdW5jdGlvbnMtPmdsR2V0VW5pZm9ybUxvY2F0aW9uKG1fcHJv Z3JhbSwgInVfdGV4dHVyZSIpOwogCiAgICAgc3RhdGljIHN0cnVjdCB3cGVfdmlld19iYWNrZW5k X2V4cG9ydGFibGVfZmRvX2VnbF9jbGllbnQgZXhwb3J0YWJsZUNsaWVudCA9IHsKLSAgICAgICAg Ly8gZXhwb3J0X2J1ZmZlcl9yZXNvdXJjZQotICAgICAgICBbXSh2b2lkKiBkYXRhLCBFR0xJbWFn ZUtIUiBpbWFnZSkKKyAgICAgICAgLy8gZXhwb3J0X2VnbF9pbWFnZQorICAgICAgICBudWxscHRy LAorICAgICAgICBbXSh2b2lkKiBkYXRhLCBzdHJ1Y3Qgd3BlX2Zkb19lZ2xfZXhwb3J0ZWRfaW1h Z2UqIGltYWdlKQogICAgICAgICB7CiAgICAgICAgICAgICBzdGF0aWNfY2FzdDxXUEVRdFZpZXdC YWNrZW5kKj4oZGF0YSktPmRpc3BsYXlJbWFnZShpbWFnZSk7CiAgICAgICAgIH0sCiAgICAgICAg IC8vIHBhZGRpbmcKLSAgICAgICAgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0ciwgbnVsbHB0cgor ICAgICAgICBudWxscHRyLCBudWxscHRyLCBudWxscHRyCiAgICAgfTsKIAogICAgIG1fZXhwb3J0 YWJsZSA9IHdwZV92aWV3X2JhY2tlbmRfZXhwb3J0YWJsZV9mZG9fZWdsX2NyZWF0ZSgmZXhwb3J0 YWJsZUNsaWVudCwgdGhpcywgbV9zaXplLndpZHRoKCksIG1fc2l6ZS5oZWlnaHQoKSk7CkBAIC0x NzEsNyArMTcyLDcgQEAgR0x1aW50IFdQRVF0Vmlld0JhY2tlbmQ6OnRleHR1cmUoUU9wZW5HTENv bnRleHQqIGNvbnRleHQpCiAKICAgICBnbEZ1bmN0aW9ucy0+Z2xBY3RpdmVUZXh0dXJlKEdMX1RF WFRVUkUwKTsKICAgICBnbEZ1bmN0aW9ucy0+Z2xCaW5kVGV4dHVyZShHTF9URVhUVVJFXzJELCBt X3RleHR1cmVJZCk7Ci0gICAgaW1hZ2VUYXJnZXRUZXh0dXJlMkRPRVMoR0xfVEVYVFVSRV8yRCwg bV9sb2NrZWRJbWFnZSk7CisgICAgaW1hZ2VUYXJnZXRUZXh0dXJlMkRPRVMoR0xfVEVYVFVSRV8y RCwgd3BlX2Zkb19lZ2xfZXhwb3J0ZWRfaW1hZ2VfZ2V0X2VnbF9pbWFnZShtX2xvY2tlZEltYWdl KSk7CiAgICAgZ2xGdW5jdGlvbnMtPmdsVW5pZm9ybTFpKG1fdGV4dHVyZVVuaWZvcm0sIDApOwog CiAgICAgc3RhdGljIGNvbnN0IEdMZmxvYXQgdmVydGljZXNbNF1bMl0gPSB7CkBAIC0yMDAsMTUg KzIwMSwxNSBAQCBHTHVpbnQgV1BFUXRWaWV3QmFja2VuZDo6dGV4dHVyZShRT3BlbkdMQ29udGV4 dCogY29udGV4dCkKICAgICBnbEZ1bmN0aW9ucy0+Z2xEaXNhYmxlVmVydGV4QXR0cmliQXJyYXko MSk7CiAKICAgICB3cGVfdmlld19iYWNrZW5kX2V4cG9ydGFibGVfZmRvX2Rpc3BhdGNoX2ZyYW1l X2NvbXBsZXRlKG1fZXhwb3J0YWJsZSk7Ci0gICAgd3BlX3ZpZXdfYmFja2VuZF9leHBvcnRhYmxl X2Zkb19lZ2xfZGlzcGF0Y2hfcmVsZWFzZV9pbWFnZShtX2V4cG9ydGFibGUsIG1fbG9ja2VkSW1h Z2UpOwotICAgIG1fbG9ja2VkSW1hZ2UgPSBFR0xfTk9fSU1BR0VfS0hSOworICAgIHdwZV92aWV3 X2JhY2tlbmRfZXhwb3J0YWJsZV9mZG9fZWdsX2Rpc3BhdGNoX3JlbGVhc2VfZXhwb3J0ZWRfaW1h Z2UobV9leHBvcnRhYmxlLCBtX2xvY2tlZEltYWdlKTsKKyAgICBtX2xvY2tlZEltYWdlID0gbnVs bHB0cjsKIAogICAgIHJldHVybiBtX3RleHR1cmVJZDsKIH0KIAotdm9pZCBXUEVRdFZpZXdCYWNr ZW5kOjpkaXNwbGF5SW1hZ2UoRUdMSW1hZ2VLSFIgaW1hZ2UpCit2b2lkIFdQRVF0Vmlld0JhY2tl bmQ6OmRpc3BsYXlJbWFnZShzdHJ1Y3Qgd3BlX2Zkb19lZ2xfZXhwb3J0ZWRfaW1hZ2UqIGltYWdl KQogewotICAgIFJFTEVBU0VfQVNTRVJUKG1fbG9ja2VkSW1hZ2UgPT0gRUdMX05PX0lNQUdFX0tI Uik7CisgICAgUkVMRUFTRV9BU1NFUlQobV9sb2NrZWRJbWFnZSA9PSBudWxscHRyKTsKICAgICBt X2xvY2tlZEltYWdlID0gaW1hZ2U7CiAgICAgaWYgKG1fdmlldykKICAgICAgICAgbV92aWV3LT50 cmlnZ2VyVXBkYXRlKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkv d3BlL3F0L1dQRVF0Vmlld0JhY2tlbmQuaCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93 cGUvcXQvV1BFUXRWaWV3QmFja2VuZC5oCmluZGV4IGYwNDU2ZDZmYmFkOTcwODUxMGY1M2FhMzM0 NGJjOGVhZjVmZjE2MzEuLmEwYzBlN2QyZTM3MjczZTU4ZmQ5ZGJiYTJjZDUxNjY2OGEyY2RhMjQg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRWaWV3 QmFja2VuZC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvcXQvV1BFUXRW aWV3QmFja2VuZC5oCkBAIC02MSwxNCArNjEsMTMgQEAgcHVibGljOgogICAgIHN0cnVjdCB3cGVf dmlld19iYWNrZW5kKiBiYWNrZW5kKCkgY29uc3QgeyByZXR1cm4gd3BlX3ZpZXdfYmFja2VuZF9l eHBvcnRhYmxlX2Zkb19nZXRfdmlld19iYWNrZW5kKG1fZXhwb3J0YWJsZSk7IH07CiAKIHByaXZh dGU6Ci0gICAgdm9pZCBkaXNwbGF5SW1hZ2UoRUdMSW1hZ2VLSFIpOworICAgIHZvaWQgZGlzcGxh eUltYWdlKHN0cnVjdCB3cGVfZmRvX2VnbF9leHBvcnRlZF9pbWFnZSopOwogICAgIHVpbnQzMl90 IG1vZGlmaWVycygpIGNvbnN0OwogCiAgICAgRUdMRGlzcGxheSBtX2VnbERpc3BsYXkgeyBudWxs cHRyIH07CiAgICAgRUdMQ29udGV4dCBtX2VnbENvbnRleHQgeyBudWxscHRyIH07CiAgICAgc3Ry dWN0IHdwZV92aWV3X2JhY2tlbmRfZXhwb3J0YWJsZV9mZG8qIG1fZXhwb3J0YWJsZSB7IG51bGxw dHIgfTsKLQotICAgIEVHTEltYWdlS0hSIG1fbG9ja2VkSW1hZ2UgeyBFR0xfTk9fSU1BR0VfS0hS IH07CisgICAgc3RydWN0IHdwZV9mZG9fZWdsX2V4cG9ydGVkX2ltYWdlKiBtX2xvY2tlZEltYWdl IHsgbnVsbHB0ciB9OwogCiAgICAgUVBvaW50ZXI8V1BFUXRWaWV3PiBtX3ZpZXc7CiAgICAgUU9m ZnNjcmVlblN1cmZhY2UgbV9zdXJmYWNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlv bnNXUEUuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQppbmRleCA1Yzk5MjMy YmEwY2Q0OWQzNWRmZGViMWU4YmM2MWM0MDQ4ZjI3YWJiLi41MmUzMjFlYTFlYWI1YmNkYTIxMWIx OTJmMmIwODhmYmZjZTEyM2FlIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5j bWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dQRS5jbWFrZQpAQCAtMTcyLDcgKzE3Miw3 IEBAIGlmIChFTkFCTEVfV1BFX1FUX0FQSSkKICAgICBmaW5kX3BhY2thZ2UoUXQ1IFJFUVVJUkVE IENPTVBPTkVOVFMgQ29yZSBRdWljayBHdWkpCiAgICAgZmluZF9wYWNrYWdlKFF0NVRlc3QgUkVR VUlSRUQpCiAgICAgZmluZF9wYWNrYWdlKFBrZ0NvbmZpZykKLSAgICBwa2dfY2hlY2tfbW9kdWxl cyhXUEVfQkFDS0VORF9GRE8gUkVRVUlSRUQgd3BlYmFja2VuZC1mZG8tMS4wKQorICAgIHBrZ19j aGVja19tb2R1bGVzKFdQRV9CQUNLRU5EX0ZETyBSRVFVSVJFRCAid3BlYmFja2VuZC1mZG8tMS4w ID49IDEuMy4wIikKIGVuZGlmICgpCiAKIGFkZF9kZWZpbml0aW9ucygtREJVSUxESU5HX1dQRV9f PTEpCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXgg ZjQ3Mjk1NmYwNWRlNmZjODRmZGMyZGY2MjdhZTBhNGU2NTdmZGRiNS4uNTUyZjg5NjJjOGM3ZThj NTIzZDE4ZGE4ODgyNjdiZDBmZTMyMWEzNiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisr KyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA2LTEwICBQaGlsaXBw ZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtRdF0gUG9y dCB0byBuZXcgd3BlX2Zkb19lZ2xfZXhwb3J0ZWRfaW1hZ2UgQVBJCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg3MTMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGZsYXRwYWsvb3JnLndlYmtpdC5XUEVN b2R1bGVzLnlhbWw6IEluY2x1ZGUgd3BlYmFja2VuZC1mZG8KKyAgICAgICAgcGF0Y2hlcyBjdXJy ZW50bHkgdXNlZCBpbiBKSEJ1aWxkLgorCiAyMDE5LTA2LTEwICBaYW4gRG9iZXJzZWsgIDx6ZG9i ZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIGZvbGxvdy11cCB0byByMjQ2 MTQ4LiBBZGQgYW5vdGhlciBXUEVCYWNrZW5kLWZkbyBwYXRjaCB0aGF0CmRpZmYgLS1naXQgYS9U b29scy9mbGF0cGFrL29yZy53ZWJraXQuV1BFTW9kdWxlcy55YW1sIGIvVG9vbHMvZmxhdHBhay9v cmcud2Via2l0LldQRU1vZHVsZXMueWFtbAppbmRleCA5NzAzNDhmMmQxNDk0NWQyZGIzNGE0NzFl MjFhNjAzZGU0MzhiZDQ4Li41MTU1YWUyNTM1ZDdjMjExZGUzYWU0MDhlNDU4MDM5MmUwNjcwOWNj IDEwMDY0NAotLS0gYS9Ub29scy9mbGF0cGFrL29yZy53ZWJraXQuV1BFTW9kdWxlcy55YW1sCisr KyBiL1Rvb2xzL2ZsYXRwYWsvb3JnLndlYmtpdC5XUEVNb2R1bGVzLnlhbWwKQEAgLTEwLDMgKzEw LDcgQEAKICAgICAtIHR5cGU6IGFyY2hpdmUKICAgICAgIHVybDogaHR0cHM6Ly93cGV3ZWJraXQu b3JnL3JlbGVhc2VzL3dwZWJhY2tlbmQtZmRvLTEuMy4wLnRhci54egogICAgICAgc2hhMjU2OiBm ZWQ5YWIyOWY1ZDUzY2Y0NjUxODhkYTgwZDAxNGYzYWEwNjdjNzc3MDRmODUwOGM2YmQxNzk3MWZk ZWQzNTlkCisgICAgLSB0eXBlOiBwYXRjaAorICAgICAgcGF0aDogLi4vZ3RrL3BhdGNoZXMvd3Bl YmFja2VuZC1mZG8tSGFuZGxlLXRoZS1jYXNlLW9mLW5ldy10YXJnZXQtY3JlYXRlZC1mb3ItdGhl LXNhbWUtdi5wYXRjaAorICAgIC0gdHlwZTogcGF0Y2gKKyAgICAgIHBhdGg6IC4uL2d0ay93cGVi YWNrZW5kLWZkby12aWV3LWJhY2tlbmQtZXhwb3J0YWJsZS1wcml2YXRlLWRvbi10LWRvdWJsZS1m cmVlLWNhLnBhdGNoCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggNzhj ODA0ZTJhYjdhNGQzMWVhYTVlYzg3NjFmMzZmMDA4MzU1MWM4Mi4uMjE2NGM0NjQ2YTE4MThkOWY1 OWI2M2U3M2Y0NGNkYzAyN2M4NTI5OCAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE5LTA2LTEwICBQaGlsaXBwZSBOb3JtYW5kICA8cG5v cm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtRdF0gUG9ydCB0byBuZXcgd3BlX2Zk b19lZ2xfZXhwb3J0ZWRfaW1hZ2UgQVBJCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTg3MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlOgorCiAyMDE5 LTA2LTA0ICBUYWthc2hpIEtvbW9yaSAgPFRha2FzaGkuS29tb3JpQHNvbnkuY29tPgogCiAgICAg ICAgIFtXaW5DYWlyb10gSW1wbGVtZW50IGNwdSBhbmQgbWVtb3J5IG1lYXN1cmluZyBmdW5jdGlv bnMuCg==