198699 2019-06-09 14:21:47 -0700 [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests 2019-06-10 13:55:16 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh aestes bdakin commit-queue graouts simon.fraser sroberts thorton tsavell webkit-bug-importer yongjun_zhang oldest_to_newest 1543223 0 wenson_hsieh 2019-06-09 14:21:47 -0700 <rdar://problem/50501718> 1543224 1 371713 wenson_hsieh 2019-06-09 14:34:42 -0700 Created attachment 371713 Patch 1543226 2 wenson_hsieh 2019-06-09 16:25:10 -0700 > : No such file or directory at /home/buildbot/WebKit/Source/WebCore/bindings/scripts/preprocess-idls.pl line 105. > Died at C:/cygwin/home/buildbot/WebKit/Source/WebCore/bindings/scripts/generate-bindings-all.pl line 85. > C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(209,5): error MSB6006: "cmd.exe" exited with code 2. [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebCore\WebCoreBindings.vcxproj] > Generating ../../DerivedSources/JavaScriptCore/JSInternalPromiseConstructor.lut.h It doesn't look like this build failure is related. 1543247 3 ap 2019-06-09 21:30:36 -0700 Really interesting how these viewport test failures turn out to have entirely different root causes - see also bug 196236 and bug 197286. There are others that are still waiting to be resolved: bug 196298, bug 195341, bug 181821. 1543248 4 wenson_hsieh 2019-06-09 21:39:49 -0700 (In reply to Alexey Proskuryakov from comment #3) > Really interesting how these viewport test failures turn out to have > entirely different root causes - see also bug 196236 and bug 197286. > > There are others that are still waiting to be resolved: bug 196298, bug > 195341, bug 181821. It's not unusual that the tests in fast/viewport/ios are so flaky for different reasons than other tests that are generally about visual viewports, since the iOS tests tend to exercise the obscure nooks and crannies of ViewportConfiguration and friends, which only affect iOS. I'll be investigating the other fast/viewport/ios failures (fast/viewport/ios/use-minimum-device-width-for-page-without-viewport-meta.html and fast/viewport/ios/*-width-viewport-after-changing-view-scale.html) next. 1543437 5 371713 commit-queue 2019-06-10 13:11:23 -0700 Comment on attachment 371713 Patch Clearing flags on attachment: 371713 Committed r246276: <https://trac.webkit.org/changeset/246276> 1543438 6 commit-queue 2019-06-10 13:11:25 -0700 All reviewed patches have been landed. Closing bug. 1543454 7 wenson_hsieh 2019-06-10 13:55:16 -0700 *** Bug 197616 has been marked as a duplicate of this bug. *** 371713 2019-06-09 14:34:42 -0700 2019-06-10 13:11:23 -0700 Patch bug-198699-20190609143441.patch text/plain 5553 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDY4NDcwMTNiM2U2Yzg5ODkx OWViOTA1ZGVlMTBhOTNkZDcwNTdhZDMuLmIzMDdiMjU3MzNhNWQ1MDllMWQ0NDc4NThlZjU0MGM4 ODYzMjkyZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDYtMDkgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gZmFzdC94c2wg dGVzdHMgYXJlIGZsYWt5IHdoZW4gcnVuIGFmdGVyIGNlcnRhaW4gdmlld3BvcnQgc2hyaW5rLXRv LWZpdCB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTk4Njk5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDUwMTcxOD4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBMaWZ0IGxvZ2ljIHRoYXQgc2V0 cyB0aGUgIklzS25vd25Ub0xheU91dFdpZGVyVGhhblZpZXdwb3J0IiBmbGFnIG91dCBvZiByZXNl dFZpZXdwb3J0RGVmYXVsdENvbmZpZ3VyYXRpb24sIGFuZAorICAgICAgICBpbnRvIGRpZENvbW1p dExvYWQgaW5zdGVhZCAoYWxvbmcgd2l0aCBvdGhlciBsb2dpYyBmb3IgcmVzZXR0aW5nIHZpZXdw b3J0IGFyZ3VtZW50cykuIFRoZSBwcmV2aW91cyBtZXRob2QsCisgICAgICAgIHJlc2V0Vmlld3Bv cnREZWZhdWx0Q29uZmlndXJhdGlvbiwgd2FzIGJlaW5nIHRyaWdnZXJlZCB2ZXJ5IGZyZXF1ZW50 bHkgdW5kbyBkaWRSZWNlaXZlTW9iaWxlRG9jVHlwZSwgY2F1c2luZyB0aGUKKyAgICAgICAgc2hy aW5rLXRvLWZpdCBoZXVyaXN0aWMgdG8gc29tZXRpbWVzIHRha2Ugbm8gZWZmZWN0LiBUaGUgb3Jp Z2luYWwgaW50ZW50aW9uIGhlcmUgd2FzIHNpbXBseSB0byByZXNldCB0aGUgZmxhZworICAgICAg ICB1cG9uIHBhZ2UgbG9hZC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdl LmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6ZGlkQ29tbWl0TG9hZCk6CisgICAgICAg ICogV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlOjpyZXNldFZpZXdwb3J0RGVmYXVsdENvbmZpZ3VyYXRpb24pOgorCiAyMDE5LTA2 LTA4ICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtp T1NdIFRoZSBkZWZhdWx0IGFwcGxpY2F0aW9uIG5hbWUgZm9yIHVzZXIgYWdlbnQgd2hlbiByZXF1 ZXN0aW5nIGRlc2t0b3AgY29udGVudCBpcyBzdGlsbCAiTW9iaWxlLzE1RTE0OCIKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHAKaW5kZXggMmVkN2U5MzE4MjJm Y2I2YzA0ZjJjOGUyZWRjOTk1NjNmOGFlNTVmOC4uZjdiMTMxMmViZGYyMmZmOTAwNTQyYWZkNjc1 MGFmZjNiYWViYWE5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2Vi UGFnZS5jcHAKQEAgLTU3NTMsNiArNTc1Myw5IEBAIHZvaWQgV2ViUGFnZTo6ZGlkQ29tbWl0TG9h ZChXZWJGcmFtZSogZnJhbWUpCiAgICAgaWYgKG1fdmlld3BvcnRDb25maWd1cmF0aW9uLnNldFZp ZXdwb3J0QXJndW1lbnRzKGNvcmVGcmFtZS0+ZG9jdW1lbnQoKS0+dmlld3BvcnRBcmd1bWVudHMo KSkpCiAgICAgICAgIHZpZXdwb3J0Q2hhbmdlZCA9IHRydWU7CiAKKyAgICBpZiAobV92aWV3cG9y dENvbmZpZ3VyYXRpb24uc2V0SXNLbm93blRvTGF5T3V0V2lkZXJUaGFuVmlld3BvcnQoZmFsc2Up KQorICAgICAgICB2aWV3cG9ydENoYW5nZWQgPSB0cnVlOworCiAgICAgaWYgKHZpZXdwb3J0Q2hh bmdlZCkKICAgICAgICAgdmlld3BvcnRDb25maWd1cmF0aW9uQ2hhbmdlZCgpOwogI2VuZGlmCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2ViUGFnZUlP Uy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1t CmluZGV4IDM4YmY4ZmU1Zjc3YThjMTZkNjYxMGIwYTE1OTZiYjcxZWFhZjdhNTAuLjhhZTMwMjVi NjQ5MjFjMDU1NTc0MTVjOTE3MDU3YTdiOGNmOThlMWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0zMjEwLDcgKzMyMTAs NiBAQCB2b2lkIFdlYlBhZ2U6OnJlc2V0Vmlld3BvcnREZWZhdWx0Q29uZmlndXJhdGlvbihXZWJG cmFtZSogZnJhbWUsIGJvb2wgaGFzTW9iaWxlRAogICAgICAgICBtX3ZpZXdwb3J0Q29uZmlndXJh dGlvbi5zZXREZWZhdWx0Q29uZmlndXJhdGlvbihWaWV3cG9ydENvbmZpZ3VyYXRpb246OnRleHRE b2N1bWVudFBhcmFtZXRlcnMoKSk7CiAgICAgZWxzZQogICAgICAgICBtX3ZpZXdwb3J0Q29uZmln dXJhdGlvbi5zZXREZWZhdWx0Q29uZmlndXJhdGlvbihwYXJhbWV0ZXJzRm9yU3RhbmRhcmRGcmFt ZSgpKTsKLSAgICBtX3ZpZXdwb3J0Q29uZmlndXJhdGlvbi5zZXRJc0tub3duVG9MYXlPdXRXaWRl clRoYW5WaWV3cG9ydChmYWxzZSk7CiAKICAgICBpZiAoYXV0byBvdmVycmlkZGVuVmlld0xheW91 dFdpZHRoID0gZG9jdW1lbnQtPnF1aXJrcygpLm92ZXJyaWRkZW5WaWV3TGF5b3V0V2lkdGgobV92 aWV3cG9ydENvbmZpZ3VyYXRpb24ubGF5b3V0V2lkdGgoKSkpCiAgICAgICAgIG1fdmlld3BvcnRD b25maWd1cmF0aW9uLnNldFZpZXdMYXlvdXRTaXplKEZsb2F0U2l6ZSgqb3ZlcnJpZGRlblZpZXdM YXlvdXRXaWR0aCwgbV92aWV3cG9ydENvbmZpZ3VyYXRpb24ubGF5b3V0SGVpZ2h0KCkpKTsKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjNmFhNzBh NDU0NmNmMDc5ZjY0OTlmZGIwNDYyNTEwMTBjOTMzYWY5Li5kMDA4MzliNjcxYmRhYWE3OTNjMjNj NjQ3NmEwYTA0MTRkYTQ4NWM3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDYtMDkgIFdlbnNvbiBIc2llaCAg PHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gZmFzdC94c2wgdGVzdHMg YXJlIGZsYWt5IHdoZW4gcnVuIGFmdGVyIGNlcnRhaW4gdmlld3BvcnQgc2hyaW5rLXRvLWZpdCB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4 Njk5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDUwMTcxOD4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbG9naWMgdG8gcGxhdGZvcm1SZXNl dFByZWZlcmVuY2VzVG9Db25zaXN0ZW50VmFsdWVzLCB0byByZXNldCB0aGUgIlNob3VsZElnbm9y ZU1ldGFWaWV3cG9ydCIgcHJlZmVyZW5jZS4KKyAgICAgICAgV2hpbGUgdGhpcyBpcyBhbHJlYWR5 IGJlaW5nIGFkanVzdGVkIGluIHBsYXRmb3JtQ29uZmlndXJlVmlld0ZvclRlc3QgdXNpbmcgdGhl IGNvcnJlY3QsIFRlc3RPcHRpb25zLCB0aGlzIG1pZ2h0CisgICAgICAgIGhhcHBlbiB0b28gbGF0 ZSwgYWxsb3dpbmcgdGhlIHNocmluay10by1maXQtY29udGVudCBoZXVyaXN0aWMgdG8gdW5leHBl Y3RlZGx5IGtpY2sgaW4gb24gdGVzdHMgd2hlcmUgdGVzdGluZworICAgICAgICB2aWV3cG9ydCBw YXJhbWV0ZXJzIGFyZSB1c2VkLgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVz dENvbnRyb2xsZXJJT1MubW06CisgICAgICAgIChXVFI6OlRlc3RDb250cm9sbGVyOjpwbGF0Zm9y bVJlc2V0UHJlZmVyZW5jZXNUb0NvbnNpc3RlbnRWYWx1ZXMpOgorICAgICAgICAoV1RSOjpUZXN0 Q29udHJvbGxlcjo6cGxhdGZvcm1Db25maWd1cmVWaWV3Rm9yVGVzdCk6CisKIDIwMTktMDYtMDgg IFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g VGhlIGRlZmF1bHQgYXBwbGljYXRpb24gbmFtZSBmb3IgdXNlciBhZ2VudCB3aGVuIHJlcXVlc3Rp bmcgZGVza3RvcCBjb250ZW50IGlzIHN0aWxsICJNb2JpbGUvMTVFMTQ4IgpkaWZmIC0tZ2l0IGEv VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9pb3MvVGVzdENvbnRyb2xsZXJJT1MubW0gYi9Ub29scy9X ZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0Q29udHJvbGxlcklPUy5tbQppbmRleCA3ZTllMWU3YmI3 MWQ2N2UzMTcxY2I0ZjYxZjc0NTQxNjgyZjA0MTA2Li43MzcwNjMxM2FlODZjMzk3NWM0MjNkOTY2 N2I3ZTdmMzhlMmRlZTE4IDEwMDY0NAotLS0gYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9U ZXN0Q29udHJvbGxlcklPUy5tbQorKysgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2lvcy9UZXN0 Q29udHJvbGxlcklPUy5tbQpAQCAtMTM0LDYgKzEzNCw3IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6 OnBsYXRmb3JtUmVzZXRQcmVmZXJlbmNlc1RvQ29uc2lzdGVudFZhbHVlcygpCiAgICAgV0tQcmVm ZXJlbmNlc1JlZiBwcmVmZXJlbmNlcyA9IHBsYXRmb3JtUHJlZmVyZW5jZXMoKTsKICAgICBXS1By ZWZlcmVuY2VzU2V0VGV4dEF1dG9zaXppbmdFbmFibGVkKHByZWZlcmVuY2VzLCBmYWxzZSk7CiAg ICAgV0tQcmVmZXJlbmNlc1NldENvbnRlbnRDaGFuZ2VPYnNlcnZlckVuYWJsZWQocHJlZmVyZW5j ZXMsIGZhbHNlKTsKKyAgICBbKF9fYnJpZGdlIFdLUHJlZmVyZW5jZXMgKilwcmVmZXJlbmNlcyBf c2V0U2hvdWxkSWdub3JlTWV0YVZpZXdwb3J0Ok5PXTsKIH0KIAogdm9pZCBUZXN0Q29udHJvbGxl cjo6cGxhdGZvcm1SZXNldFN0YXRlVG9Db25zaXN0ZW50VmFsdWVzKGNvbnN0IFRlc3RPcHRpb25z JiBvcHRpb25zKQpAQCAtMTg5LDcgKzE5MCw4IEBAIHZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRm b3JtQ29uZmlndXJlVmlld0ZvclRlc3QoY29uc3QgVGVzdEludm9jYXRpb24mIHRlc3QpCiB7CiAg ICAgVGVzdFJ1bm5lcldLV2ViVmlldyAqd2ViVmlldyA9IG1haW5XZWJWaWV3KCktPnBsYXRmb3Jt VmlldygpOwogCi0gICAgd2ViVmlldy5jb25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl9zaG91bGRJ Z25vcmVNZXRhVmlld3BvcnQgPSB0ZXN0Lm9wdGlvbnMoKS5zaG91bGRJZ25vcmVNZXRhVmlld3Bv cnQ7CisgICAgaWYgKHRlc3Qub3B0aW9ucygpLnNob3VsZElnbm9yZU1ldGFWaWV3cG9ydCkKKyAg ICAgICAgd2ViVmlldy5jb25maWd1cmF0aW9uLnByZWZlcmVuY2VzLl9zaG91bGRJZ25vcmVNZXRh Vmlld3BvcnQgPSBZRVM7CiAKICAgICBpZiAoIXRlc3Qub3B0aW9ucygpLnVzZUZsZXhpYmxlVmll d3BvcnQpCiAgICAgICAgIHJldHVybjsK