198696 2019-06-08 18:39:40 -0700 Drag starting state can get stuck even though the drag has ended 2019-06-09 13:03:34 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 dino dino webkit-bug-importer wenson_hsieh oldest_to_newest 1543165 0 dino 2019-06-08 18:39:40 -0700 Drag starting state can get stuck even though the drag has ended 1543168 1 371693 dino 2019-06-08 18:41:35 -0700 Created attachment 371693 Patch 1543169 2 webkit-bug-importer 2019-06-08 18:42:30 -0700 <rdar://problem/51556045> 1543171 3 371693 wenson_hsieh 2019-06-08 18:44:39 -0700 Comment on attachment 371693 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371693&action=review > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:6746 > + RELEASE_LOG(DragAndDrop, "Drag session willAnimateLiftWithAnimator: %p (animation completion block fired)", session); Nit - this is redundant in the case where finalPosition == UIViewAnimatingPositionStart. Maybe add this logging state as an `else` clause of the `if (finalPosition == UIViewAnimatingPositionStart)` below? 1543209 4 dino 2019-06-09 13:03:34 -0700 Committed r246239: <https://trac.webkit.org/changeset/246239> 371693 2019-06-08 18:41:35 -0700 2019-06-08 18:44:39 -0700 Patch bug-198696-20190609114133.patch text/plain 4276 dino U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAyODQ4ZWU0ZDZkMTdkMmM0 YTBmMTE3ZWY2MWU1ZDk5MTcyOTEwNTIuLjNmNDZiMWQxMTM0NDQyOWM4ZmQ0ZWEwYzNlNDhhZTM5 MDU2MWJkYWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDYtMDggIERlYW4gSmFj a3NvbiAgPGRpbm9AYXBwbGUuY29tPgorCisgICAgICAgIERyYWcgc3RhcnRpbmcgc3RhdGUgY2Fu IGdldCBzdHVjayBldmVuIHRob3VnaCB0aGUgZHJhZyBoYXMgZW5kZWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODY5NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIGlPUyAxMywgd2UncmUgc2VlaW5n IGNhc2VzIG9mIHRoZSBEcmFnU2Vzc2lvbiBub3QKKyAgICAgICAgY29ycmVjdGx5IGVuZGluZywg YW5kIHRodXMgbGVhdmluZyBtX2lzU3RhcnRpbmdEcmFnIGluCisgICAgICAgIGFuIGluY29ycmVj dCBzdGF0ZS4gVGVtcG9yYXJpbHkgZm9yY2UgdGhpcyB0byBiZSByZXNldAorICAgICAgICBpbiA6 OmRyYWdFbmRlZCB3aGlsZSBpbnZlc3RpZ2F0aW5nCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9z L1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbTogQWRkIHNvbWUgbW9yZSByZWxlYXNlIGxvZ2dp bmcKKyAgICAgICAgd2hpbGUgaGVyZS4KKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBkcmFnSW50 ZXJhY3Rpb246d2lsbEFuaW1hdGVMaWZ0V2l0aEFuaW1hdG9yOnNlc3Npb246XSk6CisgICAgICAg ICgtW1dLQ29udGVudFZpZXcgZHJhZ0ludGVyYWN0aW9uOml0ZW06d2lsbEFuaW1hdGVDYW5jZWxX aXRoQW5pbWF0b3I6XSk6CisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpkcmFnRW5kZWQpOgorCiAyMDE5LTA2LTA3ICBB bnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChy MjQ1MDA2KTogU2V0dGluZyBzY3JvbGx2aWV3LnNjcm9sbEVuYWJsZWQgY2xvYmJlcnMgYW55IHNj cm9sbEVuYWJsZWQgc2V0IGJ5IGEgY2xpZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJ UHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQppbmRleCBiM2E0OWVlYWM3 ZjlmM2RjMTIwOGVmYjNkMDFmNzk0ZTg5ZDE0MWM4Li43YjY2NTQ1OTA5ZmY4ODgyMDA1NDM5MmE0 YTdkNmU5YTBkZWUxMGZjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTY3MzAsNiArNjczMCw3IEBAIHN0 YXRpYyBXZWJLaXQ6OkRvY3VtZW50RWRpdGluZ0NvbnRleHRSZXF1ZXN0IHRvV2ViUmVxdWVzdChV SVdLRG9jdW1lbnRSZXF1ZXN0ICpyCiAKIC0gKHZvaWQpZHJhZ0ludGVyYWN0aW9uOihVSURyYWdJ bnRlcmFjdGlvbiAqKWludGVyYWN0aW9uIHdpbGxBbmltYXRlTGlmdFdpdGhBbmltYXRvcjooaWQg PFVJRHJhZ0FuaW1hdGluZz4pYW5pbWF0b3Igc2Vzc2lvbjooaWQgPFVJRHJhZ1Nlc3Npb24+KXNl c3Npb24KIHsKKyAgICBSRUxFQVNFX0xPRyhEcmFnQW5kRHJvcCwgIkRyYWcgc2Vzc2lvbjogJXAg d2lsbEFuaW1hdGVMaWZ0V2l0aEFuaW1hdG9yOiAlcCIsIHNlc3Npb24pOwogICAgIGlmICghX3No b3VsZFJlc3RvcmVDYWxsb3V0QmFyQWZ0ZXJEcm9wICYmIF9kcmFnRHJvcEludGVyYWN0aW9uU3Rh dGUuYW55QWN0aXZlRHJhZ1NvdXJjZUlzKFdlYkNvcmU6OkRyYWdTb3VyY2VBY3Rpb25TZWxlY3Rp b24pKSB7CiAgICAgICAgIC8vIEZJWE1FOiBUaGlzIFNQSSBzaG91bGQgYmUgcmVuYW1lZCBpbiBV SUtpdCB0byByZWZsZWN0IGEgbW9yZSBnZW5lcmFsIHB1cnBvc2Ugb2YgaGlkaW5nIGludGVyYWN0 aW9uIGFzc2lzdGFudCBjb250cm9scy4KICAgICAgICAgW190ZXh0U2VsZWN0aW9uQXNzaXN0YW50 IHdpbGxTdGFydFNjcm9sbGluZ092ZXJmbG93XTsKQEAgLTY3NDIsNiArNjc0Myw3IEBAIHN0YXRp YyBXZWJLaXQ6OkRvY3VtZW50RWRpdGluZ0NvbnRleHRSZXF1ZXN0IHRvV2ViUmVxdWVzdChVSVdL RG9jdW1lbnRSZXF1ZXN0ICpyCiAjaWYgUkVMRUFTRV9MT0dfRElTQUJMRUQKICAgICAgICAgVU5V U0VEX1BBUkFNKHNlc3Npb24pOwogI2VuZGlmCisgICAgICAgIFJFTEVBU0VfTE9HKERyYWdBbmRE cm9wLCAiRHJhZyBzZXNzaW9uIHdpbGxBbmltYXRlTGlmdFdpdGhBbmltYXRvcjogJXAgKGFuaW1h dGlvbiBjb21wbGV0aW9uIGJsb2NrIGZpcmVkKSIsIHNlc3Npb24pOwogICAgICAgICBpZiAoZmlu YWxQb3NpdGlvbiA9PSBVSVZpZXdBbmltYXRpbmdQb3NpdGlvblN0YXJ0KSB7CiAgICAgICAgICAg ICBSRUxFQVNFX0xPRyhEcmFnQW5kRHJvcCwgIkRyYWcgc2Vzc2lvbiBlbmRlZCBhdCBzdGFydDog JXAiLCBzZXNzaW9uKTsKICAgICAgICAgICAgIC8vIFRoZSBsaWZ0IHdhcyBjYW5jZWxlZCwgc28g LWRyb3BJbnRlcmFjdGlvbjpzZXNzaW9uRGlkRW5kOiB3aWxsIG5ldmVyIGJlIGludm9rZWQuIFRo aXMgaXMgdGhlIGxhc3QgY2hhbmNlIHRvIGNsZWFuIHVwLgpAQCAtNjc5OSw3ICs2ODAxLDkgQEAg c3RhdGljIFdlYktpdDo6RG9jdW1lbnRFZGl0aW5nQ29udGV4dFJlcXVlc3QgdG9XZWJSZXF1ZXN0 KFVJV0tEb2N1bWVudFJlcXVlc3QgKnIKIAogLSAodm9pZClkcmFnSW50ZXJhY3Rpb246KFVJRHJh Z0ludGVyYWN0aW9uICopaW50ZXJhY3Rpb24gaXRlbTooVUlEcmFnSXRlbSAqKWl0ZW0gd2lsbEFu aW1hdGVDYW5jZWxXaXRoQW5pbWF0b3I6KGlkIDxVSURyYWdBbmltYXRpbmc+KWFuaW1hdG9yCiB7 CisgICAgUkVMRUFTRV9MT0coRHJhZ0FuZERyb3AsICJEcmFnIGludGVyYWN0aW9uIHdpbGxBbmlt YXRlQ2FuY2VsV2l0aEFuaW1hdG9yIik7CiAgICAgW2FuaW1hdG9yIGFkZENvbXBsZXRpb246W3By b3RlY3RlZFNlbGYgPSByZXRhaW5QdHIoc2VsZiksIHBhZ2UgPSBfcGFnZV0gKFVJVmlld0FuaW1h dGluZ1Bvc2l0aW9uIGZpbmFsUG9zaXRpb24pIHsKKyAgICAgICAgUkVMRUFTRV9MT0coRHJhZ0Fu ZERyb3AsICJEcmFnIGludGVyYWN0aW9uIHdpbGxBbmltYXRlQ2FuY2VsV2l0aEFuaW1hdG9yIChh bmltYXRpb24gY29tcGxldGlvbiBibG9jayBmaXJlZCkiKTsKICAgICAgICAgcGFnZS0+ZHJhZ0Nh bmNlbGxlZCgpOwogICAgICAgICBpZiAoYXV0byBjb21wbGV0aW9uID0gcHJvdGVjdGVkU2VsZi0+ X2RyYWdEcm9wSW50ZXJhY3Rpb25TdGF0ZS50YWtlRHJhZ0NhbmNlbFNldERvd25CbG9jaygpKSB7 CiAgICAgICAgICAgICBwYWdlLT5jYWxsQWZ0ZXJOZXh0UHJlc2VudGF0aW9uVXBkYXRlKFtjb21w bGV0aW9uXSAoV2ViS2l0OjpDYWxsYmFja0Jhc2U6OkVycm9yKSB7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDJlZDdlOTMxODIyZmNiNmMwNGYy YzhlMmVkYzk5NTYzZjhhZTU1ZjguLjk1NzE2Y2ZhNTMxMmE3ZDRlMDVlZDBjNDI2NTQxMTI5NDJm ODk2NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBh Z2UuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3Bw CkBAIC0zOTExLDYgKzM5MTEsOCBAQCB2b2lkIFdlYlBhZ2U6OmRyYWdFbmRlZChXZWJDb3JlOjpJ bnRQb2ludCBjbGllbnRQb3NpdGlvbiwgV2ViQ29yZTo6SW50UG9pbnQgZ2xvYgogICAgIG1fcGFn ZS0+bWFpbkZyYW1lKCkuZXZlbnRIYW5kbGVyKCkuZHJhZ1NvdXJjZUVuZGVkQXQoZXZlbnQsIChE cmFnT3BlcmF0aW9uKW9wZXJhdGlvbik7CiAKICAgICBzZW5kKE1lc3NhZ2VzOjpXZWJQYWdlUHJv eHk6OkRpZEVuZERyYWdnaW5nKCkpOworCisgICAgbV9pc1N0YXJ0aW5nRHJhZyA9IGZhbHNlOwog fQogCiB2b2lkIFdlYlBhZ2U6OndpbGxQZXJmb3JtTG9hZERyYWdEZXN0aW5hdGlvbkFjdGlvbigp Cg==