198692 2019-06-08 14:01:49 -0700 [iOS] ResourceLoadStatistics state is not properly relayed to the NetworkProcess 2019-06-09 17:25:27 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198694 InRadar P2 Normal --- 198694 1 bfulgham bfulgham achristensen beidson bfulgham cdumez commit-queue jiewen_tan mjs pvollan webkit-bug-importer wilander youennf oldest_to_newest 1543110 0 bfulgham 2019-06-08 14:01:49 -0700 When I moved the ResourceLoadStatistics logic to the NetworkProcess, I did not realize that the iOS process startup does not have a WebsiteDataStore attached until much later in the launch cycle. Because of this, we do not pass the ITP state to the NetworkProcess at launch (as part of its configuration parameters), and when we attempt to message the state to the NetworkProcess during startup we do so at a moment when we have not associated the WebProcessPool with the WebsiteDataStore object that knows about ITP status. Furthermore, I failed to notice that the method to activate ITP only messages the WebContent processes, not the NetworkProcess. This had not been needed before I moved the logic to the NetworkProcess, and was an oversight. This patch updates WebProcessPool::setResourceLoadStatisticsEnabled so that the process pool tells the NetworkProcess when the ITP state changes. 1543111 1 bfulgham 2019-06-08 14:03:37 -0700 <rdar://problem/51538088> 1543112 2 371666 bfulgham 2019-06-08 14:04:43 -0700 Created attachment 371666 Patch 1543113 3 371666 wilander 2019-06-08 14:15:42 -0700 Comment on attachment 371666 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371666&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:1491 > + sendToNetworkingProcess(Messages::WebProcess::SetResourceLoadStatisticsEnabled(enabled)); This message type should be for the NetworkProcess, not the WebProcess. 1543116 4 371666 mjs 2019-06-08 14:25:00 -0700 Comment on attachment 371666 Patch This really needs a test, since it is a fix for a real regression and one that wen't long unnoticed. r- for lack of test case. 1543142 5 371681 bfulgham 2019-06-08 16:50:00 -0700 Created attachment 371681 Patch 1543143 6 371681 bfulgham 2019-06-08 16:51:33 -0700 Comment on attachment 371681 Patch Updated to use proper message heading. I'll tackle the test separately since it will be a larger patch. 1543144 7 371682 bfulgham 2019-06-08 17:01:23 -0700 Created attachment 371682 Patch 1543145 8 371682 bfulgham 2019-06-08 17:01:46 -0700 Comment on attachment 371682 Patch Updated to address WPE build failure. 1543147 9 371682 wilander 2019-06-08 17:19:13 -0700 Comment on attachment 371682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371682&action=review > Source/WebKit/UIProcess/WebProcessPool.cpp:1492 > + sendToNetworkingProcess(Messages::NetworkProcess::SetResourceLoadStatisticsEnabled(enabled)); I’m looking at this on my phone so I don’t have the larger picture. Do we need to ensure that there is a network process here? I know we had some cases where that was a requirement. 1543155 10 371682 bfulgham 2019-06-08 17:44:15 -0700 Comment on attachment 371682 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371682&action=review >> Source/WebKit/UIProcess/WebProcessPool.cpp:1492 >> + sendToNetworkingProcess(Messages::NetworkProcess::SetResourceLoadStatisticsEnabled(enabled)); > > I’m looking at this on my phone so I don’t have the larger picture. Do we need to ensure that there is a network process here? I know we had some cases where that was a requirement. That's probably a good idea. It looks like we do something like that when dealing with Ephemeral sessions, so this probably has the same requirement. 1543157 11 bfulgham 2019-06-08 17:47:14 -0700 (In reply to Maciej Stachowiak from comment #4) > Comment on attachment 371666 [details] > Patch > > This really needs a test, since it is a fix for a real regression and one > that wen't long unnoticed. r- for lack of test case. I started doing this, but the patch grew much larger. I would rather handle the test case as a distinct patch so that it's clear what's going on. See Bug 198694 for that work. 1543163 12 371691 bfulgham 2019-06-08 18:20:44 -0700 Created attachment 371691 Patch 1543178 13 bfulgham 2019-06-08 19:07:27 -0700 (In reply to Brent Fulgham from comment #10) > Comment on attachment 371682 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371682&action=review > > >> Source/WebKit/UIProcess/WebProcessPool.cpp:1492 > >> + sendToNetworkingProcess(Messages::NetworkProcess::SetResourceLoadStatisticsEnabled(enabled)); > > > > I’m looking at this on my phone so I don’t have the larger picture. Do we need to ensure that there is a network process here? I know we had some cases where that was a requirement. > > That's probably a good idea. It looks like we do something like that when > dealing with Ephemeral sessions, so this probably has the same requirement. Actually it's not a good idea because it breaks the API tests involving a lack of a process pool (TestWebKitAPI.WebKit.WKHTTPCookieStoreWithoutProcessPoolWithPrewarming and the without prewarming case). So, we don't want to force a network process launch if it doesn't already exist -- we just want to make sure we do send it the message. 1543180 14 371697 bfulgham 2019-06-08 19:10:16 -0700 Created attachment 371697 Patch 1543228 15 371697 mjs 2019-06-09 16:30:20 -0700 Comment on attachment 371697 Patch Looks good. 1543231 16 371697 commit-queue 2019-06-09 17:25:25 -0700 Comment on attachment 371697 Patch Clearing flags on attachment: 371697 Committed r246248: <https://trac.webkit.org/changeset/246248> 1543232 17 commit-queue 2019-06-09 17:25:27 -0700 All reviewed patches have been landed. Closing bug. 371666 2019-06-08 14:04:43 -0700 2019-06-08 16:49:58 -0700 Patch bug-198692-20190608140442.patch text/plain 1523 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmNDk1M2E0ZjI0OTg4MjA2 NWIzMDlhNTA5ZTY3NjVkNzRhMjZkMzQuLmVhNjJhMTcwZGMyZDY4ODMwNDBhM2VhNGQyY2VkOTNm Zjc1ZDY1MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMDggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVzb3VyY2VMb2Fk U3RhdGlzdGljcyBzdGF0ZSBpcyBub3QgcHJvcGVybHkgcmVsYXllZCB0byB0aGUgTmV0d29ya1By b2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODY5MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE1MzgwODg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6c2V0UmVzb3VyY2VMb2Fk U3RhdGlzdGljc0VuYWJsZWQpOiBNZXNzYWdlIHRoZSBOZXR3b3JrUHJvY2VzcworICAgICAgICBv biBzdGF0ZSBjaGFuZ2UuCisKIDIwMTktMDYtMDcgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVXBkYXRlIHNhbmRib3hlcyB0byBhZGRyZXNzIGlv a2l0LWdldC1wcm9wZXJ0eSBlcnJvcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQb29sLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcAppbmRleCAzNGJmYzAzOGI5NTdjMTc1MWE1YmQwMThmNjU0YTQ3MjA0M2E5MDQ0 Li43MWE5ZmFlNDVjZDE0MjBiNTg4MTA2NTdmMmY3ODAwMTFiNWMzNGNlIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCkBAIC0xNDg4LDYgKzE0ODgsNyBAQCB2 b2lkIFdlYlByb2Nlc3NQb29sOjpzZXRTaG91bGRVc2VGb250U21vb3RoaW5nKGJvb2wgdXNlRm9u dFNtb290aGluZykKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNldFJlc291cmNlTG9hZFN0YXRpc3Rp Y3NFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKICAgICBzZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2Fn ZXM6OldlYlByb2Nlc3M6OlNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGVuYWJsZWQp KTsKKyAgICBzZW5kVG9OZXR3b3JraW5nUHJvY2VzcyhNZXNzYWdlczo6V2ViUHJvY2Vzczo6U2V0 UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJsZWQoZW5hYmxlZCkpOwogfQogCiB2b2lkIFdlYlBy b2Nlc3NQb29sOjpjbGVhclJlc291cmNlTG9hZFN0YXRpc3RpY3MoKQo= 371681 2019-06-08 16:50:00 -0700 2019-06-08 17:01:21 -0700 Patch bug-198692-20190608164959.patch text/plain 1527 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmNDk1M2E0ZjI0OTg4MjA2 NWIzMDlhNTA5ZTY3NjVkNzRhMjZkMzQuLmVhNjJhMTcwZGMyZDY4ODMwNDBhM2VhNGQyY2VkOTNm Zjc1ZDY1MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMDggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVzb3VyY2VMb2Fk U3RhdGlzdGljcyBzdGF0ZSBpcyBub3QgcHJvcGVybHkgcmVsYXllZCB0byB0aGUgTmV0d29ya1By b2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODY5MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE1MzgwODg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6c2V0UmVzb3VyY2VMb2Fk U3RhdGlzdGljc0VuYWJsZWQpOiBNZXNzYWdlIHRoZSBOZXR3b3JrUHJvY2VzcworICAgICAgICBv biBzdGF0ZSBjaGFuZ2UuCisKIDIwMTktMDYtMDcgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVXBkYXRlIHNhbmRib3hlcyB0byBhZGRyZXNzIGlv a2l0LWdldC1wcm9wZXJ0eSBlcnJvcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQb29sLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcAppbmRleCAzNGJmYzAzOGI5NTdjMTc1MWE1YmQwMThmNjU0YTQ3MjA0M2E5MDQ0 Li4wOGEzM2FjOTJmZDRiZDU4NTVlMDVjMGE2ODYzNzgyZjg5Yzg5YzZmIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCkBAIC0xNDg4LDYgKzE0ODgsNyBAQCB2 b2lkIFdlYlByb2Nlc3NQb29sOjpzZXRTaG91bGRVc2VGb250U21vb3RoaW5nKGJvb2wgdXNlRm9u dFNtb290aGluZykKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNldFJlc291cmNlTG9hZFN0YXRpc3Rp Y3NFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKICAgICBzZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2Fn ZXM6OldlYlByb2Nlc3M6OlNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGVuYWJsZWQp KTsKKyAgICBzZW5kVG9OZXR3b3JraW5nUHJvY2VzcyhNZXNzYWdlczo6TmV0d29ya1Byb2Nlc3M6 OlNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGVuYWJsZWQpKTsKIH0KIAogdm9pZCBX ZWJQcm9jZXNzUG9vbDo6Y2xlYXJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzKCkK 371682 2019-06-08 17:01:23 -0700 2019-06-08 18:20:42 -0700 Patch bug-198692-20190608170122.patch text/plain 1573 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFmNDk1M2E0ZjI0OTg4MjA2 NWIzMDlhNTA5ZTY3NjVkNzRhMjZkMzQuLmVhNjJhMTcwZGMyZDY4ODMwNDBhM2VhNGQyY2VkOTNm Zjc1ZDY1MzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMDggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVzb3VyY2VMb2Fk U3RhdGlzdGljcyBzdGF0ZSBpcyBub3QgcHJvcGVybHkgcmVsYXllZCB0byB0aGUgTmV0d29ya1By b2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODY5MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE1MzgwODg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6c2V0UmVzb3VyY2VMb2Fk U3RhdGlzdGljc0VuYWJsZWQpOiBNZXNzYWdlIHRoZSBOZXR3b3JrUHJvY2VzcworICAgICAgICBv biBzdGF0ZSBjaGFuZ2UuCisKIDIwMTktMDYtMDcgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUBh cHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVXBkYXRlIHNhbmRib3hlcyB0byBhZGRyZXNzIGlv a2l0LWdldC1wcm9wZXJ0eSBlcnJvcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL1dlYlByb2Nlc3NQb29sLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nl c3NQb29sLmNwcAppbmRleCAzNGJmYzAzOGI5NTdjMTc1MWE1YmQwMThmNjU0YTQ3MjA0M2E5MDQ0 Li42MDRmZjRmYTMzZDQyMDk1NGQ5ZTQwYzJhMDUyNTE0ZTZlZmNlNTBiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCkBAIC0xNDg4LDYgKzE0ODgsOSBAQCB2 b2lkIFdlYlByb2Nlc3NQb29sOjpzZXRTaG91bGRVc2VGb250U21vb3RoaW5nKGJvb2wgdXNlRm9u dFNtb290aGluZykKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNldFJlc291cmNlTG9hZFN0YXRpc3Rp Y3NFbmFibGVkKGJvb2wgZW5hYmxlZCkKIHsKICAgICBzZW5kVG9BbGxQcm9jZXNzZXMoTWVzc2Fn ZXM6OldlYlByb2Nlc3M6OlNldFJlc291cmNlTG9hZFN0YXRpc3RpY3NFbmFibGVkKGVuYWJsZWQp KTsKKyNpZiBFTkFCTEUoUkVTT1VSQ0VfTE9BRF9TVEFUSVNUSUNTKQorICAgIHNlbmRUb05ldHdv cmtpbmdQcm9jZXNzKE1lc3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6U2V0UmVzb3VyY2VMb2FkU3Rh dGlzdGljc0VuYWJsZWQoZW5hYmxlZCkpOworI2VuZGlmCiB9CiAKIHZvaWQgV2ViUHJvY2Vzc1Bv b2w6OmNsZWFyUmVzb3VyY2VMb2FkU3RhdGlzdGljcygpCg== 371691 2019-06-08 18:20:44 -0700 2019-06-08 19:10:14 -0700 Patch bug-198692-20190608182043.patch text/plain 1615 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1NGNmYmU0OGMwNjQzODQz ZGIxNjdjNGM1MDY5MWFiMGUwNmEwZDEuLmQzNTNlOTgwMzMyNzZkNTE3OTM5ZDNhODVlMWY5YmFh YTM0MzdmZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMDggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVzb3VyY2VMb2Fk U3RhdGlzdGljcyBzdGF0ZSBpcyBub3QgcHJvcGVybHkgcmVsYXllZCB0byB0aGUgTmV0d29ya1By b2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODY5MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE1MzgwODg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6c2V0UmVzb3VyY2VMb2Fk U3RhdGlzdGljc0VuYWJsZWQpOiBNZXNzYWdlIHRoZSBOZXR3b3JrUHJvY2VzcworICAgICAgICBv biBzdGF0ZSBjaGFuZ2UuCisKIDIwMTktMDYtMDggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFtBcHBsZSBQYXldIElmIHdlIGhhdmUgYSBib3VuZCBpbnRlcmZhY2Ug aWRlbnRpZmllciwgc2V0IGl0IG9uIG5ldyBQS1BheW1lbnRSZXF1ZXN0cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IDM0YmZjMDM4Yjk1N2MxNzUxYTVi ZDAxOGY2NTRhNDcyMDQzYTkwNDQuLmI3MzU0NGFhZjMwZDM2YTAwYjc5YjkxMTQ1MmUyZWIyMzQ2 MjNlOGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29s LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKQEAg LTE0ODgsNiArMTQ4OCw5IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNldFNob3VsZFVzZUZvbnRT bW9vdGhpbmcoYm9vbCB1c2VGb250U21vb3RoaW5nKQogdm9pZCBXZWJQcm9jZXNzUG9vbDo6c2V0 UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJsZWQoYm9vbCBlbmFibGVkKQogewogICAgIHNlbmRU b0FsbFByb2Nlc3NlcyhNZXNzYWdlczo6V2ViUHJvY2Vzczo6U2V0UmVzb3VyY2VMb2FkU3RhdGlz dGljc0VuYWJsZWQoZW5hYmxlZCkpOworI2lmIEVOQUJMRShSRVNPVVJDRV9MT0FEX1NUQVRJU1RJ Q1MpCisgICAgc2VuZFRvTmV0d29ya2luZ1Byb2Nlc3NSZWxhdW5jaGluZ0lmTmVjZXNzYXJ5KE1l c3NhZ2VzOjpOZXR3b3JrUHJvY2Vzczo6U2V0UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJsZWQo ZW5hYmxlZCkpOworI2VuZGlmCiB9CiAKIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OmNsZWFyUmVzb3Vy Y2VMb2FkU3RhdGlzdGljcygpCg== 371697 2019-06-08 19:10:16 -0700 2019-06-09 17:25:25 -0700 Patch bug-198692-20190608191015.patch text/plain 1593 bfulgham U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDI1NGNmYmU0OGMwNjQzODQz ZGIxNjdjNGM1MDY5MWFiMGUwNmEwZDEuLmQzNTNlOTgwMzMyNzZkNTE3OTM5ZDNhODVlMWY5YmFh YTM0MzdmZDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMDggIEJyZW50IEZ1 bGdoYW0gIDxiZnVsZ2hhbUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUmVzb3VyY2VMb2Fk U3RhdGlzdGljcyBzdGF0ZSBpcyBub3QgcHJvcGVybHkgcmVsYXllZCB0byB0aGUgTmV0d29ya1By b2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODY5MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNTE1MzgwODg+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvV2ViUHJvY2Vzc1Bv b2wuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzUG9vbDo6c2V0UmVzb3VyY2VMb2Fk U3RhdGlzdGljc0VuYWJsZWQpOiBNZXNzYWdlIHRoZSBOZXR3b3JrUHJvY2VzcworICAgICAgICBv biBzdGF0ZSBjaGFuZ2UuCisKIDIwMTktMDYtMDggIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUu Y29tPgogCiAgICAgICAgIFtBcHBsZSBQYXldIElmIHdlIGhhdmUgYSBib3VuZCBpbnRlcmZhY2Ug aWRlbnRpZmllciwgc2V0IGl0IG9uIG5ldyBQS1BheW1lbnRSZXF1ZXN0cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwIGIvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvV2ViUHJvY2Vzc1Bvb2wuY3BwCmluZGV4IDM0YmZjMDM4Yjk1N2MxNzUxYTVi ZDAxOGY2NTRhNDcyMDQzYTkwNDQuLjYwNGZmNGZhMzNkNDIwOTU0ZDllNDBjMmEwNTI1MTRlNmVm Y2U1MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlByb2Nlc3NQb29s LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKQEAg LTE0ODgsNiArMTQ4OCw5IEBAIHZvaWQgV2ViUHJvY2Vzc1Bvb2w6OnNldFNob3VsZFVzZUZvbnRT bW9vdGhpbmcoYm9vbCB1c2VGb250U21vb3RoaW5nKQogdm9pZCBXZWJQcm9jZXNzUG9vbDo6c2V0 UmVzb3VyY2VMb2FkU3RhdGlzdGljc0VuYWJsZWQoYm9vbCBlbmFibGVkKQogewogICAgIHNlbmRU b0FsbFByb2Nlc3NlcyhNZXNzYWdlczo6V2ViUHJvY2Vzczo6U2V0UmVzb3VyY2VMb2FkU3RhdGlz dGljc0VuYWJsZWQoZW5hYmxlZCkpOworI2lmIEVOQUJMRShSRVNPVVJDRV9MT0FEX1NUQVRJU1RJ Q1MpCisgICAgc2VuZFRvTmV0d29ya2luZ1Byb2Nlc3MoTWVzc2FnZXM6Ok5ldHdvcmtQcm9jZXNz OjpTZXRSZXNvdXJjZUxvYWRTdGF0aXN0aWNzRW5hYmxlZChlbmFibGVkKSk7CisjZW5kaWYKIH0K IAogdm9pZCBXZWJQcm9jZXNzUG9vbDo6Y2xlYXJSZXNvdXJjZUxvYWRTdGF0aXN0aWNzKCkK