198678 2019-06-07 14:10:08 -0700 Add a quirk for washingtonpost.com and nytimes.com 2019-06-11 09:27:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sihui_liu sihui_liu commit-queue ggaren webkit-bug-importer oldest_to_newest 1542942 0 sihui_liu 2019-06-07 14:10:08 -0700 Similar to https://bugs.webkit.org/show_bug.cgi?id=195155. Enable WebSQL for these sites for now. 1542943 1 371609 sihui_liu 2019-06-07 14:11:40 -0700 Created attachment 371609 Patch 1543464 2 371609 ggaren 2019-06-10 14:21:50 -0700 Comment on attachment 371609 Patch r=me Given that this is more than just one site now, I think we need a follow-up bug to reduce the scope and impact of this quirk. Specifically, I'd recommend the following behavior: If we're on a site where this quirk is enabled, make available a global function named openDatabase. If the function is called with four arguments, and all arguments are null, then return an empty object. Otherwise, throw an exception that says "WebSQL is not enabled". 1543725 3 371609 commit-queue 2019-06-11 09:26:35 -0700 Comment on attachment 371609 Patch Clearing flags on attachment: 371609 Committed r246319: <https://trac.webkit.org/changeset/246319> 1543726 4 commit-queue 2019-06-11 09:26:36 -0700 All reviewed patches have been landed. Closing bug. 1543727 5 webkit-bug-importer 2019-06-11 09:27:17 -0700 <rdar://problem/51626476> 371609 2019-06-07 14:11:40 -0700 2019-06-11 09:26:35 -0700 Patch bug-198678-20190607141139.patch text/plain 1495 sihui_liu U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzMzZDRhZGUyZTNiMTAx ZWVkYWExNGFjYjI2NmRiMDM3YWU2NzFhOS4uMmIzNzg3NmU3YTQxOGI0YTJiZGM5YmJhNGU5ZDNj ODNmNWNlODY0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTA3ICBTaWh1 aSBMaXUgIDxzaWh1aV9saXVAYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBhIHF1aXJrIGZvciB3 YXNoaW5ndG9ucG9zdC5jb20gYW5kIG55dGltZXMuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg2NzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb3ZlcmVkIGJ5IG1hbnVhbCB0ZXN0LgorCisgICAg ICAgICogcGFnZS9RdWlya3MuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UXVpcmtzOjpoYXNXZWJT UUxTdXBwb3J0UXVpcmsgY29uc3QpOgorCiAyMDE5LTA2LTA3ICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBIE1lZGlhU3RyZWFtVHJhY2sgY2Fubm90IG1vZGlm eSB3aGV0aGVyIGJlaW5nIGEgY2FwdHVyZSB0cmFjayBvciBub3QKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNw cAppbmRleCA2NTNhZmJiNjFlZjJkMjVmMDQyMzBmMzdiMDNiNzc1NmU1NmZlMGY4Li4yMmI5Nzdj ZGQwZDM3Mzk1ZTM2YWE2MWU0YTgzNDc4MmYxZjgxMzJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL1F1aXJrcy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3Bw CkBAIC0xODIsNyArMTgyLDExIEBAIGJvb2wgUXVpcmtzOjpoYXNXZWJTUUxTdXBwb3J0UXVpcmso KSBjb25zdAogICAgIG1faGFzV2ViU1FMU3VwcG9ydFF1aXJrID0gZG9tYWluID09ICJib3N0b25n bG9iZS5jb20iCiAgICAgICAgIHx8IGRvbWFpbi5lbmRzV2l0aCgiLmJvc3Rvbmdsb2JlLmNvbSIp CiAgICAgICAgIHx8IGRvbWFpbiA9PSAibGF0aW1lcy5jb20iCi0gICAgICAgIHx8IGRvbWFpbi5l bmRzV2l0aCgiLmxhdGltZXMuY29tIik7CisgICAgICAgIHx8IGRvbWFpbi5lbmRzV2l0aCgiLmxh dGltZXMuY29tIikKKyAgICAgICAgfHwgZG9tYWluID09ICJ3YXNoaW5ndG9ucG9zdC5jb20iCisg ICAgICAgIHx8IGRvbWFpbi5lbmRzV2l0aCgiLndhc2hpbmd0b25wb3N0LmNvbSIpCisgICAgICAg IHx8IGRvbWFpbiA9PSAibnl0aW1lcy5jb20iCisgICAgICAgIHx8IGRvbWFpbi5lbmRzV2l0aCgi Lm55dGltZXMuY29tIik7CiAgICAgCiAgICAgcmV0dXJuIG1faGFzV2ViU1FMU3VwcG9ydFF1aXJr LnZhbHVlKCk7CiB9Cg==