198675 2019-06-07 13:28:43 -0700 Open up xcfilelist processing to more platforms 2019-06-11 12:40:32 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin achristensen commit-queue ews-watchlist glenn jbedard webkit-bug-importer oldest_to_newest 1542920 0 krollin 2019-06-07 13:28:43 -0700 Now that it's been tested, add AppleTV{OS,Simulator} to the set of platforms on which to perform xcfilelist generation/updating. 1542921 1 webkit-bug-importer 2019-06-07 13:28:58 -0700 <rdar://problem/51533238> 1542923 2 371605 krollin 2019-06-07 13:30:14 -0700 Created attachment 371605 Patch 1542936 3 371605 jbedard 2019-06-07 13:56:32 -0700 Comment on attachment 371605 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371605&action=review > Tools/ChangeLog:3 > + Open up xcfilelist processing to more platforms Is this a multi-part change? Or is tvOS the end of it? 1542938 4 krollin 2019-06-07 14:04:47 -0700 I'm not sure what you're getting at. There will be a similar change in another, internal repository. And we'll be adding support for any new platforms that Apple creates in the future. If you're asking about iPadOS, there's no need for any changes along those lines. 1543486 5 krollin 2019-06-10 15:07:45 -0700 Jonathan, any concerns with this patch? 1543731 6 krollin 2019-06-11 09:44:58 -0700 Jonathan, could you please look at this? 1543772 7 jbedard 2019-06-11 11:16:23 -0700 (In reply to Keith Rollin from comment #6) > Jonathan, could you please look at this? No, looks good. Sorry for the delay, had slipped my task queue. 1543793 8 371605 commit-queue 2019-06-11 12:40:30 -0700 Comment on attachment 371605 Patch Clearing flags on attachment: 371605 Committed r246329: <https://trac.webkit.org/changeset/246329> 1543794 9 commit-queue 2019-06-11 12:40:32 -0700 All reviewed patches have been landed. Closing bug. 371605 2019-06-07 13:30:14 -0700 2019-06-11 12:40:30 -0700 Patch bug-198675-20190607133013.patch text/plain 2640 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjEwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZTc3OTZlMTk3ZTBiMzUxYzI5NmY0Y2FjZDkwODZjNDMx MGNmMDk3YS4uNWQyMDQ4MmNhYWExOWY1MmU0NjI3Y2Y1MTM3ODE0MTY3YzQxM2M4NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE5LTA2LTA3ICBLZWl0aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAg ICAgICBPcGVuIHVwIHhjZmlsZWxpc3QgcHJvY2Vzc2luZyB0byBtb3JlIHBsYXRmb3JtcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4Njc1CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81MTUzMzIzOD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBOb3cgdGhhdCBpdCdzIGJlZW4gdGVzdGVkLCBhZGQgQXBw bGVUVntPUyxTaW11bGF0b3J9IHRvIHRoZSBzZXQgb2YKKyAgICAgICAgcGxhdGZvcm1zIG9uIHdo aWNoIHRvIHBlcmZvcm0geGNmaWxlbGlzdCBnZW5lcmF0aW9uL3VwZGF0aW5nLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9nZW5lcmF0ZV94Y2ZpbGVsaXN0c19saWIvZ2VuZXJhdG9ycy5w eToKKyAgICAgICAgKEphdmFTY3JpcHRDb3JlR2VuZXJhdG9yKToKKyAgICAgICAgKFdlYkNvcmVH ZW5lcmF0b3IpOgorICAgICAgICAoV2ViS2l0R2VuZXJhdG9yKToKKwogMjAxOS0wNi0wNyAgV2Vu c29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBBdCBs ZWFzdCA2IEFQSSB0ZXN0cyBhcmUgZmFpbGluZyBkdWUgdG8gYW4gZXhjZXB0aW9uIHdoZW4gd3Jp dGluZyBOU0F0dHJpYnV0ZWRTdHJpbmcgdG8gdGhlIHBhc3RlYm9hcmQKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvZ2VuZXJhdGVfeGNmaWxlbGlzdHNfbGliL2dlbmVyYXRvcnMu cHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2dlbmVyYXRlX3hjZmlsZWxpc3RzX2xpYi9nZW5l cmF0b3JzLnB5CmluZGV4IGQ4NjJkNGYxZGE4NzM2NWRkMDBkZDU4ODJjYzhlMDg3ZDZlZGM1ZjYu LmNmNjc0NWJlN2M2NjZkZTBmOWM1Mzk2ZDYxMDE2Yzg1ZGIwODhjMTYgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvZ2VuZXJhdGVfeGNmaWxlbGlzdHNfbGliL2dlbmVyYXRvcnMu cHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9nZW5lcmF0ZV94Y2ZpbGVsaXN0c19saWIv Z2VuZXJhdG9ycy5weQpAQCAtNjQ4LDcgKzY0OCw3IEBAIGNsYXNzIEJhc2VHZW5lcmF0b3Iob2Jq ZWN0KToKIAogCiBjbGFzcyBKYXZhU2NyaXB0Q29yZUdlbmVyYXRvcihCYXNlR2VuZXJhdG9yKToK LSAgICBWQUxJRF9QTEFURk9STVMgPSAoIm1hY29zeCIsICJpb3NtYWMiLCAiaXBob25lb3MiLCAi aXBob25lc2ltdWxhdG9yIiwgIndhdGNob3MiLCAid2F0Y2hzaW11bGF0b3IiKQorICAgIFZBTElE X1BMQVRGT1JNUyA9ICgibWFjb3N4IiwgImlvc21hYyIsICJpcGhvbmVvcyIsICJpcGhvbmVzaW11 bGF0b3IiLCAid2F0Y2hvcyIsICJ3YXRjaHNpbXVsYXRvciIsICJhcHBsZXR2b3MiLCAiYXBwbGV0 dnNpbXVsYXRvciIpCiAgICAgVkFMSURfQ09ORklHVVJBVElPTlMgPSAoIkRlYnVnIiwgIlJlbGVh c2UiLCAiUHJvZHVjdGlvbiIsICJQcm9maWxpbmciKQogCiAgICAgQHV0aWwuTG9nRW50cnlFeGl0 CkBAIC02NjUsNyArNjY1LDcgQEAgY2xhc3MgSmF2YVNjcmlwdENvcmVHZW5lcmF0b3IoQmFzZUdl bmVyYXRvcik6CiAKIAogY2xhc3MgV2ViQ29yZUdlbmVyYXRvcihCYXNlR2VuZXJhdG9yKToKLSAg ICBWQUxJRF9QTEFURk9STVMgPSAoIm1hY29zeCIsICJpb3NtYWMiLCAiaXBob25lb3MiLCAiaXBo b25lc2ltdWxhdG9yIiwgIndhdGNob3MiLCAid2F0Y2hzaW11bGF0b3IiKQorICAgIFZBTElEX1BM QVRGT1JNUyA9ICgibWFjb3N4IiwgImlvc21hYyIsICJpcGhvbmVvcyIsICJpcGhvbmVzaW11bGF0 b3IiLCAid2F0Y2hvcyIsICJ3YXRjaHNpbXVsYXRvciIsICJhcHBsZXR2b3MiLCAiYXBwbGV0dnNp bXVsYXRvciIpCiAgICAgVkFMSURfQ09ORklHVVJBVElPTlMgPSAoIkRlYnVnIiwgIlJlbGVhc2Ui LCAiUHJvZHVjdGlvbiIpCiAKICAgICBAdXRpbC5Mb2dFbnRyeUV4aXQKQEAgLTY4Miw3ICs2ODIs NyBAQCBjbGFzcyBXZWJDb3JlR2VuZXJhdG9yKEJhc2VHZW5lcmF0b3IpOgogCiAKIGNsYXNzIFdl YktpdEdlbmVyYXRvcihCYXNlR2VuZXJhdG9yKToKLSAgICBWQUxJRF9QTEFURk9STVMgPSAoIm1h Y29zeCIsICJpb3NtYWMiLCAiaXBob25lb3MiLCAiaXBob25lc2ltdWxhdG9yIiwgIndhdGNob3Mi LCAid2F0Y2hzaW11bGF0b3IiKQorICAgIFZBTElEX1BMQVRGT1JNUyA9ICgibWFjb3N4IiwgImlv c21hYyIsICJpcGhvbmVvcyIsICJpcGhvbmVzaW11bGF0b3IiLCAid2F0Y2hvcyIsICJ3YXRjaHNp bXVsYXRvciIsICJhcHBsZXR2b3MiLCAiYXBwbGV0dnNpbXVsYXRvciIpCiAgICAgVkFMSURfQ09O RklHVVJBVElPTlMgPSAoIkRlYnVnIiwgIlJlbGVhc2UiLCAiUHJvZHVjdGlvbiIpCiAKICAgICBA dXRpbC5Mb2dFbnRyeUV4aXQK