198657 2019-06-07 05:35:59 -0700 Limit simulated mouse events on Google Maps to entering Street View 2024-09-06 01:24:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=199904 InRadar P2 Normal --- 279250 1 graouts graouts bfulgham dino ews-watchlist mcatanzaro myakura.web webkit-bug-importer oldest_to_newest 1542809 0 graouts 2019-06-07 05:35:59 -0700 Limit simulated mouse events on Google Maps to entering Street View 1542810 1 371584 graouts 2019-06-07 05:36:19 -0700 Created attachment 371584 Patch 1542811 2 graouts 2019-06-07 05:36:24 -0700 <rdar://problem/51345064> 1542812 3 ews-watchlist 2019-06-07 05:39:05 -0700 Attachment 371584 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:9: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1542813 4 371585 graouts 2019-06-07 05:41:02 -0700 Created attachment 371585 Patch 1542850 5 371585 bfulgham 2019-06-07 09:56:43 -0700 Comment on attachment 371585 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371585&action=review > Source/WebCore/page/Quirks.cpp:336 > +#endif In file included from /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified-sources/UnifiedSource321.cpp:4: ./page/Quirks.cpp:324:70: error: unused parameter 'target' [-Werror,-Wunused-parameter] bool Quirks::shouldDispatchSimulatedMouseEventsOnTarget(EventTarget* target) const ^ 1 error generated. You need an UNUSED_PARAM(target) here. 1542851 6 371585 bfulgham 2019-06-07 09:57:13 -0700 Comment on attachment 371585 Patch r=me with the fix I suggested. 1542852 7 graouts 2019-06-07 09:58:42 -0700 (In reply to Brent Fulgham from comment #5) > Comment on attachment 371585 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371585&action=review > > > Source/WebCore/page/Quirks.cpp:336 > > +#endif > > In file included from > /Volumes/Data/EWS/WebKit/WebKitBuild/Release/DerivedSources/WebCore/unified- > sources/UnifiedSource321.cpp:4: > ./page/Quirks.cpp:324:70: error: unused parameter 'target' > [-Werror,-Wunused-parameter] > bool Quirks::shouldDispatchSimulatedMouseEventsOnTarget(EventTarget* target) > const > ^ > 1 error generated. > > You need an UNUSED_PARAM(target) here. Yeah, I figured :) But instead I'm going to make the two Quirk methods related to simulated mouse events only defined for PLATFORM(IOS_FAMILY) since it really doesn't make sense to ever call those on another platform. 1542858 8 graouts 2019-06-07 10:11:10 -0700 Committed r246205: <https://trac.webkit.org/changeset/246205> 1542972 9 mcatanzaro 2019-06-07 15:18:45 -0700 Committed r246216: <https://trac.webkit.org/changeset/246216> 1542974 10 mcatanzaro 2019-06-07 15:23:28 -0700 Ah apologies Brent, I improperly pasted a Reviewed By line with your name in my build fix, but that is not correct because you didn't review my patch. Either I forgot to remove that line, or maybe (I suspect) webkit-patch added it in. (I don't think it used to do that. Or perhaps it did it because I forgot to write "unreviewed" in the commit message.) Anyway, for the record, Brent didn't review r246216. 1543086 11 myakura.web 2019-06-08 07:58:28 -0700 https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/page/Quirks.cpp?rev=246205#L331 > if (equalLettersIgnoringASCIICase(host, "www.google.com") && url.path().startsWithIgnoringASCIICase("/maps/")) Unlike other Google properties, people can access Google Maps using localized URLs (e.g. https://www.google.co.jp/maps , https://www.google.de/maps , https://www.google.com.hk/maps , and bunch more) and Google doesn't redirect them to google.com so if this quirk is not specific to the US version, we'll have trouble in non-US countries. 1553888 12 graouts 2019-07-18 05:52:20 -0700 (In reply to Masataka Yakura from comment #11) > https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/page/Quirks. > cpp?rev=246205#L331 > > > if (equalLettersIgnoringASCIICase(host, "www.google.com") && url.path().startsWithIgnoringASCIICase("/maps/")) > > Unlike other Google properties, people can access Google Maps using > localized URLs (e.g. https://www.google.co.jp/maps , > https://www.google.de/maps , https://www.google.com.hk/maps , and bunch > more) and Google doesn't redirect them to google.com so if this quirk is not > specific to the US version, we'll have trouble in non-US countries. Thanks Masataka, I filed https://bugs.webkit.org/show_bug.cgi?id=199904 to track that issue. 371584 2019-06-07 05:36:19 -0700 2019-06-07 05:40:59 -0700 Patch bug-198657-20190607143618.patch text/plain 2544 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTEzMzcxZTExN2UzYWZi ZTEzN2I1NWM4ZDYyY2Q3Njk1MTJmZTk1Yy4uZWI0M2YzMjFkOTUyYWM1NGFkNjYwMTA2NzRhOTNl NWVmMTlkMjU5MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA2LTA3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGltaXQgc2ltdWxhdGVk IG1vdXNlIGV2ZW50cyBvbiBHb29nbGUgTWFwcyB0byBlbnRlcmluZyBTdHJlZXQgVmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NjU3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81MTM0NTA2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgKE9PUFMhKS4KKworICAgICAgICAq IHBhZ2UvUXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlF1aXJrczo6c2hvdWxkRGlzcGF0 Y2hTaW11bGF0ZWRNb3VzZUV2ZW50c09uVGFyZ2V0IGNvbnN0KToKKyAgICAgICAgKiBwYWdlL1F1 aXJrcy5oOgorCiAyMDE5LTA2LTA2ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAK ICAgICAgICAgUkVMRUFTRV9BU1NFUlQgaGl0IGluIENhY2hlZEZyYW1lIGNvbnN0cnVjdG9yCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL1F1aXJrcy5jcHAKaW5kZXggMmFhYTA3MTEzYTFiZWJiMGI1ZDMyN2MwMzQyYmEwYTQ4 N2VmMTQxYi4uOWM3NTUyYTgwOGE0NWYzMTM1ZmY3ZWVkNGI3ODBjZmVkMTIzYWQ5NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3BhZ2UvUXVpcmtzLmNwcApAQCAtMzIxLDYgKzMyMSwyMiBAQCBib29sIFF1aXJrczo6c2hvdWxk RGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50cygpIGNvbnN0CiAgICAgcmV0dXJuIGZhbHNlOwog fQogCitib29sIFF1aXJrczo6c2hvdWxkRGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50c09uVGFy Z2V0KEV2ZW50VGFyZ2V0KiB0YXJnZXQpIGNvbnN0Cit7CisjaWYgUExBVEZPUk0oSU9TX0ZBTUlM WSkKKyAgICBpZiAoIW5lZWRzUXVpcmtzKCkgfHwgIXNob3VsZERpc3BhdGNoU2ltdWxhdGVkTW91 c2VFdmVudHMoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgLy8gT24gR29vZ2xlIE1h cHMsIHdlIHdhbnQgdG8gbGltaXQgc2ltdWxhdGVkIG1vdXNlIGV2ZW50cyB0byBkcmFnZ2luZyB0 aGUgbGl0dGxlIG1hbiB0aGF0IGFsbG93cyBlbnRlcmluZyBpbnRvIFN0cmVldCBWaWV3LgorICAg IGF1dG8mIHVybCA9IG1fZG9jdW1lbnQtPnRvcERvY3VtZW50KCkudXJsKCk7CisgICAgYXV0byBo b3N0ID0gdXJsLmhvc3QoKTsKKyAgICBpZiAoZXF1YWxMZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2Uo aG9zdCwgInd3dy5nb29nbGUuY29tIikgJiYgdXJsLnBhdGgoKS5zdGFydHNXaXRoSWdub3JpbmdB U0NJSUNhc2UoIi9tYXBzLyIpKQorICAgICAgICByZXR1cm4gaXM8RWxlbWVudD4odGFyZ2V0KSAm JiBkb3duY2FzdDxFbGVtZW50Pih0YXJnZXQpLT5nZXRBdHRyaWJ1dGUoImNsYXNzIikgPT0gIndp ZGdldC1leHBhbmQtYnV0dG9uLXBlZ21hbi1pY29uIjsKKyAgICByZXR1cm4gdHJ1ZTsKKyNlbmRp ZgorICAgIHJldHVybiBmYWxzZTsKK30KKwogYm9vbCBRdWlya3M6OnNob3VsZERpc2FibGVQb2lu dGVyRXZlbnRzUXVpcmsoKSBjb25zdAogewogI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5oIGIvU291cmNlL1dlYkNvcmUvcGFn ZS9RdWlya3MuaAppbmRleCA2YjFmMWJiOTUzN2E1ZDAzM2Q5NTdlODUxZTliNGMxNWYzZjFiMTk0 Li5mNmFkYzNlNThjOTBmNzZmMWM2ODFjOTJjY2EyZGEyYjQ3Y2ViNDY2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVp cmtzLmgKQEAgLTUwLDYgKzUwLDcgQEAgcHVibGljOgogICAgIGJvb2wgaGFzQnJva2VuRW5jcnlw dGVkTWVkaWFBUElTdXBwb3J0UXVpcmsoKSBjb25zdDsKICAgICBib29sIGhhc1dlYlNRTFN1cHBv cnRRdWlyaygpIGNvbnN0OwogICAgIGJvb2wgc2hvdWxkRGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2 ZW50cygpIGNvbnN0OworICAgIGJvb2wgc2hvdWxkRGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50 c09uVGFyZ2V0KEV2ZW50VGFyZ2V0KikgY29uc3Q7CiAgICAgYm9vbCBzaG91bGREaXNhYmxlUG9p bnRlckV2ZW50c1F1aXJrKCkgY29uc3Q7CiAgICAgYm9vbCBuZWVkc0lucHV0TW9kZU5vbmVJbXBs aWNpdGx5KGNvbnN0IEhUTUxFbGVtZW50JikgY29uc3Q7CiAK 371585 2019-06-07 05:41:02 -0700 2019-06-07 09:57:13 -0700 Patch bug-198657-20190607144101.patch text/plain 2511 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MTg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTEzMzcxZTExN2UzYWZi ZTEzN2I1NWM4ZDYyY2Q3Njk1MTJmZTk1Yy4uZGQzNDliMTIzZTYzN2FmMzE3ZjRmMzQwYjhmYzAx YWIxZjZjNDUzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE5LTA2LTA3ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgTGltaXQgc2ltdWxhdGVk IG1vdXNlIGV2ZW50cyBvbiBHb29nbGUgTWFwcyB0byBlbnRlcmluZyBTdHJlZXQgVmlldworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NjU3CisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS81MTM0NTA2ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhZ2UvUXVpcmtzLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlF1aXJrczo6c2hvdWxkRGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50c09uVGFyZ2V0IGNv bnN0KToKKyAgICAgICAgKiBwYWdlL1F1aXJrcy5oOgorCiAyMDE5LTA2LTA2ICBDaHJpcyBEdW1l eiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVMRUFTRV9BU1NFUlQgaGl0IGluIENh Y2hlZEZyYW1lIGNvbnN0cnVjdG9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1 aXJrcy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5jcHAKaW5kZXggMmFhYTA3MTEz YTFiZWJiMGI1ZDMyN2MwMzQyYmEwYTQ4N2VmMTQxYi4uOWM3NTUyYTgwOGE0NWYzMTM1ZmY3ZWVk NGI3ODBjZmVkMTIzYWQ5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3Mu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmNwcApAQCAtMzIxLDYgKzMyMSwy MiBAQCBib29sIFF1aXJrczo6c2hvdWxkRGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50cygpIGNv bnN0CiAgICAgcmV0dXJuIGZhbHNlOwogfQogCitib29sIFF1aXJrczo6c2hvdWxkRGlzcGF0Y2hT aW11bGF0ZWRNb3VzZUV2ZW50c09uVGFyZ2V0KEV2ZW50VGFyZ2V0KiB0YXJnZXQpIGNvbnN0Cit7 CisjaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKKyAgICBpZiAoIW5lZWRzUXVpcmtzKCkgfHwgIXNo b3VsZERpc3BhdGNoU2ltdWxhdGVkTW91c2VFdmVudHMoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgLy8gT24gR29vZ2xlIE1hcHMsIHdlIHdhbnQgdG8gbGltaXQgc2ltdWxhdGVkIG1v dXNlIGV2ZW50cyB0byBkcmFnZ2luZyB0aGUgbGl0dGxlIG1hbiB0aGF0IGFsbG93cyBlbnRlcmlu ZyBpbnRvIFN0cmVldCBWaWV3LgorICAgIGF1dG8mIHVybCA9IG1fZG9jdW1lbnQtPnRvcERvY3Vt ZW50KCkudXJsKCk7CisgICAgYXV0byBob3N0ID0gdXJsLmhvc3QoKTsKKyAgICBpZiAoZXF1YWxM ZXR0ZXJzSWdub3JpbmdBU0NJSUNhc2UoaG9zdCwgInd3dy5nb29nbGUuY29tIikgJiYgdXJsLnBh dGgoKS5zdGFydHNXaXRoSWdub3JpbmdBU0NJSUNhc2UoIi9tYXBzLyIpKQorICAgICAgICByZXR1 cm4gaXM8RWxlbWVudD4odGFyZ2V0KSAmJiBkb3duY2FzdDxFbGVtZW50Pih0YXJnZXQpLT5nZXRB dHRyaWJ1dGUoImNsYXNzIikgPT0gIndpZGdldC1leHBhbmQtYnV0dG9uLXBlZ21hbi1pY29uIjsK KyAgICByZXR1cm4gdHJ1ZTsKKyNlbmRpZgorICAgIHJldHVybiBmYWxzZTsKK30KKwogYm9vbCBR dWlya3M6OnNob3VsZERpc2FibGVQb2ludGVyRXZlbnRzUXVpcmsoKSBjb25zdAogewogI2lmIFBM QVRGT1JNKElPU19GQU1JTFkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJr cy5oIGIvU291cmNlL1dlYkNvcmUvcGFnZS9RdWlya3MuaAppbmRleCA2YjFmMWJiOTUzN2E1ZDAz M2Q5NTdlODUxZTliNGMxNWYzZjFiMTk0Li5mNmFkYzNlNThjOTBmNzZmMWM2ODFjOTJjY2EyZGEy YjQ3Y2ViNDY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL1F1aXJrcy5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3BhZ2UvUXVpcmtzLmgKQEAgLTUwLDYgKzUwLDcgQEAgcHVibGljOgog ICAgIGJvb2wgaGFzQnJva2VuRW5jcnlwdGVkTWVkaWFBUElTdXBwb3J0UXVpcmsoKSBjb25zdDsK ICAgICBib29sIGhhc1dlYlNRTFN1cHBvcnRRdWlyaygpIGNvbnN0OwogICAgIGJvb2wgc2hvdWxk RGlzcGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50cygpIGNvbnN0OworICAgIGJvb2wgc2hvdWxkRGlz cGF0Y2hTaW11bGF0ZWRNb3VzZUV2ZW50c09uVGFyZ2V0KEV2ZW50VGFyZ2V0KikgY29uc3Q7CiAg ICAgYm9vbCBzaG91bGREaXNhYmxlUG9pbnRlckV2ZW50c1F1aXJrKCkgY29uc3Q7CiAgICAgYm9v bCBuZWVkc0lucHV0TW9kZU5vbmVJbXBsaWNpdGx5KGNvbnN0IEhUTUxFbGVtZW50JikgY29uc3Q7 CiAK