198648 2019-06-07 00:44:01 -0700 [JSC] Use mergePrediction in ValuePow prediction propagation 2019-06-09 00:09:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki commit-queue ews-watchlist keith_miller mark.lam msaboff saam ticaiolima webkit-bug-importer oldest_to_newest 1542760 0 ysuzuki 2019-06-07 00:44:01 -0700 Currently, we are accidentally using setPrediction. This is wrong since prediction propagation (not processInvariant) must extend the speculation types to ensure we eventually reach to the fixed point. setPrediction can discard previously configured predictions, can lead to oscillation potentially. 1542762 1 371572 ysuzuki 2019-06-07 00:47:14 -0700 Created attachment 371572 Patch 1542763 2 ysuzuki 2019-06-07 00:49:03 -0700 <rdar://problem/51472985> 1542765 3 371572 ysuzuki 2019-06-07 01:00:08 -0700 Comment on attachment 371572 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371572&action=review > Source/JavaScriptCore/dfg/DFGPredictionPropagationPhase.cpp:291 > + changed |= mergePrediction(SpecBytecodeDouble | SpecBigInt); And this also does not propagate "change" :) 1542783 4 371572 ticaiolima 2019-06-07 02:01:54 -0700 Comment on attachment 371572 Patch Nice catch! Informal r+. 1543187 5 371701 ysuzuki 2019-06-08 21:42:17 -0700 Created attachment 371701 Patch 1543194 6 371701 saam 2019-06-08 23:35:47 -0700 Comment on attachment 371701 Patch r=me 1543196 7 371701 ysuzuki 2019-06-08 23:39:12 -0700 Comment on attachment 371701 Patch Thanks! :) 1543198 8 371701 commit-queue 2019-06-09 00:09:53 -0700 Comment on attachment 371701 Patch Clearing flags on attachment: 371701 Committed r246237: <https://trac.webkit.org/changeset/246237> 1543199 9 commit-queue 2019-06-09 00:09:55 -0700 All reviewed patches have been landed. Closing bug. 371572 2019-06-07 00:47:14 -0700 2019-06-08 21:42:16 -0700 Patch bug-198648-20190607004713.patch text/plain 3203 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA0 NjE1ZWEyY2ZkOTg5ZjkxMmFkYTM3NGYxMzhhZjFhMzBhYjk0Y2UwLi43MzMxN2ZmN2Y4MmRlZGFj NTE0ZWE4ZmJmZDc0M2QxOTI2NGQyODM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNi0wNyAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFVzZSBtZXJnZVByZWRpY3Rpb24gaW4gVmFsdWVQb3cgcHJlZGlj dGlvbiBwcm9wYWdhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk4NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2UgYXJlIGFjY2lkZW50YWxseSB1c2luZyBzZXRQcmVkaWN0aW9uLiBUaGlzIGlz IHdyb25nIHNpbmNlIHByZWRpY3Rpb24gcHJvcGFnYXRpb24gKG5vdCBwcm9jZXNzSW52YXJpYW50 KQorICAgICAgICBtdXN0IGV4dGVuZCB0aGUgc3BlY3VsYXRpb24gdHlwZXMgdG8gZW5zdXJlIHdl IGV2ZW50dWFsbHkgcmVhY2ggdG8gdGhlIGZpeGVkIHBvaW50LiBzZXRQcmVkaWN0aW9uIGNhbiBk aXNjYXJkCisgICAgICAgIHByZXZpb3VzbHkgY29uZmlndXJlZCBwcmVkaWN0aW9ucywgY2FuIGxl YWQgdG8gb3NjaWxsYXRpb24gcG90ZW50aWFsbHkuIFVzZSBtZXJnZVByZWRpY3Rpb24gaW5zdGVh ZC4KKworICAgICAgICAqIGRmZy9ERkdQcmVkaWN0aW9uUHJvcGFnYXRpb25QaGFzZS5jcHA6CisK IDIwMTktMDYtMDYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAg IFdlYiBJbnNwZWN0b3I6IGNyZWF0ZSBDb21tYW5kTGluZUFQSUhvc3QgbGF6aWx5IGxpa2UgdGhl IG90aGVyIGFnZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQ cmVkaWN0aW9uUHJvcGFnYXRpb25QaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcAppbmRleCA4NGQ2MWRlNjc0OGFmNzNi MTk5NTNjMjc1ZDc5ZGM4NGU0MjNhZTVkLi45NTM3Y2UwNjI0MDdjMDIyY2FhMWE4N2I3MjYxMDFj MzA3NWU3M2MxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ByZWRp Y3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcApAQCAtMjg2LDkgKzI4Niw5IEBAIGNs YXNzIFByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlIDogcHVibGljIFBoYXNlIHsKICAgICAgICAg ICAgICAgICAgICAgY2hhbmdlZCB8PSBtZXJnZVByZWRpY3Rpb24oU3BlY0JpZ0ludCk7CiAgICAg ICAgICAgICAgICAgZWxzZSBpZiAoaXNGdWxsTnVtYmVyT3JCb29sZWFuU3BlY3VsYXRpb25FeHBl Y3RpbmdEZWZpbmVkKGxlZnQpCiAgICAgICAgICAgICAgICAgICAgICYmIGlzRnVsbE51bWJlck9y Qm9vbGVhblNwZWN1bGF0aW9uRXhwZWN0aW5nRGVmaW5lZChyaWdodCkpCi0gICAgICAgICAgICAg ICAgICAgIHNldFByZWRpY3Rpb24oU3BlY0J5dGVjb2RlRG91YmxlKTsKKyAgICAgICAgICAgICAg ICAgICAgY2hhbmdlZCB8PSBtZXJnZVByZWRpY3Rpb24oU3BlY0J5dGVjb2RlRG91YmxlKTsKICAg ICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIHNldFByZWRpY3Rpb24oU3Bl Y0J5dGVjb2RlRG91YmxlIHwgU3BlY0JpZ0ludCk7CisgICAgICAgICAgICAgICAgICAgIGNoYW5n ZWQgfD0gbWVyZ2VQcmVkaWN0aW9uKFNwZWNCeXRlY29kZURvdWJsZSB8IFNwZWNCaWdJbnQpOwog ICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KZGlmZiAtLWdpdCBh L0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTlmYzJhY2FlNjdi OTcxNThmOWMyMjVmNmI4ODhlMTNhOTUzZjBmZS4uZWY5ZWIyNmY2MjcyZTMwODIwM2FlNDlkYjJi N2ZlYzI0YmJjNjE2ZCAxMDA2NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0 cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxOS0wNi0wNyAgWXVzdWtlIFN1enVraSAg PHlzdXp1a2lAYXBwbGUuY29tPgorCisgICAgICAgIFtKU0NdIFVzZSBtZXJnZVByZWRpY3Rpb24g aW4gVmFsdWVQb3cgcHJlZGljdGlvbiBwcm9wYWdhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvcHJlZGljdGlvbi1wcm9wYWdhdGlv bi1zaG91bGQtdXNlLW1lcmdlLXByZWRpY3Rpb24tZm9yLXZhbHVlLXBvdy5qczogQWRkZWQuCisK IDIwMTktMDYtMDUgIEp1c3RpbiBNaWNoYXVkICA8anVzdGluX21pY2hhdWRAYXBwbGUuY29tPgog CiAgICAgICAgIFtXQVNNLVJlZmVyZW5jZXNdIEFkZCBzdXBwb3J0IGZvciBBbnlyZWYgdGFibGVz LCBUYWJsZS5nZXQgYW5kIFRhYmxlLnNldCAoZm9yIEFueXJlZiBvbmx5KS4KZGlmZiAtLWdpdCBh L0pTVGVzdHMvc3RyZXNzL3ByZWRpY3Rpb24tcHJvcGFnYXRpb24tc2hvdWxkLXVzZS1tZXJnZS1w cmVkaWN0aW9uLWZvci12YWx1ZS1wb3cuanMgYi9KU1Rlc3RzL3N0cmVzcy9wcmVkaWN0aW9uLXBy b3BhZ2F0aW9uLXNob3VsZC11c2UtbWVyZ2UtcHJlZGljdGlvbi1mb3ItdmFsdWUtcG93LmpzCm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLmU3MDMyNWYzYzJhZDRiNmJlMmExMzU5ZGU1NDVjYmMyOGU2YTg3NmIKLS0tIC9k ZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9wcmVkaWN0aW9uLXByb3BhZ2F0aW9uLXNob3Vs ZC11c2UtbWVyZ2UtcHJlZGljdGlvbi1mb3ItdmFsdWUtcG93LmpzCkBAIC0wLDAgKzEsMyBAQAor Zm9yIChsZXQgaSA9IDA7IGkgPCAxMDAwMDA7IGkgPSBpICsgMSB8IDApIHsKKyAgICBpZiAoaSAq KiAyKSB7fQorfQo= 371701 2019-06-08 21:42:17 -0700 2019-06-09 00:09:53 -0700 Patch bug-198648-20190608214216.patch text/plain 3273 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MjM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 MzYyMzJjNTBkOTg5ZTU0MDhhZWIxNDg3Y2U5ZmUxMGE0Yzg4MGNlLi45YzFmNjY3YWE5Njc5OWJj NTE4ZDhjNDMxMGNjZDQxOTZkNDk3ZGM1IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOS0wNi0wOCAgWXVzdWtlIFN1enVraSAgPHlzdXp1a2lAYXBwbGUuY29t PgorCisgICAgICAgIFtKU0NdIFVzZSBtZXJnZVByZWRpY3Rpb24gaW4gVmFsdWVQb3cgcHJlZGlj dGlvbiBwcm9wYWdhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTk4NjQ4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2UgYXJlIGFjY2lkZW50YWxseSB1c2luZyBzZXRQcmVkaWN0aW9uLiBUaGlzIGlz IHdyb25nIHNpbmNlIHByZWRpY3Rpb24gcHJvcGFnYXRpb24gKG5vdCBwcm9jZXNzSW52YXJpYW50 KQorICAgICAgICBtdXN0IGV4dGVuZCB0aGUgc3BlY3VsYXRpb24gdHlwZXMgdG8gZW5zdXJlIHdl IGV2ZW50dWFsbHkgcmVhY2ggdG8gdGhlIGZpeGVkIHBvaW50LiBzZXRQcmVkaWN0aW9uIGNhbiBk aXNjYXJkCisgICAgICAgIHByZXZpb3VzbHkgY29uZmlndXJlZCBwcmVkaWN0aW9ucywgY2FuIGxl YWQgdG8gb3NjaWxsYXRpb24gcG90ZW50aWFsbHkuIFVzZSBtZXJnZVByZWRpY3Rpb24gaW5zdGVh ZC4KKworICAgICAgICAqIGRmZy9ERkdQcmVkaWN0aW9uUHJvcGFnYXRpb25QaGFzZS5jcHA6CisK IDIwMTktMDYtMDcgIFRhZGV1IFphZ2FsbG8gIDx0emFnYWxsb0BhcHBsZS5jb20+CiAKICAgICAg ICAgQUkgc2hvdWxkIGdldCBHZXR0ZXJTZXR0ZXIgc3RydWN0dXJlIGZyb20gdGhlIGJhc2UncyBH bG9iYWxPYmplY3QgZm9yIEdldEdldHRlclNldHRlckJ5T2Zmc2V0CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcCBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHJlZGljdGlvblByb3BhZ2F0aW9uUGhhc2Uu Y3BwCmluZGV4IDg0ZDYxZGU2NzQ4YWY3M2IxOTk1M2MyNzVkNzlkYzg0ZTQyM2FlNWQuLjk1Mzdj ZTA2MjQwN2MwMjJjYWExYTg3YjcyNjEwMWMzMDc1ZTczYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9K YXZhU2NyaXB0Q29yZS9kZmcvREZHUHJlZGljdGlvblByb3BhZ2F0aW9uUGhhc2UuY3BwCisrKyBi L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUHJlZGljdGlvblByb3BhZ2F0aW9uUGhhc2Uu Y3BwCkBAIC0yODYsOSArMjg2LDkgQEAgY2xhc3MgUHJlZGljdGlvblByb3BhZ2F0aW9uUGhhc2Ug OiBwdWJsaWMgUGhhc2UgewogICAgICAgICAgICAgICAgICAgICBjaGFuZ2VkIHw9IG1lcmdlUHJl ZGljdGlvbihTcGVjQmlnSW50KTsKICAgICAgICAgICAgICAgICBlbHNlIGlmIChpc0Z1bGxOdW1i ZXJPckJvb2xlYW5TcGVjdWxhdGlvbkV4cGVjdGluZ0RlZmluZWQobGVmdCkKICAgICAgICAgICAg ICAgICAgICAgJiYgaXNGdWxsTnVtYmVyT3JCb29sZWFuU3BlY3VsYXRpb25FeHBlY3RpbmdEZWZp bmVkKHJpZ2h0KSkKLSAgICAgICAgICAgICAgICAgICAgc2V0UHJlZGljdGlvbihTcGVjQnl0ZWNv ZGVEb3VibGUpOworICAgICAgICAgICAgICAgICAgICBjaGFuZ2VkIHw9IG1lcmdlUHJlZGljdGlv bihTcGVjQnl0ZWNvZGVEb3VibGUpOwogICAgICAgICAgICAgICAgIGVsc2UKLSAgICAgICAgICAg ICAgICAgICAgc2V0UHJlZGljdGlvbihTcGVjQnl0ZWNvZGVEb3VibGUgfCBTcGVjQmlnSW50KTsK KyAgICAgICAgICAgICAgICAgICAgY2hhbmdlZCB8PSBtZXJnZVByZWRpY3Rpb24oU3BlY0J5dGVj b2RlRG91YmxlIHwgU3BlY0JpZ0ludCk7CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBicmVh azsKICAgICAgICAgfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9DaGFuZ2VMb2cgYi9KU1Rlc3RzL0No YW5nZUxvZwppbmRleCAwODJjMTQ5MWQ4MDk3NmZlMWU5MjliMmQ5MzM3MGE2ZmZmYzcyYTY0Li42 MGM3OGJkMDcwNTg5N2M5ZGQzOTI1MWNiZWM4OWY3ZDliMWNmMWEyIDEwMDY0NAotLS0gYS9KU1Rl c3RzL0NoYW5nZUxvZworKysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisy MDE5LTA2LTA4ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAg W0pTQ10gVXNlIG1lcmdlUHJlZGljdGlvbiBpbiBWYWx1ZVBvdyBwcmVkaWN0aW9uIHByb3BhZ2F0 aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg2 NDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0 cmVzcy9wcmVkaWN0aW9uLXByb3BhZ2F0aW9uLXNob3VsZC11c2UtbWVyZ2UtcHJlZGljdGlvbi1m b3ItdmFsdWUtcG93LmpzOiBBZGRlZC4KKwogMjAxOS0wNi0wNyAgVGFkZXUgWmFnYWxsbyAgPHR6 YWdhbGxvQGFwcGxlLmNvbT4KIAogICAgICAgICBBSSBzaG91bGQgZ2V0IEdldHRlclNldHRlciBz dHJ1Y3R1cmUgZnJvbSB0aGUgYmFzZSdzIEdsb2JhbE9iamVjdCBmb3IgR2V0R2V0dGVyU2V0dGVy QnlPZmZzZXQKZGlmZiAtLWdpdCBhL0pTVGVzdHMvc3RyZXNzL3ByZWRpY3Rpb24tcHJvcGFnYXRp b24tc2hvdWxkLXVzZS1tZXJnZS1wcmVkaWN0aW9uLWZvci12YWx1ZS1wb3cuanMgYi9KU1Rlc3Rz L3N0cmVzcy9wcmVkaWN0aW9uLXByb3BhZ2F0aW9uLXNob3VsZC11c2UtbWVyZ2UtcHJlZGljdGlv bi1mb3ItdmFsdWUtcG93LmpzCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjM0OTU0MjM1Y2U3N2I1MTM5N2QzNzBhZDE1 MzVmZGZhMmExZjAzY2YKLS0tIC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL3N0cmVzcy9wcmVkaWN0 aW9uLXByb3BhZ2F0aW9uLXNob3VsZC11c2UtbWVyZ2UtcHJlZGljdGlvbi1mb3ItdmFsdWUtcG93 LmpzCkBAIC0wLDAgKzEsNCBAQAorLy9AIHJ1bkRlZmF1bHQoIi0tdXNlUmFuZG9taXppbmdGdXp6 ZXJBZ2VudD0xIikKK2ZvciAobGV0IGkgPSAwOyBpIDwgMTAwMDAwOyBpID0gaSArIDEgfCAwKSB7 CisgICAgaWYgKGkgKiogMikge30KK30K