19864 2008-07-02 19:17:41 -0700 Computed style for webkitTransform property 2008-08-04 11:18:15 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac All RESOLVED FIXED P2 Normal --- 19863 19028 0 dino webkit-unassigned dino simon.fraser oldest_to_newest 85030 0 dino 2008-07-02 19:17:41 -0700 The computed style for the -webkit-transform property is not implemented. 85031 1 22058 dino 2008-07-02 19:18:43 -0700 Created attachment 22058 implements computed style for webkit-transform prop 85032 2 22059 dino 2008-07-02 19:19:20 -0700 Created attachment 22059 testcase for computed style of transforms 85432 3 simon.fraser 2008-07-07 20:26:27 -0700 This change: WebKitCSSTransformValue::WebKitCSSTransformValue(TransformOperationType op) - : CSSValueList(false) + : CSSValueList(true) , m_type(op) { } is showing up in several of your patches. 85469 4 22058 hyatt 2008-07-08 11:15:44 -0700 Comment on attachment 22058 implements computed style for webkit-transform prop r=me, please land a layout test with this change though, as it should be possible to make a text-only layout test for this. 85495 5 dino 2008-07-08 15:11:27 -0700 Simon, it's redoing the undo of the redo of that change :) either way, i'll make sure only the correct change gets submitted - once. and yeah, will add a layout test 85745 6 dino 2008-07-10 21:54:23 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/css3/transform-computed-style-001-expected.txt A LayoutTests/css3/transform-computed-style-001.html M WebCore/ChangeLog M WebCore/css/CSSComputedStyleDeclaration.cpp A WebCore/manual-tests/computed-transform-value.html Committed r35117 22058 2008-07-02 19:18:43 -0700 2008-07-08 11:15:44 -0700 implements computed style for webkit-transform prop patch3-transform-computed-style.patch text/plain 4303 dino ZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbi5jcHAg Yi9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCmluZGV4IDFiM2Nm MDkuLjEzNjUyOTUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvY3NzL0NTU0NvbXB1dGVkU3R5bGVEZWNs YXJhdGlvbi5jcHAKKysrIGIvV2ViQ29yZS9jc3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9u LmNwcApAQCAtMzcsNiArMzcsNyBAQAogI2luY2x1ZGUgIlJlY3QuaCIKICNpbmNsdWRlICJSZW5k ZXJPYmplY3QuaCIKICNpbmNsdWRlICJTaGFkb3dWYWx1ZS5oIgorI2luY2x1ZGUgIldlYktpdENT U1RyYW5zZm9ybVZhbHVlLmgiCiAKICNpZiBFTkFCTEUoREFTSEJPQVJEX1NVUFBPUlQpCiAjaW5j bHVkZSAiRGFzaGJvYXJkUmVnaW9uLmgiCkBAIC0xODMsNiArMTg0LDkgQEAgc3RhdGljIGNvbnN0 IGludCBjb21wdXRlZFByb3BlcnRpZXNbXSA9IHsKICAgICBDU1NQcm9wZXJ0eVdlYmtpdFRleHRT ZWN1cml0eSwKICAgICBDU1NQcm9wZXJ0eVdlYmtpdFRleHRTdHJva2VDb2xvciwKICAgICBDU1NQ cm9wZXJ0eVdlYmtpdFRleHRTdHJva2VXaWR0aCwKKyAgICBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5z Zm9ybSwKKyAgICBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybU9yaWdpblgsCisgICAgQ1NTUHJv cGVydHlXZWJraXRUcmFuc2Zvcm1PcmlnaW5ZLAogICAgIENTU1Byb3BlcnR5V2Via2l0VXNlckRy YWcsCiAgICAgQ1NTUHJvcGVydHlXZWJraXRVc2VyTW9kaWZ5LAogICAgIENTU1Byb3BlcnR5V2Vi a2l0VXNlclNlbGVjdCwKQEAgLTM4Myw2ICszODcsMzEgQEAgc3RhdGljIEludFJlY3Qgc2l6aW5n Qm94KFJlbmRlck9iamVjdCogcmVuZGVyZXIpCiAgICAgcmV0dXJuIHJlbmRlcmVyLT5zdHlsZSgp LT5ib3hTaXppbmcoKSA9PSBDT05URU5UX0JPWCA/IHJlbmRlcmVyLT5jb250ZW50Qm94KCkgOiBy ZW5kZXJlci0+Ym9yZGVyQm94KCk7CiB9CiAKK3N0YXRpYyBQYXNzUmVmUHRyPENTU1ZhbHVlTGlz dD4gY29tcHV0ZWRUcmFuc2Zvcm0oUmVuZGVyT2JqZWN0KiByZW5kZXJlcikKK3sKKyAgICBpZiAo IXJlbmRlcmVyKQorICAgICAgICByZXR1cm4gMDsKKworICAgIEludFJlY3QgYm94ID0gc2l6aW5n Qm94KHJlbmRlcmVyKTsKKworICAgIEFmZmluZVRyYW5zZm9ybSB0cmFuc2Zvcm07CisgICAgcmVu ZGVyZXItPnN0eWxlKCktPmFwcGx5VHJhbnNmb3JtKHRyYW5zZm9ybSwgYm94LnNpemUoKSk7CisK KyAgICBSZWZQdHI8V2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWU+IHRyYW5zZm9ybVZhbCA9IFdlYktp dENTU1RyYW5zZm9ybVZhbHVlOjpjcmVhdGUoV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWU6Ok1hdHJp eFRyYW5zZm9ybU9wZXJhdGlvbik7CisKKyAgICB0cmFuc2Zvcm1WYWwtPmFwcGVuZChDU1NQcmlt aXRpdmVWYWx1ZTo6Y3JlYXRlKHRyYW5zZm9ybS5hKCksIENTU1ByaW1pdGl2ZVZhbHVlOjpDU1Nf TlVNQkVSKSk7CisgICAgdHJhbnNmb3JtVmFsLT5hcHBlbmQoQ1NTUHJpbWl0aXZlVmFsdWU6OmNy ZWF0ZSh0cmFuc2Zvcm0uYigpLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX05VTUJFUikpOworICAg IHRyYW5zZm9ybVZhbC0+YXBwZW5kKENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUodHJhbnNmb3Jt LmMoKSwgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpKTsKKyAgICB0cmFuc2Zvcm1WYWwt PmFwcGVuZChDU1NQcmltaXRpdmVWYWx1ZTo6Y3JlYXRlKHRyYW5zZm9ybS5kKCksIENTU1ByaW1p dGl2ZVZhbHVlOjpDU1NfTlVNQkVSKSk7CisgICAgdHJhbnNmb3JtVmFsLT5hcHBlbmQoQ1NTUHJp bWl0aXZlVmFsdWU6OmNyZWF0ZSh0cmFuc2Zvcm0uZSgpLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NT X05VTUJFUikpOworICAgIHRyYW5zZm9ybVZhbC0+YXBwZW5kKENTU1ByaW1pdGl2ZVZhbHVlOjpj cmVhdGUodHJhbnNmb3JtLmYoKSwgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19OVU1CRVIpKTsKKwor ICAgIFJlZlB0cjxDU1NWYWx1ZUxpc3Q+IGxpc3QgPSBDU1NWYWx1ZUxpc3Q6OmNyZWF0ZVNwYWNl U2VwYXJhdGVkKCk7CisgICAgbGlzdC0+YXBwZW5kKHRyYW5zZm9ybVZhbCk7CisKKyAgICByZXR1 cm4gbGlzdC5yZWxlYXNlKCk7Cit9CisKIENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Q1NT Q29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uKFBhc3NSZWZQdHI8Tm9kZT4gbikKICAgICA6IG1fbm9k ZShuKQogewpAQCAtMTAxMCw2ICsxMDM5LDIyIEBAIFBhc3NSZWZQdHI8Q1NTVmFsdWU+IENTU0Nv bXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Z2V0UHJvcGVydHlDU1NWYWx1ZShpbnQgcHJvcGVyCiAg ICAgICAgICAgICB9CiAgICAgICAgICAgICByZXR1cm4gMDsKICAgICAgICAgfQorICAgICAgICBj YXNlIENTU1Byb3BlcnR5V2Via2l0VHJhbnNmb3JtOgorICAgICAgICAgICAgcmV0dXJuIGNvbXB1 dGVkVHJhbnNmb3JtKHJlbmRlcmVyKTsKKyAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRy YW5zZm9ybU9yaWdpblg6CisgICAgICAgICAgICBpZiAocmVuZGVyZXIpIHsKKyAgICAgICAgICAg ICAgICBJbnRSZWN0IGJveCA9IHNpemluZ0JveChyZW5kZXJlcik7CisgICAgICAgICAgICAgICAg cmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUoc3R5bGUtPnRyYW5zZm9ybU9yaWdpblgo KS5jYWxjTWluVmFsdWUoYm94LndpZHRoKCkpLCBDU1NQcmltaXRpdmVWYWx1ZTo6Q1NTX1BYKTsK KyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGVsc2UKKyAgICAgICAgICAgICAgICByZXR1cm4g Q1NTUHJpbWl0aXZlVmFsdWU6OmNyZWF0ZShzdHlsZS0+dHJhbnNmb3JtT3JpZ2luWCgpKTsKKyAg ICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybU9yaWdpblk6CisgICAgICAgICAg ICBpZiAocmVuZGVyZXIpIHsKKyAgICAgICAgICAgICAgICBJbnRSZWN0IGJveCA9IHNpemluZ0Jv eChyZW5kZXJlcik7CisgICAgICAgICAgICAgICAgcmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpj cmVhdGUoc3R5bGUtPnRyYW5zZm9ybU9yaWdpblkoKS5jYWxjTWluVmFsdWUoYm94LmhlaWdodCgp KSwgQ1NTUHJpbWl0aXZlVmFsdWU6OkNTU19QWCk7CisgICAgICAgICAgICB9CisgICAgICAgICAg ICBlbHNlCisgICAgICAgICAgICAgICAgcmV0dXJuIENTU1ByaW1pdGl2ZVZhbHVlOjpjcmVhdGUo c3R5bGUtPnRyYW5zZm9ybU9yaWdpblkoKSk7CiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlCYWNr Z3JvdW5kOgogICAgICAgICBjYXNlIENTU1Byb3BlcnR5Qm9yZGVyOgogICAgICAgICBjYXNlIENT U1Byb3BlcnR5Qm9yZGVyQm90dG9tOgpAQCAtMTA2NywxMCArMTExMiw2IEBAIFBhc3NSZWZQdHI8 Q1NTVmFsdWU+IENTU0NvbXB1dGVkU3R5bGVEZWNsYXJhdGlvbjo6Z2V0UHJvcGVydHlDU1NWYWx1 ZShpbnQgcHJvcGVyCiAgICAgICAgIGNhc2UgQ1NTUHJvcGVydHlXZWJraXRNYXNrOgogICAgICAg ICBjYXNlIENTU1Byb3BlcnR5V2Via2l0UGFkZGluZ1N0YXJ0OgogICAgICAgICBjYXNlIENTU1By b3BlcnR5V2Via2l0VGV4dFN0cm9rZToKLSAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRy YW5zZm9ybToKLSAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybU9yaWdpbjoK LSAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybU9yaWdpblg6Ci0gICAgICAg IGNhc2UgQ1NTUHJvcGVydHlXZWJraXRUcmFuc2Zvcm1PcmlnaW5ZOgogICAgICAgICBjYXNlIENT U1Byb3BlcnR5V2Via2l0VHJhbnNpdGlvbjoKICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtp dFRyYW5zaXRpb25EdXJhdGlvbjoKICAgICAgICAgY2FzZSBDU1NQcm9wZXJ0eVdlYmtpdFRyYW5z aXRpb25Qcm9wZXJ0eToKZGlmZiAtLWdpdCBhL1dlYkNvcmUvY3NzL1dlYktpdENTU1RyYW5zZm9y bVZhbHVlLmNwcCBiL1dlYkNvcmUvY3NzL1dlYktpdENTU1RyYW5zZm9ybVZhbHVlLmNwcAppbmRl eCA1NzY0OTZhLi5hNmU3MWNkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9XZWJLaXRDU1NUcmFu c2Zvcm1WYWx1ZS5jcHAKKysrIGIvV2ViQ29yZS9jc3MvV2ViS2l0Q1NTVHJhbnNmb3JtVmFsdWUu Y3BwCkBAIC0zMyw3ICszMyw3IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIFdlYktpdENTU1Ry YW5zZm9ybVZhbHVlOjpXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZShUcmFuc2Zvcm1PcGVyYXRpb25U eXBlIG9wKQotICAgIDogQ1NTVmFsdWVMaXN0KGZhbHNlKQorICAgIDogQ1NTVmFsdWVMaXN0KHRy dWUpCiAgICAgLCBtX3R5cGUob3ApCiB7CiB9Cg== 22059 2008-07-02 19:19:20 -0700 2008-07-02 19:19:20 -0700 testcase for computed style of transforms get_current_2d_transform.html text/html 1655 dino PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogICAgPG1ldGEgaHR0cC1lcXVpdj0iQ29udGVudC1UeXBlIiBjb250 ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiPgogICAgPHRpdGxlPkdldCBDb21wdXRlZCBU cmFuc2Zvcm08L3RpdGxlPgogICAgPHN0eWxlIHR5cGU9InRleHQvY3NzIiBtZWRpYT0ic2NyZWVu Ij4KICAgIC5ib3ggewogICAgICAgIGhlaWdodDogMjAwcHg7CiAgICAgICAgd2lkdGg6IDIwMHB4 OwogICAgICAgIGJhY2tncm91bmQtY29sb3I6ICMwMGEwYTA7CiAgICB9CiAgICA8L3N0eWxlPgog ICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIGNoYXJzZXQ9InV0Zi04Ij4KICAgICAg ICBmdW5jdGlvbiBwcmludFRyYW5zZm9ybShldmVudCkKICAgICAgICB7CiAgICAgICAgICAgIHZh ciBib3ggPSBldmVudC50YXJnZXQ7CiAgICAgICAgICAgIHZhciBjb21wdXRlZFRyYW5zZm9ybSA9 IHdpbmRvdy5nZXRDb21wdXRlZFN0eWxlKGJveCkud2Via2l0VHJhbnNmb3JtOwogICAgICAgICAg ICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgib3V0cHV0IikuaW5uZXJIVE1MID0gJ0NvbXB1dGVk IHRyYW5zZm9ybSBpcyAnICsgY29tcHV0ZWRUcmFuc2Zvcm07CiAgICAgICAgfQogICAgICAgIAog ICAgPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHkgb25jbGljaz0icHJpbnRUcmFuc2Zvcm0oZXZlbnQp Ij4KCjxoMT5UZXN0aW5nIHRyYW5zZm9ybSBjb21wdXRlZCBzdHlsZTwvaDE+CjxwPkFsbCBib3hl cyBhcmUgMjAweDIwMCBwaXhlbHMuIFdoZW4geW91IGNsaWNrIG9uIGFuIGVsZW1lbnQsIHRoZSBj b21wdXRlZCB0cmFuc2Zvcm0gc3R5bGUgd2lsbCBiZSBkaXNwbGF5ZWQgYmVsb3c8L3A+CjxwIGlk PSJvdXRwdXQiPkNvbXB1dGVkIHN0eWxlIGZvciAtd2Via2l0LXRyYW5zZm9ybSBkaXNwbGF5ZWQg aGVyZTwvcD4KCgo8ZGl2IGNsYXNzPSJib3giIHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IGxl ZnQ6IDEwMHB4OyB0b3A6IDIwMHB4OyAtd2Via2l0LXRyYW5zZm9ybTogc2NhbGUoMS41LCAwLjc1 KSI+CiAgc2NhbGUoMS41LCAwLjc1KQo8L2Rpdj4KCjxkaXYgY2xhc3M9ImJveCIgc3R5bGU9InBv c2l0aW9uOiBhYnNvbHV0ZTsgbGVmdDogNDAwcHg7IHRvcDogMjAwcHg7IC13ZWJraXQtdHJhbnNm b3JtOiByb3RhdGUoMzBkZWcpIj4KICByb3RhdGUoMzBkZWcpCjwvZGl2PgoKPGRpdiBjbGFzcz0i Ym94IiBzdHlsZT0icG9zaXRpb246IGFic29sdXRlOyBsZWZ0OiAxMDBweDsgdG9wOiA0MDBweDsg LXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZSg1MHB4LCA4MHB4KSI+CiAgdHJhbnNsYXRlKDUw cHgsIDgwcHgpCjwvZGl2PgoKPGRpdiBjbGFzcz0iYm94IiBzdHlsZT0icG9zaXRpb246IGFic29s dXRlOyBsZWZ0OiA0MDBweDsgdG9wOiA0MDBweDsgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0 ZSgxMHB4LCA1MHB4KSBzY2FsZSgwLjgpIHJvdGF0ZSgtMTBkZWcpIj4KICB0cmFuc2xhdGUoMTBw eCwgNTBweCkgc2NhbGUoMC44KSByb3RhdGUoLTEwZGVnKQo8L2Rpdj4KCjwvYm9keT4KPC9odG1s Pgo=