198639 2019-06-06 19:03:44 -0700 Web Inspector: Timelines: only complete Composite records if the m_startedComposite (followup to r246142) 2019-06-06 20:39:15 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 198497 1 hi hi commit-queue ews-watchlist hi inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1542681 0 hi 2019-06-06 19:03:44 -0700 In r246142, an `ASSERT` was removed because it is possible for Web Inspector to be opened in between `willComposite` and `didComposite`, meaning that previously the `ASSERT` would fire. In order to properly handle this, we should replace the `ASSERT` with an `if` so that we don't even try to complete a `Composite` record if Web Inspector is opened in that case. 1542683 1 371549 hi 2019-06-06 19:04:55 -0700 Created attachment 371549 Patch 1542695 2 371549 mattbaker 2019-06-06 20:07:12 -0700 Comment on attachment 371549 Patch rs=me 1542700 3 371549 commit-queue 2019-06-06 20:38:28 -0700 Comment on attachment 371549 Patch Clearing flags on attachment: 371549 Committed r246186: <https://trac.webkit.org/changeset/246186> 1542701 4 commit-queue 2019-06-06 20:38:30 -0700 All reviewed patches have been landed. Closing bug. 1542702 5 webkit-bug-importer 2019-06-06 20:39:15 -0700 <rdar://problem/51510395> 371549 2019-06-06 19:04:55 -0700 2019-06-06 20:38:28 -0700 Patch bug-198639-20190606190454.patch text/plain 1864 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1Yzc2NDIyMTM4ZjkwNzY5MmZmZWI3MmJjYjhhM2FmNTVmMDg0NjNlLi4y MjBmNzlhY2E5M2UyMzVmY2ZiN2QxMzY0ZTM0Zjg3ZTNiZmQzMTZhIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMTktMDYtMDYgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lczogb25seSBjb21wbGV0ZSBDb21w b3NpdGUgcmVjb3JkcyBpZiB0aGUgbV9zdGFydGVkQ29tcG9zaXRlIChmb2xsb3d1cCB0byByMjQ2 MTQyKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4 NjM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4g cjI0NjE0MiwgYW4gYEFTU0VSVGAgd2FzIHJlbW92ZWQgYmVjYXVzZSBpdCBpcyBwb3NzaWJsZSBm b3IgV2ViIEluc3BlY3RvciB0byBiZSBvcGVuZWQgaW4KKyAgICAgICAgYmV0d2VlbiBgd2lsbENv bXBvc2l0ZWAgYW5kIGBkaWRDb21wb3NpdGVgLCBtZWFuaW5nIHRoYXQgcHJldmlvdXNseSB0aGUg YEFTU0VSVGAgd291bGQgZmlyZS4KKworICAgICAgICBJbiBvcmRlciB0byBwcm9wZXJseSBoYW5k bGUgdGhpcywgd2Ugc2hvdWxkIHJlcGxhY2UgdGhlIGBBU1NFUlRgIHdpdGggYW4gYGlmYCBzbyB0 aGF0IFdlYgorICAgICAgICBJbnNwZWN0b3IgZG9lc24ndCBldmVuIHRyeSB0byBjb21wbGV0ZSBh IGBDb21wb3NpdGVgIHJlY29yZCBpZiBpdCB3YXMgb3BlbmVkIGluIHRoYXQgY2FzZS4KKworICAg ICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpJbnNwZWN0b3JUaW1lbGluZUFnZW50OjpkaWRDb21wb3NpdGUpOgorCiAy MDE5LTA2LTA2ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBB bGxvdyBXZWJLaXRUZXN0UnVubmVyIHRvIHRlcm1pbmF0ZSBuZXR3b3JrIHByb2Nlc3MgYWZ0ZXIg aXQgZmluaXNoZXMgc2VydmljZSB3b3JrZXIgZmlsZSBvcGVyYXRpb25zCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3Bw IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JUaW1lbGluZUFnZW50 LmNwcAppbmRleCBmNjM2ODNmYTM5MjZiM2M3NWVmMTk2MmVhYmYxNjkxZjU1ZTEwYzI5Li40M2Ey NGVhMDM1Zjk5YWRhNmEzYzQzNjZmMzhjMDdhNTNhOWE5YTQwIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3RvclRpbWVsaW5lQWdlbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yVGltZWxpbmVBZ2VudC5j cHAKQEAgLTM2NCw3ICszNjQsOCBAQCB2b2lkIEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OndpbGxD b21wb3NpdGUoRnJhbWUmIGZyYW1lKQogCiB2b2lkIEluc3BlY3RvclRpbWVsaW5lQWdlbnQ6OmRp ZENvbXBvc2l0ZSgpCiB7Ci0gICAgZGlkQ29tcGxldGVDdXJyZW50UmVjb3JkKFRpbWVsaW5lUmVj b3JkVHlwZTo6Q29tcG9zaXRlKTsKKyAgICBpZiAobV9zdGFydGVkQ29tcG9zaXRlKQorICAgICAg ICBkaWRDb21wbGV0ZUN1cnJlbnRSZWNvcmQoVGltZWxpbmVSZWNvcmRUeXBlOjpDb21wb3NpdGUp OwogICAgIG1fc3RhcnRlZENvbXBvc2l0ZSA9IGZhbHNlOwogfQogCg==