198625 2019-06-06 15:29:08 -0700 RELEASE_ASSERT hit in CachedFrame constructor 2019-06-06 22:14:42 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez commit-queue ggaren rniwa webkit-bug-importer oldest_to_newest 1542566 0 cdumez 2019-06-06 15:29:08 -0700 RELEASE_ASSERT hit in CachedFrame constructor: [ 1] 0x0000000106256ffa WebCore`WebCore::CachedFrame::CachedFrame(WebCore::Frame&) + 842 at CachedFrame.cpp:148:5 138 { 139 #ifndef NDEBUG 140 cachedFrameCounter.increment(); 141 #endif 142 ASSERT(m_document); 143 ASSERT(m_documentLoader); 144 ASSERT(m_view); 145 ASSERT(m_document->pageCacheState() == Document::InPageCache); 146 147 RELEASE_ASSERT(m_document->domWindow()); -> 148 RELEASE_ASSERT(m_document->frame()); 149 RELEASE_ASSERT(m_document->domWindow()->frame()); 150 151 // FIXME: We have evidence that constructing CachedFrames for descendant frames may detach the document from its frame (rdar://problem/49877867). 152 // This sets the flag to help find the guilty code. 153 m_document->setMayBeDetachedFromFrame(false); 154 155 // Create the CachedFrames for all Frames in the FrameTree. 156 for (Frame* child = frame.tree().firstChild(); child; child = child->tree().nextSibling()) 157 m_childFrames.append(std::make_unique<CachedFrame>(*child)); 158 1542567 1 cdumez 2019-06-06 15:29:32 -0700 <rdar://problem/49877867> 1542572 2 371529 cdumez 2019-06-06 15:35:45 -0700 Created attachment 371529 Patch 1542710 3 371529 ggaren 2019-06-06 21:19:10 -0700 Comment on attachment 371529 Patch r=me 1542719 4 371529 commit-queue 2019-06-06 22:14:41 -0700 Comment on attachment 371529 Patch Clearing flags on attachment: 371529 Committed r246187: <https://trac.webkit.org/changeset/246187> 1542720 5 commit-queue 2019-06-06 22:14:42 -0700 All reviewed patches have been landed. Closing bug. 371529 2019-06-06 15:35:45 -0700 2019-06-06 22:14:41 -0700 Patch bug-198625-20190606153543.patch text/plain 2829 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzcxNjRlMTlkZjAwZDE2 MWMzOTM2NTE0YzBmOWIyZDUxNTFjMDk2OS4uZWY1Y2U5N2E4NDdkYTk5ZDA2YTU1YzA4ZGZhNTA1 ZGE2NTk2OGM1ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDE5LTA2LTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVMRUFTRV9BU1NFUlQgaGl0 IGluIENhY2hlZEZyYW1lIGNvbnN0cnVjdG9yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTg2MjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQ5ODc3 ODY3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo aXMgaXMgYSBzcGVjdWxhdGl2ZSBmaXgsIGl0IGFwcGVhcnMgdGhlIGRvY3VtZW50IGlzIGFscmVh ZHkgZGV0YWNoZWQgZnJvbSBpdHMKKyAgICAgICAgZnJhbWUgYnkgdGhlIHRpbWUgd2UgY29uc3Ry dWN0IGEgQ2FjaGVkRnJhbWUgZm9yIGl0IHdoZW4gZW50ZXJpbmcgUGFnZUNhY2hlLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cywgYmVjYXVzZSB3ZSBkbyBub3Qga25vdyB5ZXQgaG93IHRoaXMgY2Fu IGJlIHJlcHJvZHVjZWQuCisKKyAgICAgICAgKiBoaXN0b3J5L1BhZ2VDYWNoZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpjYW5DYWNoZUZyYW1lKToKKyAgICAgICAgTWFrZSBhIGZyYW1lIGFzIGlu ZWxpZ2libGUgZm9yIFBhZ2VDYWNoZSBpZjoKKyAgICAgICAgMS4gSXQgZG9lcyBub3QgaGF2ZSBh IGRvY3VtZW50CisgICAgICAgIG9yCisgICAgICAgIDIuIEl0cyBkb2N1bWVudCBpcyBhbHJlYWR5 IGRldGFjaGVkIGZyb20gdGhlIGZyYW1lCisKKyAgICAgICAgKFdlYkNvcmU6OlBhZ2VDYWNoZTo6 YWRkSWZDYWNoZWFibGUpOgorICAgICAgICBEZXN0cm95IHRoZSByZW5kZXIgdHJlZSAqYmVmb3Jl KiB3ZSBjaGVjayBpZiB0aGUgcGFnZSBjYW4gZW50ZXIgcGFnZSBjYWNoZSwgaW4gY2FzZQorICAg ICAgICBkZXN0cm95aW5nIHRoZSByZW5kZXIgdHJlZSBoYXMgYW55IHNpZGUgZWZmZWN0cyB0aGF0 IGNvdWxkIG1ha2UgdGhlIHBhZ2UgaW5lbGlnaWJsZQorICAgICAgICBmb3IgUGFnZSBDYWNoZS4K KwogMjAxOS0wNi0wNSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAg ICBbV0hMU0xdIEltcGxlbWVudCBsb29wIGV4cHJlc3Npb25zCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9oaXN0b3J5L1BhZ2VDYWNoZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9oaXN0b3J5L1Bh Z2VDYWNoZS5jcHAKaW5kZXggZjEzZTVhOGU4YjJjYjc3MTA3MGYyMjRhY2Y1OGJlYjRiMjRiZGEz MC4uMjM3OWQ5ZGI3YTBkZjVlMzAzYjU5NjUxM2RhMGQ1ZmMyMjg1MzI0YSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvaGlzdG9yeS9QYWdlQ2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2hpc3RvcnkvUGFnZUNhY2hlLmNwcApAQCAtOTAsNiArOTAsMTcgQEAgc3RhdGljIGJvb2wgY2Fu Q2FjaGVGcmFtZShGcmFtZSYgZnJhbWUsIERpYWdub3N0aWNMb2dnaW5nQ2xpZW50JiBkaWFnbm9z dGljTG9nZ2kKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIAorICAgIGlmICghZnJhbWUu ZG9jdW1lbnQoKSkgeworICAgICAgICBQQ0xPRygiICAgLUZyYW1lIGhhcyBubyBkb2N1bWVudCIp OworICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCisgICAgaWYgKCFmcmFtZS5kb2N1bWVu dCgpLT5mcmFtZSgpKSB7CisgICAgICAgIFBDTE9HKCIgICAtRG9jdW1lbnQgaXMgZGV0YWNoZWQg ZnJvbSBmcmFtZSIpOworICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIH0KKwogICAgIERvY3VtZW50TG9hZGVyKiBkb2N1bWVudExvYWRlciA9 IGZyYW1lTG9hZGVyLmRvY3VtZW50TG9hZGVyKCk7CiAgICAgaWYgKCFkb2N1bWVudExvYWRlcikg ewogICAgICAgICBQQ0xPRygiICAgLVRoZXJlIGlzIG5vIERvY3VtZW50TG9hZGVyIG9iamVjdCIp OwpAQCAtNDQ1LDYgKzQ1Niw4IEBAIGJvb2wgUGFnZUNhY2hlOjphZGRJZkNhY2hlYWJsZShIaXN0 b3J5SXRlbSYgaXRlbSwgUGFnZSogcGFnZSkKICAgICAvLyBGaXJlIHRoZSBwYWdlaGlkZSBldmVu dCBpbiBhbGwgZnJhbWVzLgogICAgIGZpcmVQYWdlSGlkZUV2ZW50UmVjdXJzaXZlbHkocGFnZS0+ bWFpbkZyYW1lKCkpOwogCisgICAgZGVzdHJveVJlbmRlclRyZWUocGFnZS0+bWFpbkZyYW1lKCkp OworCiAgICAgLy8gQ2hlY2sgdGhhdCB0aGUgcGFnZSBpcyBzdGlsbCBwYWdlLWNhY2hlYWJsZSBh ZnRlciBmaXJpbmcgdGhlIHBhZ2VoaWRlIGV2ZW50LiBUaGUgSlMgZXZlbnQgaGFuZGxlcnMKICAg ICAvLyBjb3VsZCBoYXZlIGFsdGVyZWQgdGhlIHBhZ2UgaW4gYSB3YXkgdGhhdCBjb3VsZCBwcmV2 ZW50IGNhY2hpbmcuCiAgICAgaWYgKCFjYW5DYWNoZSgqcGFnZSkpIHsKQEAgLTQ1Miw4ICs0NjUs NiBAQCBib29sIFBhZ2VDYWNoZTo6YWRkSWZDYWNoZWFibGUoSGlzdG9yeUl0ZW0mIGl0ZW0sIFBh Z2UqIHBhZ2UpCiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICB9CiAKLSAgICBkZXN0cm95UmVu ZGVyVHJlZShwYWdlLT5tYWluRnJhbWUoKSk7Ci0KICAgICBzZXRQYWdlQ2FjaGVTdGF0ZSgqcGFn ZSwgRG9jdW1lbnQ6OkluUGFnZUNhY2hlKTsKIAogICAgIHsK