198618 2019-06-06 12:02:04 -0700 [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with non-default port number 2019-06-06 12:28:18 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Local Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates bfulgham dino jer.noble simon.fraser webkit-bug-importer oldest_to_newest 1542508 0 dbates 2019-06-06 12:02:04 -0700 When debugging a document whose URL contains a non-default port (e.g. example.com:8800) the LLDB pretty-printer died with the following trace: Traceback (most recent call last): File "/Volumes/Data/.../Tools/lldb/lldb_webkit.py", line 231, in WebCoreSecurityOrigin_SummaryProvider return '{ %s, domain = %s, hasUniversalAccess = %d }' % (provider.to_string(), provider.domain(), provider.has_universal_access()) File "/Volumes/Data/.../Tools/lldb/lldb_webkit.py", line 694, in to_string result += ':' + port TypeError: cannot concatenate 'str' and 'int' objects 1542511 1 371518 dbates 2019-06-06 12:05:10 -0700 Created attachment 371518 Patch 1542512 2 dbates 2019-06-06 12:06:05 -0700 Cannot write a test for this without building WebCore every time you run test-webkitpy. We need to land bug #187916 to be able to write such tests. 1542518 3 371518 bfulgham 2019-06-06 12:13:01 -0700 Comment on attachment 371518 Patch Perl wouldn't make you do these manual type conversions! :-) r=me 1542523 4 dbates 2019-06-06 12:24:50 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 371518 [details] > Patch > > Perl wouldn't make you do these manual type conversions! :-) r=me I know!!! <-- That's why I like Perl so much 😀 1542526 5 dbates 2019-06-06 12:27:19 -0700 Committed r246164: <https://trac.webkit.org/changeset/246164> 1542527 6 webkit-bug-importer 2019-06-06 12:28:18 -0700 <rdar://problem/51494693> 371518 2019-06-06 12:05:10 -0700 2019-06-06 12:13:01 -0700 Patch bug-198618-20190606120509.patch text/plain 1631 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDY5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDZiM2RjMjc5YjBiOGQwY2ViZmQ2NzRjNDRlMjE0ZmZi NmQ2NjE1MS4uNmU5YWFkZTU0YzBkNTAzN2NiMzk1NzQ4ZjcwYzQzN2NiMWYxMjJhZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE5LTA2LTA2ICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbbGxkYi13ZWJraXRdIFR5cGVFcnJvcjogY2Fubm90IGNvbmNhdGVuYXRlICdzdHInIGFu ZCAnaW50JyBvYmplY3RzIHdoZW4gcHJldHRpZnkgVVJMIHdpdGggcG9ydCBudW1iZXIKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODYxOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlYkNvcmVTZWN1cml0 eU9yaWdpblByb3ZpZGVyLnBvcnQoKSByZXR1cm5zIGEgaW50IGRhdGEgdHlwZS4gV2UgbmVlZCB0 byBleHBsaWNpdGx5IGNvbnZlcnQgdGhpcyB0bworICAgICAgICBhIHN0cmluZyBiZWZvcmUgd2Ug Y29uY2F0ZW5hdGUgaXQgd2l0aCBhbm90aGVyIHN0cmluZyB3aGVuIGJ1aWxkaW5nIHRoZSBzdHJp bmcgcmVwcmVzZW50YXRpb24KKyAgICAgICAgZm9yIHRoZSBXZWJDb3JlOjpTZWN1cml0eU9yaWdp biBvYmplY3QuIE90aGVyd2lzZSwgUHl0aG9uIGNvbXBsYWlucyB0aGF0IHdlIGFyZSBjb25jYXRl bmF0aW5nIGEgc3RyCisgICAgICAgIHdpdGggYW4gaW50IGFuZCB3ZSBkb24ndCBnZXQgYSBwcmV0 dHktcHJpbnRlZCByZXByZXNlbnRhdGlvbiBmb3IgV2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4uCisK KyAgICAgICAgKiBsbGRiL2xsZGJfd2Via2l0LnB5OgorICAgICAgICAoV2ViQ29yZVNlY3VyaXR5 T3JpZ2luUHJvdmlkZXIudG9fc3RyaW5nKTogQ2FsbCBzdHIoKSBvbiB0aGUgcG9ydCBiZWZvcmUg Y29uY2F0ZW50aW5nIGl0LgorCiAyMDE5LTA2LTA0ICBaYW4gRG9iZXJzZWsgIDx6ZG9iZXJzZWtA aWdhbGlhLmNvbT4KIAogICAgICAgICBbbWlzY10gUmVtb3ZlIEpTQ09ubHkgQVJNdjcgVHJhZGl0 aW9uYWwgYm90CmRpZmYgLS1naXQgYS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5IGIvVG9vbHMv bGxkYi9sbGRiX3dlYmtpdC5weQppbmRleCA5OWJmODg1NjhiZmQ4Y2NlYzJiYmM5ZmZmMTMyNGQ5 NzE1YjljZTEyLi41ZWIyZDg4YWFiMzZhNzQ1OGE4NmZjYzQ3YmIyYjM0YzJmZDBmM2IzIDEwMDY0 NAotLS0gYS9Ub29scy9sbGRiL2xsZGJfd2Via2l0LnB5CisrKyBiL1Rvb2xzL2xsZGIvbGxkYl93 ZWJraXQucHkKQEAgLTY5MSw3ICs2OTEsNyBAQCBjbGFzcyBXZWJDb3JlU2VjdXJpdHlPcmlnaW5Q cm92aWRlcjoKICAgICAgICAgICAgIHJldHVybiAnZmlsZTovLycKICAgICAgICAgcmVzdWx0ID0g J3t9Oi8ve30nLmZvcm1hdChzY2hlbWUsIGhvc3QpCiAgICAgICAgIGlmIHBvcnQ6Ci0gICAgICAg ICAgICByZXN1bHQgKz0gJzonICsgcG9ydAorICAgICAgICAgICAgcmVzdWx0ICs9ICc6JyArIHN0 cihwb3J0KQogICAgICAgICByZXR1cm4gcmVzdWx0CiAKIAo=