<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>198605</bug_id>
          
          <creation_ts>2019-06-06 04:02:41 -0700</creation_ts>
          <short_desc>check-webkit-style reports false positive whitespace in multiline macro comment</short_desc>
          <delta_ts>2019-06-12 03:09:29 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paulo Matos">pmatos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>pnormand</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1542346</commentid>
    <comment_count>0</comment_count>
    <who name="Paulo Matos">pmatos</who>
    <bug_when>2019-06-06 04:02:41 -0700</bug_when>
    <thetext>With multiline macro comments such as:

```
#define FOR_EACH_FP_REGISTER(m)                 \
    /* Parameter/result registers. */           \
    macro(m, n(q0), 0, 0) 
```

check-webkit-style generates a &apos;Weird number of spaces at line-start&apos; even though the whole macro /body/, including comment, is indented properly (4 spaces).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543292</commentid>
    <comment_count>1</comment_count>
    <who name="Philippe Normand">pnormand</who>
    <bug_when>2019-06-10 04:29:20 -0700</bug_when>
    <thetext>Can you try again, with a single space before every backslash?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1544013</commentid>
    <comment_count>2</comment_count>
    <who name="Paulo Matos">pmatos</who>
    <bug_when>2019-06-12 02:56:00 -0700</bug_when>
    <thetext>(In reply to Philippe Normand from comment #1)
&gt; Can you try again, with a single space before every backslash?

You mean like this:

#define FOR_EACH_GP_REGISTER(macro)                             \
    /* Parameter/result registers. */ \
    macro_forward(macro, n(x0), 0, 0)                           \
    macro_forward(macro, n(x1), 0, 0)

Doesn&apos;t work either. Getting:
ERROR: Source/JavaScriptCore/assembler/ARM64Registers.h:52:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1544017</commentid>
    <comment_count>3</comment_count>
    <who name="Paulo Matos">pmatos</who>
    <bug_when>2019-06-12 03:09:29 -0700</bug_when>
    <thetext>For _every_ backslash as in:
#define FOO \
    /* test */ \
    macro_forward(foo) \
    macro_forward(bar)

doesn&apos;t work either.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>