198563 2019-06-05 05:49:55 -0700 [JSCOnly] JSCOnly port is not building on macOS 2019-06-06 01:59:21 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima benjamin cdumez cmarcelo commit-queue dbates don.olmstead ews-watchlist mcatanzaro webkit-bug-importer oldest_to_newest 1541950 0 ticaiolima 2019-06-05 05:49:55 -0700 After https://trac.webkit.org/changeset/245492, build JSCOnly port on mac results in the following build error: ``` CMake Error at Source/cmake/OptionsJSCOnly.cmake:102 (include): include could not find load file: target/icu.cmake Call Stack (most recent call first): Source/cmake/WebKitCommon.cmake:56 (include) CMakeLists.txt:168 (include) -- Platform-specific CMakeLists not found: /Source/webkit/Source/bmalloc/PlatformJSCOnly.cmake -- Using platform-specific CMakeLists: /Source/webkit/Source/WTF/wtf/PlatformJSCOnly.cmake CMake Error at Source/WTF/CMakeLists.txt:10 (file): file COPY given no DESTINATION ``` 1542168 1 don.olmstead 2019-06-05 14:13:25 -0700 Maybe fixed in https://bugs.webkit.org/show_bug.cgi?id=197132 ? 1542194 2 ticaiolima 2019-06-05 15:44:27 -0700 (In reply to Don Olmstead from comment #1) > Maybe fixed in https://bugs.webkit.org/show_bug.cgi?id=197132 ? It does, indeed. Thx! I just found another issue but I have a patch already. 1542204 3 371444 ticaiolima 2019-06-05 16:01:10 -0700 Created attachment 371444 Patch 1542205 4 ticaiolima 2019-06-05 16:03:04 -0700 Current failure is: ``` FAILED: Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DBUILDING_JSCONLY__ -DBUILDING_WITH_CMAKE=1 -DBUILDING_WTF -DHAVE_CONFIG_H=1 -DU_DISABLE_RENAMING=1 -DU_SHOW_CPLUSPLUS_API=0 -I. -IDerivedSources -I../../Source/ThirdParty -IDerivedSources/WTF -I../../Source/WTF -I../../Source/WTF/wtf -I../../Source/WTF/wtf/dtoa -I../../Source/WTF/wtf/persistence -I../../Source/WTF/wtf/text -I../../Source/WTF/wtf/text/icu -I../../Source/WTF/wtf/threads -I../../Source/WTF/wtf/unicode -IDerivedSources/ForwardingHeaders -isystem ICU/Headers -fdiagnostics-color=always -fcolor-diagnostics -Wextra -Wall -Wno-parentheses-equality -Wno-noexcept-type -Qunused-arguments -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk -fPIC -MD -MT Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o -MF Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o.d -o Source/WTF/wtf/CMakeFiles/WTF.dir/WTFAssertions.cpp.o -c ../../Source/WTF/wtf/WTFAssertions.cpp ../../Source/WTF/wtf/WTFAssertions.cpp:52:15: error: use of undeclared identifier 'mach_vm_offset_t' static_assert(MACH_VM_MAX_ADDRESS <= ((1ULL << WTF_CPU_EFFECTIVE_ADDRESS_WIDTH) - 1)); ^ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/mach/i386/vm_param.h:161:43: note: expanded from macro 'MACH_VM_MAX_ADDRESS' #define MACH_VM_MAX_ADDRESS ((mach_vm_offset_t) VM_MAX_PAGE_ADDRESS) ``` 1542326 5 ticaiolima 2019-06-06 01:28:47 -0700 Thx for the review! 1542328 6 371444 commit-queue 2019-06-06 01:58:10 -0700 Comment on attachment 371444 Patch Clearing flags on attachment: 371444 Committed r246146: <https://trac.webkit.org/changeset/246146> 1542329 7 commit-queue 2019-06-06 01:58:12 -0700 All reviewed patches have been landed. Closing bug. 1542330 8 webkit-bug-importer 2019-06-06 01:59:21 -0700 <rdar://problem/51474999> 371444 2019-06-05 16:01:10 -0700 2019-06-06 01:58:10 -0700 Patch bug-198563-20190606010109.patch text/plain 1074 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDcxNDdiMmFjYmQ5OTFhZjliYTdlZjk2 YTA2NGFiZGYzYzFlYjYxODEuLjI4N2Q2NDIwMDE3Mzg0NWM5MDA0NjA2YmNhYjYyNDk5MDE2OWJk ZDYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDYtMDUgIENhaW8gTGltYSAgPHRpY2Fpb2xp bWFAZ21haWwuY29tPgorCisgICAgICAgIFtKU0NPbmx5XSBKU0NPbmx5IHBvcnQgaXMgbm90IGJ1 aWxkaW5nIG9uIG1hY09TCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xOTg1NjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBXZSBhcmUgYWRkaW5nIGA8bWFjaC92bV90eXBlcy5oPmAgdG8gZml4IGJ1aWxkIGlz c3VlcyB3aGVuIGNvbXBpbGluZworICAgICAgICBKU0NPbmx5IHBvcnQgb24gbWFjT1MuCisKKyAg ICAgICAgKiB3dGYvV1RGQXNzZXJ0aW9ucy5jcHA6CisKIDIwMTktMDYtMDMgIENvbW1pdCBRdWV1 ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIyNDYwMjIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9XVEZBc3NlcnRpb25z LmNwcCBiL1NvdXJjZS9XVEYvd3RmL1dURkFzc2VydGlvbnMuY3BwCmluZGV4IGM0YTJhYTM5ZjI4 NTA0NzBjNGE0MzczY2FhZDFkMmJhZGIyZjZkYjEuLmExN2I3YzNhM2JjNjA1ZDM4ZTI5ZmRkNjI5 ZmM1MmVlZWQwNjA0MDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1dURkFzc2VydGlvbnMu Y3BwCisrKyBiL1NvdXJjZS9XVEYvd3RmL1dURkFzc2VydGlvbnMuY3BwCkBAIC0zMiw2ICszMiw3 IEBACiAKICNpZiBPUyhEQVJXSU4pCiAjaW5jbHVkZSA8bWFjaC92bV9wYXJhbS5oPgorI2luY2x1 ZGUgPG1hY2gvdm1fdHlwZXMuaD4KICNlbmRpZgogCiBuYW1lc3BhY2UgV1RGIHsK