198435 2019-05-31 14:03:44 -0700 Layout test landed flaky in 245873 [ Release ] http/wpt/service-workers/service-worker-networkprocess-crash.html is a flaky failure 2019-06-05 15:42:02 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198434 https://bugs.webkit.org/show_bug.cgi?id=198584 InRadar P2 Normal --- 1 sroberts youennf achristensen cdumez commit-queue ggaren jlewis3 ryanhaddad tsavell webkit-bug-importer youennf oldest_to_newest 1540835 0 sroberts 2019-05-31 14:03:44 -0700 The following layout test is flaky on Mac WK2 and iOS Simulator Release builds http/wpt/service-workers/service-worker-networkprocess-crash.html Probable cause: New test added in r245873 is a flaky failure on Release builds. When run in Debug will get a flaky assertion, or cause other tests to assert. see https://bugs.webkit.org/show_bug.cgi?id=198434 run-webkit-tests http/wpt/service-workers/service-worker-networkprocess-crash.html --iter 100 -f --exit-after-n-failures=2 Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fservice-worker-networkprocess-crash.html Diff: --- /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/service-worker-networkprocess-crash-expected.txt +++ /Volumes/Data/slave/ios-simulator-12-release-tests-wk2/build/layout-test-results/http/wpt/service-workers/service-worker-networkprocess-crash-actual.txt @@ -1,5 +1,6 @@ + PASS Setup worker PASS Frame being controlled -PASS Frame being controlled after network process crash +FAIL Frame being controlled after network process crash assert_not_equals: got disallowed value null 1540836 1 webkit-bug-importer 2019-05-31 14:04:15 -0700 <rdar://problem/51314295> 1540896 2 371098 youennf 2019-05-31 16:48:37 -0700 Created attachment 371098 Patch 1541763 3 youennf 2019-06-04 15:54:30 -0700 ping review 1541791 4 ggaren 2019-06-04 16:50:07 -0700 r=me > LayoutTests/http/wpt/service-workers/service-worker-networkprocess-crash.html:59 > + let count = 0; > + while (count++ < 20) { > + const frame = await withFrame(scope + "/empty.html"); > + if (frame.contentWindow.navigator.serviceWorker.controller) > + break; > + frame.remove(); > + await new Promise(resolve => setTimeout(resolve, 50)); > + } > + assert_true(count < 20); Seems like it would be nicer to load the frame only once and then check repeatedly that it eventually gets a service worker. The way this test is written, the frame might never get a service worker, and the test wouldn't notice. 1541798 5 371098 commit-queue 2019-06-04 17:11:16 -0700 Comment on attachment 371098 Patch Clearing flags on attachment: 371098 Committed r246089: <https://trac.webkit.org/changeset/246089> 1541799 6 commit-queue 2019-06-04 17:11:17 -0700 All reviewed patches have been landed. Closing bug. 1542077 7 youennf 2019-06-05 10:47:12 -0700 > Seems like it would be nicer to load the frame only once and then check > repeatedly that it eventually gets a service worker. The way this test is > written, the frame might never get a service worker, and the test wouldn't > notice. There is an inherent race condition between terminating the network process in UIProcess and detecting network process crash on web process based on IPC connection being closed. The flakiness here is due to the fact that webprocess checks for a matching registration, then is informed the network process crashes and continues the load as if there is no service worker. We could probably try to make it work in the future. 1542119 8 youennf 2019-06-05 12:38:20 -0700 Dashboard still shows some flakiness. 1542186 9 youennf 2019-06-05 15:03:49 -0700 (In reply to youenn fablet from comment #8) > Dashboard still shows some flakiness. Network process maybe be crashing before the SW SQL database is written on disk. On restart, there is no service worker. I'll fix it. 1542193 10 youennf 2019-06-05 15:41:57 -0700 (In reply to youenn fablet from comment #9) > (In reply to youenn fablet from comment #8) > > Dashboard still shows some flakiness. > > Network process maybe be crashing before the SW SQL database is written on > disk. > On restart, there is no service worker. > I'll fix it. Filed bug 198584 371098 2019-05-31 16:48:37 -0700 2019-06-04 17:11:16 -0700 Patch bug-198435-20190531164836.patch text/plain 2717 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODQ5CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZTg4Mjg1MGM4N2RlMThmN2Y1NGE4 ZDg2YTRlNmMwZGI2MDI3MThiYS4uNmI5NzIwM2QwZDk3MjljNGEwYzY1ZTMxMTY4ZWZhYWFiZTg4 NTUzMiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTMxICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBMYXlvdXQgdGVzdCBsYW5kZWQgZmxha3kgaW4g MjQ1ODczIFsgUmVsZWFzZSBdIGh0dHAvd3B0L3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtl ci1uZXR3b3JrcHJvY2Vzcy1jcmFzaC5odG1sIGlzIGEgZmxha3kgZmFpbHVyZQorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4NDM1CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS81MTMxNDI5NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBNYWtlIHRoZSB0ZXN0IG1vcmUgcm9idXN0IGJ5IHJldHJ5aW5nIHRo ZSBudWxsIHRlc3QgbW9yZSB0aGFuIG9uY2UuCisKKyAgICAgICAgKiBodHRwL3dwdC9zZXJ2aWNl LXdvcmtlcnMvc2VydmljZS13b3JrZXItbmV0d29ya3Byb2Nlc3MtY3Jhc2gtZXhwZWN0ZWQudHh0 OgorICAgICAgICAqIGh0dHAvd3B0L3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNlLXdvcmtlci1uZXR3 b3JrcHJvY2Vzcy1jcmFzaC5odG1sOgorCiAyMDE5LTA1LTMxICBZb3Vlbm4gRmFibGV0ICA8eW91 ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBBbGxvdyByZXNpemluZyBvZiBjYW1lcmEgdmlkZW8g ZmVlZHMgdG8gdmVyeSBzbWFsbCByZXNvbHV0aW9ucwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv aHR0cC93cHQvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyLW5ldHdvcmtwcm9jZXNzLWNy YXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2h0dHAvd3B0L3NlcnZpY2Utd29ya2Vycy9z ZXJ2aWNlLXdvcmtlci1uZXR3b3JrcHJvY2Vzcy1jcmFzaC1leHBlY3RlZC50eHQKaW5kZXggMTJk ZWEwZmI5MWIxMDQxNmQwNDliYzYxMzI5ZGVmOTkwZDNlYmVhNi4uMmJjZmM1NWRmZmI4ZmQxZWM0 MjBmMTYyOGQ0OWM5MmMyZjAwZjQ4ZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC93cHQv c2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyLW5ldHdvcmtwcm9jZXNzLWNyYXNoLWV4cGVj dGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3dwdC9zZXJ2aWNlLXdvcmtlcnMvc2Vydmlj ZS13b3JrZXItbmV0d29ya3Byb2Nlc3MtY3Jhc2gtZXhwZWN0ZWQudHh0CkBAIC0xLDQgKzEsNSBA QAogCisKIFBBU1MgU2V0dXAgd29ya2VyIAogUEFTUyBGcmFtZSBiZWluZyBjb250cm9sbGVkIAog UEFTUyBGcmFtZSBiZWluZyBjb250cm9sbGVkIGFmdGVyIG5ldHdvcmsgcHJvY2VzcyBjcmFzaCAK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvd3B0L3NlcnZpY2Utd29ya2Vycy9zZXJ2aWNl LXdvcmtlci1uZXR3b3JrcHJvY2Vzcy1jcmFzaC5odG1sIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQv c2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyLW5ldHdvcmtwcm9jZXNzLWNyYXNoLmh0bWwK aW5kZXggODA0MjBjMmVlMDQ3ODEwZmU1MTAxYTIwMWJhNzZjOGYzZDVhOGI4Ni4uOWMyOTJiYjlj MzNjYmNiOTA3MTgxNGMzNjUzOGI1ODczNWRmYTNhNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aHR0cC93cHQvc2VydmljZS13b3JrZXJzL3NlcnZpY2Utd29ya2VyLW5ldHdvcmtwcm9jZXNzLWNy YXNoLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC93cHQvc2VydmljZS13b3JrZXJzL3NlcnZp Y2Utd29ya2VyLW5ldHdvcmtwcm9jZXNzLWNyYXNoLmh0bWwKQEAgLTQ4LDkgKzQ4LDE1IEBAIHBy b21pc2VfdGVzdChhc3luYyAodGVzdCkgPT4gewogICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lciAm JiB3aW5kb3cudGVzdFJ1bm5lci50ZXJtaW5hdGVOZXR3b3JrUHJvY2VzcykKICAgICAgICAgdGVz dFJ1bm5lci50ZXJtaW5hdGVOZXR3b3JrUHJvY2VzcygpOwogCi0gICAgY29uc3QgZnJhbWUgPSBh d2FpdCB3aXRoRnJhbWUoc2NvcGUgKyAiL2VtcHR5Lmh0bWwiKTsKLSAgICBhc3NlcnRfbm90X2Vx dWFscyhmcmFtZS5jb250ZW50V2luZG93Lm5hdmlnYXRvci5zZXJ2aWNlV29ya2VyLmNvbnRyb2xs ZXIsIG51bGwpOwotICAgIGZyYW1lLnJlbW92ZSgpOworICAgIGxldCBjb3VudCA9IDA7CisgICAg d2hpbGUgKGNvdW50KysgPCAyMCkgeworICAgICAgICBjb25zdCBmcmFtZSA9IGF3YWl0IHdpdGhG cmFtZShzY29wZSArICIvZW1wdHkuaHRtbCIpOworICAgICAgICBpZiAoZnJhbWUuY29udGVudFdp bmRvdy5uYXZpZ2F0b3Iuc2VydmljZVdvcmtlci5jb250cm9sbGVyKQorICAgICAgICAgICAgYnJl YWs7CisgICAgICAgIGZyYW1lLnJlbW92ZSgpOworICAgICAgICBhd2FpdCBuZXcgUHJvbWlzZShy ZXNvbHZlID0+IHNldFRpbWVvdXQocmVzb2x2ZSwgNTApKTsKKyAgICB9CisgICAgYXNzZXJ0X3Ry dWUoY291bnQgPCAyMCk7CiB9LCAiRnJhbWUgYmVpbmcgY29udHJvbGxlZCBhZnRlciBuZXR3b3Jr IHByb2Nlc3MgY3Jhc2giKTsKIDwvc2NyaXB0PgogPC9ib2R5Pgo=