198434 2019-05-31 13:54:09 -0700 REGRESSION (r245913) [ Debug ] ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash 2019-06-04 09:11:46 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198379 https://bugs.webkit.org/show_bug.cgi?id=198435 InRadar P2 Normal --- 1 sroberts youennf achristensen cdumez commit-queue jlewis3 ryanhaddad tsavell webkit-bug-importer youennf oldest_to_newest 1540825 0 sroberts 2019-05-31 13:54:09 -0700 The following layout test is flaky on Mac WK2 iOS Simulator Debug http/wpt/service-workers/update-service-worker.https.html Probable cause: Test originally started crashing after r245873 and affected all testers Release and Debug. After r245913 (which fixed release builds) it is crashing with a different Assertion just on Debug builds. I cannot reproduce it on Release builds. The way to reproduce the failure remains the same. run-webkit-tests http/wpt/service-workers/service-worker-networkprocess-crash.html http/wpt/service-workers/update-service-worker.https.html --child-process 1 --iter 50 --exit-after-n-crashes=1 --ios-simulator --debug Usually crashes within 5 runs. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fupdate-service-worker.https.html https://build.webkit.org/results/Apple%20iOS%2012%20Simulator%20Debug%20WK2%20(Tests)/r245973%20(3961)/http/wpt/service-workers/update-service-worker.https-stderr.txt ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) /Volumes/Data/worker/trunk-peacee-ios-sim-debug-archive/build/OpenSource/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp(270) : void WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection &) 1 0x5a321c659 WTFCrash 2 0x101d9783b WTFCrashWithInfo(int, char const*, char const*, int) 3 0x102cc5165 WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection&) 4 0x102d2eab3 WebKit::WebSWClientConnection::~WebSWClientConnection() 5 0x102d2ec05 WebKit::WebSWClientConnection::~WebSWClientConnection() 6 0x102d2ec69 WebKit::WebSWClientConnection::~WebSWClientConnection() 1540827 1 webkit-bug-importer 2019-05-31 13:54:48 -0700 <rdar://problem/51313917> 1540882 2 371094 youennf 2019-05-31 16:15:29 -0700 Created attachment 371094 Patch 1541354 3 371094 achristensen 2019-06-03 15:10:27 -0700 Comment on attachment 371094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371094&action=review > Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:198 > + auto connections = WTFMove(m_swConnectionsByIdentifier); This feels like more of a std::exchange kind of use. 1541357 4 sroberts 2019-06-03 15:14:06 -0700 The bots are hitting this Assertion, and I think it might be related. ietestcenter/css3/grid/grid-column-002.htm is crashing on the testers now. Running the test by itself I cannot reproduce, running with a test list now to see what test is triggering it. https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=%20ietestcenter%2Fcss3%2Fgrid%2Fgrid-column-002.htm https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r246043%20(2865)/ietestcenter/css3/grid/grid-column-002-crash-log.txt ASSERTION FAILED: m_swConnectionsByIdentifier.contains(connection.serverConnectionIdentifier()) /Volumes/Data/slave/mojave-debug/build/Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp(270) : void WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection &) 1 0x531230759 WTFCrash 2 0x10d9159bb WTFCrashWithInfo(int, char const*, char const*, int) 3 0x10e9e6785 WebKit::NetworkProcessConnection::removeSWClientConnection(WebKit::WebSWClientConnection&) 4 0x10ea6a913 WebKit::WebSWClientConnection::~WebSWClientConnection() 5 0x10ea6aa65 WebKit::WebSWClientConnection::~WebSWClientConnection() 6 0x10ea6aac9 WebKit::WebSWClientConnection::~WebSWClientConnection() 1541444 5 371094 youennf 2019-06-03 21:42:18 -0700 Comment on attachment 371094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371094&action=review >> Source/WebKit/WebProcess/Network/NetworkProcessConnection.cpp:198 >> + auto connections = WTFMove(m_swConnectionsByIdentifier); > > This feels like more of a std::exchange kind of use. The containers are implemented with this ability in mind, so std::exchange does not bring any benefit. I see a slight benefit in WTFMove in terms of readability, less character and this pattern is used in many places, more than std::exchange. 1541447 6 371244 youennf 2019-06-03 21:45:56 -0700 Created attachment 371244 Patch for landing 1541600 7 371244 commit-queue 2019-06-04 09:11:44 -0700 Comment on attachment 371244 Patch for landing Clearing flags on attachment: 371244 Committed r246068: <https://trac.webkit.org/changeset/246068> 1541601 8 commit-queue 2019-06-04 09:11:46 -0700 All reviewed patches have been landed. Closing bug. 371094 2019-05-31 16:15:29 -0700 2019-06-03 21:45:54 -0700 Patch bug-198434-20190531161528.patch text/plain 1898 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDYxZjY1NTljODNjYjFmYzM0 MzNiNzM5NTgyNGY3ZGUzMWRhZTBlZmYuLjNhMzU3NzdmYTAxMWU3NWVmZjA2Yzk1ZTZhZTNjYTRj NjY2NDM4NTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTktMDUtMzEgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDU5MTMp IFsgRGVidWcgXSBBU1NFUlRJT04gRkFJTEVEOiBtX3N3Q29ubmVjdGlvbnNCeUlkZW50aWZpZXIu Y29udGFpbnMoY29ubmVjdGlvbi5zZXJ2ZXJDb25uZWN0aW9uSWRlbnRpZmllcigpKSBMYXlvdXQg VGVzdCBodHRwL3dwdC9zZXJ2aWNlLXdvcmtlcnMvdXBkYXRlLXNlcnZpY2Utd29ya2VyLmh0dHBz Lmh0bWwgaXMgYSBmbGFreSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk4NDM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTMxMzkxNz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdGVyYXRl IHRocm91Z2ggdGhlIGNvbm5lY3Rpb25JRC1iYXNlZCBjb25uZWN0aW9uIG1hcCBpbnN0ZWFkIG9m IHRoZSBzZXNzaW9uSUQtYmFzZWQgbWFwCisgICAgICAgIHRvIG5vdGlmeSB0aGVtIHRoZWlyIGNv bm5lY3Rpb24gaXMgbG9zdC4KKworICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9OZXR3b3Jr UHJvY2Vzc0Nvbm5lY3Rpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzc0Nv bm5lY3Rpb246OmRpZENsb3NlKToKKwogMjAxOS0wNS0zMCAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjI0NTg3MykgW01hYyBXSzJdIExh eW91dCBUZXN0IGh0dHAvd3B0L3NlcnZpY2Utd29ya2Vycy91cGRhdGUtc2VydmljZS13b3JrZXIu aHR0cHMuaHRtbCBpcyBhIGZsYWt5IGNyYXNoIGFmdGVyIHJ1bm5pbmcgbmV3IHRlc3QKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzQ29u bmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJv Y2Vzc0Nvbm5lY3Rpb24uY3BwCmluZGV4IDE2MWY4ZGE0MWZhODZlNjExZmQ5NDMxMDdkZmU2ZjYz NjQwYzNlMmUuLjYxOWVhNDU3NTE1YTAyZTI1NDUyYjAzNDhhN2NiZGQ2YzM3MjYyYzAgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzQ29u bmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvTmV0d29y a1Byb2Nlc3NDb25uZWN0aW9uLmNwcApAQCAtMTk1LDggKzE5NSw4IEBAIHZvaWQgTmV0d29ya1By b2Nlc3NDb25uZWN0aW9uOjpkaWRDbG9zZShJUEM6OkNvbm5lY3Rpb24mKQogI2VuZGlmCiAKICNp ZiBFTkFCTEUoU0VSVklDRV9XT1JLRVIpCi0gICAgbV9zd0Nvbm5lY3Rpb25zQnlJZGVudGlmaWVy LmNsZWFyKCk7Ci0gICAgZm9yIChhdXRvJiBjb25uZWN0aW9uIDogbV9zd0Nvbm5lY3Rpb25zQnlT ZXNzaW9uLnZhbHVlcygpKQorICAgIGF1dG8gY29ubmVjdGlvbnMgPSBXVEZNb3ZlKG1fc3dDb25u ZWN0aW9uc0J5SWRlbnRpZmllcik7CisgICAgZm9yIChhdXRvJiBjb25uZWN0aW9uIDogY29ubmVj dGlvbnMudmFsdWVzKCkpCiAgICAgICAgIGNvbm5lY3Rpb24tPmNvbm5lY3Rpb25Ub1NlcnZlckxv c3QoKTsKICNlbmRpZgogfQo= 371244 2019-06-03 21:45:56 -0700 2019-06-04 09:11:44 -0700 Patch for landing bug-198434-20190603214555.patch text/plain 1829 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MDM0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDg5NGYzN2Q5ZDMwYjQ1YzRl ZGEzN2NhZjYwYWU3YmRjY2E1OTYwYzIuLjIwNWE5Yzk5MGFjN2ExNGM1OTJhNDAzYWJhNDk4NDNi ODQ4ZDRlYzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTktMDYtMDMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDU5MTMp IFsgRGVidWcgXSBBU1NFUlRJT04gRkFJTEVEOiBtX3N3Q29ubmVjdGlvbnNCeUlkZW50aWZpZXIu Y29udGFpbnMoY29ubmVjdGlvbi5zZXJ2ZXJDb25uZWN0aW9uSWRlbnRpZmllcigpKSBMYXlvdXQg VGVzdCBodHRwL3dwdC9zZXJ2aWNlLXdvcmtlcnMvdXBkYXRlLXNlcnZpY2Utd29ya2VyLmh0dHBz Lmh0bWwgaXMgYSBmbGFreSBjcmFzaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTk4NDM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MTMxMzkxNz4K KworICAgICAgICBSZXZpZXdlZCBieSBBbGV4IENocmlzdGVuc2VuLgorCisgICAgICAgIEl0ZXJh dGUgdGhyb3VnaCB0aGUgY29ubmVjdGlvbklELWJhc2VkIGNvbm5lY3Rpb24gbWFwIGluc3RlYWQg b2YgdGhlIHNlc3Npb25JRC1iYXNlZCBtYXAgdG8gbm90aWZ5IHRoZW0gdGhlaXIgY29ubmVjdGlv biBpcyBsb3N0LgorCisgICAgICAgICogV2ViUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNz Q29ubmVjdGlvbi5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNzQ29ubmVjdGlv bjo6ZGlkQ2xvc2UpOgorCiAyMDE5LTA2LTAzICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KIAogICAgICAgICBnZXRVc2VyTWVkaWEgcmVxdWVzdHMgc2hvdWxkIGJlIHByb2Nlc3Nl ZCBzZXF1ZW50aWFsbHkgaW4gVUlQcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwIGIvU291cmNlL1dl YktpdC9XZWJQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uLmNwcAppbmRl eCAxNjFmOGRhNDFmYTg2ZTYxMWZkOTQzMTA3ZGZlNmY2MzY0MGMzZTJlLi4zYzZkZTM5OWI1MjVj N2Y2ZGEyMjE4M2EyN2JlNmJkZDcyNWYzMzVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dl YlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24uY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbi5jcHAK QEAgLTE5NSw4ICsxOTUsOCBAQCB2b2lkIE5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbjo6ZGlkQ2xv c2UoSVBDOjpDb25uZWN0aW9uJikKICNlbmRpZgogCiAjaWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VS KQotICAgIG1fc3dDb25uZWN0aW9uc0J5SWRlbnRpZmllci5jbGVhcigpOwotICAgIGZvciAoYXV0 byYgY29ubmVjdGlvbiA6IG1fc3dDb25uZWN0aW9uc0J5U2Vzc2lvbi52YWx1ZXMoKSkKKyAgICBh dXRvIGNvbm5lY3Rpb25zID0gc3RkOjpleGNoYW5nZShtX3N3Q29ubmVjdGlvbnNCeUlkZW50aWZp ZXIsIHsgfSk7CisgICAgZm9yIChhdXRvJiBjb25uZWN0aW9uIDogY29ubmVjdGlvbnMudmFsdWVz KCkpCiAgICAgICAgIGNvbm5lY3Rpb24tPmNvbm5lY3Rpb25Ub1NlcnZlckxvc3QoKTsKICNlbmRp ZgogfQo=