198418 2019-05-31 05:28:24 -0700 REGRESSION(r244182): [CoordinatedGraphics] Related view doesn't receive graphic updates 2019-06-03 01:07:12 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=177484 Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply magomez zan oldest_to_newest 1540696 0 cgarcia 2019-05-31 05:28:24 -0700 This is because we need a DisplayRefreshMonitor per drawing area, but the one from the first ThreradedCompositor is always reused because they use the same display ID. 1540697 1 371051 cgarcia 2019-05-31 05:32:38 -0700 Created attachment 371051 Patch 1540704 2 371051 zan 2019-05-31 06:17:52 -0700 Comment on attachment 371051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=371051&action=review > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:549 > + m_webPage.windowScreenDidChange(std::numeric_limits<uint32_t>::max() - m_webPage.pageID().toUInt64()); If you can find a better way to make that page ID into a 32-bit, then go ahead. 1540705 3 cgarcia 2019-05-31 06:23:53 -0700 (In reply to Zan Dobersek from comment #2) > Comment on attachment 371051 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=371051&action=review > > > Source/WebKit/WebProcess/WebPage/CoordinatedGraphics/DrawingAreaCoordinatedGraphics.cpp:549 > > + m_webPage.windowScreenDidChange(std::numeric_limits<uint32_t>::max() - m_webPage.pageID().toUInt64()); > > If you can find a better way to make that page ID into a 32-bit, then go > ahead. I'm following the same approach as mac port. 1541190 4 cgarcia 2019-06-03 01:07:12 -0700 Committed r246030: <https://trac.webkit.org/changeset/246030> 371051 2019-05-31 05:32:38 -0700 2019-05-31 06:17:52 -0700 Patch wk-coord-graphics-display-id.diff text/plain 5382 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggM2EzYTA2NjcyZGMuLmVlYTQ0ZmUxNmU0IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIxIEBACisyMDE5LTA1LTMxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIyNDQxODIpOiBbQ29vcmRpbmF0ZWRHcmFwaGlj c10gUmVsYXRlZCB2aWV3IGRvZXNuJ3QgcmVjZWl2ZSBncmFwaGljIHVwZGF0ZXMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODQxOAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYmVjYXVzZSB3 ZSBuZWVkIGEgRGlzcGxheVJlZnJlc2hNb25pdG9yIHBlciBkcmF3aW5nIGFyZWEsIGJ1dCB0aGUg b25lIGZyb20gdGhlIGZpcnN0IFRocmVyYWRlZENvbXBvc2l0b3IKKyAgICAgICAgaXMgYWx3YXlz IHJldXNlZCBiZWNhdXNlIHRoZXkgdXNlIHRoZSBzYW1lIGRpc3BsYXkgSUQuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3aW5nQXJlYUNvb3Jk aW5hdGVkR3JhcGhpY3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpEcmF3aW5nQXJlYUNvb3JkaW5h dGVkR3JhcGhpY3M6OmVudGVyQWNjZWxlcmF0ZWRDb21wb3NpdGluZ01vZGUpOiBVc2UgYSB1bmlx dWUgZGlzcGxheSBJRCBkZXJpdmVkIGZyb20KKyAgICAgICAgV2ViUGFnZSdzIElELgorICAgICAg ICAoV2ViS2l0OjpEcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3JhcGhpY3M6OmV4aXRBY2NlbGVyYXRl ZENvbXBvc2l0aW5nTW9kZSk6IFVzZSB0aGUgcHJpbWFyeSBkaXNwbGF5IElELgorICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZUhvc3QuY3Bw OgorICAgICAgICAoV2ViS2l0OjpMYXllclRyZWVIb3N0OjpMYXllclRyZWVIb3N0KTogR2V0IHRo ZSBjdXJyZW50IHdlYiBwYWdlIGRpc3BsYXkgSUQgaW5zdGVhZCBvZiBpbnZlbnRpbmcgb25lLgor ICAgICAgICAoV2ViS2l0OjpMYXllclRyZWVIb3N0OjpzZXRJc0Rpc2NhcmRhYmxlKTogRG8gbm90 IGNoYW5nZSBkaXNwbGF5IElELgorCiAyMDE5LTA1LTMxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAg PGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBXUEVSZW5kZXJlcjogZW5zdXJl IHdlIGNvbXBsZXRlIHRoZSBsYXN0IGZyYW1lIHdoZW4gbGVhdmluZyBBQyBtb2RlCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNz L0RyYXdpbmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljcy5jcHAgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0RyYXdpbmdBcmVhQ29vcmRpbmF0ZWRH cmFwaGljcy5jcHAKaW5kZXggOTBmNzRmMmZkZjMuLjA3MjAwMGU4MmMzIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGluYXRlZEdyYXBoaWNzL0RyYXdp bmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljcy5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9EcmF3aW5nQXJlYUNvb3JkaW5hdGVkR3Jh cGhpY3MuY3BwCkBAIC01NDQsNiArNTQ0LDEwIEBAIHZvaWQgRHJhd2luZ0FyZWFDb29yZGluYXRl ZEdyYXBoaWNzOjplbnRlckFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2RlKEdyYXBoaWNzTGF5CiAg ICAgbV9leGl0Q29tcG9zaXRpbmdUaW1lci5zdG9wKCk7CiAgICAgbV93YW50c1RvRXhpdEFjY2Vs ZXJhdGVkQ29tcG9zaXRpbmdNb2RlID0gZmFsc2U7CiAKKyAgICAvLyBJbiBvcmRlciB0byBlbnN1 cmUgdGhhdCB3ZSBnZXQgYSB1bmlxdWUgRGlzcGxheVJlZnJlc2hNb25pdG9yIHBlci1EcmF3aW5n QXJlYSAobmVjZXNzYXJ5IGJlY2F1c2UgVGhyZWFkZWREaXNwbGF5UmVmcmVzaE1vbml0b3IKKyAg ICAvLyBpcyBkcml2ZW4gYnkgdGhlIFRocmVhZGVkQ29tcG9zaXRvciBvZiB0aGUgZHJhd2luZyBh cmVhKSwgZ2l2ZSBlYWNoIHBhZ2UgYSB1bmlxdWUgRGlzcGxheUlEIGRlcml2ZWQgZnJvbSBXZWJQ YWdlJ3MgdW5pcXVlIElELgorICAgIG1fd2ViUGFnZS53aW5kb3dTY3JlZW5EaWRDaGFuZ2Uoc3Rk OjpudW1lcmljX2xpbWl0czx1aW50MzJfdD46Om1heCgpIC0gbV93ZWJQYWdlLnBhZ2VJRCgpLnRv VUludDY0KCkpOworCiAgICAgQVNTRVJUKCFtX2xheWVyVHJlZUhvc3QpOwogICAgIGlmIChtX3By ZXZpb3VzTGF5ZXJUcmVlSG9zdCkgewogICAgICAgICBtX2xheWVyVHJlZUhvc3QgPSBXVEZNb3Zl KG1fcHJldmlvdXNMYXllclRyZWVIb3N0KTsKQEAgLTU5Nyw2ICs2MDEsOSBAQCB2b2lkIERyYXdp bmdBcmVhQ29vcmRpbmF0ZWRHcmFwaGljczo6ZXhpdEFjY2VsZXJhdGVkQ29tcG9zaXRpbmdNb2Rl KCkKICAgICBtX3ByZXZpb3VzTGF5ZXJUcmVlSG9zdC0+c2V0TGF5ZXJGbHVzaFNjaGVkdWxpbmdF bmFibGVkKGZhbHNlKTsKICAgICBtX2Rpc2NhcmRQcmV2aW91c0xheWVyVHJlZUhvc3RUaW1lci5z dGFydE9uZVNob3QoNV9zKTsKIAorICAgIC8vIEFsd2F5cyB1c2UgdGhlIHByaW1hcnkgZGlzcGxh eSBJRCAoMCkgd2hlbiBub3QgaW4gYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcgbW9kZS4KKyAgICBt X3dlYlBhZ2Uud2luZG93U2NyZWVuRGlkQ2hhbmdlKDApOworCiAgICAgbV9kaXJ0eVJlZ2lvbiA9 IG1fd2ViUGFnZS5ib3VuZHMoKTsKIAogICAgIGlmIChtX2luVXBkYXRlQmFja2luZ1N0b3JlU3Rh dGUpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9Db29yZGlu YXRlZEdyYXBoaWNzL0xheWVyVHJlZUhvc3QuY3BwIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVIb3N0LmNwcAppbmRleCAyY2I4 MmY3YTU1Yy4uZTg5NGJkMTYxZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vz cy9XZWJQYWdlL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlSG9zdC5jcHAKKysrIGIvU291 cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRy ZWVIb3N0LmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2luY2x1ZGUgIkRyYXdpbmdBcmVhLmgiCiAj aW5jbHVkZSAiV2ViUGFnZS5oIgogI2luY2x1ZGUgIldlYlBhZ2VQcm94eU1lc3NhZ2VzLmgiCisj aW5jbHVkZSA8V2ViQ29yZS9DaHJvbWUuaD4KICNpbmNsdWRlIDxXZWJDb3JlL0ZyYW1lLmg+CiAj aW5jbHVkZSA8V2ViQ29yZS9GcmFtZVZpZXcuaD4KICNpbmNsdWRlIDxXZWJDb3JlL1BhZ2VPdmVy bGF5Q29udHJvbGxlci5oPgpAQCAtNDUsMTMgKzQ2LDYgQEAKIG5hbWVzcGFjZSBXZWJLaXQgewog dXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKLXN0YXRpYyBjb25zdCBQbGF0Zm9ybURpc3BsYXlJ RCBwcmltYXJ5RGlzcGxheUlEID0gMDsKLSNpZiBQTEFURk9STShHVEspCi1zdGF0aWMgY29uc3Qg UGxhdGZvcm1EaXNwbGF5SUQgY29tcG9zaXRpbmdEaXNwbGF5SUQgPSAxOwotI2Vsc2UKLXN0YXRp YyBjb25zdCBQbGF0Zm9ybURpc3BsYXlJRCBjb21wb3NpdGluZ0Rpc3BsYXlJRCA9IHByaW1hcnlE aXNwbGF5SUQ7Ci0jZW5kaWYKLQogTGF5ZXJUcmVlSG9zdDo6TGF5ZXJUcmVlSG9zdChXZWJQYWdl JiB3ZWJQYWdlKQogICAgIDogbV93ZWJQYWdlKHdlYlBhZ2UpCiAgICAgLCBtX2Nvb3JkaW5hdG9y KHdlYlBhZ2UuY29yZVBhZ2UoKSwgKnRoaXMpCkBAIC04MywxMiArNzcsMTAgQEAgTGF5ZXJUcmVl SG9zdDo6TGF5ZXJUcmVlSG9zdChXZWJQYWdlJiB3ZWJQYWdlKQogICAgICAgICBpZiAobV9zdXJm YWNlLT5zaG91bGRQYWludE1pcnJvcmVkKCkpCiAgICAgICAgICAgICBwYWludEZsYWdzIHw9IFRl eHR1cmVNYXBwZXI6OlBhaW50aW5nTWlycm9yZWQ7CiAKLSAgICAgICAgbV9jb21wb3NpdG9yID0g VGhyZWFkZWRDb21wb3NpdG9yOjpjcmVhdGUobV9jb21wb3NpdG9yQ2xpZW50LCBtX2NvbXBvc2l0 b3JDbGllbnQsIGNvbXBvc2l0aW5nRGlzcGxheUlELCBzY2FsZWRTaXplLCBzY2FsZUZhY3Rvciwg VGhyZWFkZWRDb21wb3NpdG9yOjpTaG91bGREb0ZyYW1lU3luYzo6WWVzLCBwYWludEZsYWdzKTsK KyAgICAgICAgbV9jb21wb3NpdG9yID0gVGhyZWFkZWRDb21wb3NpdG9yOjpjcmVhdGUobV9jb21w b3NpdG9yQ2xpZW50LCBtX2NvbXBvc2l0b3JDbGllbnQsIG1fd2ViUGFnZS5jb3JlUGFnZSgpLT5j aHJvbWUoKS5kaXNwbGF5SUQoKSwgc2NhbGVkU2l6ZSwgc2NhbGVGYWN0b3IsIFRocmVhZGVkQ29t cG9zaXRvcjo6U2hvdWxkRG9GcmFtZVN5bmM6OlllcywgcGFpbnRGbGFncyk7CiAgICAgICAgIG1f bGF5ZXJUcmVlQ29udGV4dC5jb250ZXh0SUQgPSBtX3N1cmZhY2UtPnN1cmZhY2VJRCgpOwogICAg IH0gZWxzZQotICAgICAgICBtX2NvbXBvc2l0b3IgPSBUaHJlYWRlZENvbXBvc2l0b3I6OmNyZWF0 ZShtX2NvbXBvc2l0b3JDbGllbnQsIG1fY29tcG9zaXRvckNsaWVudCwgY29tcG9zaXRpbmdEaXNw bGF5SUQsIHNjYWxlZFNpemUsIHNjYWxlRmFjdG9yKTsKLQotICAgIG1fd2ViUGFnZS53aW5kb3dT Y3JlZW5EaWRDaGFuZ2UoY29tcG9zaXRpbmdEaXNwbGF5SUQpOworICAgICAgICBtX2NvbXBvc2l0 b3IgPSBUaHJlYWRlZENvbXBvc2l0b3I6OmNyZWF0ZShtX2NvbXBvc2l0b3JDbGllbnQsIG1fY29t cG9zaXRvckNsaWVudCwgbV93ZWJQYWdlLmNvcmVQYWdlKCktPmNocm9tZSgpLmRpc3BsYXlJRCgp LCBzY2FsZWRTaXplLCBzY2FsZUZhY3Rvcik7CiAKICAgICBkaWRDaGFuZ2VWaWV3cG9ydCgpOwog fQpAQCAtMzI0LDEwICszMTYsOCBAQCB2b2lkIExheWVyVHJlZUhvc3Q6OnNldElzRGlzY2FyZGFi bGUoYm9vbCBkaXNjYXJkYWJsZSkKICAgICBtX2lzRGlzY2FyZGFibGUgPSBkaXNjYXJkYWJsZTsK ICAgICBpZiAobV9pc0Rpc2NhcmRhYmxlKSB7CiAgICAgICAgIG1fZGlzY2FyZGFibGVTeW5jQWN0 aW9ucyA9IE9wdGlvblNldDxEaXNjYXJkYWJsZVN5bmNBY3Rpb25zPigpOwotICAgICAgICBtX3dl YlBhZ2Uud2luZG93U2NyZWVuRGlkQ2hhbmdlKHByaW1hcnlEaXNwbGF5SUQpOwogICAgICAgICBy ZXR1cm47CiAgICAgfQotICAgIG1fd2ViUGFnZS53aW5kb3dTY3JlZW5EaWRDaGFuZ2UoY29tcG9z aXRpbmdEaXNwbGF5SUQpOwogCiAgICAgaWYgKG1fZGlzY2FyZGFibGVTeW5jQWN0aW9ucy5pc0Vt cHR5KCkpCiAgICAgICAgIHJldHVybjsK