198379 2019-05-30 09:49:09 -0700 REGRESSION (r245873) [Mac WK2] Layout Test http/wpt/service-workers/update-service-worker.https.html is a flaky crash after running new test 2019-05-31 14:00:28 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198434 InRadar P2 Normal --- 1 sroberts youennf achristensen commit-queue jlewis3 ryanhaddad tsavell webkit-bug-importer youennf oldest_to_newest 1540331 0 sroberts 2019-05-30 09:49:09 -0700 The following layout test is failing on Mac WK2 http/wpt/service-workers/update-service-worker.https.html Probable cause: Due to an unrelated issue we do not have results on the dashboard yet, but I was able to verify locally this crash happens after r245873 . New test added http/wpt/service-workers/service-worker-networkprocess-crash.html when run before http/wpt/service-workers/update-service-worker.https.html will flakily cause a crash on Mac WK2 reproduces like this: run-webkit-tests http/wpt/service-workers/service-worker-networkprocess-crash.html http/wpt/service-workers/update-service-worker.https.html --child-process 1 --iter 10 --exit-after-n-crashes=1 Usually crashes in 3 runs. Flakiness Dashboard: https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Fwpt%2Fservice-workers%2Fupdate-service-worker.https.html Will post full crash log in radar: 0 com.apple.WebKit 0x000000010976889d WebKit::SharedStringHashTableReadOnly::setSharedMemory(WTF::RefPtr<WebKit::SharedMemory, WTF::DumbPtrTraits<WebKit::SharedMemory> >&&) + 19 1 com.apple.WebKit 0x00000001099ccc59 WebKit::WebSWOriginTable::setSharedMemory(WebKit::SharedMemory::Handle const&) + 63 2 com.apple.WebKit 0x0000000109ad7208 WebKit::WebSWClientConnection::didReceiveMessage(IPC::Connection&, IPC::Decoder&) + 6580 3 com.apple.WebKit 0x00000001095fdd67 IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) + 165 4 com.apple.WebKit 0x000000010960476e WTF::Detail::CallableWrapper<IPC::Connection::enqueueIncomingMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >)::$_14, void>::call() + 202 1540334 1 webkit-bug-importer 2019-05-30 09:49:54 -0700 <rdar://problem/51264361> 1540335 2 sroberts 2019-05-30 09:50:13 -0700 Occurring in iOS Simulator as well. 1540336 3 youennf 2019-05-30 09:52:35 -0700 Will fix it today 1540402 4 sroberts 2019-05-30 11:54:37 -0700 Thank you. Layout test : http/tests/websocket/tests/hybi/no-subprotocol.html is hitting the same crash as well. It's not triggering off your new test however. I can bisect and find out which test is triggering it, if it's helpful? Crash Log: https://build.webkit.org/results/Apple%20Mojave%20Release%20WK2%20(Tests)/r245891%20(4385)/http/wpt/service-workers/update-service-worker.https-crash-log.txt 1540404 5 youennf 2019-05-30 11:55:50 -0700 I think I know the route cause of this. We probably need to remove the WebSWClientConnection from NetworkProcessConnection map at destruction time. 1540464 6 370979 youennf 2019-05-30 14:25:40 -0700 Created attachment 370979 Patch 1540528 7 370979 commit-queue 2019-05-30 17:08:10 -0700 Comment on attachment 370979 Patch Clearing flags on attachment: 370979 Committed r245913: <https://trac.webkit.org/changeset/245913> 1540529 8 commit-queue 2019-05-30 17:08:11 -0700 All reviewed patches have been landed. Closing bug. 370979 2019-05-30 14:25:40 -0700 2019-05-30 17:08:10 -0700 Patch bug-198379-20190530142539.patch text/plain 3678 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDE4NTE3OGUzZmZiNjRkZDU2 ZWZhMWIyZjc1MGRiY2E5Y2Y1NjYyNmEuLjYxZjY1NTljODNjYjFmYzM0MzNiNzM5NTgyNGY3ZGUz MWRhZTBlZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTktMDUtMzAgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyNDU4NzMp IFtNYWMgV0syXSBMYXlvdXQgVGVzdCBodHRwL3dwdC9zZXJ2aWNlLXdvcmtlcnMvdXBkYXRlLXNl cnZpY2Utd29ya2VyLmh0dHBzLmh0bWwgaXMgYSBmbGFreSBjcmFzaCBhZnRlciBydW5uaW5nIG5l dyB0ZXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x OTgzNzkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUxMjY0MzYxPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2FzZSBjYW4gaGFwcGVuIHdo ZW4gbmV0d29yayBwcm9jZXNzIGlzIGNyYXNoaW5nLgorICAgICAgICBHaXZlbiB0aGUgV2ViU1dD bGllbnRDb25uZWN0aW9uIG1heSBiZSBrZXB0IGFsaXZlLCBpdCBtaWdodCByZXJlZ2lzdGVyIGl0 c2VsZiBidXQgaW4gdGhhdCBjYXNlIHdpbGwgbmV2ZXIgYmUgdW5yZWdpc3RlcmVkLgorICAgICAg ICBSZW1vdmUgdGhlIFdlYlNXQ2xpZW50Q29ubmVjdGlvbiBmcm9tIHRoZSBOZXR3b3JrUHJvY2Vz c0Nvbm5lY3Rpb24gY29ycmVzcG9uZGluZyBtYXAgb24gZGVzdHJ1Y3Rpb24gdGltZS4KKyAgICAg ICAgQ292ZXJlZCBieSBubyBsb25nZXIgY3Jhc2hpbmcgdGVzdHMuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uLmNwcDoKKyAgICAgICAgKFdl YktpdDo6TmV0d29ya1Byb2Nlc3NDb25uZWN0aW9uOjpyZW1vdmVTV0NsaWVudENvbm5lY3Rpb24p OgorICAgICAgICAqIFdlYlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24u aDoKKyAgICAgICAgKiBXZWJQcm9jZXNzL1N0b3JhZ2UvV2ViU1dDbGllbnRDb25uZWN0aW9uLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2ViU1dDbGllbnRDb25uZWN0aW9uOjp+V2ViU1dDbGllbnRD b25uZWN0aW9uKToKKwogMjAxOS0wNS0yOSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgQWRkIGFuIG9wdGlvbiB0byBtdXRlIGF1ZGlvIGNhcHR1cmUgYXV0b21h dGljYWxseSB3aGVuIHBhZ2UgaXMgbm90IHZpc2libGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbi5jcHAgYi9Tb3Vy Y2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9OZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24uY3Bw CmluZGV4IDAzN2Y3MTAwNGI3NzE1M2FiMWFjZDZjZDlkYjZjZWVhNmY4YTU4OTcuLjE2MWY4ZGE0 MWZhODZlNjExZmQ5NDMxMDdkZmU2ZjYzNjQwYzNlMmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9OZXR3b3JrL05ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbi5jcHAKKysrIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL05ldHdvcmsvTmV0d29ya1Byb2Nlc3NDb25uZWN0aW9u LmNwcApAQCAtMjY1LDYgKzI2NSwxMiBAQCBXZWJTV0NsaWVudENvbm5lY3Rpb24mIE5ldHdvcmtQ cm9jZXNzQ29ubmVjdGlvbjo6c2VydmljZVdvcmtlckNvbm5lY3Rpb25Gb3JTZXNzaQogICAgIH0p Lml0ZXJhdG9yLT52YWx1ZTsKIH0KIAordm9pZCBOZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb246OnJl bW92ZVNXQ2xpZW50Q29ubmVjdGlvbihXZWJTV0NsaWVudENvbm5lY3Rpb24mIGNvbm5lY3Rpb24p Cit7CisgICAgQVNTRVJUKG1fc3dDb25uZWN0aW9uc0J5SWRlbnRpZmllci5jb250YWlucyhjb25u ZWN0aW9uLnNlcnZlckNvbm5lY3Rpb25JZGVudGlmaWVyKCkpKTsKKyAgICBtX3N3Q29ubmVjdGlv bnNCeUlkZW50aWZpZXIucmVtb3ZlKGNvbm5lY3Rpb24uc2VydmVyQ29ubmVjdGlvbklkZW50aWZp ZXIoKSk7Cit9CisKIFNXU2VydmVyQ29ubmVjdGlvbklkZW50aWZpZXIgTmV0d29ya1Byb2Nlc3ND b25uZWN0aW9uOjppbml0aWFsaXplU1dDbGllbnRDb25uZWN0aW9uKFdlYlNXQ2xpZW50Q29ubmVj dGlvbiYgY29ubmVjdGlvbikKIHsKICAgICBTV1NlcnZlckNvbm5lY3Rpb25JZGVudGlmaWVyIGlk ZW50aWZpZXI7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvTmV0d29yay9O ZXR3b3JrUHJvY2Vzc0Nvbm5lY3Rpb24uaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3 b3JrL05ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbi5oCmluZGV4IDVhOWM0ZGM0YmY0MWUwNDBmZWE1 MGRlYTVmOTkyNGNkNGY4MTJiNTAuLjBjZGU1OTliMWUwNDlkODgzMTNhMGQwMzA1ZjgwMmFmNTI3 OWRjZDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3b3JrL05ldHdv cmtQcm9jZXNzQ29ubmVjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9OZXR3 b3JrL05ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbi5oCkBAIC03Nyw2ICs3Nyw3IEBAIHB1YmxpYzoK ICAgICBXZWJTV0NsaWVudENvbm5lY3Rpb24mIHNlcnZpY2VXb3JrZXJDb25uZWN0aW9uRm9yU2Vz c2lvbihQQUw6OlNlc3Npb25JRCk7CiAKICAgICBXZWJDb3JlOjpTV1NlcnZlckNvbm5lY3Rpb25J ZGVudGlmaWVyIGluaXRpYWxpemVTV0NsaWVudENvbm5lY3Rpb24oV2ViU1dDbGllbnRDb25uZWN0 aW9uJik7CisgICAgdm9pZCByZW1vdmVTV0NsaWVudENvbm5lY3Rpb24oV2ViU1dDbGllbnRDb25u ZWN0aW9uJik7CiAjZW5kaWYKIAogcHJpdmF0ZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9TdG9yYWdlL1dlYlNXQ2xpZW50Q29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvU3RvcmFnZS9XZWJTV0NsaWVudENvbm5lY3Rpb24uY3BwCmluZGV4IDk1 MWU2NWY2YzA1YjFjNTUzMWM4MGFlMzM0NGZiNGQ1NDBhY2UzNWUuLmQ1M2QxMzNkNzI1ZTI3YTA3 MzJkNTI3ZDNjZDBiYTZkN2Y2N2E2MDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9TdG9yYWdlL1dlYlNXQ2xpZW50Q29ubmVjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL1N0b3JhZ2UvV2ViU1dDbGllbnRDb25uZWN0aW9uLmNwcApAQCAtNjIsNiAr NjIsOCBAQCBXZWJTV0NsaWVudENvbm5lY3Rpb246OldlYlNXQ2xpZW50Q29ubmVjdGlvbihTZXNz aW9uSUQgc2Vzc2lvbklEKQogCiBXZWJTV0NsaWVudENvbm5lY3Rpb246On5XZWJTV0NsaWVudENv bm5lY3Rpb24oKQogeworICAgIGlmIChtX2Nvbm5lY3Rpb24pCisgICAgICAgIFdlYlByb2Nlc3M6 OnNpbmdsZXRvbigpLmVuc3VyZU5ldHdvcmtQcm9jZXNzQ29ubmVjdGlvbigpLnJlbW92ZVNXQ2xp ZW50Q29ubmVjdGlvbigqdGhpcyk7CiB9CiAKIHZvaWQgV2ViU1dDbGllbnRDb25uZWN0aW9uOjpp bml0aWFsaXplQ29ubmVjdGlvbklmTmVlZGVkKCkK