198372 2019-05-30 05:42:03 -0700 [GTK] WPERenderer: ensure we complete the last frame when leaving AC mode 2019-05-31 01:17:45 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply magomez mcatanzaro zan oldest_to_newest 1540289 0 cgarcia 2019-05-30 05:42:03 -0700 It can happen that we leave AC mode after a new image is received from the web process but before it's committed. It can also happen that we receive a new image from the web process right after we have left AC mode. In both cases we need to complete the frame to ensure we don't leave the wayland compositor waiting forever for a frame to be completed. 1540290 1 370938 cgarcia 2019-05-30 05:45:46 -0700 Created attachment 370938 Patch 1540669 2 cgarcia 2019-05-31 01:17:45 -0700 Committed r245957: <https://trac.webkit.org/changeset/245957> 370938 2019-05-30 05:45:46 -0700 2019-05-30 08:25:53 -0700 Patch wkgtk-wpe-pending-image.diff text/plain 4109 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYTc1YzQzYmE3ZWQuLmFkODU2YTk3MTM5IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDIxIEBACisyMDE5LTA1LTMwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KKworICAgICAgICBbR1RLXSBXUEVSZW5kZXJlcjogZW5zdXJlIHdlIGNvbXBsZXRlIHRo ZSBsYXN0IGZyYW1lIHdoZW4gbGVhdmluZyBBQyBtb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgzNzIKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBjYW4gaGFwcGVuIHRoYXQgd2UgbGVhdmUgQUMg bW9kZSBhZnRlciBhIG5ldyBpbWFnZSBpcyByZWNlaXZlZCBmcm9tIHRoZSB3ZWIgcHJvY2VzcyBi dXQgYmVmb3JlIGl0J3MKKyAgICAgICAgY29tbWl0dGVkLiBJdCBjYW4gYWxzbyBoYXBwZW4gdGhh dCB3ZSByZWNlaXZlIGEgbmV3IGltYWdlIGZyb20gdGhlIHdlYiBwcm9jZXNzIHJpZ2h0IGFmdGVy IHdlIGhhdmUgbGVmdCBBQworICAgICAgICBtb2RlLiBJbiBib3RoIGNhc2VzIHdlIG5lZWQgdG8g Y29tcGxldGUgdGhlIGZyYW1lIHRvIGVuc3VyZSB3ZSBkb24ndCBsZWF2ZSB0aGUgd2F5bGFuZCBj b21wb3NpdG9yIHdhaXRpbmcKKyAgICAgICAgZm9yZXZlciBmb3IgYSBmcmFtZSB0byBiZSBjb21w bGV0ZWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3Jl V2F5bGFuZC5jcHA6CisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5 bGFuZDo6dXBkYXRlKTogQ29tcGxldGUgYW55IHBlbmRpbmcgaW1hZ2Ugd2hlbiBhIG5ldyBzdXJm YWNlIGlzIHVzZWQuCisgICAgICAgIChXZWJLaXQ6OkFjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5 bGFuZDo6ZGlzcGxheUJ1ZmZlcik6IENvbXBsZXRlIHRoZSBnaXZlbiBpbWFnZSBhbmQgcmV0dXJu IGVhcmx5IGlmIHdlIGFscmVhZHkKKyAgICAgICAgbGVmdCBBQyBtb2RlLgorICAgICAgICAqIFVJ UHJvY2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kLmg6CisKIDIwMTktMDUt MzAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAg IFtDb29yZGluYXRlZEdyYXBoaWNzXSBXUEVSZW5kZXJlcjogZG8gbm90IHJlbGVhc2UgdGhlIGhv c3QgZmlsZSBkZXNjcml0b3Igd2hlbiBpbml0aWFsaXppbmcgdGhlIHJlbmRlciB0YXJnZXQKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdT dG9yZVdheWxhbmQuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVk QmFja2luZ1N0b3JlV2F5bGFuZC5jcHAKaW5kZXggYTI0MmQ3MGRlNjAuLjU3ZjY3OTUxYTRjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5n U3RvcmVXYXlsYW5kLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsvQWNjZWxl cmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kLmNwcApAQCAtMjgsNiArMjgsNyBAQAogCiAjaWYgUExB VEZPUk0oV0FZTEFORCkgJiYgVVNFKEVHTCkKIAorI2luY2x1ZGUgIkxheWVyVHJlZUNvbnRleHQu aCIKICNpbmNsdWRlICJXZWJQYWdlUHJveHkuaCIKIC8vIFRoZXNlIGluY2x1ZGVzIG5lZWQgdG8g YmUgaW4gdGhpcyBvcmRlciBiZWNhdXNlIHdheWxhbmQtZWdsLmggZGVmaW5lcyBXTF9FR0xfUExB VEZPUk0KIC8vIGFuZCBlZ2xwbGF0Zm9ybS5oLCBpbmNsdWRlZCBieSBlZ2wuaCwgY2hlY2tzIHRo YXQgdG8gZGVjaWRlIHdoZXRoZXIgaXQncyBXYXlsYW5kIHBsYXRmb3JtLgpAQCAtMTgxLDYgKzE4 MiwxOSBAQCBib29sIEFjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5bGFuZDo6bWFrZUNvbnRleHRD dXJyZW50KCkKIH0KIAogI2lmIFVTRShXUEVfUkVOREVSRVIpCit2b2lkIEFjY2VsZXJhdGVkQmFj a2luZ1N0b3JlV2F5bGFuZDo6dXBkYXRlKGNvbnN0IExheWVyVHJlZUNvbnRleHQmIGNvbnRleHQp Cit7CisgICAgaWYgKG1fc3VyZmFjZUlEID09IGNvbnRleHQuY29udGV4dElEKQorICAgICAgICBy ZXR1cm47CisKKyAgICBtX3N1cmZhY2VJRCA9IGNvbnRleHQuY29udGV4dElEOworICAgIGlmICht X3BlbmRpbmdJbWFnZSkgeworICAgICAgICB3cGVfdmlld19iYWNrZW5kX2V4cG9ydGFibGVfZmRv X2Rpc3BhdGNoX2ZyYW1lX2NvbXBsZXRlKG1fZXhwb3J0YWJsZSk7CisgICAgICAgIHdwZV92aWV3 X2JhY2tlbmRfZXhwb3J0YWJsZV9mZG9fZWdsX2Rpc3BhdGNoX3JlbGVhc2VfZXhwb3J0ZWRfaW1h Z2UobV9leHBvcnRhYmxlLCBtX3BlbmRpbmdJbWFnZSk7CisgICAgICAgIG1fcGVuZGluZ0ltYWdl ID0gbnVsbHB0cjsKKyAgICB9Cit9CisKIGludCBBY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVdheWxh bmQ6OnJlbmRlckhvc3RGaWxlRGVzY3JpcHRvcigpCiB7CiAgICAgcmV0dXJuIHdwZV92aWV3X2Jh Y2tlbmRfZ2V0X3JlbmRlcmVyX2hvc3RfZmQod3BlX3ZpZXdfYmFja2VuZF9leHBvcnRhYmxlX2Zk b19nZXRfdmlld19iYWNrZW5kKG1fZXhwb3J0YWJsZSkpOwpAQCAtMTg4LDYgKzIwMiwxMiBAQCBp bnQgQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kOjpyZW5kZXJIb3N0RmlsZURlc2NyaXB0 b3IoKQogCiB2b2lkIEFjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5bGFuZDo6ZGlzcGxheUJ1ZmZl cihzdHJ1Y3Qgd3BlX2Zkb19lZ2xfZXhwb3J0ZWRfaW1hZ2UqIGltYWdlKQogeworICAgIGlmICgh bV9zdXJmYWNlSUQpIHsKKyAgICAgICAgd3BlX3ZpZXdfYmFja2VuZF9leHBvcnRhYmxlX2Zkb19k aXNwYXRjaF9mcmFtZV9jb21wbGV0ZShtX2V4cG9ydGFibGUpOworICAgICAgICB3cGVfdmlld19i YWNrZW5kX2V4cG9ydGFibGVfZmRvX2VnbF9kaXNwYXRjaF9yZWxlYXNlX2V4cG9ydGVkX2ltYWdl KG1fZXhwb3J0YWJsZSwgaW1hZ2UpOworICAgICAgICByZXR1cm47CisgICAgfQorCiAgICAgaWYg KCFtX3ZpZXdUZXh0dXJlKSB7CiAgICAgICAgIGlmICghbWFrZUNvbnRleHRDdXJyZW50KCkpCiAg ICAgICAgICAgICByZXR1cm47CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9n dGsvQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kLmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9ndGsvQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kLmgKaW5kZXggYjQ0MzQ5ZjM0 MjMuLmI2OTdkNjgzZGUwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9ndGsv QWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVXYXlsYW5kLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlV2F5bGFuZC5oCkBAIC02Niw2ICs2Niw3 IEBAIHByaXZhdGU6CiAgICAgYm9vbCBwYWludChjYWlyb190KiwgY29uc3QgV2ViQ29yZTo6SW50 UmVjdCYpIG92ZXJyaWRlOwogICAgIGJvb2wgbWFrZUNvbnRleHRDdXJyZW50KCkgb3ZlcnJpZGU7 CiAjaWYgVVNFKFdQRV9SRU5ERVJFUikKKyAgICB2b2lkIHVwZGF0ZShjb25zdCBMYXllclRyZWVD b250ZXh0Jikgb3ZlcnJpZGU7CiAgICAgaW50IHJlbmRlckhvc3RGaWxlRGVzY3JpcHRvcigpIG92 ZXJyaWRlOwogI2VuZGlmCiAKQEAgLTc4LDYgKzc5LDcgQEAgcHJpdmF0ZToKIAogI2lmIFVTRShX UEVfUkVOREVSRVIpCiAgICAgc3RydWN0IHdwZV92aWV3X2JhY2tlbmRfZXhwb3J0YWJsZV9mZG8q IG1fZXhwb3J0YWJsZSB7IG51bGxwdHIgfTsKKyAgICB1aW50NjRfdCBtX3N1cmZhY2VJRCB7IDAg fTsKICAgICB1bnNpZ25lZCBtX3ZpZXdUZXh0dXJlIHsgMCB9OwogICAgIHN0cnVjdCB3cGVfZmRv X2VnbF9leHBvcnRlZF9pbWFnZSogbV9jb21taXR0ZWRJbWFnZSB7IG51bGxwdHIgfTsKICAgICBz dHJ1Y3Qgd3BlX2Zkb19lZ2xfZXhwb3J0ZWRfaW1hZ2UqIG1fcGVuZGluZ0ltYWdlIHsgbnVsbHB0 ciB9Owo=