198353 2019-05-29 15:48:36 -0700 Move some HistoricalVelocityData code into the cpp file 2019-05-30 10:03:17 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser simon.fraser thorton webkit-bug-importer oldest_to_newest 1540148 0 simon.fraser 2019-05-29 15:48:36 -0700 Move some HistoricalVelocityData code into the cpp file 1540150 1 370891 simon.fraser 2019-05-29 15:49:22 -0700 Created attachment 370891 Patch 1540154 2 simon.fraser 2019-05-29 15:50:41 -0700 Probably need a WEBCORE_EXPORT in there. 1540155 3 370891 thorton 2019-05-29 15:50:50 -0700 Comment on attachment 370891 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370891&action=review > Source/WebCore/platform/graphics/VelocityData.cpp:36 > + { brace on the previous line imo 1540340 4 simon.fraser 2019-05-30 10:02:53 -0700 https://trac.webkit.org/r245892 1540342 5 webkit-bug-importer 2019-05-30 10:03:17 -0700 <rdar://problem/51264853> 370891 2019-05-29 15:49:22 -0700 2019-05-29 15:50:50 -0700 Patch bug-198353-20190529154922.patch text/plain 6210 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjljYWNlZWVjNjE2ZjBm NzgzNjIyODU2NjQzN2M0MTRmNmM2YTUxOC4uZjc2MjI1N2FlODMzYzkyMjg5ZmMzNzI2YjI5OTE5 ODU0ZjRmMDkxNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA1LTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIE1vdmUgc29tZSBI aXN0b3JpY2FsVmVsb2NpdHlEYXRhIGNvZGUgaW50byB0aGUgY3BwIGZpbGUKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODM1MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgTm93IHRoYXQgd2Ug aGF2ZSBWZWxvY2l0eURhdGEuY3BwIHB1dCB0aGUgbm9uLXRyaXZpYWwgSGlzdG9yaWNhbFZlbG9j aXR5RGF0YTo6dmVsb2NpdHlGb3JOZXdEYXRhKCkKKyAgICAgICAgaW50byBpdC4gYXBwZW5kKCkg Y2FuIGJlY29tZSBhIGxhbWJkYSBmdW5jdGlvbi4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL1ZlbG9jaXR5RGF0YS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIaXN0b3JpY2FsVmVsb2Np dHlEYXRhOjp2ZWxvY2l0eUZvck5ld0RhdGEpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNz L1ZlbG9jaXR5RGF0YS5oOgorICAgICAgICAoV2ViQ29yZTo6SGlzdG9yaWNhbFZlbG9jaXR5RGF0 YTo6dmVsb2NpdHlGb3JOZXdEYXRhKTogRGVsZXRlZC4KKyAgICAgICAgKFdlYkNvcmU6Okhpc3Rv cmljYWxWZWxvY2l0eURhdGE6OmFwcGVuZCk6IERlbGV0ZWQuCisKIDIwMTktMDUtMjkgIFJ5YW4g SGFkZGFkICA8cnlhbmhhZGRhZEBhcHBsZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9s bGluZyBvdXQgcjI0NTg1Ny4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL1ZlbG9jaXR5RGF0YS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9WZWxvY2l0eURhdGEuY3BwCmluZGV4IGIyMDUyOWRmODUwY2QzY2RkNGMxN2FiMTQyNWFkNzZk NTkxOWM1MTAuLjNhNmIwOTM2N2M2NzcwMDNmY2EzNGU0MDYyNjg1YzU5N2YwMTUzMGYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL1ZlbG9jaXR5RGF0YS5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVmVsb2NpdHlEYXRhLmNwcApA QCAtMzAsNiArMzAsNDUgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitWZWxvY2l0eURhdGEg SGlzdG9yaWNhbFZlbG9jaXR5RGF0YTo6dmVsb2NpdHlGb3JOZXdEYXRhKEZsb2F0UG9pbnQgbmV3 UG9zaXRpb24sIGRvdWJsZSBzY2FsZSwgTW9ub3RvbmljVGltZSB0aW1lc3RhbXApCit7CisgICAg YXV0byBhcHBlbmQgPSBbJl0oRmxvYXRQb2ludCBuZXdQb3NpdGlvbiwgZG91YmxlIHNjYWxlLCBN b25vdG9uaWNUaW1lIHRpbWVzdGFtcCkKKyAgICB7CisgICAgICAgIG1fbGF0ZXN0RGF0YUluZGV4 ID0gKG1fbGF0ZXN0RGF0YUluZGV4ICsgMSkgJSBtYXhIaXN0b3J5RGVwdGg7CisgICAgICAgIG1f cG9zaXRpb25IaXN0b3J5W21fbGF0ZXN0RGF0YUluZGV4XSA9IHsgdGltZXN0YW1wLCBuZXdQb3Np dGlvbiwgc2NhbGUgfTsKKyAgICAgICAgbV9oaXN0b3J5U2l6ZSA9IHN0ZDo6bWluKG1faGlzdG9y eVNpemUgKyAxLCBtYXhIaXN0b3J5RGVwdGgpOworICAgICAgICBtX2xhc3RBcHBlbmRUaW1lc3Rh bXAgPSB0aW1lc3RhbXA7CisgICAgfTsKKworICAgIC8vIER1ZSB0byBhbGwgdGhlIHNvdXJjZSBv ZiByZWN0IHVwZGF0ZSwgdGhlIGlucHV0IGlzIHZlcnkgbm9pc3kuIFRvIHNtb290aCB0aGUgb3V0 cHV0LCB3ZSBhY2N1bXVsYXRlIGFsbCBjaGFuZ2VzCisgICAgLy8gd2l0aGluIDEgZnJhbWUgYXMg YSBzaW5nbGUgdXBkYXRlLiBObyBzcGVlZCBjb21wdXRhdGlvbiBpcyBldmVyIGRvbmUgb24gZGF0 YSB3aXRoaW4gdGhlIHNhbWUgZnJhbWUuCisgICAgY29uc3QgU2Vjb25kcyBmaWx0ZXJpbmdUaHJl c2hvbGQoMS4wIC8gNjApOworCisgICAgVmVsb2NpdHlEYXRhIHZlbG9jaXR5RGF0YTsKKyAgICBp ZiAobV9oaXN0b3J5U2l6ZSA+IDApIHsKKyAgICAgICAgdW5zaWduZWQgb2xkZXN0RGF0YUluZGV4 OworICAgICAgICB1bnNpZ25lZCBkaXN0YW5jZVRvTGFzdEhpc3RvcmljYWxEYXRhID0gbV9oaXN0 b3J5U2l6ZSAtIDE7CisgICAgICAgIGlmIChkaXN0YW5jZVRvTGFzdEhpc3RvcmljYWxEYXRhIDw9 IG1fbGF0ZXN0RGF0YUluZGV4KQorICAgICAgICAgICAgb2xkZXN0RGF0YUluZGV4ID0gbV9sYXRl c3REYXRhSW5kZXggLSBkaXN0YW5jZVRvTGFzdEhpc3RvcmljYWxEYXRhOworICAgICAgICBlbHNl CisgICAgICAgICAgICBvbGRlc3REYXRhSW5kZXggPSBtX2hpc3RvcnlTaXplIC0gKGRpc3RhbmNl VG9MYXN0SGlzdG9yaWNhbERhdGEgLSBtX2xhdGVzdERhdGFJbmRleCk7CisKKyAgICAgICAgU2Vj b25kcyB0aW1lRGVsdGEgPSB0aW1lc3RhbXAgLSBtX3Bvc2l0aW9uSGlzdG9yeVtvbGRlc3REYXRh SW5kZXhdLnRpbWVzdGFtcDsKKyAgICAgICAgaWYgKHRpbWVEZWx0YSA+IGZpbHRlcmluZ1RocmVz aG9sZCkgeworICAgICAgICAgICAgRGF0YSYgb2xkZXN0RGF0YSA9IG1fcG9zaXRpb25IaXN0b3J5 W29sZGVzdERhdGFJbmRleF07CisgICAgICAgICAgICB2ZWxvY2l0eURhdGEgPSBWZWxvY2l0eURh dGEoKG5ld1Bvc2l0aW9uLngoKSAtIG9sZGVzdERhdGEucG9zaXRpb24ueCgpKSAvIHRpbWVEZWx0 YS5zZWNvbmRzKCksIChuZXdQb3NpdGlvbi55KCkgLSBvbGRlc3REYXRhLnBvc2l0aW9uLnkoKSkg LyB0aW1lRGVsdGEuc2Vjb25kcygpLCAoc2NhbGUgLSBvbGRlc3REYXRhLnNjYWxlKSAvIHRpbWVE ZWx0YS5zZWNvbmRzKCksIHRpbWVzdGFtcCk7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBTZWNv bmRzIHRpbWVTaW5jZUxhc3RBcHBlbmQgPSB0aW1lc3RhbXAgLSBtX2xhc3RBcHBlbmRUaW1lc3Rh bXA7CisgICAgaWYgKHRpbWVTaW5jZUxhc3RBcHBlbmQgPiBmaWx0ZXJpbmdUaHJlc2hvbGQpCisg ICAgICAgIGFwcGVuZChuZXdQb3NpdGlvbiwgc2NhbGUsIHRpbWVzdGFtcCk7CisgICAgZWxzZQor ICAgICAgICBtX3Bvc2l0aW9uSGlzdG9yeVttX2xhdGVzdERhdGFJbmRleF0gPSB7IHRpbWVzdGFt cCwgbmV3UG9zaXRpb24sIHNjYWxlIH07CisKKyAgICByZXR1cm4gdmVsb2NpdHlEYXRhOworfQor CiBUZXh0U3RyZWFtJiBvcGVyYXRvcjw8KFRleHRTdHJlYW0mIHRzLCBjb25zdCBWZWxvY2l0eURh dGEmIHZlbG9jaXR5RGF0YSkKIHsKICAgICB0cy5kdW1wUHJvcGVydHkoInRpbWVzdGFtcCIsIHZl bG9jaXR5RGF0YS5sYXN0VXBkYXRlVGltZS5zZWNvbmRzU2luY2VFcG9jaCgpLnZhbHVlKCkpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvVmVsb2NpdHlEYXRh LmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9WZWxvY2l0eURhdGEuaAppbmRl eCA0YmJlMjlhZDE1NzE4Mzc2NzIxYTdlMDdkMzU3YTYxMGM0NzU1YTA3Li41Mjc2YzdjNGM3ZDk2 MTMzYmRhY2U1MzZiYWJjYzllZmUyYTcwMDYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9WZWxvY2l0eURhdGEuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9WZWxvY2l0eURhdGEuaApAQCAtNjgsNDggKzY4LDEwIEBAIGNsYXNzIEhp c3RvcmljYWxWZWxvY2l0eURhdGEgewogcHVibGljOgogICAgIEhpc3RvcmljYWxWZWxvY2l0eURh dGEoKSA9IGRlZmF1bHQ7CiAKLSAgICBWZWxvY2l0eURhdGEgdmVsb2NpdHlGb3JOZXdEYXRhKEZs b2F0UG9pbnQgbmV3UG9zaXRpb24sIGRvdWJsZSBzY2FsZSwgTW9ub3RvbmljVGltZSB0aW1lc3Rh bXApCi0gICAgewotICAgICAgICAvLyBEdWUgdG8gYWxsIHRoZSBzb3VyY2Ugb2YgcmVjdCB1cGRh dGUsIHRoZSBpbnB1dCBpcyB2ZXJ5IG5vaXN5LiBUbyBzbW9vdGggdGhlIG91dHB1dCwgd2UgYWNj dW11bGF0ZSBhbGwgY2hhbmdlcwotICAgICAgICAvLyB3aXRoaW4gMSBmcmFtZSBhcyBhIHNpbmds ZSB1cGRhdGUuIE5vIHNwZWVkIGNvbXB1dGF0aW9uIGlzIGV2ZXIgZG9uZSBvbiBkYXRhIHdpdGhp biB0aGUgc2FtZSBmcmFtZS4KLSAgICAgICAgY29uc3QgU2Vjb25kcyBmaWx0ZXJpbmdUaHJlc2hv bGQoMS4wIC8gNjApOwotCi0gICAgICAgIFZlbG9jaXR5RGF0YSB2ZWxvY2l0eURhdGE7Ci0gICAg ICAgIGlmIChtX2hpc3RvcnlTaXplID4gMCkgewotICAgICAgICAgICAgdW5zaWduZWQgb2xkZXN0 RGF0YUluZGV4OwotICAgICAgICAgICAgdW5zaWduZWQgZGlzdGFuY2VUb0xhc3RIaXN0b3JpY2Fs RGF0YSA9IG1faGlzdG9yeVNpemUgLSAxOwotICAgICAgICAgICAgaWYgKGRpc3RhbmNlVG9MYXN0 SGlzdG9yaWNhbERhdGEgPD0gbV9sYXRlc3REYXRhSW5kZXgpCi0gICAgICAgICAgICAgICAgb2xk ZXN0RGF0YUluZGV4ID0gbV9sYXRlc3REYXRhSW5kZXggLSBkaXN0YW5jZVRvTGFzdEhpc3Rvcmlj YWxEYXRhOwotICAgICAgICAgICAgZWxzZQotICAgICAgICAgICAgICAgIG9sZGVzdERhdGFJbmRl eCA9IG1faGlzdG9yeVNpemUgLSAoZGlzdGFuY2VUb0xhc3RIaXN0b3JpY2FsRGF0YSAtIG1fbGF0 ZXN0RGF0YUluZGV4KTsKLQotICAgICAgICAgICAgU2Vjb25kcyB0aW1lRGVsdGEgPSB0aW1lc3Rh bXAgLSBtX3Bvc2l0aW9uSGlzdG9yeVtvbGRlc3REYXRhSW5kZXhdLnRpbWVzdGFtcDsKLSAgICAg ICAgICAgIGlmICh0aW1lRGVsdGEgPiBmaWx0ZXJpbmdUaHJlc2hvbGQpIHsKLSAgICAgICAgICAg ICAgICBEYXRhJiBvbGRlc3REYXRhID0gbV9wb3NpdGlvbkhpc3Rvcnlbb2xkZXN0RGF0YUluZGV4 XTsKLSAgICAgICAgICAgICAgICB2ZWxvY2l0eURhdGEgPSBWZWxvY2l0eURhdGEoKG5ld1Bvc2l0 aW9uLngoKSAtIG9sZGVzdERhdGEucG9zaXRpb24ueCgpKSAvIHRpbWVEZWx0YS5zZWNvbmRzKCks IChuZXdQb3NpdGlvbi55KCkgLSBvbGRlc3REYXRhLnBvc2l0aW9uLnkoKSkgLyB0aW1lRGVsdGEu c2Vjb25kcygpLCAoc2NhbGUgLSBvbGRlc3REYXRhLnNjYWxlKSAvIHRpbWVEZWx0YS5zZWNvbmRz KCksIHRpbWVzdGFtcCk7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLQotICAgICAgICBTZWNv bmRzIHRpbWVTaW5jZUxhc3RBcHBlbmQgPSB0aW1lc3RhbXAgLSBtX2xhc3RBcHBlbmRUaW1lc3Rh bXA7Ci0gICAgICAgIGlmICh0aW1lU2luY2VMYXN0QXBwZW5kID4gZmlsdGVyaW5nVGhyZXNob2xk KQotICAgICAgICAgICAgYXBwZW5kKG5ld1Bvc2l0aW9uLCBzY2FsZSwgdGltZXN0YW1wKTsKLSAg ICAgICAgZWxzZQotICAgICAgICAgICAgbV9wb3NpdGlvbkhpc3RvcnlbbV9sYXRlc3REYXRhSW5k ZXhdID0geyB0aW1lc3RhbXAsIG5ld1Bvc2l0aW9uLCBzY2FsZSB9OwotCi0gICAgICAgIHJldHVy biB2ZWxvY2l0eURhdGE7Ci0gICAgfQotCisgICAgVmVsb2NpdHlEYXRhIHZlbG9jaXR5Rm9yTmV3 RGF0YShGbG9hdFBvaW50IG5ld1Bvc2l0aW9uLCBkb3VibGUgc2NhbGUsIE1vbm90b25pY1RpbWUp OwogICAgIHZvaWQgY2xlYXIoKSB7IG1faGlzdG9yeVNpemUgPSAwOyB9CiAKIHByaXZhdGU6Ci0g ICAgdm9pZCBhcHBlbmQoRmxvYXRQb2ludCBuZXdQb3NpdGlvbiwgZG91YmxlIHNjYWxlLCBNb25v dG9uaWNUaW1lIHRpbWVzdGFtcCkKLSAgICB7Ci0gICAgICAgIG1fbGF0ZXN0RGF0YUluZGV4ID0g KG1fbGF0ZXN0RGF0YUluZGV4ICsgMSkgJSBtYXhIaXN0b3J5RGVwdGg7Ci0gICAgICAgIG1fcG9z aXRpb25IaXN0b3J5W21fbGF0ZXN0RGF0YUluZGV4XSA9IHsgdGltZXN0YW1wLCBuZXdQb3NpdGlv biwgc2NhbGUgfTsKLSAgICAgICAgbV9oaXN0b3J5U2l6ZSA9IHN0ZDo6bWluKG1faGlzdG9yeVNp emUgKyAxLCBtYXhIaXN0b3J5RGVwdGgpOwotICAgICAgICBtX2xhc3RBcHBlbmRUaW1lc3RhbXAg PSB0aW1lc3RhbXA7Ci0gICAgfQotCiAgICAgc3RhdGljIGNvbnN0ZXhwciB1bnNpZ25lZCBtYXhI aXN0b3J5RGVwdGggPSAzOwogCiAgICAgdW5zaWduZWQgbV9oaXN0b3J5U2l6ZSB7IDAgfTsK