198351 2019-05-29 14:35:23 -0700 Clean up a few #include statements in WTF 2019-05-29 16:08:16 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=198349 InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen benjamin cdumez cmarcelo commit-queue dbates ews-watchlist fujii saam webkit-bug-importer ysuzuki oldest_to_newest 1540114 0 ddkilzer 2019-05-29 14:35:23 -0700 Clean up a few #include statements in WTF. Found using this command from Bug 198349: $ ./Tools/Scripts/check-webkit-style --filter=-,+build/include_order Source/WTF 2>&1 | grep -i primary 1540115 1 ddkilzer 2019-05-29 14:37:42 -0700 NOTE: The style bot will report errors until Bug 198349 is fixed. 1540117 2 370885 ddkilzer 2019-05-29 14:38:14 -0700 Created attachment 370885 Patch v1 1540120 3 ews-watchlist 2019-05-29 14:40:44 -0700 Attachment 370885 did not pass style-queue: ERROR: Source/WTF/wtf/StackBounds.cpp:22: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] ERROR: Source/WTF/wtf/StackBounds.cpp:23: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WTF/wtf/ParallelJobsGeneric.cpp:29: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 3 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1540121 4 ddkilzer 2019-05-29 14:41:43 -0700 Need to wait for WPE/Win builds to complete since Source/WTF/wtf/ParallelJobsGeneric.cpp is only built by those ports. 1540163 5 370885 commit-queue 2019-05-29 16:07:36 -0700 Comment on attachment 370885 Patch v1 Clearing flags on attachment: 370885 Committed r245876: <https://trac.webkit.org/changeset/245876> 1540164 6 commit-queue 2019-05-29 16:07:37 -0700 All reviewed patches have been landed. Closing bug. 1540165 7 webkit-bug-importer 2019-05-29 16:08:16 -0700 <rdar://problem/51241724> 370885 2019-05-29 14:38:14 -0700 2019-05-29 16:07:36 -0700 Patch v1 bug-198351-20190529143812.patch text/plain 2483 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1ODU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGE0NDlhOWJhMjFiZTY3YmQyZTZlZDAz ZDMyOGFjNDc2MWQ3OWMyY2EuLjYxYWVkOGYzY2FjMThlMTBlMDBlYWUzNWRhMWNkNWUzZWIyZmJi ODcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTktMDUtMjkgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBhIGZldyAjaW5jbHVkZSBzdGF0ZW1l bnRzIGluIFdURgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTk4MzUxPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogYmVuY2htYXJrcy9I YXNoU2V0REZHUmVwbGF5LmNwcDoKKyAgICAgICAgLSBBZGQgbWlzc2luZyAiY29uZmlnLmgiIGlu Y2x1ZGUuCisgICAgICAgICogd3RmL1BhcmFsbGVsSm9ic0dlbmVyaWMuY3BwOgorICAgICAgICAt IFJlcGxhY2UgaW5jbHVkZSBvZiBQYXJhbGxlbEpvYnMuaCB3aXRoCisgICAgICAgICAgUGFyYWxs ZWxKb2JzR2VuZXJpYy5oLgorICAgICAgICAqIHd0Zi9TdGFja0JvdW5kcy5jcHA6CisgICAgICAg IC0gRml4IGluY2x1ZGUgb3JkZXJpbmcgb2YgU3RhY2tCb3VuZHMuaC4KKwogMjAxOS0wNS0yOSAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEluZGV4ZWREYXRh YmFzZSBTZXJ2ZXIgdGhyZWFkIGluIGNvbS5hcHBsZS5XZWJLaXQuTmV0d29ya2luZyBwcm9jZXNz IGxlYWtzIG9iamVjdHMgaW50byBhbiBhdXRvcmVsZWFzZVBvb2wgdGhhdCdzIG5ldmVyIGNsZWFy ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvYmVuY2htYXJrcy9IYXNoU2V0REZHUmVwbGF5LmNw cCBiL1NvdXJjZS9XVEYvYmVuY2htYXJrcy9IYXNoU2V0REZHUmVwbGF5LmNwcAppbmRleCAxYjAz ZDFkNjJmMzI3MTQzNGY4ZWE3NmJkNWRhNWY0OWY4YjVmMTlhLi5iNjZkNTgyNWJjNDRkYzMzYjE1 MjRjN2YzM2U0NWYwYjEwOWI2YmQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL2JlbmNobWFya3Mv SGFzaFNldERGR1JlcGxheS5jcHAKKysrIGIvU291cmNlL1dURi9iZW5jaG1hcmtzL0hhc2hTZXRE RkdSZXBsYXkuY3BwCkBAIC0yNSw2ICsyNSw4IEBACiAKIC8vIENvbXBpbGUgd2l0aDogeGNydW4g Y2xhbmcrKyAtbyBIYXNoU2V0REZHUmVwbGF5IFNvdXJjZS9XVEYvYmVuY2htYXJrcy9IYXNoU2V0 REZHUmVwbGF5LmNwcCAtTzIgLVcgLUlTb3VyY2UvV1RGIC1JU291cmNlL1dURi9iZW5jaG1hcmtz IC1MV2ViS2l0QnVpbGQvUmVsZWFzZSAtbFdURiAtZnJhbWV3b3JrIEZvdW5kYXRpb24gLWxpY3Vj b3JlIC1zdGQ9YysrMTEgLWZ2aXNpYmlsaXR5PWhpZGRlbiAtRE5ERUJVRz0xCiAKKyNpbmNsdWRl ICJjb25maWcuaCIKKwogI2luY2x1ZGUgPHd0Zi9EYXRhTG9nLmg+CiAjaW5jbHVkZSA8d3RmL0hh c2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvV2FsbFRpbWUuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL1BhcmFsbGVsSm9ic0dlbmVyaWMuY3BwIGIvU291cmNlL1dURi93dGYvUGFyYWxsZWxK b2JzR2VuZXJpYy5jcHAKaW5kZXggOGFjZGM1N2VhOGMyNTRlNTc2NDkyMTc5ODIwOGJjZmM3YmJj MWMzNy4uY2Q1M2E5YWJkOGNkMDJkMThiMDU0OTRjNmY3OWRiM2I0YzFkZGFjNCAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvUGFyYWxsZWxKb2JzR2VuZXJpYy5jcHAKKysrIGIvU291cmNlL1dU Ri93dGYvUGFyYWxsZWxKb2JzR2VuZXJpYy5jcHAKQEAgLTI2LDExICsyNiwxMSBAQAogICovCiAK ICNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlIDx3dGYvUGFyYWxsZWxKb2JzR2VuZXJpYy5o PgogCiAjaWYgRU5BQkxFKFRIUkVBRElOR19HRU5FUklDKQogCiAjaW5jbHVkZSA8d3RmL051bWJl ck9mQ29yZXMuaD4KLSNpbmNsdWRlIDx3dGYvUGFyYWxsZWxKb2JzLmg+CiAKIG5hbWVzcGFjZSBX VEYgewogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAgYi9Tb3Vy Y2UvV1RGL3d0Zi9TdGFja0JvdW5kcy5jcHAKaW5kZXggODNlMDE1NGI5ODBmYTVlYjE3MWM4MTA4 MjY1MjU5MzRmMGIxZTk2Ny4uYWFiMjBmYTc2ZGMyMmFlZTM2ZjRhYjFiYjlhN2QyYTBjYmQ3NWE5 NyAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvU3RhY2tCb3VuZHMuY3BwCisrKyBiL1NvdXJj ZS9XVEYvd3RmL1N0YWNrQm91bmRzLmNwcApAQCAtMTksOSArMTksMTAgQEAKICAqLwogCiAjaW5j bHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSA8d3RmL1N0YWNrQm91bmRzLmg+CisKICNpbmNsdWRl IDxtdXRleD4KICNpbmNsdWRlIDx3dGYvTm9UYWlsQ2FsbHMuaD4KLSNpbmNsdWRlIDx3dGYvU3Rh Y2tCb3VuZHMuaD4KIAogI2lmIE9TKERBUldJTikKIAo=