198306 2019-05-28 15:03:18 -0700 [WHLSL] The name resolver does not deal with nativeFunctionDeclaration 2019-06-18 19:57:35 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 198704 https://bugs.webkit.org/show_bug.cgi?id=198704 InRadar P2 Normal --- 1 rmorisset rmorisset commit-queue mmaxfield saam tsavell webkit-bug-importer oldest_to_newest 1539737 0 rmorisset 2019-05-28 15:03:18 -0700 ... 1542260 1 371465 rmorisset 2019-06-05 19:01:44 -0700 Created attachment 371465 Patch for landing 1542262 2 371465 mmaxfield 2019-06-05 19:12:09 -0700 Comment on attachment 371465 Patch for landing This should be pretty easy to test. 1543266 3 mmaxfield 2019-06-09 23:43:17 -0700 https://bugs.webkit.org/show_bug.cgi?id=198704 will include a fix for this bug. 1543414 4 371769 rmorisset 2019-06-10 12:12:52 -0700 Created attachment 371769 Patch Now with testing. 1545471 5 371769 commit-queue 2019-06-17 17:06:22 -0700 Comment on attachment 371769 Patch Clearing flags on attachment: 371769 Committed r246524: <https://trac.webkit.org/changeset/246524> 1545472 6 commit-queue 2019-06-17 17:06:24 -0700 All reviewed patches have been landed. Closing bug. 1545473 7 webkit-bug-importer 2019-06-17 17:08:28 -0700 <rdar://problem/51828048> 1545625 8 tsavell 2019-06-18 08:58:10 -0700 The changes in https://trac.webkit.org/changeset/246524/webkit has caused 45 WebGPU/ crashes on Mac Debug WK2 only which is why EWS did not catch this. Results: https://build.webkit.org/results/Apple%20Mojave%20Debug%20WK2%20(Tests)/r246525%20(3123)/results.html I was able to reproduce this locally on 246524 but not on 246523 1545640 9 tsavell 2019-06-18 09:44:40 -0700 Reverted r246524 for reason: Caused 45 webgpu/ crashes. Committed r246543: <https://trac.webkit.org/changeset/246543> 1545943 10 mmaxfield 2019-06-18 19:57:35 -0700 Handled by https://bugs.webkit.org/show_bug.cgi?id=198704 *** This bug has been marked as a duplicate of bug 198704 *** 371465 2019-06-05 19:01:44 -0700 2019-06-10 12:12:52 -0700 Patch for landing patch198306 text/plain 2876 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1YmRiODg1YzQ5NS4uZWY3OTQ3MDE0MDcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOS0wNi0wNSAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtXSExTTF0gVGhlIG5hbWUgcmVzb2x2ZXIgZG9lcyBub3QgZGVhbCB3 aXRoIG5hdGl2ZUZ1bmN0aW9uRGVjbGFyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRseSBoYXZlIGEgY3Jhc2ggaW4gdGhlIG5h bWVSZXNvbHZlciB3aGVuIHRyeWluZyB0byB1c2UgdGhlIGZ1bGwgc3RhbmRhcmQgbGlicmFyeS4K KyAgICAgICAgV2hhdCBpcyBoYXBwZW5pbmcgaXMgdGhhdCBiZWNhdXNlIHdlIGRvbid0IHNwZWNp ZnkgYW55dGhpbmcgdG8gZG8gdG8gbmF0aXZlRnVuY3Rpb25EZWNsYXJhdGlvbnMsIG5hbWVzIGlu IHRoZWlyIHBhcmFtZXRlcnMKKyAgICAgICAgYXJlIGFkZGVkIHRvIHRoZSBnbG9iYWwgZW52aXJv bm1lbnQuIEFuZCBzbyBhcyBzb29uIGFzIHdlIGhhdmUgdHdvIHN1Y2ggcGFyYW1ldGVycyB3aXRo IHRoZSBzYW1lIG5hbWUsIHRoZSBuYW1lIHJlc29sdmVyIGZhaWxzLgorCisgICAgICAgICogTW9k dWxlcy93ZWJncHUvV0hMU0wvV0hMU0xOYW1lUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V0hMU0w6Ok5hbWVSZXNvbHZlcjo6dmlzaXQpOgorICAgICAgICAqIE1vZHVsZXMvd2ViZ3B1 L1dITFNML1dITFNMTmFtZVJlc29sdmVyLmg6CisKIDIwMTktMDYtMDUgIFJvYmluIE1vcmlzc2V0 ICA8cm1vcmlzc2V0QGFwcGxlLmNvbT4KIAogICAgICAgICBbV0hMU0xdIFBhcnNpbmcgYW5kIGxl eGluZyB0aGUgc3RhbmRhcmQgbGlicmFyeSBpcyBzbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTE5hbWVSZXNvbHZlci5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTE5hbWVSZXNvbHZlci5jcHAKaW5kZXgg MjFjYTE4ZGNmYTMuLmM4MDA0MjkwZGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL3dlYmdwdS9XSExTTC9XSExTTE5hbWVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xOYW1lUmVzb2x2ZXIuY3BwCkBAIC05NCw2ICs5 NCwxNiBAQCB2b2lkIE5hbWVSZXNvbHZlcjo6dmlzaXQoQVNUOjpGdW5jdGlvbkRlZmluaXRpb24m IGZ1bmN0aW9uRGVmaW5pdGlvbikKICAgICBuZXdOYW1lUmVzb2x2ZXIuY2hlY2tFcnJvckFuZFZp c2l0KGZ1bmN0aW9uRGVmaW5pdGlvbi5ibG9jaygpKTsKIH0KIAordm9pZCBOYW1lUmVzb2x2ZXI6 OnZpc2l0KEFTVDo6TmF0aXZlRnVuY3Rpb25EZWNsYXJhdGlvbiYgbmF0aXZlRnVuY3Rpb25EZWNs YXJhdGlvbikKK3sKKyAgICBOYW1lQ29udGV4dCBuZXdOYW1lQ29udGV4dCgmbV9uYW1lQ29udGV4 dCk7CisgICAgTmFtZVJlc29sdmVyIG5ld05hbWVSZXNvbHZlcihuZXdOYW1lQ29udGV4dCk7Cisg ICAgbmV3TmFtZVJlc29sdmVyLnNldEN1cnJlbnRGdW5jdGlvbkRlZmluaXRpb24obV9jdXJyZW50 RnVuY3Rpb24pOworICAgIGNoZWNrRXJyb3JBbmRWaXNpdChuYXRpdmVGdW5jdGlvbkRlY2xhcmF0 aW9uLnR5cGUoKSk7CisgICAgZm9yIChhdXRvJiBwYXJhbWV0ZXIgOiBuYXRpdmVGdW5jdGlvbkRl Y2xhcmF0aW9uLnBhcmFtZXRlcnMoKSkKKyAgICAgICAgbmV3TmFtZVJlc29sdmVyLmNoZWNrRXJy b3JBbmRWaXNpdChwYXJhbWV0ZXIpOworfQorCiB2b2lkIE5hbWVSZXNvbHZlcjo6dmlzaXQoQVNU OjpCbG9jayYgYmxvY2spCiB7CiAgICAgTmFtZUNvbnRleHQgbmFtZUNvbnRleHQoJm1fbmFtZUNv bnRleHQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wv V0hMU0xOYW1lUmVzb2x2ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNM L1dITFNMTmFtZVJlc29sdmVyLmgKaW5kZXggOGZiNGEzNGZiZDQuLjg5ZjA4NjY5MDc1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTE5hbWVSZXNv bHZlci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMTmFt ZVJlc29sdmVyLmgKQEAgLTQzLDE0ICs0MywxNCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5O YW1lUmVzb2x2ZXIoKSA9IGRlZmF1bHQ7CiAKLSAgICB2b2lkIHZpc2l0KEFTVDo6RnVuY3Rpb25E ZWZpbml0aW9uJikgb3ZlcnJpZGU7Ci0KICAgICB2b2lkIHNldEN1cnJlbnRGdW5jdGlvbkRlZmlu aXRpb24oQVNUOjpGdW5jdGlvbkRlZmluaXRpb24qIGZ1bmN0aW9uRGVmaW5pdGlvbikKICAgICB7 CiAgICAgICAgIG1fY3VycmVudEZ1bmN0aW9uID0gZnVuY3Rpb25EZWZpbml0aW9uOwogICAgIH0K IAogcHJpdmF0ZToKKyAgICB2b2lkIHZpc2l0KEFTVDo6RnVuY3Rpb25EZWZpbml0aW9uJikgb3Zl cnJpZGU7CisgICAgdm9pZCB2aXNpdChBU1Q6Ok5hdGl2ZUZ1bmN0aW9uRGVjbGFyYXRpb24mKSBv dmVycmlkZTsKICAgICB2b2lkIHZpc2l0KEFTVDo6VHlwZVJlZmVyZW5jZSYpIG92ZXJyaWRlOwog ICAgIHZvaWQgdmlzaXQoQVNUOjpCbG9jayYpIG92ZXJyaWRlOwogICAgIHZvaWQgdmlzaXQoQVNU OjpJZlN0YXRlbWVudCYpIG92ZXJyaWRlOwo= 371769 2019-06-10 12:12:52 -0700 2019-06-17 17:06:22 -0700 Patch patch198306 text/plain 3660 rmorisset ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3MmNkN2VjNjc1OC4uOGRhOTNhNjQ0MmUgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxOS0wNi0xMCAgUm9iaW4gTW9yaXNzZXQgIDxybW9yaXNzZXRAYXBwbGUu Y29tPgorCisgICAgICAgIFtXSExTTF0gVGhlIG5hbWUgcmVzb2x2ZXIgZG9lcyBub3QgZGVhbCB3 aXRoIG5hdGl2ZUZ1bmN0aW9uRGVjbGFyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODMwNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlIGN1cnJlbnRseSBoYXZlIGEgY3Jhc2ggaW4gdGhlIG5h bWVSZXNvbHZlciB3aGVuIHRyeWluZyB0byB1c2UgdGhlIGZ1bGwgc3RhbmRhcmQgbGlicmFyeS4K KyAgICAgICAgV2hhdCBpcyBoYXBwZW5pbmcgaXMgdGhhdCBiZWNhdXNlIHdlIGRvbid0IHNwZWNp ZnkgYW55dGhpbmcgdG8gZG8gdG8gbmF0aXZlRnVuY3Rpb25EZWNsYXJhdGlvbnMsIG5hbWVzIGlu IHRoZWlyIHBhcmFtZXRlcnMKKyAgICAgICAgYXJlIGFkZGVkIHRvIHRoZSBnbG9iYWwgZW52aXJv bm1lbnQuIEFuZCBzbyBhcyBzb29uIGFzIHdlIGhhdmUgdHdvIHN1Y2ggcGFyYW1ldGVycyB3aXRo IHRoZSBzYW1lIG5hbWUsIHRoZSBuYW1lIHJlc29sdmVyIGZhaWxzLgorCisgICAgICAgIFRlc3Rl ZCBieSBhZGRpbmcgdHdvIG5hdGl2ZSBmdW5jdGlvbnMgdGhhdCBzaGFyZSBhIHBhcmFtZXRlciBu YW1lIHRvIHRoZSBzdGFuZGFyZCBsaWJyYXJ5LgorCisgICAgICAgICogTW9kdWxlcy93ZWJncHUv V0hMU0wvV0hMU0xOYW1lUmVzb2x2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6V0hMU0w6Ok5h bWVSZXNvbHZlcjo6dmlzaXQpOgorICAgICAgICAqIE1vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNM TmFtZVJlc29sdmVyLmg6CisKIDIwMTktMDYtMTAgIEFsaSBKdW1hICA8YWp1bWFAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJFR1JFU1NJT04gKHIyNDUzOTYpOiBQYWdlIGxvYWQgdGltZSBwZXJm b3JtYW5jZSByZWdyZXNzaW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dl YmdwdS9XSExTTC9XSExTTE5hbWVSZXNvbHZlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L3dlYmdwdS9XSExTTC9XSExTTE5hbWVSZXNvbHZlci5jcHAKaW5kZXggMjFjYTE4ZGNmYTMuLmM4 MDA0MjkwZGVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExT TC9XSExTTE5hbWVSZXNvbHZlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJn cHUvV0hMU0wvV0hMU0xOYW1lUmVzb2x2ZXIuY3BwCkBAIC05NCw2ICs5NCwxNiBAQCB2b2lkIE5h bWVSZXNvbHZlcjo6dmlzaXQoQVNUOjpGdW5jdGlvbkRlZmluaXRpb24mIGZ1bmN0aW9uRGVmaW5p dGlvbikKICAgICBuZXdOYW1lUmVzb2x2ZXIuY2hlY2tFcnJvckFuZFZpc2l0KGZ1bmN0aW9uRGVm aW5pdGlvbi5ibG9jaygpKTsKIH0KIAordm9pZCBOYW1lUmVzb2x2ZXI6OnZpc2l0KEFTVDo6TmF0 aXZlRnVuY3Rpb25EZWNsYXJhdGlvbiYgbmF0aXZlRnVuY3Rpb25EZWNsYXJhdGlvbikKK3sKKyAg ICBOYW1lQ29udGV4dCBuZXdOYW1lQ29udGV4dCgmbV9uYW1lQ29udGV4dCk7CisgICAgTmFtZVJl c29sdmVyIG5ld05hbWVSZXNvbHZlcihuZXdOYW1lQ29udGV4dCk7CisgICAgbmV3TmFtZVJlc29s dmVyLnNldEN1cnJlbnRGdW5jdGlvbkRlZmluaXRpb24obV9jdXJyZW50RnVuY3Rpb24pOworICAg IGNoZWNrRXJyb3JBbmRWaXNpdChuYXRpdmVGdW5jdGlvbkRlY2xhcmF0aW9uLnR5cGUoKSk7Cisg ICAgZm9yIChhdXRvJiBwYXJhbWV0ZXIgOiBuYXRpdmVGdW5jdGlvbkRlY2xhcmF0aW9uLnBhcmFt ZXRlcnMoKSkKKyAgICAgICAgbmV3TmFtZVJlc29sdmVyLmNoZWNrRXJyb3JBbmRWaXNpdChwYXJh bWV0ZXIpOworfQorCiB2b2lkIE5hbWVSZXNvbHZlcjo6dmlzaXQoQVNUOjpCbG9jayYgYmxvY2sp CiB7CiAgICAgTmFtZUNvbnRleHQgbmFtZUNvbnRleHQoJm1fbmFtZUNvbnRleHQpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xOYW1lUmVzb2x2 ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMTmFtZVJlc29s dmVyLmgKaW5kZXggOGZiNGEzNGZiZDQuLjg5ZjA4NjY5MDc1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTE5hbWVSZXNvbHZlci5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMTmFtZVJlc29sdmVyLmgKQEAg LTQzLDE0ICs0MywxNCBAQCBwdWJsaWM6CiAKICAgICB2aXJ0dWFsIH5OYW1lUmVzb2x2ZXIoKSA9 IGRlZmF1bHQ7CiAKLSAgICB2b2lkIHZpc2l0KEFTVDo6RnVuY3Rpb25EZWZpbml0aW9uJikgb3Zl cnJpZGU7Ci0KICAgICB2b2lkIHNldEN1cnJlbnRGdW5jdGlvbkRlZmluaXRpb24oQVNUOjpGdW5j dGlvbkRlZmluaXRpb24qIGZ1bmN0aW9uRGVmaW5pdGlvbikKICAgICB7CiAgICAgICAgIG1fY3Vy cmVudEZ1bmN0aW9uID0gZnVuY3Rpb25EZWZpbml0aW9uOwogICAgIH0KIAogcHJpdmF0ZToKKyAg ICB2b2lkIHZpc2l0KEFTVDo6RnVuY3Rpb25EZWZpbml0aW9uJikgb3ZlcnJpZGU7CisgICAgdm9p ZCB2aXNpdChBU1Q6Ok5hdGl2ZUZ1bmN0aW9uRGVjbGFyYXRpb24mKSBvdmVycmlkZTsKICAgICB2 b2lkIHZpc2l0KEFTVDo6VHlwZVJlZmVyZW5jZSYpIG92ZXJyaWRlOwogICAgIHZvaWQgdmlzaXQo QVNUOjpCbG9jayYpIG92ZXJyaWRlOwogICAgIHZvaWQgdmlzaXQoQVNUOjpJZlN0YXRlbWVudCYp IG92ZXJyaWRlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hM U0wvV0hMU0xTdGFuZGFyZExpYnJhcnkudHh0IGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJn cHUvV0hMU0wvV0hMU0xTdGFuZGFyZExpYnJhcnkudHh0CmluZGV4IDk2NjMwNjcyZDY2Li5kYjI2 MDQxOGNhMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wv V0hMU0xTdGFuZGFyZExpYnJhcnkudHh0CisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2Vi Z3B1L1dITFNML1dITFNMU3RhbmRhcmRMaWJyYXJ5LnR4dApAQCAtNDA3LDQgKzQwNyw3IEBAIG9w ZXJhdG9yIGZsb2F0NChmbG9hdCB4LCBmbG9hdCB5LCBmbG9hdCB6LCBmbG9hdCB3KSB7CiAgICAg cmV0dXJuIHJlc3VsdDsKIH0KIAorbmF0aXZlIHVzaG9ydCBTYW1wbGUoVGV4dHVyZTFEPHVzaG9y dD4sIHNhbXBsZXIsIGZsb2F0IGxvY2F0aW9uKTsKK25hdGl2ZSB1c2hvcnQgU2FtcGxlKFRleHR1 cmUxRDx1c2hvcnQ+LCBzYW1wbGVyLCBmbG9hdCBsb2NhdGlvbiwgaW50IG9mZnNldCk7CisKIC8v IEZJWE1FOiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTkyODkwIElu c2VydCB0aGUgcmVzdCBvZiB0aGUgc3RhbmRhcmQgbGlicmFyeSBvbmNlIHRoZSBwYXJzZXIgaXMg ZmFzdCBlbm91Z2gK