198283 2019-05-28 00:14:36 -0700 [JSC] Enable 16bit CLoop Win 2024-05-19 01:11:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki webkit-bug-importer ysuzuki oldest_to_newest 1539493 0 ysuzuki 2019-05-28 00:14:36 -0700 ... 1540481 1 ysuzuki 2019-05-30 15:41:41 -0700 Windows CLoop in MSVC is half-broken state right now. MSVC can compile it, the semantics of the compiled CLoop::execute seems fine. The problem is, not sure why, MSVC compiled CLoop::execute requires massive amount of stack space... I don't check it carefully, but inserting some currentStackPointer() and diffing the values say CLoop::execute takes almost 100KB stack space. It does not make sense, CLoop::execute should take very few amount of stack space. This leads to very easy stack overflow everywhere. If you call CLoop::execute in a nested manner (maybe) 10 times, then you will see stack-overflow range error will be thrown. I think we should rather switching to LLInt ASM interpreter for Windows. 2036266 2 webkit-bug-importer 2024-05-18 23:11:15 -0700 <rdar://problem/128344991> 2036267 3 ysuzuki 2024-05-18 23:12:23 -0700 Pull request: https://github.com/WebKit/WebKit/pull/28767 2036274 4 ews-feeder 2024-05-19 01:11:28 -0700 Committed 278968@main (2c77a224cdd2): <https://commits.webkit.org/278968@main> Reviewed commits have been landed. Closing PR #28767 and removing active labels.