<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>198274</bug_id>
          
          <creation_ts>2019-05-27 08:15:46 -0700</creation_ts>
          <short_desc>REGRESSION(r244766): [GTK] 2.25.1 does not build on 32-bit ARM due to bit-packing assertion, requires -DENABLE_DARK_MODE_CSS=OFF</short_desc>
          <delta_ts>2019-06-10 15:19:01 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Michael Catanzaro">mcatanzaro</reporter>
          <assigned_to name="Michael Catanzaro">mcatanzaro</assigned_to>
          <cc>berto</cc>
    
    <cc>bugs-noreply</cc>
    
    <cc>commit-queue</cc>
    
    <cc>mcatanzaro</cc>
    
    <cc>pvollan</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>timothy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1539393</commentid>
    <comment_count>0</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-05-27 08:15:46 -0700</bug_when>
    <thetext>2.25.1 is rejected for GNOME because it does not build on aarch64:

FAILED: Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-23.cpp.o 
/usr/bin/c++  -DBUILDING_GTK__=1 -DBUILDING_WEBKIT -DBUILDING_WITH_CMAKE=1 -DBUILDING_WebCore -DGETTEXT_PACKAGE=\&quot;WebKit2GTK-4.0\&quot; -DHAVE_CONFIG_H=1 -DJSC_GLIB_API_ENABLED -DSTATICALLY_LINKED_WITH_PAL=1 -DWEBKITGTK_API_VERSION_STRING=\&quot;4.0\&quot; -IDerivedSources/ForwardingHeaders -I. -IDerivedSources/WebCore -I../Source/WebCore -I../Source/WebCore/Modules/airplay -I../Source/WebCore/Modules/applepay -I../Source/WebCore/Modules/applepay/paymentrequest -I../Source/WebCore/Modules/applicationmanifest -I../Source/WebCore/Modules/beacon -I../Source/WebCore/Modules/cache -I../Source/WebCore/Modules/credentialmanagement -I../Source/WebCore/Modules/encryptedmedia -I../Source/WebCore/Modules/encryptedmedia/legacy -I../Source/WebCore/Modules/entriesapi -I../Source/WebCore/Modules/fetch -I../Source/WebCore/Modules/geolocation -I../Source/WebCore/Modules/indexeddb -I../Source/WebCore/Modules/indexeddb/client -I../Source/WebCore/Modules/indexeddb/server -I../Source/WebCore/Modules/indexeddb/shared -I../Source/WebCore/Modules/mediacapabilities -I../Source/WebCore/Modules/mediacontrols -I../Source/WebCore/Modules/mediarecorder -I../Source/WebCore/Modules/mediasession -I../Source/WebCore/Modules/mediasource -I../Source/WebCore/Modules/mediastream -I../Source/WebCore/Modules/mediastream/libwebrtc -I../Source/WebCore/Modules/navigatorcontentutils -I../Source/WebCore/Modules/notifications -I../Source/WebCore/Modules/paymentrequest -I../Source/WebCore/Modules/plugins -I../Source/WebCore/Modules/quota -I../Source/WebCore/Modules/speech -I../Source/WebCore/Modules/streams -I../Source/WebCore/Modules/webaudio -I../Source/WebCore/Modules/webauthn -I../Source/WebCore/Modules/webauthn/cbor -I../Source/WebCore/Modules/webauthn/fido -I../Source/WebCore/Modules/webdatabase -I../Source/WebCore/Modules/webdriver -I../Source/WebCore/Modules/webgpu -I../Source/WebCore/Modules/websockets -I../Source/WebCore/Modules/webvr -I../Source/WebCore/accessibility -I../Source/WebCore/accessibility/isolatedtree -I../Source/WebCore/animation -I../Source/WebCore/bindings -I../Source/WebCore/bindings/js -I../Source/WebCore/bridge -I../Source/WebCore/bridge/c -I../Source/WebCore/bridge/jsc -I../Source/WebCore/contentextensions -I../Source/WebCore/crypto -I../Source/WebCore/crypto/algorithms -I../Source/WebCore/crypto/keys -I../Source/WebCore/crypto/parameters -I../Source/WebCore/css -I../Source/WebCore/css/parser -I../Source/WebCore/css/typedom -I../Source/WebCore/cssjit -I../Source/WebCore/dom -I../Source/WebCore/dom/messageports -I../Source/WebCore/domjit -I../Source/WebCore/editing -I../Source/WebCore/fileapi -I../Source/WebCore/history -I../Source/WebCore/html -I../Source/WebCore/html/canvas -I../Source/WebCore/html/forms -I../Source/WebCore/html/parser -I../Source/WebCore/html/shadow -I../Source/WebCore/html/track -I../Source/WebCore/inspector -I../Source/WebCore/inspector/agents -I../Source/WebCore/inspector/agents/page -I../Source/WebCore/inspector/agents/worker -I../Source/WebCore/layout -I../Source/WebCore/layout/blockformatting -I../Source/WebCore/layout/displaytree -I../Source/WebCore/layout/floats -I../Source/WebCore/layout/inlineformatting -I../Source/WebCore/layout/inlineformatting/text -I../Source/WebCore/layout/layouttree -I../Source/WebCore/loader -I../Source/WebCore/loader/appcache -I../Source/WebCore/loader/archive -I../Source/WebCore/loader/archive/mhtml -I../Source/WebCore/loader/cache -I../Source/WebCore/loader/icon -I../Source/WebCore/mathml -I../Source/WebCore/page -I../Source/WebCore/page/animation -I../Source/WebCore/page/csp -I../Source/WebCore/page/scrolling -I../Source/WebCore/platform -I../Source/WebCore/platform/animation -I../Source/WebCore/platform/audio -I../Source/WebCore/platform/encryptedmedia -I../Source/WebCore/platform/gamepad -I../Source/WebCore/platform/graphics -I../Source/WebCore/platform/graphics/cpu/arm -I../Source/WebCore/platform/graphics/cpu/arm/filters -I../Source/WebCore/platform/graphics/displaylists -I../Source/WebCore/platform/graphics/filters -I../Source/WebCore/platform/graphics/iso -I../Source/WebCore/platform/graphics/opentype -I../Source/WebCore/platform/graphics/transforms -I../Source/WebCore/platform/mediacapabilities -I../Source/WebCore/platform/mediarecorder -I../Source/WebCore/platform/mediasession -I../Source/WebCore/platform/mediastream -I../Source/WebCore/platform/mediastream/libwebrtc -I../Source/WebCore/platform/mock -I../Source/WebCore/platform/mock/mediasource -I../Source/WebCore/platform/network -I../Source/WebCore/platform/sql -I../Source/WebCore/platform/text -I../Source/WebCore/platform/vr -I../Source/WebCore/plugins -I../Source/WebCore/rendering -I../Source/WebCore/rendering/line -I../Source/WebCore/rendering/mathml -I../Source/WebCore/rendering/shapes -I../Source/WebCore/rendering/style -I../Source/WebCore/rendering/svg -I../Source/WebCore/rendering/updating -I../Source/WebCore/replay -I../Source/WebCore/storage -I../Source/WebCore/style -I../Source/WebCore/svg -I../Source/WebCore/svg/animation -I../Source/WebCore/svg/graphics -I../Source/WebCore/svg/graphics/filters -I../Source/WebCore/svg/properties -I../Source/WebCore/websockets -I../Source/WebCore/workers -I../Source/WebCore/workers/service -I../Source/WebCore/workers/service/context -I../Source/WebCore/workers/service/server -I../Source/WebCore/worklets -I../Source/WebCore/xml -I../Source/WebCore/xml/parser -I../Source/WebCore/platform/graphics/gpu -I../Source/ThirdParty/xdgmime/src -I../Source/WebCore/platform/graphics/cairo -I../Source/WebCore/platform/graphics/freetype -I../Source/WebCore/platform/graphics/harfbuzz -I../Source/WebCore/platform/graphics/harfbuzz/ng -I../Source/WebCore/platform/graphics/gstreamer -I../Source/WebCore/platform/graphics/gstreamer/mse -I../Source/WebCore/platform/graphics/gstreamer/eme -I../Source/WebCore/platform/audio/gstreamer -I../Source/WebCore/platform/image-decoders -I../Source/WebCore/platform/image-decoders/bmp -I../Source/WebCore/platform/image-decoders/gif -I../Source/WebCore/platform/image-decoders/ico -I../Source/WebCore/platform/image-decoders/jpeg -I../Source/WebCore/platform/image-decoders/jpeg2000 -I../Source/WebCore/platform/image-decoders/png -I../Source/WebCore/platform/image-decoders/webp -I../Source/WebCore/platform/network/soup -I../Source/WebCore/platform/graphics/texmap -I../Source/WebCore/page/scrolling/nicosia -I../Source/WebCore/platform/graphics/texmap/coordinated -I../Source/WebCore/platform/graphics/nicosia -I../Source/WebCore/platform/graphics/nicosia/cairo -I../Source/WebCore/platform/graphics/nicosia/texmap -I../Source/WebCore/accessibility/atk -I../Source/WebCore/editing/atk -I../Source/WebCore/page/gtk -I../Source/WebCore/platform/generic -I../Source/WebCore/platform/gtk -I../Source/WebCore/platform/graphics/egl -I../Source/WebCore/platform/graphics/glx -I../Source/WebCore/platform/graphics/gtk -I../Source/WebCore/platform/graphics/opengl -I../Source/WebCore/platform/graphics/wayland -I../Source/WebCore/platform/graphics/x11 -I../Source/WebCore/platform/mediastream/gtk -I../Source/WebCore/platform/mediastream/gstreamer -I../Source/WebCore/platform/network/gtk -I../Source/WebCore/platform/text/gtk -I../Source/WebCore/bindings/gobject -IDerivedSources -I../Source/ThirdParty -isystem /usr/include/libxml2 -isystem /usr/include/cairo -isystem /usr/include/freetype2 -isystem /usr/include/harfbuzz -isystem /usr/include/gstreamer-1.0 -isystem /usr/include/glib-2.0 -isystem /usr/lib/arm-linux-gnueabihf/glib-2.0/include -isystem /usr/lib/arm-linux-gnueabihf/libffi-3.2.1/include -isystem /usr/include/orc-0.4 -isystem /usr/lib/arm-linux-gnueabihf/gstreamer-1.0/include -isystem /usr/include/libdrm -isystem /usr/include/openjpeg-2.3 -isystem /usr/include/libsoup-2.4 -isystem /usr/include/atk-1.0 -isystem /usr/include/enchant-2 -isystem /usr/include/gio-unix-2.0 -isystem /usr/include/libmount -isystem /usr/include/blkid -isystem /usr/include/uuid -isystem /usr/include/libsecret-1 -fdiagnostics-color=always -Wextra -Wall -Wno-expansion-to-defined -Wno-psabi -Wno-noexcept-type -Wno-maybe-uninitialized -Wwrite-strings -Wundef -Wpointer-arith -Wmissing-format-attribute -Wformat-security -Wcast-align -O2 -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions -fstack-protector-strong -grecord-gcc-switches -g1 -fno-strict-aliasing -fno-exceptions -fno-rtti -std=c++17 -O3 -DNDEBUG -fPIC -MD -MT Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-23.cpp.o -MF Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-23.cpp.o.d -o Source/WebCore/CMakeFiles/WebCore.dir/__/__/DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-23.cpp.o -c DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-23.cpp
In file included from DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:32,
                 from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:25,
                 from ../Source/WebCore/config.h:50,
                 from ../Source/WebCore/rendering/style/StyleGeneratedImage.cpp:24,
                 from DerivedSources/WebCore/unified-sources/UnifiedSource-043dd90b-23.cpp:1:
../Source/WebCore/rendering/style/StyleRareInheritedData.cpp:78:47: error: static assertion failed: StyleRareInheritedData_should_bit_pack
 COMPILE_ASSERT(sizeof(StyleRareInheritedData) &lt;= sizeof(GreaterThanOrSameSizeAsStyleRareInheritedData), StyleRareInheritedData_should_bit_pack);
DerivedSources/ForwardingHeaders/wtf/Assertions.h:440:50: note: in definition of macro ‘COMPILE_ASSERT’
 #define COMPILE_ASSERT(exp, name) static_assert((exp), #name)
                                                  ^~~


Suspicious change to StyleRareInheritedData is:

#if ENABLE(DARK_MODE_CSS)
    StyleColorScheme colorScheme;
#endif</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1541120</commentid>
    <comment_count>1</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-02 13:06:36 -0700</bug_when>
    <thetext>Same failure on 32-bit ARM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1542089</commentid>
    <comment_count>2</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-05 11:20:33 -0700</bug_when>
    <thetext>I was able to get 2.25.1 into GNOME by using -DENABLE_DARK_MODE_CSS=OFF (not great!). We will have to remove that build flag from gnome-build-meta when this is fixed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1542560</commentid>
    <comment_count>3</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-06 14:50:59 -0700</bug_when>
    <thetext>I&apos;m struggling to figure out what the problem is here:

 * We know Fedora (which uses GCC 9) is not affected
 * We know our aarch64 bot (not sure which GCC it uses) is not affected
 * We know from Berto that Debian is affected
 * We know from me that GNOME (which uses GCC 8) is affected

I&apos;ve tested a modified buildroot configured to build 2.25.1 with both GCC 7 and GCC 8, with good results. Stumped. We can&apos;t plausibly debug this without access to an affected build machine.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1542745</commentid>
    <comment_count>4</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2019-06-06 23:32:16 -0700</bug_when>
    <thetext>(In reply to Michael Catanzaro from comment #3)
&gt;  * We know from Berto that Debian is affected

Debian can build 2.25.1 for aarch64:

https://buildd.debian.org/status/package.php?p=webkit2gtk&amp;suite=experimental</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1542816</commentid>
    <comment_count>5</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-07 07:10:38 -0700</bug_when>
    <thetext>Fedora reports having trouble only on 32-bit ARM. Sounds like it&apos;s the same for Debian.

Reviewing our build logs, I see I&apos;ve been wrong about this the whole time. This error only occurs on 32-bit ARM. For aarch64, our original build failure is mysterious, with no error message whatsoever that I can see. There is probably an error buried in there somewhere, impossible to see past all the spam from bug #198014, but it&apos;s not a normal GCC error since the string &quot;error:&quot; doesn&apos;t appear anywhere in the logs.

So I wasted a bunch of time building for aarch64 yesterday. Will try again with 32-bit ARM now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1542853</commentid>
    <comment_count>6</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-07 09:59:10 -0700</bug_when>
    <thetext>CCing some people who have edited these structs recently.

I stole from https://stackoverflow.com/a/43434880/1120203:

#define COMPILE_TIME_SIZEOF(t)      template&lt;int s&gt; struct SIZEOF_ ## t ## _IS; \
                                    struct foo { \
                                        int a,b; \
                                    }; \
                                    SIZEOF_ ## t ## _IS&lt;sizeof(t)&gt; SIZEOF_ ## t ## _IS;

COMPILE_TIME_SIZEOF(StyleRareInheritedData);
COMPILE_TIME_SIZEOF(GreaterThanOrSameSizeAsStyleRareInheritedData);

With this, I learned:

 * The size of both structs on x86_64 is currently 272
 * The size of StyleRareInheritedData on ARM is currently 224
 * The size of GreaterThanOrSameSizeAsStyleRareInheritedData on ARM is currently 216. Bad!

Before r244766 &quot;[GTK] Support prefers-color-scheme media query&quot;, the size of both structs on ARM was 216, so the dark mode CSS is to &quot;blame,&quot; even though that change itself looks good; the problem had just been latent before.

The very first thing I tried was moving void* customPropertyDataRefs[1] in GreaterThanOrSameSizeAsStyleRareInheritedData from the bottom of the struct to up between TextDecorationThickness thickness and unsigned bitfields[4], which successfully increased the size of GreaterThanOrSameSizeAsStyleRareInheritedData to 224. Of course, this sort of defeats the goal of ensuring that StyleRareInheritedData remains small, but the logic behind the desired packing is quite unclear. Obviously it must be possible to reduce the size of StyleRareInheritedData down to 216 bytes by moving everything around, but this would reduce the readability of the struct, and since this isn&apos;t code I&apos;m familiar with, I&apos;d rather not touch that myself, so my patch will just increase the size of GreaterThanOrSameSizeAsStyleRareInheritedData to keep things simple.

After this change, both structs are 224 bytes on ARM. StyleRareInheritedData remains unchanged at 272 bytes on x86_64. But GreaterThanOrSameSizeAsStyleRareInheritedData increases to 280 bytes on x86_64. Not ideal, but again, I really don&apos;t understand how to keep the size down without reordering everything to be exactly the same order as GreaterThanOrSameSizeAsStyleRareInheritedData, and even then the order of the members of GreaterThanOrSameSizeAsStyleRareInheritedData seems pretty arbitrary. So other reviewers&apos; opinions would be great here.

I *suspect* this change will allow us to remove this obsolete member from GreaterThanOrSameSizeAsStyleRareInheritedData:

#if PLATFORM(IOS_FAMILY)
    Color compositionColor; // FIXME: this has gone.
#endif

which is probably currently needed to prevent iOS from encountering this build failure. But of course, no way to know without first trying it on EWS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1542854</commentid>
    <comment_count>7</comment_count>
      <attachid>371591</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-07 09:59:18 -0700</bug_when>
    <thetext>Created attachment 371591
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543318</commentid>
    <comment_count>8</comment_count>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-10 07:14:34 -0700</bug_when>
    <thetext>Ping reviewers

I&apos;ll push unreviewed if nobody wants to review it, since this is an important build fix. But a review would be great.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543475</commentid>
    <comment_count>9</comment_count>
      <attachid>371591</attachid>
    <who name="Michael Catanzaro">mcatanzaro</who>
    <bug_when>2019-06-10 14:49:27 -0700</bug_when>
    <thetext>Comment on attachment 371591
Patch

OK then, thanks Timothy!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543490</commentid>
    <comment_count>10</comment_count>
      <attachid>371591</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-06-10 15:18:59 -0700</bug_when>
    <thetext>Comment on attachment 371591
Patch

Clearing flags on attachment: 371591

Committed r246286: &lt;https://trac.webkit.org/changeset/246286&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1543491</commentid>
    <comment_count>11</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2019-06-10 15:19:01 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>371591</attachid>
            <date>2019-06-07 09:59:18 -0700</date>
            <delta_ts>2019-06-10 15:18:59 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-198274-20190607115917.patch</filename>
            <type>text/plain</type>
            <size>2247</size>
            <attacher name="Michael Catanzaro">mcatanzaro</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ2MTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTc3NGM5MGNiNzdkODM3
ZjBmOWZiMTUyMDJkOWUwNzNhOTY1M2RjMi4uZjQ1ZGU0NTdhM2JiMmVhMDlkODlmMTEwMWQzMmRh
N2UyN2I4N2EzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA2LTA3ICBNaWNo
YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSAy
LjI1LjEgZG9lcyBub3QgYnVpbGQgb24gMzItYml0IEFSTSBkdWUgdG8gYml0LXBhY2tpbmcgYXNz
ZXJ0aW9uLCByZXF1aXJlcyAtREVOQUJMRV9EQVJLX01PREVfQ1NTPU9GRgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4Mjc0CisKKyAgICAgICAgUmV2
aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmF0aGVyIHRoYW4gcmVvcmRlciBl
dmVyeXRoaW5nIGluIFN0eWxlUmFyZUluaGVyaXRlZERhdGEsIGxldCdzIHNsaWdodGx5IGluY3Jl
YXNlIHRoZSBzaXplCisgICAgICAgIG9mIEdyZWF0ZXJUaGFuT3JTYW1lU2l6ZUFzU3R5bGVSYXJl
SW5oZXJpdGVkRGF0YSB0byBhbGxvdyB0aGUgc3RhdGljIGFzc2VydCB0byBwYXNzLgorCisgICAg
ICAgIEF0IHRoZSBzYW1lIHRpbWUsIHJlbW92ZSBhbiBvYnNvbG90ZSBpT1Mtc3BlY2lmaWMgbWVt
YmVyIHRoYXQgaXMgcHJvYmFibHkgbm8gbG9uZ2VyIG5lZWRlZC4KKworICAgICAgICAqIHJlbmRl
cmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmNwcDoKKwogMjAxOS0wNi0wNyAgTWlj
aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g
R0xDb250ZXh0RUdMLmggbXVzdCBiZSBidWlsdCB3aXRoIEBuby11bmlmeQpkaWZmIC0tZ2l0IGEv
U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuY3Bw
IGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEu
Y3BwCmluZGV4IDFmMjJhMWE1YTRhNTllMjhmOWQwMTc4NTc4ZGNkOTY2M2QwYjI4ZDUuLjE0ZTMx
YjVjNTA2YWZmZDUzYTZiYTkzNGEwYzVjMTJlNzA5ZmIwNTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X
ZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmNwcAorKysgYi9T
b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5jcHAK
QEAgLTQ4LDE0ICs0OCwxMiBAQCBzdHJ1Y3QgR3JlYXRlclRoYW5PclNhbWVTaXplQXNTdHlsZVJh
cmVJbmhlcml0ZWREYXRhIDogcHVibGljIFJlZkNvdW50ZWQ8R3JlYXRlcgogICAgIGZsb2F0IHNl
Y29uZEZsb2F0OwogICAgIFRleHRVbmRlcmxpbmVPZmZzZXQgb2Zmc2V0OwogICAgIFRleHREZWNv
cmF0aW9uVGhpY2tuZXNzIHRoaWNrbmVzczsKKyAgICB2b2lkKiBjdXN0b21Qcm9wZXJ0eURhdGFS
ZWZzWzFdOwogICAgIHVuc2lnbmVkIGJpdGZpZWxkc1s0XTsKICAgICBzaG9ydCBwYWdlZE1lZGlh
U2hvcnRzWzJdOwogICAgIFRhYlNpemUgdGFiU2l6ZTsKICAgICBzaG9ydCBoeXBoZW5hdGlvblNo
b3J0c1szXTsKIAotI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCi0gICAgQ29sb3IgY29tcG9zaXRp
b25Db2xvcjsgLy8gRklYTUU6IHRoaXMgaGFzIGdvbmUuCi0jZW5kaWYKICNpZiBFTkFCTEUoVEVY
VF9BVVRPU0laSU5HKQogICAgIFRleHRTaXplQWRqdXN0bWVudCB0ZXh0U2l6ZUFkanVzdDsKICNl
bmRpZgpAQCAtNzEsOCArNjksNiBAQCBzdHJ1Y3QgR3JlYXRlclRoYW5PclNhbWVTaXplQXNTdHls
ZVJhcmVJbmhlcml0ZWREYXRhIDogcHVibGljIFJlZkNvdW50ZWQ8R3JlYXRlcgogI2lmIEVOQUJM
RShEQVJLX01PREVfQ1NTKQogICAgIFN0eWxlQ29sb3JTY2hlbWUgY29sb3JTY2hlbWU7CiAjZW5k
aWYKLQotICAgIHZvaWQqIGN1c3RvbVByb3BlcnR5RGF0YVJlZnNbMV07CiB9OwogCiBDT01QSUxF
X0FTU0VSVChzaXplb2YoU3R5bGVSYXJlSW5oZXJpdGVkRGF0YSkgPD0gc2l6ZW9mKEdyZWF0ZXJU
aGFuT3JTYW1lU2l6ZUFzU3R5bGVSYXJlSW5oZXJpdGVkRGF0YSksIFN0eWxlUmFyZUluaGVyaXRl
ZERhdGFfc2hvdWxkX2JpdF9wYWNrKTsK
</data>

          </attachment>
      

    </bug>

</bugzilla>