198214 2019-05-23 22:29:46 -0700 Update messages_unittest.py after r245715 2019-05-24 13:00:50 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf achristensen ap cdumez commit-queue ryanhaddad webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1538940 0 youennf 2019-05-23 22:29:46 -0700 Update messages_unittest.py after https://trac.webkit.org/changeset/245715 to cope with messages.py changes. 1538942 1 370563 youennf 2019-05-23 22:33:25 -0700 Created attachment 370563 Patch 1538995 2 370563 ap 2019-05-24 09:58:19 -0700 Comment on attachment 370563 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370563&action=review > Source/WebKit/ChangeLog:3 > + Update messages_unittest.py after https://trac.webkit.org/changeset/245715 Probably enough to say r245715 here. > Source/WebKit/ChangeLog:9 > + Small update to messages.py so that cancelReply is called in case of decoding error. The patch looks good overall, but the ChangeLog confuses me. Isn't the change to messages.py more important? I know that we don't expect this path to be taken, but it has some potential for changing observed behavior anyway. If that happens, everyone will be confused by the title. 1539005 3 youennf 2019-05-24 10:58:53 -0700 (In reply to Alexey Proskuryakov from comment #2) > Comment on attachment 370563 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370563&action=review > > > Source/WebKit/ChangeLog:3 > > + Update messages_unittest.py after https://trac.webkit.org/changeset/245715 > > Probably enough to say r245715 here. Will do. > > Source/WebKit/ChangeLog:9 > > + Small update to messages.py so that cancelReply is called in case of decoding error. > > The patch looks good overall, but the ChangeLog confuses me. Isn't the > change to messages.py more important? I know that we don't expect this path > to be taken, but it has some potential for changing observed behavior > anyway. If that happens, everyone will be confused by the title. Will update the changelog. This patch does not change observed behavior though, r245715 does. The changes here to messages.py are just to call cancelReply in case of decode error instead of calling completionHandler(IPC::AsyncReplyError<>...) as done in r245715. 1539006 4 370577 youennf 2019-05-24 11:08:04 -0700 Created attachment 370577 Patch for landing 1539023 5 370577 commit-queue 2019-05-24 11:55:35 -0700 Comment on attachment 370577 Patch for landing Clearing flags on attachment: 370577 Committed r245749: <https://trac.webkit.org/changeset/245749> 1539024 6 commit-queue 2019-05-24 11:55:36 -0700 All reviewed patches have been landed. Closing bug. 1539025 7 webkit-bug-importer 2019-05-24 11:56:30 -0700 <rdar://problem/51115730> 1539042 8 ap 2019-05-24 13:00:50 -0700 > The changes here to messages.py are just to call cancelReply in case of decode error instead of calling completionHandler(IPC::AsyncReplyError<>...) as done in r245715. Which is a change in behavior. 370563 2019-05-23 22:33:25 -0700 2019-05-24 11:08:02 -0700 Patch bug-198214-20190523223324.patch text/plain 4529 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NTY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDRhYTQzM2UwZDFiY2YxNjA0 NTM4NTkzNmEyZmVlYzc5NDU5YzYwMTguLjliYjMxNjQzNmU2MmEzYzRlNmZlODgyZGY2ZjVmZDYz MTQ4ZDE3YTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDUtMjMgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBtZXNzYWdlc191bml0 dGVzdC5weSBhZnRlciBodHRwczovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMjQ1NzE1Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgyMTQKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgZXhw ZWN0ZWQgcmVzdWx0cyBmb3IgbWVzc2FnZXMucHkgb3V0cHV0LgorICAgICAgICBTbWFsbCB1cGRh dGUgdG8gbWVzc2FnZXMucHkgc28gdGhhdCBjYW5jZWxSZXBseSBpcyBjYWxsZWQgaW4gY2FzZSBv ZiBkZWNvZGluZyBlcnJvci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0L01lc3NhZ2VSZWNl aXZlclN1cGVyY2xhc3MtZXhwZWN0ZWQuY3BwOgorICAgICAgICAoTWVzc2FnZXM6OldlYlBhZ2U6 OlRlc3RBc3luY01lc3NhZ2U6OmNhbGxSZXBseSk6CisgICAgICAgIChNZXNzYWdlczo6V2ViUGFn ZTo6VGVzdEFzeW5jTWVzc2FnZTo6Y2FuY2VsUmVwbHkpOgorICAgICAgICAoTWVzc2FnZXM6Oldl YlBhZ2U6OlRlc3RBc3luY01lc3NhZ2VXaXRoTXVsdGlwbGVBcmd1bWVudHM6OmNhbGxSZXBseSk6 CisgICAgICAgIChNZXNzYWdlczo6V2ViUGFnZTo6VGVzdEFzeW5jTWVzc2FnZVdpdGhNdWx0aXBs ZUFyZ3VtZW50czo6Y2FuY2VsUmVwbHkpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0L21lc3Nh Z2VzLnB5OgorCiAyMDE5LTA1LTIyICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4K IAogICAgICAgICBDYWNoZVN0b3JhZ2VDb25uZWN0aW9uIGNhbGxiYWNrcyBzaG91bGQgYmUgY29t cGxldGVkIG9uIG5ldHdvcmsgY29ubmVjdGlvbiBjbG9zZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9TY3JpcHRzL3dlYmtpdC9NZXNzYWdlUmVjZWl2ZXJTdXBlcmNsYXNzLWV4cGVjdGVkLmNw cCBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvTWVzc2FnZVJlY2VpdmVyU3VwZXJjbGFz cy1leHBlY3RlZC5jcHAKaW5kZXggZTJmOTYyZjIxYWZmOTJiMjFhMDI3ODI5MDY4ODMxNmFiY2Jl MmQ5MC4uMTQyMTJkNWM4YWE1MTI4MDU2MDBhZmFjOWJhMjc3YmQ1MzFmYTM3MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC9NZXNzYWdlUmVjZWl2ZXJTdXBlcmNsYXNz LWV4cGVjdGVkLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0L01lc3NhZ2VS ZWNlaXZlclN1cGVyY2xhc3MtZXhwZWN0ZWQuY3BwCkBAIC00OSw2ICs0OSw3IEBAIHZvaWQgVGVz dEFzeW5jTWVzc2FnZTo6Y2FsbFJlcGx5KElQQzo6RGVjb2RlciYgZGVjb2RlciwgQ29tcGxldGlv bkhhbmRsZXI8dm9pZCh1CiAgICAgZGVjb2RlciA+PiByZXN1bHQ7CiAgICAgaWYgKCFyZXN1bHQp IHsKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAgIGNhbmNlbFJlcGx5KFdU Rk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBj b21wbGV0aW9uSGFuZGxlcihXVEZNb3ZlKCpyZXN1bHQpKTsKQEAgLTU2LDcgKzU3LDcgQEAgdm9p ZCBUZXN0QXN5bmNNZXNzYWdlOjpjYWxsUmVwbHkoSVBDOjpEZWNvZGVyJiBkZWNvZGVyLCBDb21w bGV0aW9uSGFuZGxlcjx2b2lkKHUKIAogdm9pZCBUZXN0QXN5bmNNZXNzYWdlOjpjYW5jZWxSZXBs eShDb21wbGV0aW9uSGFuZGxlcjx2b2lkKHVpbnQ2NF90JiYpPiYmIGNvbXBsZXRpb25IYW5kbGVy KQogewotICAgIGNvbXBsZXRpb25IYW5kbGVyKHsgfSk7CisgICAgY29tcGxldGlvbkhhbmRsZXIo SVBDOjpBc3luY1JlcGx5RXJyb3I8dWludDY0X3Q+OjpjcmVhdGUoKSk7CiB9CiAKIHZvaWQgVGVz dEFzeW5jTWVzc2FnZTo6c2VuZChzdGQ6OnVuaXF1ZV9wdHI8SVBDOjpFbmNvZGVyPiYmIGVuY29k ZXIsIElQQzo6Q29ubmVjdGlvbiYgY29ubmVjdGlvbiwgdWludDY0X3QgcmVzdWx0KQpAQCAtOTQs MTIgKzk1LDE0IEBAIHZvaWQgVGVzdEFzeW5jTWVzc2FnZVdpdGhNdWx0aXBsZUFyZ3VtZW50czo6 Y2FsbFJlcGx5KElQQzo6RGVjb2RlciYgZGVjb2RlciwgQ29tCiAgICAgZGVjb2RlciA+PiBmbGFn OwogICAgIGlmICghZmxhZykgewogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAg ICAgY2FuY2VsUmVwbHkoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpOwogICAgICAgICByZXR1 cm47CiAgICAgfQogICAgIE9wdGlvbmFsPHVpbnQ2NF90PiB2YWx1ZTsKICAgICBkZWNvZGVyID4+ IHZhbHVlOwogICAgIGlmICghdmFsdWUpIHsKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7 CisgICAgICAgIGNhbmNlbFJlcGx5KFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAgICAg ICAgcmV0dXJuOwogICAgIH0KICAgICBjb21wbGV0aW9uSGFuZGxlcihXVEZNb3ZlKCpmbGFnKSwg V1RGTW92ZSgqdmFsdWUpKTsKQEAgLTEwNyw3ICsxMTAsNyBAQCB2b2lkIFRlc3RBc3luY01lc3Nh Z2VXaXRoTXVsdGlwbGVBcmd1bWVudHM6OmNhbGxSZXBseShJUEM6OkRlY29kZXImIGRlY29kZXIs IENvbQogCiB2b2lkIFRlc3RBc3luY01lc3NhZ2VXaXRoTXVsdGlwbGVBcmd1bWVudHM6OmNhbmNl bFJlcGx5KENvbXBsZXRpb25IYW5kbGVyPHZvaWQoYm9vbCYmLCB1aW50NjRfdCYmKT4mJiBjb21w bGV0aW9uSGFuZGxlcikKIHsKLSAgICBjb21wbGV0aW9uSGFuZGxlcih7IH0sIHsgfSk7CisgICAg Y29tcGxldGlvbkhhbmRsZXIoSVBDOjpBc3luY1JlcGx5RXJyb3I8Ym9vbD46OmNyZWF0ZSgpLCBJ UEM6OkFzeW5jUmVwbHlFcnJvcjx1aW50NjRfdD46OmNyZWF0ZSgpKTsKIH0KIAogdm9pZCBUZXN0 QXN5bmNNZXNzYWdlV2l0aE11bHRpcGxlQXJndW1lbnRzOjpzZW5kKHN0ZDo6dW5pcXVlX3B0cjxJ UEM6OkVuY29kZXI+JiYgZW5jb2RlciwgSVBDOjpDb25uZWN0aW9uJiBjb25uZWN0aW9uLCBib29s IGZsYWcsIHVpbnQ2NF90IHZhbHVlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TY3JpcHRz L3dlYmtpdC9tZXNzYWdlcy5weSBiL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvbWVzc2Fn ZXMucHkKaW5kZXggNTI1MTQ5MDJhYmJlMWNjNzE0NmI0M2JlN2NkOGM0NmJhYjQ5MDU4OC4uOWU2 ZTkzMjA2YmRjMWIwMTAyMmRlYTUwNDRkMjgzM2JkNWU5NGVkYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9TY3JpcHRzL3dlYmtpdC9tZXNzYWdlcy5weQorKysgYi9Tb3VyY2UvV2ViS2l0L1Nj cmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5CkBAIC01OTQsOSArNTk0LDcgQEAgZGVmIGdlbmVyYXRl X21lc3NhZ2VfaGFuZGxlcihmaWxlKToKICAgICAgICAgICAgICAgICBmb3IgeCBpbiBtZXNzYWdl LnJlcGx5X3BhcmFtZXRlcnM6CiAgICAgICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJyAg ICBPcHRpb25hbDwlcz4gJXM7XG4nICUgKHgudHlwZSwgeC5uYW1lKSkKICAgICAgICAgICAgICAg ICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIGRlY29kZXIgPj4gJXM7XG4nICUgeC5uYW1lKQotICAg ICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKCcgICAgaWYgKCElcykge1xuICAgICAgICBB U1NFUlRfTk9UX1JFQUNIRUQoKTtcbiAgICAgICAgY29tcGxldGlvbkhhbmRsZXIoJyAlIHgubmFt ZSkKLSAgICAgICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgnLCAnLmpvaW4oWydJUEM6OkFz eW5jUmVwbHlFcnJvcjwnICsgeC50eXBlICsgJz46OmNyZWF0ZSgpJyBmb3IgeCBpbiBtZXNzYWdl LnJlcGx5X3BhcmFtZXRlcnNdKSkKLSAgICAgICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgn KTtcbiAgICAgICAgcmV0dXJuO1xuICAgIH1cbicpCisgICAgICAgICAgICAgICAgICAgIHJlc3Vs dC5hcHBlbmQoJyAgICBpZiAoISVzKSB7XG4gICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpO1xu ICAgICAgICBjYW5jZWxSZXBseShXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7XG4gICAgICAg IHJldHVybjtcbiAgICB9XG4nICUgeC5uYW1lKQogICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBl bmQoJyAgICBjb21wbGV0aW9uSGFuZGxlcignKQogICAgICAgICAgICAgICAgIGlmIGxlbihtZXNz YWdlLnJlcGx5X3BhcmFtZXRlcnMpOgogICAgICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5k KCdXVEZNb3ZlKColcyknICUgKCcpLCBXVEZNb3ZlKConLmpvaW4oeC5uYW1lIGZvciB4IGluIG1l c3NhZ2UucmVwbHlfcGFyYW1ldGVycykpKQo= 370577 2019-05-24 11:08:04 -0700 2019-05-24 11:55:35 -0700 Patch for landing bug-198214-20190524110803.patch text/plain 4584 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NzQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc2Y2YyNDAwMGFkNzYzMGVj OGVkZDI3ZDRkZWQ2OWNlYTc1ZmMzNGUuLjNkYmI1YzJhN2RiN2RhNzJjNDIwMDMyYjIzYTVhYTE4 MWUwNGNkYTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTktMDUtMjQgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFVwZGF0ZSBtZXNzYWdlc191bml0 dGVzdC5weSBhZnRlciByMjQ1NzE1CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xOTgyMTQKKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1 cnlha292LgorCisgICAgICAgIFVwZGF0ZSBleHBlY3RlZCByZXN1bHRzIGZvciBtZXNzYWdlcy5w eSBvdXRwdXQuaQorICAgICAgICBTbWFsbCByZWZhY3RvcmluZyB0byBtZXNzYWdlcy5weTogaW5z dGVhZCBvZiBjYWxsaW5nIHRoZSBjb21wbGV0aW9uSGFuZGxlciBpbiBjYXNlIG9mIGRlY29kaW5n IGVycm9yIHdpdGggQXN5bmNSZXBseSBlcnJvcnMsCisgICAgICAgIGNhbGwgY2FuY2VsUmVwbHkg ZGlyZWN0bHkgYXMgaXQgZG9lcyB0aGUgc2FtZSB0aGluZy4KKworICAgICAgICAqIFNjcmlwdHMv d2Via2l0L01lc3NhZ2VSZWNlaXZlclN1cGVyY2xhc3MtZXhwZWN0ZWQuY3BwOgorICAgICAgICAo TWVzc2FnZXM6OldlYlBhZ2U6OlRlc3RBc3luY01lc3NhZ2U6OmNhbGxSZXBseSk6CisgICAgICAg IChNZXNzYWdlczo6V2ViUGFnZTo6VGVzdEFzeW5jTWVzc2FnZTo6Y2FuY2VsUmVwbHkpOgorICAg ICAgICAoTWVzc2FnZXM6OldlYlBhZ2U6OlRlc3RBc3luY01lc3NhZ2VXaXRoTXVsdGlwbGVBcmd1 bWVudHM6OmNhbGxSZXBseSk6CisgICAgICAgIChNZXNzYWdlczo6V2ViUGFnZTo6VGVzdEFzeW5j TWVzc2FnZVdpdGhNdWx0aXBsZUFyZ3VtZW50czo6Y2FuY2VsUmVwbHkpOgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0L21lc3NhZ2VzLnB5OgorCiAyMDE5LTA1LTIzICBSb3NzIEtpcnNsaW5nICA8 cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAgICBTb2NrZXQtYmFzZWQgUldJIHNob3Vs ZCBiZSBhYmxlIHRvIGluc3BlY3QgYSBKU0NvbnRleHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvU2NyaXB0cy93ZWJraXQvTWVzc2FnZVJlY2VpdmVyU3VwZXJjbGFzcy1leHBlY3RlZC5jcHAg Yi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0L01lc3NhZ2VSZWNlaXZlclN1cGVyY2xhc3Mt ZXhwZWN0ZWQuY3BwCmluZGV4IGUyZjk2MmYyMWFmZjkyYjIxYTAyNzgyOTA2ODgzMTZhYmNiZTJk OTAuLjE0MjEyZDVjOGFhNTEyODA1NjAwYWZhYzliYTI3N2JkNTMxZmEzNzAgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93ZWJraXQvTWVzc2FnZVJlY2VpdmVyU3VwZXJjbGFzcy1l eHBlY3RlZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9TY3JpcHRzL3dlYmtpdC9NZXNzYWdlUmVj ZWl2ZXJTdXBlcmNsYXNzLWV4cGVjdGVkLmNwcApAQCAtNDksNiArNDksNyBAQCB2b2lkIFRlc3RB c3luY01lc3NhZ2U6OmNhbGxSZXBseShJUEM6OkRlY29kZXImIGRlY29kZXIsIENvbXBsZXRpb25I YW5kbGVyPHZvaWQodQogICAgIGRlY29kZXIgPj4gcmVzdWx0OwogICAgIGlmICghcmVzdWx0KSB7 CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgICAgICBjYW5jZWxSZXBseShXVEZN b3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgY29t cGxldGlvbkhhbmRsZXIoV1RGTW92ZSgqcmVzdWx0KSk7CkBAIC01Niw3ICs1Nyw3IEBAIHZvaWQg VGVzdEFzeW5jTWVzc2FnZTo6Y2FsbFJlcGx5KElQQzo6RGVjb2RlciYgZGVjb2RlciwgQ29tcGxl dGlvbkhhbmRsZXI8dm9pZCh1CiAKIHZvaWQgVGVzdEFzeW5jTWVzc2FnZTo6Y2FuY2VsUmVwbHko Q29tcGxldGlvbkhhbmRsZXI8dm9pZCh1aW50NjRfdCYmKT4mJiBjb21wbGV0aW9uSGFuZGxlcikK IHsKLSAgICBjb21wbGV0aW9uSGFuZGxlcih7IH0pOworICAgIGNvbXBsZXRpb25IYW5kbGVyKElQ Qzo6QXN5bmNSZXBseUVycm9yPHVpbnQ2NF90Pjo6Y3JlYXRlKCkpOwogfQogCiB2b2lkIFRlc3RB c3luY01lc3NhZ2U6OnNlbmQoc3RkOjp1bmlxdWVfcHRyPElQQzo6RW5jb2Rlcj4mJiBlbmNvZGVy LCBJUEM6OkNvbm5lY3Rpb24mIGNvbm5lY3Rpb24sIHVpbnQ2NF90IHJlc3VsdCkKQEAgLTk0LDEy ICs5NSwxNCBAQCB2b2lkIFRlc3RBc3luY01lc3NhZ2VXaXRoTXVsdGlwbGVBcmd1bWVudHM6OmNh bGxSZXBseShJUEM6OkRlY29kZXImIGRlY29kZXIsIENvbQogICAgIGRlY29kZXIgPj4gZmxhZzsK ICAgICBpZiAoIWZsYWcpIHsKICAgICAgICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgICAg IGNhbmNlbFJlcGx5KFdURk1vdmUoY29tcGxldGlvbkhhbmRsZXIpKTsKICAgICAgICAgcmV0dXJu OwogICAgIH0KICAgICBPcHRpb25hbDx1aW50NjRfdD4gdmFsdWU7CiAgICAgZGVjb2RlciA+PiB2 YWx1ZTsKICAgICBpZiAoIXZhbHVlKSB7CiAgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwor ICAgICAgICBjYW5jZWxSZXBseShXVEZNb3ZlKGNvbXBsZXRpb25IYW5kbGVyKSk7CiAgICAgICAg IHJldHVybjsKICAgICB9CiAgICAgY29tcGxldGlvbkhhbmRsZXIoV1RGTW92ZSgqZmxhZyksIFdU Rk1vdmUoKnZhbHVlKSk7CkBAIC0xMDcsNyArMTEwLDcgQEAgdm9pZCBUZXN0QXN5bmNNZXNzYWdl V2l0aE11bHRpcGxlQXJndW1lbnRzOjpjYWxsUmVwbHkoSVBDOjpEZWNvZGVyJiBkZWNvZGVyLCBD b20KIAogdm9pZCBUZXN0QXN5bmNNZXNzYWdlV2l0aE11bHRpcGxlQXJndW1lbnRzOjpjYW5jZWxS ZXBseShDb21wbGV0aW9uSGFuZGxlcjx2b2lkKGJvb2wmJiwgdWludDY0X3QmJik+JiYgY29tcGxl dGlvbkhhbmRsZXIpCiB7Ci0gICAgY29tcGxldGlvbkhhbmRsZXIoeyB9LCB7IH0pOworICAgIGNv bXBsZXRpb25IYW5kbGVyKElQQzo6QXN5bmNSZXBseUVycm9yPGJvb2w+OjpjcmVhdGUoKSwgSVBD OjpBc3luY1JlcGx5RXJyb3I8dWludDY0X3Q+OjpjcmVhdGUoKSk7CiB9CiAKIHZvaWQgVGVzdEFz eW5jTWVzc2FnZVdpdGhNdWx0aXBsZUFyZ3VtZW50czo6c2VuZChzdGQ6OnVuaXF1ZV9wdHI8SVBD OjpFbmNvZGVyPiYmIGVuY29kZXIsIElQQzo6Q29ubmVjdGlvbiYgY29ubmVjdGlvbiwgYm9vbCBm bGFnLCB1aW50NjRfdCB2YWx1ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvU2NyaXB0cy93 ZWJraXQvbWVzc2FnZXMucHkgYi9Tb3VyY2UvV2ViS2l0L1NjcmlwdHMvd2Via2l0L21lc3NhZ2Vz LnB5CmluZGV4IDUyNTE0OTAyYWJiZTFjYzcxNDZiNDNiZTdjZDhjNDZiYWI0OTA1ODguLjllNmU5 MzIwNmJkYzFiMDEwMjJkZWE1MDQ0ZDI4MzNiZDVlOTRlZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQvU2NyaXB0cy93ZWJraXQvbWVzc2FnZXMucHkKKysrIGIvU291cmNlL1dlYktpdC9TY3Jp cHRzL3dlYmtpdC9tZXNzYWdlcy5weQpAQCAtNTk0LDkgKzU5NCw3IEBAIGRlZiBnZW5lcmF0ZV9t ZXNzYWdlX2hhbmRsZXIoZmlsZSk6CiAgICAgICAgICAgICAgICAgZm9yIHggaW4gbWVzc2FnZS5y ZXBseV9wYXJhbWV0ZXJzOgogICAgICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5kKCcgICAg T3B0aW9uYWw8JXM+ICVzO1xuJyAlICh4LnR5cGUsIHgubmFtZSkpCiAgICAgICAgICAgICAgICAg ICAgIHJlc3VsdC5hcHBlbmQoJyAgICBkZWNvZGVyID4+ICVzO1xuJyAlIHgubmFtZSkKLSAgICAg ICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgnICAgIGlmICghJXMpIHtcbiAgICAgICAgQVNT RVJUX05PVF9SRUFDSEVEKCk7XG4gICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKCcgJSB4Lm5hbWUp Ci0gICAgICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJywgJy5qb2luKFsnSVBDOjpBc3lu Y1JlcGx5RXJyb3I8JyArIHgudHlwZSArICc+OjpjcmVhdGUoKScgZm9yIHggaW4gbWVzc2FnZS5y ZXBseV9wYXJhbWV0ZXJzXSkpCi0gICAgICAgICAgICAgICAgICAgIHJlc3VsdC5hcHBlbmQoJyk7 XG4gICAgICAgIHJldHVybjtcbiAgICB9XG4nKQorICAgICAgICAgICAgICAgICAgICByZXN1bHQu YXBwZW5kKCcgICAgaWYgKCElcykge1xuICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTtcbiAg ICAgICAgY2FuY2VsUmVwbHkoV1RGTW92ZShjb21wbGV0aW9uSGFuZGxlcikpO1xuICAgICAgICBy ZXR1cm47XG4gICAgfVxuJyAlIHgubmFtZSkKICAgICAgICAgICAgICAgICByZXN1bHQuYXBwZW5k KCcgICAgY29tcGxldGlvbkhhbmRsZXIoJykKICAgICAgICAgICAgICAgICBpZiBsZW4obWVzc2Fn ZS5yZXBseV9wYXJhbWV0ZXJzKToKICAgICAgICAgICAgICAgICAgICAgcmVzdWx0LmFwcGVuZCgn V1RGTW92ZSgqJXMpJyAlICgnKSwgV1RGTW92ZSgqJy5qb2luKHgubmFtZSBmb3IgeCBpbiBtZXNz YWdlLnJlcGx5X3BhcmFtZXRlcnMpKSkK