198207 2019-05-23 19:15:32 -0700 Web Inspector: prevent stripping `console.assert` if it's used inside a string 2019-05-23 20:20:25 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 195132 1 hi hi commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1538888 0 hi 2019-05-23 19:15:32 -0700 ``` console.assert(false, "foo"); ``` should be stripped ``` let x = "console.assert(false);" ``` should not be stripped 1538894 1 370546 hi 2019-05-23 19:24:33 -0700 Created attachment 370546 Patch 1538896 2 370547 hi 2019-05-23 19:26:16 -0700 Created attachment 370547 Patch 1538900 3 370547 joepeck 2019-05-23 19:28:52 -0700 Comment on attachment 370547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370547&action=review > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:52 > + s/^\s*console\.assert\(.*\);\s*//g; This is nice. I approve this. > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 > + next if /^["'`]*console\.assert/; This doesn't do what you think it does. 1538901 4 370548 hi 2019-05-23 19:30:49 -0700 Created attachment 370548 Patch 1538905 5 370548 joepeck 2019-05-23 19:33:57 -0700 Comment on attachment 370548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review sh > Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 > + next if /^.*?["'`].*?console\.assert/; /["'`].*?console\.assert/ 1538908 6 370548 joepeck 2019-05-23 19:35:11 -0700 Comment on attachment 370548 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=370548&action=review >> Source/WebInspectorUI/Scripts/remove-console-asserts.pl:59 >> + next if /^.*?["'`].*?console\.assert/; > > /["'`].*?console\.assert/ /\/\/.*?console\.assert/ 1538911 7 370553 hi 2019-05-23 19:39:33 -0700 Created attachment 370553 Patch 1538919 8 370553 commit-queue 2019-05-23 20:19:58 -0700 Comment on attachment 370553 Patch Clearing flags on attachment: 370553 Committed r245741: <https://trac.webkit.org/changeset/245741> 1538920 9 commit-queue 2019-05-23 20:20:00 -0700 All reviewed patches have been landed. Closing bug. 1538921 10 webkit-bug-importer 2019-05-23 20:20:25 -0700 <rdar://problem/51093853> 370546 2019-05-23 19:24:33 -0700 2019-05-23 19:26:15 -0700 Patch bug-198207-20190523192432.patch text/plain 2924 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzYWE4NWIwMjIyYzY5NWE4N2ExYzQ4ZmM4YzU2 NTNkODE1OTA2YTYuLjQwYTJjMmU2NjI0YTA0NTdkZTAwYjQwMzlhZDc2NTFkNjE3ZDkwYjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA1LTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBw cmV2ZW50IHN0cmlwcGluZyBgY29uc29sZS5hc3NlcnRgIGlmIGl0J3MgdXNlZCBpbnNpZGUgYSBz dHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODIwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9yZW1vdmUtY29uc29sZS1hc3NlcnRzLnBsOgorICAgICAgICAocmVtb3ZlQ29uc29s ZUFzc2VydHNJbkZpbGUpOgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZUNv bHVtbi5qczoKKyAgICAgICAgKFdJLlRhYmxlQ29sdW1uLnByb3RvdHlwZS5zZXQgd2lkdGgpOgor ICAgICAgICBSZW1vdmUgc29tZSBjb21tZW50ZWQgb3V0IGBjb25zb2xlLmFzc2VydGAuCisKIDIw MTktMDUtMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IE92ZXJsYXk6IHJ1bGVycy9ndWlkZXMgc2hvdWxkIGJlIHNob3duIHdoZW5l dmVyIGVsZW1lbnQgc2VsZWN0aW9uIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9TY3JpcHRzL3JlbW92ZS1jb25zb2xlLWFzc2VydHMucGwgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvU2NyaXB0cy9yZW1vdmUtY29uc29sZS1hc3NlcnRzLnBsCmluZGV4IGNiMjA2 MDhkNjg1OWFiMmQwNDRlZjRjMDczMzdlNmU0NmRmODNjZmYuLjYxYjgyOTIxZjJlMDU2MzE4ZDIy MmUyMjc1MmNlYjhkZDI0Zjg2ZDUgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9T Y3JpcHRzL3JlbW92ZS1jb25zb2xlLWFzc2VydHMucGwKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1NjcmlwdHMvcmVtb3ZlLWNvbnNvbGUtYXNzZXJ0cy5wbApAQCAtNDksMTIgKzQ5LDE2IEBA IHN1YiByZW1vdmVDb25zb2xlQXNzZXJ0c0luRmlsZSgkJCkKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogCi0gICAgICAgIHMvXHMqY29uc29sZVwuYXNzZXJ0XCguKlwpO1xzKi8vZzsKKyAgICAg ICAgcy9eXHMqY29uc29sZVwuYXNzZXJ0XCguKlwpO1xzKi8vZzsKICAgICAgICAgcHJpbnQgJG91 dCAkXzsKICAgICAgICAgJHByZXZpb3VzTGluZSA9ICRfIGlmICRfICF+IC9eXHMqJC87CiAKKwog ICAgICAgICAjIElmIGNvbnNvbGUuYXNzZXJ0IGlzIHN0aWxsIG9uIHRoZSBsaW5lLCBlaXRoZXIg d2UgbWlzc2VkIGEgc2VtaWNvbG9uIG9yIGl0IGlzIG11bHRpLWxpbmUuIFRoZXNlIGRpZCBub3Qg Z2V0IHN0cmlwcGVkLgogICAgICAgICBpZiAoJF8gPX4gL1xzKmNvbnNvbGVcLmFzc2VydFwoLykg eworICAgICAgICAgICAgIyBBbGxvdyAiY29uc29sZS5hc3NlcnQoKSIgdG8gYmUgdXNlZCBhcyBw YXJ0IG9mIGEgc3RyaW5nLgorICAgICAgICAgICAgbmV4dCBpZiAvXltcIlwnXGBdKmNvbnNvbGVc LmFzc2VydC87CisKICAgICAgICAgICAgIGlmICgkXyA9fiAvXClccyokLykgewogICAgICAgICAg ICAgICAgIHByaW50ICJXQVJOSU5HOiBjb25zb2xlLmFzc2VydCBtaXNzaW5nIHRyYWlsaW5nIHNl bWljb2xvbiBvbiBsaW5lICQuOiAkXyIgOwogICAgICAgICAgICAgfSBlbHNlIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlQ29sdW1u LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGVDb2x1 bW4uanMKaW5kZXggMzg1YTNjYmVmMDYyODE0MmQ3N2YzZjhiYmViNjllNzhmZWIxNGMzNy4uZTZj YjVlZTk0NDk4NWE3ODdiMWVjY2FhYTNkZjg3Y2ExNTA3MTRlNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGVDb2x1bW4uanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGVDb2x1bW4uanMK QEAgLTgwLDExICs4MCw2IEBAIFdJLlRhYmxlQ29sdW1uID0gY2xhc3MgVGFibGVDb2x1bW4gZXh0 ZW5kcyBXSS5PYmplY3QKIAogICAgIHNldCB3aWR0aCh3aWR0aCkKICAgICB7Ci0gICAgICAgIC8v IE5PVEU6IFdlIGNhbid0IGFzc2VydCB0aGlzIGJlY2F1c2Ugd2UgcmVzaXplIHBhc3QgdGhlIG1p bmltdW0gYW5kIG1heGltdW0gc2l6ZXMuCi0gICAgICAgIC8vIElmIHdlIHN1cHBvcnQgaG9yaXpv bnRhbCBzY3JvbGxpbmcgaW4gdGhlIFRhYmxlIHRoZW4gd2UgY291bGQgYXNzZXJ0IHRoZXNlLgot ICAgICAgICAvLyBjb25zb2xlLmFzc2VydChpc05hTih3aWR0aCkgfHwgIXRoaXMuX21pbldpZHRo IHx8IHdpZHRoID49IHRoaXMuX21pbldpZHRoLCAiTmV3IHdpZHRoIHdhcyBsZXNzIHRoYW4gbWlk V2lkdGguIiwgd2lkdGgsIHRoaXMuX21pbldpZHRoKTsKLSAgICAgICAgLy8gY29uc29sZS5hc3Nl cnQoaXNOYU4od2lkdGgpIHx8ICF0aGlzLl9tYXhXaWR0aCB8fCB3aWR0aCA8PSB0aGlzLl9tYXhX aWR0aCwgIk5ldyB3aWR0aCB3YXMgZ3JlYXRlciB0aGFuIG1heFdpZHRoLiIsIHdpZHRoLCB0aGlz Ll9tYXhXaWR0aCk7Ci0KICAgICAgICAgaWYgKHRoaXMuX3dpZHRoID09PSB3aWR0aCkKICAgICAg ICAgICAgIHJldHVybjsKIAo= 370547 2019-05-23 19:26:16 -0700 2019-05-23 19:30:47 -0700 Patch bug-198207-20190523192616.patch text/plain 2919 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzYWE4NWIwMjIyYzY5NWE4N2ExYzQ4ZmM4YzU2 NTNkODE1OTA2YTYuLjQwYTJjMmU2NjI0YTA0NTdkZTAwYjQwMzlhZDc2NTFkNjE3ZDkwYjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA1LTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBw cmV2ZW50IHN0cmlwcGluZyBgY29uc29sZS5hc3NlcnRgIGlmIGl0J3MgdXNlZCBpbnNpZGUgYSBz dHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODIwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9yZW1vdmUtY29uc29sZS1hc3NlcnRzLnBsOgorICAgICAgICAocmVtb3ZlQ29uc29s ZUFzc2VydHNJbkZpbGUpOgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZUNv bHVtbi5qczoKKyAgICAgICAgKFdJLlRhYmxlQ29sdW1uLnByb3RvdHlwZS5zZXQgd2lkdGgpOgor ICAgICAgICBSZW1vdmUgc29tZSBjb21tZW50ZWQgb3V0IGBjb25zb2xlLmFzc2VydGAuCisKIDIw MTktMDUtMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IE92ZXJsYXk6IHJ1bGVycy9ndWlkZXMgc2hvdWxkIGJlIHNob3duIHdoZW5l dmVyIGVsZW1lbnQgc2VsZWN0aW9uIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9TY3JpcHRzL3JlbW92ZS1jb25zb2xlLWFzc2VydHMucGwgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvU2NyaXB0cy9yZW1vdmUtY29uc29sZS1hc3NlcnRzLnBsCmluZGV4IGNiMjA2 MDhkNjg1OWFiMmQwNDRlZjRjMDczMzdlNmU0NmRmODNjZmYuLmNiOGZhMmI0MzQ0YmYzMTgwY2Vm MjFkMzI2NWQ3YWYxNmZjMWU2OWEgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9T Y3JpcHRzL3JlbW92ZS1jb25zb2xlLWFzc2VydHMucGwKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1NjcmlwdHMvcmVtb3ZlLWNvbnNvbGUtYXNzZXJ0cy5wbApAQCAtNDksMTIgKzQ5LDE1IEBA IHN1YiByZW1vdmVDb25zb2xlQXNzZXJ0c0luRmlsZSgkJCkKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogCi0gICAgICAgIHMvXHMqY29uc29sZVwuYXNzZXJ0XCguKlwpO1xzKi8vZzsKKyAgICAg ICAgcy9eXHMqY29uc29sZVwuYXNzZXJ0XCguKlwpO1xzKi8vZzsKICAgICAgICAgcHJpbnQgJG91 dCAkXzsKICAgICAgICAgJHByZXZpb3VzTGluZSA9ICRfIGlmICRfICF+IC9eXHMqJC87CiAKICAg ICAgICAgIyBJZiBjb25zb2xlLmFzc2VydCBpcyBzdGlsbCBvbiB0aGUgbGluZSwgZWl0aGVyIHdl IG1pc3NlZCBhIHNlbWljb2xvbiBvciBpdCBpcyBtdWx0aS1saW5lLiBUaGVzZSBkaWQgbm90IGdl dCBzdHJpcHBlZC4KICAgICAgICAgaWYgKCRfID1+IC9ccypjb25zb2xlXC5hc3NlcnRcKC8pIHsK KyAgICAgICAgICAgICMgQWxsb3cgImNvbnNvbGUuYXNzZXJ0KCkiIHRvIGJlIHVzZWQgYXMgcGFy dCBvZiBhIHN0cmluZy4KKyAgICAgICAgICAgIG5leHQgaWYgL15bIidgXSpjb25zb2xlXC5hc3Nl cnQvOworCiAgICAgICAgICAgICBpZiAoJF8gPX4gL1wpXHMqJC8pIHsKICAgICAgICAgICAgICAg ICBwcmludCAiV0FSTklORzogY29uc29sZS5hc3NlcnQgbWlzc2luZyB0cmFpbGluZyBzZW1pY29s b24gb24gbGluZSAkLjogJF8iIDsKICAgICAgICAgICAgIH0gZWxzZSB7CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZUNvbHVtbi5qcyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlQ29sdW1uLmpz CmluZGV4IDM4NWEzY2JlZjA2MjgxNDJkNzdmM2Y4YmJlYjY5ZTc4ZmViMTRjMzcuLmU2Y2I1ZWU5 NDQ5ODVhNzg3YjFlY2NhYWEzZGY4N2NhMTUwNzE0ZTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlQ29sdW1uLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlQ29sdW1uLmpzCkBAIC04 MCwxMSArODAsNiBAQCBXSS5UYWJsZUNvbHVtbiA9IGNsYXNzIFRhYmxlQ29sdW1uIGV4dGVuZHMg V0kuT2JqZWN0CiAKICAgICBzZXQgd2lkdGgod2lkdGgpCiAgICAgewotICAgICAgICAvLyBOT1RF OiBXZSBjYW4ndCBhc3NlcnQgdGhpcyBiZWNhdXNlIHdlIHJlc2l6ZSBwYXN0IHRoZSBtaW5pbXVt IGFuZCBtYXhpbXVtIHNpemVzLgotICAgICAgICAvLyBJZiB3ZSBzdXBwb3J0IGhvcml6b250YWwg c2Nyb2xsaW5nIGluIHRoZSBUYWJsZSB0aGVuIHdlIGNvdWxkIGFzc2VydCB0aGVzZS4KLSAgICAg ICAgLy8gY29uc29sZS5hc3NlcnQoaXNOYU4od2lkdGgpIHx8ICF0aGlzLl9taW5XaWR0aCB8fCB3 aWR0aCA+PSB0aGlzLl9taW5XaWR0aCwgIk5ldyB3aWR0aCB3YXMgbGVzcyB0aGFuIG1pZFdpZHRo LiIsIHdpZHRoLCB0aGlzLl9taW5XaWR0aCk7Ci0gICAgICAgIC8vIGNvbnNvbGUuYXNzZXJ0KGlz TmFOKHdpZHRoKSB8fCAhdGhpcy5fbWF4V2lkdGggfHwgd2lkdGggPD0gdGhpcy5fbWF4V2lkdGgs ICJOZXcgd2lkdGggd2FzIGdyZWF0ZXIgdGhhbiBtYXhXaWR0aC4iLCB3aWR0aCwgdGhpcy5fbWF4 V2lkdGgpOwotCiAgICAgICAgIGlmICh0aGlzLl93aWR0aCA9PT0gd2lkdGgpCiAgICAgICAgICAg ICByZXR1cm47CiAK 370548 2019-05-23 19:30:49 -0700 2019-05-23 19:39:32 -0700 Patch bug-198207-20190523193048.patch text/plain 2924 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzYWE4NWIwMjIyYzY5NWE4N2ExYzQ4ZmM4YzU2 NTNkODE1OTA2YTYuLjQwYTJjMmU2NjI0YTA0NTdkZTAwYjQwMzlhZDc2NTFkNjE3ZDkwYjQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE5LTA1LTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBw cmV2ZW50IHN0cmlwcGluZyBgY29uc29sZS5hc3NlcnRgIGlmIGl0J3MgdXNlZCBpbnNpZGUgYSBz dHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODIwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U2NyaXB0cy9yZW1vdmUtY29uc29sZS1hc3NlcnRzLnBsOgorICAgICAgICAocmVtb3ZlQ29uc29s ZUFzc2VydHNJbkZpbGUpOgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UYWJsZUNv bHVtbi5qczoKKyAgICAgICAgKFdJLlRhYmxlQ29sdW1uLnByb3RvdHlwZS5zZXQgd2lkdGgpOgor ICAgICAgICBSZW1vdmUgc29tZSBjb21tZW50ZWQgb3V0IGBjb25zb2xlLmFzc2VydGAuCisKIDIw MTktMDUtMjMgIERldmluIFJvdXNzbyAgPGRyb3Vzc29AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IE92ZXJsYXk6IHJ1bGVycy9ndWlkZXMgc2hvdWxkIGJlIHNob3duIHdoZW5l dmVyIGVsZW1lbnQgc2VsZWN0aW9uIGlzIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9TY3JpcHRzL3JlbW92ZS1jb25zb2xlLWFzc2VydHMucGwgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvU2NyaXB0cy9yZW1vdmUtY29uc29sZS1hc3NlcnRzLnBsCmluZGV4IGNiMjA2 MDhkNjg1OWFiMmQwNDRlZjRjMDczMzdlNmU0NmRmODNjZmYuLjg4ZDIyMDM0MTRhZTM1MGRjNjAy OTJiZjkwYzcxZDJiMGY0NGI2NDEgMTAwNzU1Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9T Y3JpcHRzL3JlbW92ZS1jb25zb2xlLWFzc2VydHMucGwKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1NjcmlwdHMvcmVtb3ZlLWNvbnNvbGUtYXNzZXJ0cy5wbApAQCAtNDksMTIgKzQ5LDE1IEBA IHN1YiByZW1vdmVDb25zb2xlQXNzZXJ0c0luRmlsZSgkJCkKICAgICAgICAgICAgIH0KICAgICAg ICAgfQogCi0gICAgICAgIHMvXHMqY29uc29sZVwuYXNzZXJ0XCguKlwpO1xzKi8vZzsKKyAgICAg ICAgcy9eXHMqY29uc29sZVwuYXNzZXJ0XCguKlwpO1xzKi8vZzsKICAgICAgICAgcHJpbnQgJG91 dCAkXzsKICAgICAgICAgJHByZXZpb3VzTGluZSA9ICRfIGlmICRfICF+IC9eXHMqJC87CiAKICAg ICAgICAgIyBJZiBjb25zb2xlLmFzc2VydCBpcyBzdGlsbCBvbiB0aGUgbGluZSwgZWl0aGVyIHdl IG1pc3NlZCBhIHNlbWljb2xvbiBvciBpdCBpcyBtdWx0aS1saW5lLiBUaGVzZSBkaWQgbm90IGdl dCBzdHJpcHBlZC4KICAgICAgICAgaWYgKCRfID1+IC9ccypjb25zb2xlXC5hc3NlcnRcKC8pIHsK KyAgICAgICAgICAgICMgQWxsb3cgImNvbnNvbGUuYXNzZXJ0KCkiIHRvIGJlIHVzZWQgYXMgcGFy dCBvZiBhIHN0cmluZy4KKyAgICAgICAgICAgIG5leHQgaWYgL14uKj9bIidgXS4qP2NvbnNvbGVc LmFzc2VydC87CisKICAgICAgICAgICAgIGlmICgkXyA9fiAvXClccyokLykgewogICAgICAgICAg ICAgICAgIHByaW50ICJXQVJOSU5HOiBjb25zb2xlLmFzc2VydCBtaXNzaW5nIHRyYWlsaW5nIHNl bWljb2xvbiBvbiBsaW5lICQuOiAkXyIgOwogICAgICAgICAgICAgfSBlbHNlIHsKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RhYmxlQ29sdW1u LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGVDb2x1 bW4uanMKaW5kZXggMzg1YTNjYmVmMDYyODE0MmQ3N2YzZjhiYmViNjllNzhmZWIxNGMzNy4uZTZj YjVlZTk0NDk4NWE3ODdiMWVjY2FhYTNkZjg3Y2ExNTA3MTRlNyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGVDb2x1bW4uanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGFibGVDb2x1bW4uanMK QEAgLTgwLDExICs4MCw2IEBAIFdJLlRhYmxlQ29sdW1uID0gY2xhc3MgVGFibGVDb2x1bW4gZXh0 ZW5kcyBXSS5PYmplY3QKIAogICAgIHNldCB3aWR0aCh3aWR0aCkKICAgICB7Ci0gICAgICAgIC8v IE5PVEU6IFdlIGNhbid0IGFzc2VydCB0aGlzIGJlY2F1c2Ugd2UgcmVzaXplIHBhc3QgdGhlIG1p bmltdW0gYW5kIG1heGltdW0gc2l6ZXMuCi0gICAgICAgIC8vIElmIHdlIHN1cHBvcnQgaG9yaXpv bnRhbCBzY3JvbGxpbmcgaW4gdGhlIFRhYmxlIHRoZW4gd2UgY291bGQgYXNzZXJ0IHRoZXNlLgot ICAgICAgICAvLyBjb25zb2xlLmFzc2VydChpc05hTih3aWR0aCkgfHwgIXRoaXMuX21pbldpZHRo IHx8IHdpZHRoID49IHRoaXMuX21pbldpZHRoLCAiTmV3IHdpZHRoIHdhcyBsZXNzIHRoYW4gbWlk V2lkdGguIiwgd2lkdGgsIHRoaXMuX21pbldpZHRoKTsKLSAgICAgICAgLy8gY29uc29sZS5hc3Nl cnQoaXNOYU4od2lkdGgpIHx8ICF0aGlzLl9tYXhXaWR0aCB8fCB3aWR0aCA8PSB0aGlzLl9tYXhX aWR0aCwgIk5ldyB3aWR0aCB3YXMgZ3JlYXRlciB0aGFuIG1heFdpZHRoLiIsIHdpZHRoLCB0aGlz Ll9tYXhXaWR0aCk7Ci0KICAgICAgICAgaWYgKHRoaXMuX3dpZHRoID09PSB3aWR0aCkKICAgICAg ICAgICAgIHJldHVybjsKIAo= 370553 2019-05-23 19:39:33 -0700 2019-05-23 20:19:58 -0700 Patch bug-198207-20190523193932.patch text/plain 1914 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGUzYWE4NWIwMjIyYzY5NWE4N2ExYzQ4ZmM4YzU2 NTNkODE1OTA2YTYuLmMwYzNiOGE0ZTBjOGQ2MjczYjYyZDJmMDI4NjI4YzBhYzdjYmUxZGMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA1LTIzICBEZXZp biBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBw cmV2ZW50IHN0cmlwcGluZyBgY29uc29sZS5hc3NlcnRgIGlmIGl0J3MgdXNlZCBpbnNpZGUgYSBz dHJpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5 ODIwNworCisgICAgICAgIFJldmlld2VkIGJ5IEpvc2VwaCBQZWNvcmFyby4KKworICAgICAgICAq IFNjcmlwdHMvcmVtb3ZlLWNvbnNvbGUtYXNzZXJ0cy5wbDoKKyAgICAgICAgKHJlbW92ZUNvbnNv bGVBc3NlcnRzSW5GaWxlKToKKwogMjAxOS0wNS0yMyAgRGV2aW4gUm91c3NvICA8ZHJvdXNzb0Bh cHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogT3ZlcmxheTogcnVsZXJzL2d1aWRl cyBzaG91bGQgYmUgc2hvd24gd2hlbmV2ZXIgZWxlbWVudCBzZWxlY3Rpb24gaXMgZW5hYmxlZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvcmVtb3ZlLWNvbnNvbGUt YXNzZXJ0cy5wbCBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9TY3JpcHRzL3JlbW92ZS1jb25zb2xl LWFzc2VydHMucGwKaW5kZXggY2IyMDYwOGQ2ODU5YWIyZDA0NGVmNGMwNzMzN2U2ZTQ2ZGY4M2Nm Zi4uNDg4ZDg0ZGM4ZWY2YTJkZjRmZGIzYjE4MWU3YzA4NDUxMzMzMjQyOCAxMDA3NTUKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1NjcmlwdHMvcmVtb3ZlLWNvbnNvbGUtYXNzZXJ0cy5wbAor KysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvU2NyaXB0cy9yZW1vdmUtY29uc29sZS1hc3NlcnRz LnBsCkBAIC00OSwxMiArNDksMTggQEAgc3ViIHJlbW92ZUNvbnNvbGVBc3NlcnRzSW5GaWxlKCQk KQogICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgcy9ccypjb25zb2xlXC5hc3Nl cnRcKC4qXCk7XHMqLy9nOworICAgICAgICBzL15ccypjb25zb2xlXC5hc3NlcnRcKC4qXCk7XHMq Ly9nOwogICAgICAgICBwcmludCAkb3V0ICRfOwogICAgICAgICAkcHJldmlvdXNMaW5lID0gJF8g aWYgJF8gIX4gL15ccyokLzsKIAogICAgICAgICAjIElmIGNvbnNvbGUuYXNzZXJ0IGlzIHN0aWxs IG9uIHRoZSBsaW5lLCBlaXRoZXIgd2UgbWlzc2VkIGEgc2VtaWNvbG9uIG9yIGl0IGlzIG11bHRp LWxpbmUuIFRoZXNlIGRpZCBub3QgZ2V0IHN0cmlwcGVkLgogICAgICAgICBpZiAoJF8gPX4gL1xz KmNvbnNvbGVcLmFzc2VydFwoLykgeworICAgICAgICAgICAgIyBBbGxvdyAiY29uc29sZS5hc3Nl cnQoKSIgdG8gYmUgdXNlZCBhcyBwYXJ0IG9mIGEgc3RyaW5nLgorICAgICAgICAgICAgbmV4dCBp ZiAvXi4qP1siJ2BdLio/Y29uc29sZVwuYXNzZXJ0LzsKKworICAgICAgICAgICAgIyBBbGxvdyAi Y29uc29sZS5hc3NlcnQoKSIgdG8gYmUgdXNlZCBhcyBwYXJ0IG9mIGEgY29tbWVudC4KKyAgICAg ICAgICAgIG5leHQgaWYgL14uKj8oXC9cL3xcL1wqKS4qP2NvbnNvbGVcLmFzc2VydC87CisKICAg ICAgICAgICAgIGlmICgkXyA9fiAvXClccyokLykgewogICAgICAgICAgICAgICAgIHByaW50ICJX QVJOSU5HOiBjb25zb2xlLmFzc2VydCBtaXNzaW5nIHRyYWlsaW5nIHNlbWljb2xvbiBvbiBsaW5l ICQuOiAkXyIgOwogICAgICAgICAgICAgfSBlbHNlIHsK