198199 2019-05-23 15:49:45 -0700 [WHLSL] Make the AST dumper disambiguate expressions using parenthesis to represent AST construction 2019-05-23 16:43:32 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam commit-queue fpizlo jonlee justin_fan mmaxfield rmorisset webkit-bug-importer oldest_to_newest 1538816 0 saam 2019-05-23 15:49:45 -0700 We would dump "*foo.bar" for "(*foo).bar" which is throughly confusing enough to go maximal parens 1538821 1 370530 saam 2019-05-23 16:00:13 -0700 Created attachment 370530 patch 1538822 2 rmorisset 2019-05-23 16:02:02 -0700 LGTM 1538839 3 370530 commit-queue 2019-05-23 16:42:02 -0700 Comment on attachment 370530 patch Clearing flags on attachment: 370530 Committed r245727: <https://trac.webkit.org/changeset/245727> 1538840 4 commit-queue 2019-05-23 16:42:04 -0700 All reviewed patches have been landed. Closing bug. 1538841 5 webkit-bug-importer 2019-05-23 16:43:32 -0700 <rdar://problem/51088170> 370530 2019-05-23 16:00:13 -0700 2019-05-23 16:42:02 -0700 patch c-backup.diff text/plain 1784 saam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTcyMikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE5LTA1LTIzICBTYWFtIGJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFtXSExTTF0gTWFrZSB0aGUgQVNU IGR1bXBlciBkaXNhbWJpZ3VhdGUgZXhwcmVzc2lvbnMgdXNpbmcgcGFyZW50aGVzaXMgdG8gcmVw cmVzZW50IEFTVCBjb25zdHJ1Y3Rpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE5ODE5OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFdlIHdvdWxkIGR1bXAgIipmb28uYmFyIiBmb3IgIigqZm9vKS5iYXIi LCB3aGljaCBpcyBzdXBlciBjb25mdXNpbmcuCisgICAgICAgIFdlIG5vdyBkdW1wICIoKmZvbyku YmFyIi4KKworICAgICAgICAqIE1vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMQVNURHVtcGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OldITFNMOjpBU1REdW1wZXI6OnZpc2l0KToKKwogMjAxOS0w NS0yMyAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAg IFtXSExTTF0gSW1wbGVtZW50IHByb3BlcnR5IHJlc29sdmVyCkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTEFTVER1bXBlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvTW9kdWxlcy93ZWJncHUvV0hMU0wvV0hMU0xBU1REdW1wZXIuY3BwCShy ZXZpc2lvbiAyNDU3MTkpCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9X SExTTEFTVER1bXBlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQxOSw3ICs0MTksMjAgQEAgdm9p ZCBBU1REdW1wZXI6OnZpc2l0KEFTVDo6Rm9yTG9vcCYgZm9yTAogCiB2b2lkIEFTVER1bXBlcjo6 dmlzaXQoQVNUOjpFeHByZXNzaW9uJiBleHByZXNzaW9uKQogeworICAgIGJvb2wgc2tpcFBhcmVu cyA9IGlzPEFTVDo6Qm9vbGVhbkxpdGVyYWw+KGV4cHJlc3Npb24pCisgICAgICAgIHx8IGlzPEFT VDo6RmxvYXRMaXRlcmFsPihleHByZXNzaW9uKQorICAgICAgICB8fCBpczxBU1Q6OkludGVnZXJM aXRlcmFsPihleHByZXNzaW9uKQorICAgICAgICB8fCBpczxBU1Q6Ok51bGxMaXRlcmFsPihleHBy ZXNzaW9uKQorICAgICAgICB8fCBpczxBU1Q6OlVuc2lnbmVkSW50ZWdlckxpdGVyYWw+KGV4cHJl c3Npb24pCisgICAgICAgIHx8IGlzPEFTVDo6RW51bWVyYXRpb25NZW1iZXJMaXRlcmFsPihleHBy ZXNzaW9uKQorICAgICAgICB8fCBpczxBU1Q6OkNvbW1hRXhwcmVzc2lvbj4oZXhwcmVzc2lvbikK KyAgICAgICAgfHwgaXM8QVNUOjpWYXJpYWJsZVJlZmVyZW5jZT4oZXhwcmVzc2lvbik7CisKKyAg ICBpZiAoIXNraXBQYXJlbnMpCisgICAgICAgIG1fb3V0LnByaW50KCIoIik7CiAgICAgQmFzZTo6 dmlzaXQoZXhwcmVzc2lvbik7CisgICAgaWYgKCFza2lwUGFyZW5zKQorICAgICAgICBtX291dC5w cmludCgiKSIpOwogfQogCiB2b2lkIEFTVER1bXBlcjo6dmlzaXQoQVNUOjpEb3RFeHByZXNzaW9u JiBkb3RFeHByZXNzaW9uKQo=