198196 2019-05-23 14:49:11 -0700 [WHLSL] Don't wrap anonymous variables in parens in the AST dumper 2019-05-23 16:14:20 -0700 1 1 1 Unclassified WebKit WebGPU WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam commit-queue fpizlo jonlee justin_fan mmaxfield rmorisset webkit-bug-importer oldest_to_newest 1538792 0 saam 2019-05-23 14:49:11 -0700 Makes things easier to read IMO 1538793 1 saam 2019-05-23 14:52:47 -0700 foo.bar.x = 42; Goes from ($(0x7f86d9d94440) = &foo, $(0x7f86d9d944e0) = operator.bar(*$(0x7f86d9d94440)), $(0x7f86d9d944e0) = operator.x=($(0x7f86d9d944e0), 42), *$(0x7f86d9d94440) = operator.bar=(*$(0x7f86d9d94440), $(0x7f86d9d944e0))); to: ($0x7f86d9d94440 = &foo, $0x7f86d9d944e0 = operator.bar(*$0x7f86d9d94440), $0x7f86d9d944e0 = operator.x=($0x7f86d9d944e0, 42), *$0x7f86d9d94440 = operator.bar=(*$0x7f86d9d94440, $0x7f86d9d944e0)); 1538795 2 370523 saam 2019-05-23 15:00:54 -0700 Created attachment 370523 patch 1538825 3 370523 commit-queue 2019-05-23 16:13:51 -0700 Comment on attachment 370523 patch Clearing flags on attachment: 370523 Committed r245724: <https://trac.webkit.org/changeset/245724> 1538826 4 commit-queue 2019-05-23 16:13:52 -0700 All reviewed patches have been landed. Closing bug. 1538827 5 webkit-bug-importer 2019-05-23 16:14:20 -0700 <rdar://problem/51086976> 370523 2019-05-23 15:00:54 -0700 2019-05-23 16:13:51 -0700 patch c-backup.diff text/plain 1831 saam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI0NTcxOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE5LTA1LTIzICBTYWFtIGJh cmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAgIFtXSExTTF0gRG9uJ3Qgd3JhcCBh bm9ueW1vdXMgdmFyaWFibGVzIGluIHBhcmVucyBpbiB0aGUgQVNUIGR1bXBlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MTk2CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBtYWtlcyB0aGUgZHVt cCBvZiAnZm9vLmJhci54ID0gNDInIGdvIGZyb20KKyAgICAgICAgKCQoMHg3Zjg2ZDlkOTQ0NDAp ID0gJmZvbywgJCgweDdmODZkOWQ5NDRlMCkgPSBvcGVyYXRvci5iYXIoKiQoMHg3Zjg2ZDlkOTQ0 NDApKSwgJCgweDdmODZkOWQ5NDRlMCkgPSBvcGVyYXRvci54PSgkKDB4N2Y4NmQ5ZDk0NGUwKSwg NDIpLCAqJCgweDdmODZkOWQ5NDQ0MCkgPSBvcGVyYXRvci5iYXI9KCokKDB4N2Y4NmQ5ZDk0NDQw KSwgJCgweDdmODZkOWQ5NDRlMCkpKTsKKyAgICAgICAgCisgICAgICAgIHRvOgorICAgICAgICAo JDB4N2Y4NmQ5ZDk0NDQwID0gJmZvbywgJDB4N2Y4NmQ5ZDk0NGUwID0gb3BlcmF0b3IuYmFyKCok MHg3Zjg2ZDlkOTQ0NDApLCAkMHg3Zjg2ZDlkOTQ0ZTAgPSBvcGVyYXRvci54PSgkMHg3Zjg2ZDlk OTQ0ZTAsIDQyKSwgKiQweDdmODZkOWQ5NDQ0MCA9IG9wZXJhdG9yLmJhcj0oKiQweDdmODZkOWQ5 NDQ0MCwgJDB4N2Y4NmQ5ZDk0NGUwKSk7CisKKyAgICAgICAgKiBNb2R1bGVzL3dlYmdwdS9XSExT TC9XSExTTEFTVER1bXBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXSExTTDo6QVNURHVtcGVy Ojp2aXNpdCk6CisKIDIwMTktMDUtMjIgIFN0ZXBoYW5pZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5j b20+CiAKICAgICAgICAgcmVsZWFzZSBidWlsZHMgb2Ygd2Via2l0IGNhbm5vdCBiZSB1c2VkIHRv IGdlbmVyYXRlIGEgZHlsZCBzaGFyZWQgY2FjaGUKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01vZHVs ZXMvd2ViZ3B1L1dITFNML1dITFNMQVNURHVtcGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9Nb2R1bGVzL3dlYmdwdS9XSExTTC9XSExTTEFTVER1bXBlci5jcHAJKHJldmlzaW9u IDI0NTcxOSkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvd2ViZ3B1L1dITFNML1dITFNMQVNU RHVtcGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjM2LDcgKzYzNiw3IEBAIHZvaWQgQVNURHVt cGVyOjp2aXNpdChBU1Q6OlRlcm5hcnlFeHByZXMKIHZvaWQgQVNURHVtcGVyOjp2aXNpdChBU1Q6 OlZhcmlhYmxlUmVmZXJlbmNlJiB2YXJpYWJsZVJlZmVyZW5jZSkKIHsKICAgICBpZiAodmFyaWFi bGVSZWZlcmVuY2UubmFtZSgpLmlzRW1wdHkoKSkKLSAgICAgICAgbV9vdXQucHJpbnQoIiQoIiwg UmF3UG9pbnRlcih2YXJpYWJsZVJlZmVyZW5jZS52YXJpYWJsZSgpKSwgIikiKTsKKyAgICAgICAg bV9vdXQucHJpbnQoIiQiLCBSYXdQb2ludGVyKHZhcmlhYmxlUmVmZXJlbmNlLnZhcmlhYmxlKCkp KTsKICAgICBlbHNlCiAgICAgICAgIG1fb3V0LnByaW50KHZhcmlhYmxlUmVmZXJlbmNlLm5hbWUo KSk7CiB9Cg==