198150 2019-05-22 17:18:55 -0700 release builds of webkit cannot be used to generate a dyld shared cache 2019-05-23 14:22:28 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 slewis slewis ap mitz slewis oldest_to_newest 1538482 0 slewis 2019-05-22 17:18:55 -0700 https://bugs.webkit.org/show_bug.cgi?id=170385 fixed a warning about Mac OS build sleight of hand for libwebrtc by telling the linker that release builds of WebKit and WebCore will not be placed in a dyld shared cache. However on some devices this is desirable. Since we only do the sleight of hand on macosx restrict the flag to macosx. 1538483 1 slewis 2019-05-22 17:21:36 -0700 <rdar://problem/50675982> 1538487 2 370471 slewis 2019-05-22 17:26:25 -0700 Created attachment 370471 patch 1538787 3 slewis 2019-05-23 14:22:18 -0700 Thanks Dan. http://trac.webkit.org/projects/webkit/changeset/245717 370471 2019-05-22 17:26:25 -0700 2019-05-22 18:19:27 -0700 patch 0001-release-builds-of-webkit-cannot-be-used-to-generate-.patch text/plain 4352 slewis RnJvbSBlNGM2ZTUzZjg3NTBmZDcyNjMzYWExY2FiNDE3NDU5MDFkMjhjNWMwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVwaGFuaWUgTGV3aXMgPHNsZXdpc0BhcHBsZS5jb20+CkRh dGU6IFdlZCwgMjIgTWF5IDIwMTkgMTc6MjU6MDcgLTA3MDAKU3ViamVjdDogW1BBVENIXSByZWxl YXNlIGJ1aWxkcyBvZiB3ZWJraXQgY2Fubm90IGJlIHVzZWQgdG8gZ2VuZXJhdGUgYSBkeWxkCiBz aGFyZWQgY2FjaGUgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODE1 MAogPHJkYXI6Ly9wcm9ibGVtLzUwNjc1OTgyPgoKUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CgpSZXN0cmljdCB0aGUgLW5vdF9mb3JfZHlsZF9zaGFyZWRfY2FjaGUgbGlua2VyIGZsYWcgdG8g bWFjb3N4CgpTb3VyY2UvV2ViQ29yZToKCiogQ29uZmlndXJhdGlvbnMvV2ViQ29yZS54Y2NvbmZp ZzoKClNvdXJjZS9XZWJLaXQ6CgoqIENvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZzoKLS0t CiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgIHwgMTIgKysr KysrKysrKysrCiBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmln IHwgIDQgKystLQogU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICB8IDEzICsrKysrKysrKysrKysKIFNvdXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvV2ViS2l0 LnhjY29uZmlnICAgfCAgNCArKy0tCiA0IGZpbGVzIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKyks IDQgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDJhYmVkM2FjY2FiOC4uN2QzZWQwODQ5N2Nm IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTktMDUtMjIgIFN0ZXBoYW5pZSBMZXdp cyAgPHNsZXdpc0BhcHBsZS5jb20+CisKKyAgICAgICAgcmVsZWFzZSBidWlsZHMgb2Ygd2Via2l0 IGNhbm5vdCBiZSB1c2VkIHRvIGdlbmVyYXRlIGEgZHlsZCBzaGFyZWQgY2FjaGUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE5ODE1MAorICAgICAgICA8 cmRhcjovL3Byb2JsZW0vNTA2NzU5ODI+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgUmVzdHJpY3QgdGhlIC1ub3RfZm9yX2R5bGRfc2hhcmVkX2NhY2hl IGxpbmtlciBmbGFnIHRvIG1hY29zeAorCisgICAgICAgICogQ29uZmlndXJhdGlvbnMvV2ViQ29y ZS54Y2NvbmZpZzoKKwogMjAxOS0wNS0yMCAgR2FiZSBHaW9zaWEgIDxnaW9zaWFAZ29vZ2xlLmNv bT4KIAogICAgICAgICBSYW5nZSBnZXRCb3VuZGluZ0NsaWVudFJlY3QgcmV0dXJuaW5nIHplcm8g cmVjdCBvbiBzaW1wbGUgdGV4dCBub2RlIHdpdGggPGJyPiBiZWZvcmUgaXQKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dlYkNvcmUueGNjb25maWcgYi9Tb3VyY2Uv V2ViQ29yZS9Db25maWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnCmluZGV4IGM3OGI1Mjg1NGZi MS4uYTY0YTgyNDA1ZmU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9u cy9XZWJDb3JlLnhjY29uZmlnCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL1dl YkNvcmUueGNjb25maWcKQEAgLTE3NSw4ICsxNzUsOCBAQCBXS19RVU9URURfT1ZFUlJJREVfRlJB TUVXT1JLU19ESVJfWUVTID0gIiQoV0tfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVIpIjsKIFdLX0lO U1RBTExfUEFUSF9QUkVGSVggPSAkKFdLX0lOU1RBTExfUEFUSF9QUkVGSVhfREVQTE9ZTUVOVF8k KERFUExPWU1FTlRfTE9DQVRJT04pJChXS19NQUNPU18xMDE1KV9VU0VfU1RBR0lOR19JTlNUQUxM X1BBVEhfJChVU0VfU1RBR0lOR19JTlNUQUxMX1BBVEgpKTsKIFdLX0lOU1RBTExfUEFUSF9QUkVG SVhfREVQTE9ZTUVOVF9ZRVNfTUFDT1NfU0lOQ0VfMTAxNV9VU0VfU1RBR0lOR19JTlNUQUxMX1BB VEhfWUVTID0gJChQTEFURk9STV9PT0JfU1lTVEVNX0NPTlRFTlRfRElSKTsKIAotV0tfUkVMT0NB VEFCTEVfRlJBTUVXT1JLX0xERkxBR1MgPSAkKFdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS19MREZM QUdTXyQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLUykpOwotV0tfUkVMT0NBVEFCTEVfRlJBTUVX T1JLX0xERkxBR1NfWUVTID0gLVdsLC1ub3RfZm9yX2R5bGRfc2hhcmVkX2NhY2hlOworV0tfUkVM T0NBVEFCTEVfRlJBTUVXT1JLX0xERkxBR1MgPSAkKFdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS19M REZMQUdTXyQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLUylfJChXS19QTEFURk9STV9OQU1FKSk7 CitXS19SRUxPQ0FUQUJMRV9GUkFNRVdPUktfTERGTEFHU19ZRVNfbWFjb3N4ID0gLVdsLC1ub3Rf Zm9yX2R5bGRfc2hhcmVkX2NhY2hlOwogCiAvLyBFbmFibGUgSW5zdGFsbEFQSSBzdXBwb3J0LCB3 aGVuIGJ1aWx0IHdpdGggV0VCQ09SRV9FTkFCTEVfSU5TVEFMTEFQST1ZRVMuCiBTVVBQT1JUU19U RVhUX0JBU0VEX0FQSSA9ICQoU1VQUE9SVFNfVEVYVF9CQVNFRF9BUElfJChUQVJHRVRfTkFNRSkp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCmluZGV4IGVmZWI1NWNiOWRmZC4uNzZkNzUzMGJhMzdlIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDE5LTA1LTIyICBTdGVwaGFuaWUgTGV3aXMgIDxzbGV3aXNAYXBwbGUuY29t PgorCisgICAgICAgIHJlbGVhc2UgYnVpbGRzIG9mIHdlYmtpdCBjYW5ub3QgYmUgdXNlZCB0byBn ZW5lcmF0ZSBhIGR5bGQgc2hhcmVkIGNhY2hlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgxNTAKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzUwNjc1 OTgyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJl c3RyaWN0IHRoZSAtbm90X2Zvcl9keWxkX3NoYXJlZF9jYWNoZSBsaW5rZXIgZmxhZyB0byBtYWNv c3gKKworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZzoKKworCiAyMDE5 LTA1LTIwICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNvbT4KIAogICAgICAg ICBbV2luQ2Fpcm9dIEltcGxlbWVudCBSZW1vdGUgV2ViIEluc3BlY3RvciBDbGllbnQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25zL1dlYktpdC54Y2NvbmZpZyBiL1Nv dXJjZS9XZWJLaXQvQ29uZmlndXJhdGlvbnMvV2ViS2l0LnhjY29uZmlnCmluZGV4IGZlZTE0Nzkx YTgxZi4uZDlkZGEyYzk3ZWU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRp b25zL1dlYktpdC54Y2NvbmZpZworKysgYi9Tb3VyY2UvV2ViS2l0L0NvbmZpZ3VyYXRpb25zL1dl YktpdC54Y2NvbmZpZwpAQCAtMTYyLDggKzE2Miw4IEBAIFdLX0ZSQU1FV09SS19IRUFERVJfUE9T VFBST0NFU1NJTkdfRElTQUJMRURfTUFDT1NfQkVGT1JFXzEwMTUgPSBZRVM7CiBXS19GUkFNRVdP UktfSEVBREVSX1BPU1RQUk9DRVNTSU5HX0RJU0FCTEVEW3Nkaz1pcGhvbmUqMTEuKl0gPSBZRVM7 CiBXS19GUkFNRVdPUktfSEVBREVSX1BPU1RQUk9DRVNTSU5HX0RJU0FCTEVEW3Nkaz1pcGhvbmUq MTIuKl0gPSBZRVM7CiAKLVdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS19MREZMQUdTID0gJChXS19S RUxPQ0FUQUJMRV9GUkFNRVdPUktfTERGTEFHU18kKFdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS1Mp KTsKLVdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS19MREZMQUdTX1lFUyA9IC1XbCwtbm90X2Zvcl9k eWxkX3NoYXJlZF9jYWNoZTsKK1dLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS19MREZMQUdTID0gJChX S19SRUxPQ0FUQUJMRV9GUkFNRVdPUktfTERGTEFHU18kKFdLX1JFTE9DQVRBQkxFX0ZSQU1FV09S S1MpXyQoV0tfUExBVEZPUk1fTkFNRSkpOworV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLX0xERkxB R1NfWUVTX21hY29zeCA9IC1XbCwtbm90X2Zvcl9keWxkX3NoYXJlZF9jYWNoZTsKIAogV0tfSEFW RV9ERVZJQ0VfSURFTlRJVFkgPSAkKFdLX0hBVkVfREVWSUNFX0lERU5USVRZXyQoUExBVEZPUk1f TkFNRSkpOwogV0tfSEFWRV9ERVZJQ0VfSURFTlRJVFlfaXBob25lb3MgPSBZRVM7Ci0tIAoyLjIx LjAgKEFwcGxlIEdpdC0xMTgpCgo=