198141 2019-05-22 15:02:15 -0700 REGRESSION(r245148): Removing inputmode="none" does not bring up software keyboard 2019-05-22 17:30:25 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa rniwa dbates ggaren megan_gardner wenson_hsieh oldest_to_newest 1538394 0 rniwa 2019-05-22 15:02:15 -0700 r245148 changed so that we don't always create UIKeyboard. This introduced a regression that removing inputmode="none" no longer brings up the keyboard. <rdar://problem/50613388> 1538402 1 370449 rniwa 2019-05-22 15:09:22 -0700 Created attachment 370449 Fixes the bug 1538407 2 370449 ggaren 2019-05-22 15:13:48 -0700 Comment on attachment 370449 Fixes the bug r=me 1538420 3 370449 ap 2019-05-22 15:34:12 -0700 Comment on attachment 370449 Fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=370449&action=review > LayoutTests/fast/forms/ios/inputmode-removing-none.html:59 > +//setTimeout(finishJSTest, 7000); Commented out code. 1538458 4 rniwa 2019-05-22 16:27:14 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 370449 [details] > Fixes the bug > > View in context: > https://bugs.webkit.org/attachment.cgi?id=370449&action=review > > > LayoutTests/fast/forms/ios/inputmode-removing-none.html:59 > > +//setTimeout(finishJSTest, 7000); > > Commented out code. Oh oops, will remove that. 1538488 5 rniwa 2019-05-22 17:30:25 -0700 Committed r245661: <https://trac.webkit.org/changeset/245661> 370449 2019-05-22 15:09:22 -0700 2019-05-22 15:13:48 -0700 Fixes the bug bug-198141-20190522150921.patch text/plain 6739 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDkxOTExY2Q4NzFhM2Y4NDgy Y2ZlNjJlOTU1MzQxNzU1MWJlZDFhNjQuLmZlMjNkZDBjOGU3MTU1MGQzOTM3MGRhZTU5ODMyYjA1 ZjczOWM0ZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTktMDUtMjIgIFJ5b3N1a2Ug Tml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjQ1MTQ4KTog UmVtb3ZpbmcgaW5wdXRtb2RlPSJub25lIiBkb2VzIG5vdCBicmluZyB1cCBzb2Z0d2FyZSBrZXli b2FyZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4 MTQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjI0 NTE0OCBjaGFuZ2VkIF9yZXF1aXJlc0tleWJvYXJkV2hlbkZpcnN0UmVzcG9uZGVyIHRvIHJldHVy biBOTyB3aGVuIHNob3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJCisgICAgICAgIHJldHVybnMg Tk8gd2l0aCByZWdhcmRzIHRvIHNvZnR3YXJlIGtleWJvYXJkLiBUaGlzIGludHJvZHVjZWQgYSBy ZWdyZXNzaW9uIHRoYXQgcmVtb3ZpbmcgaW5wdXRtb2RlPSJub25lIgorICAgICAgICBubyBsb25n ZXIgYnJpbmdzIHVwIHRoZSBzb2Z0d2FyZSBrZXlib2FyZC4gRml4ZWQgdGhlIGJ1ZyBieSBtYWtp bmcgaXQgcmV0dXJuIFlFUyB3aGVuIGlucHV0bW9kZT0ibm9uZSIKKyAgICAgICAgaXMgcHJlc2Vu dCBvbiBhbiBlZGl0YWJsZSBlbGVtZW50IGluIHNob3VsZFNob3dBdXRvbWF0aWNLZXlib2FyZFVJ LCBwYXJ0aWFsbHkgcmVzdG9yaW5nIHRoZSBvbGQgYmVoYXZpb3IuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbToKKyAgICAgICAgKC1bV0tDb250 ZW50VmlldyBzaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSV0pOgorICAgICAgICAoLVtXS0Nv bnRlbnRWaWV3IF9zaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSUlnbm9yaW5nSW5wdXRNb2Rl XSk6CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgX3JlcXVpcmVzS2V5Ym9hcmRXaGVuRmlyc3RS ZXNwb25kZXJdKToKKwogMjAxOS0wNS0yMSAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNl bkB3ZWJraXQub3JnPgogCiAgICAgICAgIE1hcmsgV0tVSURlbGVnYXRlIHdlYlZpZXc6c2hvdWxk UHJldmlld0VsZW1lbnQ6IGFuZCB3ZWJWaWV3OnByZXZpZXdpbmdWaWV3Q29udHJvbGxlckZvckVs ZW1lbnQ6ZGVmYXVsdEFjdGlvbnM6IGFzIGRlcHJlY2F0ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2Uv V2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IGNj ZTlhZGJmZTRhZGJjODU2OWRhNmRhZGVkMzVmY2E5YTIyYTViMzkuLmM0MGRkOTI3NTQyMTQ1ZDJl ODcwOGI1ZjY3ODIwYWVjMDhjZjNmNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9j ZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KKysrIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQpAQCAtMTYzNCw2ICsxNjM0 LDExIEBAIC0gKEJPT0wpc2hvdWxkU2hvd0F1dG9tYXRpY0tleWJvYXJkVUkKICAgICBpZiAoX2Zv Y3VzZWRFbGVtZW50SW5mb3JtYXRpb24uaW5wdXRNb2RlID09IFdlYkNvcmU6OklucHV0TW9kZTo6 Tm9uZSAmJiAhR1NFdmVudElzSGFyZHdhcmVLZXlib2FyZEF0dGFjaGVkKCkpCiAgICAgICAgIHJl dHVybiBOTzsKIAorICAgIHJldHVybiBbc2VsZiBfc2hvdWxkU2hvd0F1dG9tYXRpY0tleWJvYXJk VUlJZ25vcmluZ0lucHV0TW9kZV07Cit9CisKKy0gKEJPT0wpX3Nob3VsZFNob3dBdXRvbWF0aWNL ZXlib2FyZFVJSWdub3JpbmdJbnB1dE1vZGUKK3sKICAgICBzd2l0Y2ggKF9mb2N1c2VkRWxlbWVu dEluZm9ybWF0aW9uLmVsZW1lbnRUeXBlKSB7CiAgICAgY2FzZSBXZWJLaXQ6OklucHV0VHlwZTo6 Tm9uZToKICAgICBjYXNlIFdlYktpdDo6SW5wdXRUeXBlOjpEcmF3aW5nOgpAQCAtMTY2NSw3ICsx NjcwLDcgQEAgLSAoQk9PTClfZGlzYWJsZUF1dG9tYXRpY0tleWJvYXJkVUkKIC0gKEJPT0wpX3Jl cXVpcmVzS2V5Ym9hcmRXaGVuRmlyc3RSZXNwb25kZXIKIHsKICAgICAvLyBGSVhNRTogV2Ugc2hv dWxkIGFkZCB0aGUgbG9naWMgdG8gaGFuZGxlIGtleWJvYXJkIHZpc2liaWxpdHkgZHVyaW5nIGZv Y3VzIHJlZGlyZWN0cy4KLSAgICByZXR1cm4gW3NlbGYgc2hvdWxkU2hvd0F1dG9tYXRpY0tleWJv YXJkVUldCisgICAgcmV0dXJuIFtzZWxmIF9zaG91bGRTaG93QXV0b21hdGljS2V5Ym9hcmRVSUln bm9yaW5nSW5wdXRNb2RlXQogI2lmIFVTRShVSUtJVF9LRVlCT0FSRF9BRERJVElPTlMpCiAgICAg ICAgIHx8IF9zZWVuSGFyZHdhcmVLZXlEb3duSW5Ob25FZGl0YWJsZUVsZW1lbnQKICNlbmRpZgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CmluZGV4IDM5MjBhM2QzNGQwYzg5MzEwYWVkOTg2ZGRlZmI2OGU4MzBhOTY2ZGIuLmJkMDY4MTc4 ZGY2OTIwM2UzYzU0NTlhYjgxMzZiMjI5Y2E0ODg0NzcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAxOS0wNS0yMiAgUnlvc3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KKworICAgICAgICBS RUdSRVNTSU9OKHIyNDUxNDgpOiBSZW1vdmluZyBpbnB1dG1vZGU9Im5vbmUiIGRvZXMgbm90IGJy aW5nIHVwIHNvZnR3YXJlIGtleWJvYXJkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xOTgxNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGRlZCBhIHJlZ3Jlc3Npb24gdGVzdC4KKworICAgICAgICAqIGZh c3QvZm9ybXMvaW9zL2lucHV0bW9kZS1yZW1vdmluZy1ub25lLWV4cGVjdGVkLnR4dDogQWRkZWQu CisgICAgICAgICogZmFzdC9mb3Jtcy9pb3MvaW5wdXRtb2RlLXJlbW92aW5nLW5vbmUuaHRtbDog QWRkZWQuCisKIDIwMTktMDUtMjEgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgog CiAgICAgICAgIFJUTC9vdmVyZmxvdyBzY3JvbGwgdGVzdHMgZmFpbCB3aXRoIGFzeW5jIG92ZXJm bG93IGVuYWJsZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9zL2lucHV0 bW9kZS1yZW1vdmluZy1ub25lLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv aW9zL2lucHV0bW9kZS1yZW1vdmluZy1ub25lLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEw MDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iNDVh YzAzY2YzYzdmM2Q1MjVhMGVlOGYzNjBkY2E2ZGVkNWQ5MTljCi0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pb3MvaW5wdXRtb2RlLXJlbW92aW5nLW5vbmUtZXhwZWN0 ZWQudHh0CkBAIC0wLDAgKzEsMTggQEAKK1RoaXMgdGVzdHMgcmVtb3ZpbmcgaW5wdXRtb2RlPSJu b25lIiBmcm9tIGFuIGlucHV0IGVsZW1lbnQgYWZ0ZXIgdGhlIGVsZW1lbnQgd2FzIGZvY3VzZWQu CitUbyBtYW51YWxseSB0ZXN0LCBkZXRhY2ggYSBoYXJkd2FyZSBrZXlib2FyZCBhbmQgdGFwIG9u IHRoZSB0ZXh0IGZpZWxkIGJlbG93LiBUaGUgc29mdHdhcmUga2V5Ym9hcmQgc2hvdWxkIGNvbWUg dXAuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2Fn ZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCisKK0FDVElWQVRFIGlucHV0IHdp dGggaW5wdXRtb2RlPW5vbmUKK1BBU1Mgc3lzdGVtS2V5Ym9hcmRSZWN0LmhlaWdodCBpcyAwCitQ QVNTIGlucHV0LnZhbHVlIGlzICJoZWxsbywiCisKK1JlbW92aW5nIGlucHV0bW9kZT1ub25lCitQ QVNTIHN5c3RlbUtleWJvYXJkUmVjdC5oZWlnaHQgPiAwIGlzIHRydWUKK1BBU1MgaW5wdXQudmFs dWUgaXMgImhlbGxvLCB3b3JsZCIKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKwor VEVTVCBDT01QTEVURQorICAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW9z L2lucHV0bW9kZS1yZW1vdmluZy1ub25lLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2lv cy9pbnB1dG1vZGUtcmVtb3Zpbmctbm9uZS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmVlNmZiNGE0MTE3NjJh NjM4MTkzMjAwMDRlNTdlYThlZjA5M2NlOWIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2Zvcm1zL2lvcy9pbnB1dG1vZGUtcmVtb3Zpbmctbm9uZS5odG1sCkBAIC0wLDAgKzEs NjMgQEAKKzwhRE9DVFlQRSBodG1sPiA8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIHVzZUZsZXhp YmxlVmlld3BvcnQ9dHJ1ZSBdIC0tPgorPGh0bWw+Cis8aGVhZD4KKzxtZXRhIG5hbWU9InZpZXdw b3J0IiBjb250ZW50PSJ3aWR0aD1kZXZpY2Utd2lkdGgsIGluaXRpYWwtc2NhbGU9MSwgdXNlci1z Y2FsYWJsZT1ubyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QuanMi Pjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL3Jlc291cmNlcy91aS1oZWxwZXIuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8aW5wdXQgaW5wdXRtb2RlPSJub25lIj4KKzxz Y3JpcHQ+CisKK2Rlc2NyaXB0aW9uKGBUaGlzIHRlc3RzIHJlbW92aW5nIGlucHV0bW9kZT0ibm9u ZSIgZnJvbSBhbiBpbnB1dCBlbGVtZW50IGFmdGVyIHRoZSBlbGVtZW50IHdhcyBmb2N1c2VkLjxi cj4KK1RvIG1hbnVhbGx5IHRlc3QsIGRldGFjaCBhIGhhcmR3YXJlIGtleWJvYXJkIGFuZCB0YXAg b24gdGhlIHRleHQgZmllbGQgYmVsb3cuIFRoZSBzb2Z0d2FyZSBrZXlib2FyZCBzaG91bGQgY29t ZSB1cC5gKTsKKworanNUZXN0SXNBc3luYyA9IHRydWU7CisKK2NvbnN0IGlucHV0ID0gZG9jdW1l bnQucXVlcnlTZWxlY3RvcignaW5wdXQnKTsKK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICB3 aW5kb3cub25sb2FkID0gcnVuVGVzdDsKK2Vsc2UKKyAgICBpbnB1dC5hZGRFdmVudExpc3RlbmVy KCdjbGljaycsICgpID0+IHRoaXMucmVtb3ZlQXR0cmlidXRlKCdpbnB1dG1vZGUnKSk7CisKK2xl dCBzeXN0ZW1LZXlib2FyZFJlY3Q7Cithc3luYyBmdW5jdGlvbiBydW5UZXN0KCkgeworICAgIGF3 YWl0IFVJSGVscGVyLnNldEhhcmR3YXJlS2V5Ym9hcmRBdHRhY2hlZChmYWxzZSk7CisKKyAgICAv LyBXZSBpbnNlcnQgYSBkdW1teSBpbnB1dCBlbGVtZW50IHRvIGRldGVjdCB3aGVuIHRoZSBrZXli b2FyZCBoaWRlcyBmb3IgYW4gaW5wdXQgZWxlbWVudCB3aXRoIGlucHV0bW9kZT0ibm9uZSIuCisg ICAgY29uc3QgZHVtbXlJbnB1dCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2lucHV0Jyk7Cisg ICAgZG9jdW1lbnQuYm9keS5hcHBlbmRDaGlsZChkdW1teUlucHV0KTsKKyAgICBhd2FpdCBVSUhl bHBlci5hY3RpdmF0ZUVsZW1lbnRBbmRXYWl0Rm9ySW5wdXRTZXNzaW9uKGR1bW15SW5wdXQpOwor CisgICAgZGVidWcoIlxuQUNUSVZBVEUgaW5wdXQgd2l0aCBpbnB1dG1vZGU9bm9uZSIpOworICAg IGlucHV0LmZvY3VzKCk7CisgICAgYXdhaXQgVUlIZWxwZXIuYWN0aXZhdGVFbGVtZW50KGlucHV0 KTsKKyAgICBhd2FpdCBVSUhlbHBlci53YWl0Rm9yS2V5Ym9hcmRUb0hpZGUoKTsKKyAgICBzeXN0 ZW1LZXlib2FyZFJlY3QgPSBhd2FpdCBVSUhlbHBlci5pbnB1dFZpZXdCb3VuZHMoKTsKKyAgICBz aG91bGRCZSgic3lzdGVtS2V5Ym9hcmRSZWN0LmhlaWdodCIsICIwIik7CisKKyAgICBhd2FpdCBV SUhlbHBlci5lbnRlclRleHQoImhlbGxvLCIpOworICAgIHNob3VsZEJlRXF1YWxUb1N0cmluZygi aW5wdXQudmFsdWUiLCAiaGVsbG8sIik7CisKKyAgICBkZWJ1ZygiXG5SZW1vdmluZyBpbnB1dG1v ZGU9bm9uZSIpOworICAgIGlucHV0LnJlbW92ZUF0dHJpYnV0ZSgnaW5wdXRtb2RlJyk7CisKKyAg ICBhd2FpdCBuZXcgUHJvbWlzZSgocmVzb2x2ZSkgPT4geworICAgICAgICB3aW5kb3cudmlzdWFs Vmlld3BvcnQuYWRkRXZlbnRMaXN0ZW5lcigncmVzaXplJywgcmVzb2x2ZSk7CisgICAgICAgIHNl dFRpbWVvdXQocmVzb2x2ZSwgMzAwMCk7IC8vIEZhaWxlZC4KKyAgICB9KTsKKworICAgIHN5c3Rl bUtleWJvYXJkUmVjdCA9IGF3YWl0IFVJSGVscGVyLmlucHV0Vmlld0JvdW5kcygpOworICAgIHNo b3VsZEJlVHJ1ZSgic3lzdGVtS2V5Ym9hcmRSZWN0LmhlaWdodCA+IDAiKTsKKworICAgIGF3YWl0 IFVJSGVscGVyLmVudGVyVGV4dCgiIHdvcmxkIik7CisgICAgc2hvdWxkQmVFcXVhbFRvU3RyaW5n KCJpbnB1dC52YWx1ZSIsICJoZWxsbywgd29ybGQiKTsKKworICAgIGZpbmlzaEpTVGVzdCgpOwor fQorCisvL3NldFRpbWVvdXQoZmluaXNoSlNUZXN0LCA3MDAwKTsKKworPC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg==