198125 2019-05-22 09:25:32 -0700 [WPE] Build fails with ENABLE_VIDEO=OFF and ENABLE_WEB_AUDIO=OFF 2019-05-23 00:29:19 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aperez aperez achristensen bfulgham cdumez commit-queue pnormand pvollan webkit-bug-importer zan oldest_to_newest 1538213 0 aperez 2019-05-22 09:25:32 -0700 Probably this affects the GTK port as well. Build error follows: --- In file included from DerivedSources/WebKit/unified-sources/UnifiedSource-54928a2b-17.cpp:2: ../Source/WebKit/WebProcess/glib/WebProcessGLib.cpp:31:10: fatal error: WebCore/GStreamerCommon.h: No such file or directory #include <WebCore/GStreamerCommon.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 1538219 1 370406 aperez 2019-05-22 09:45:36 -0700 Created attachment 370406 Patch 1538221 2 370406 aperez 2019-05-22 09:48:28 -0700 Comment on attachment 370406 Patch I'll have to update this patch, there is another error after fixing the first one: ../Source/WebKit/UIProcess/glib/WebProcessPoolGLib.cpp:34:10: fatal error: WebCore/GStreamerCommon.h: No such file or directory #include <WebCore/GStreamerCommon.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~ 1538246 3 370416 aperez 2019-05-22 10:24:57 -0700 Created attachment 370416 Patch v2 1538592 4 370416 pnormand 2019-05-23 00:13:49 -0700 Comment on attachment 370416 Patch v2 👍 1538596 5 370416 commit-queue 2019-05-23 00:28:30 -0700 Comment on attachment 370416 Patch v2 Clearing flags on attachment: 370416 Committed r245676: <https://trac.webkit.org/changeset/245676> 1538597 6 commit-queue 2019-05-23 00:28:32 -0700 All reviewed patches have been landed. Closing bug. 1538598 7 webkit-bug-importer 2019-05-23 00:29:19 -0700 <rdar://problem/51058526> 370406 2019-05-22 09:45:36 -0700 2019-05-22 10:24:54 -0700 Patch bug-198125-20190522184534.patch text/plain 1263 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJhMzA3Y2NkYjJjNzE0MjBl OTQzZjcxYWU4MTRjYmQ0YTRmMmZmZGQuLjJlNGIzMjAwMzIwYTk2YTgxMjQ2ZWRjMjE1MWRkMDM3 N2Y5MzM1YjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDUtMjIgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBCdWls ZCBmYWlscyB3aXRoIEVOQUJMRV9WSURFTz1PRkYgYW5kIEVOQUJMRV9XRUJfQVVESU89T0ZGCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgxMjUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nl c3MvZ2xpYi9XZWJQcm9jZXNzR0xpYi5jcHA6IEd1YXJkIHRoZSBpbmNsdXNpb24gb2YKKyAgICAg ICAgR1N0cmVhbWVyQ29tbW9uLmggd2l0aCBVU0UoR1NUUkVBTUVSKS4KKwogMjAxOS0wNS0yMiAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZC4gRml4IEdUSyB1bml0IHRlc3RzIGFmdGVyIHIyNDU1NjUKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9nbGliL1dlYlByb2Nlc3NHTGliLmNwcCBiL1NvdXJjZS9X ZWJLaXQvV2ViUHJvY2Vzcy9nbGliL1dlYlByb2Nlc3NHTGliLmNwcAppbmRleCBlYTBmMTAyODA4 MjgzNDlhOWZmZmNiNGZlOGM0Y2Q4OTcyOTc3MTFiLi41ZWFmOGZjYTg4ZGJmNWZlNTFiNzFjM2Mz ZGIyNWJhNmZmNzNkYTQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvZ2xp Yi9XZWJQcm9jZXNzR0xpYi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2dsaWIv V2ViUHJvY2Vzc0dMaWIuY3BwCkBAIC0yOCw3ICsyOCwxMSBAQAogI2luY2x1ZGUgIldlYlByb2Nl c3MuaCIKIAogI2luY2x1ZGUgIldlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaCIKKworI2lm IFVTRShHU1RSRUFNRVIpCiAjaW5jbHVkZSA8V2ViQ29yZS9HU3RyZWFtZXJDb21tb24uaD4KKyNl bmRpZgorCiAjaW5jbHVkZSA8V2ViQ29yZS9NZW1vcnlDYWNoZS5oPgogCiAjaWYgUExBVEZPUk0o V0FZTEFORCkK 370416 2019-05-22 10:24:57 -0700 2019-05-23 00:28:30 -0700 Patch v2 bug-198125-20190522192456.patch text/plain 1929 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjQ1NjE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDJhMzA3Y2NkYjJjNzE0MjBl OTQzZjcxYWU4MTRjYmQ0YTRmMmZmZGQuLjVmNWI0MjA4NzM3MjE3ZTZjYTk4Y2E5OTRmYzQwMjVl MmFjODgxODkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTktMDUtMjIgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBCdWls ZCBmYWlscyB3aXRoIEVOQUJMRV9WSURFTz1PRkYgYW5kIEVOQUJMRV9XRUJfQVVESU89T0ZGCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xOTgxMjUKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9nbGliL1dlYlByb2Nlc3NQb29sR0xpYi5jcHA6IEd1YXJkIHRoZSBpbmNsdXNpb24gb2YgR1N0 cmVhbWVyQ29tbW9uLmggd2l0aCBVU0UoR1NUUkVBTUVSKS4KKyAgICAgICAgKiBXZWJQcm9jZXNz L2dsaWIvV2ViUHJvY2Vzc0dMaWIuY3BwOiBEaXR0by4KKwogMjAxOS0wNS0yMiAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZC4g Rml4IEdUSyB1bml0IHRlc3RzIGFmdGVyIHIyNDU1NjUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL2dsaWIvV2ViUHJvY2Vzc1Bvb2xHTGliLmNwcCBiL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL2dsaWIvV2ViUHJvY2Vzc1Bvb2xHTGliLmNwcAppbmRleCBiMWUwOTY1MGIwMzE4 MWEyOWE1NzY1MDQ4MDk3NjI5YjFkMzk5ZmQzLi44MWJhYjgyZDcwZTE1NTk1ZGRjNjI3N2JmMGYx YzE5MDA5NmQ2NzYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9nbGliL1dl YlByb2Nlc3NQb29sR0xpYi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvZ2xpYi9X ZWJQcm9jZXNzUG9vbEdMaWIuY3BwCkBAIC0zMSw3ICszMSwxMSBAQAogI2luY2x1ZGUgIldlYk1l bW9yeVByZXNzdXJlSGFuZGxlci5oIgogI2luY2x1ZGUgIldlYlByb2Nlc3NDcmVhdGlvblBhcmFt ZXRlcnMuaCIKICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9SZW1vdGVJbnNwZWN0b3JTZXJ2ZXIu aD4KKworI2lmIFVTRShHU1RSRUFNRVIpCiAjaW5jbHVkZSA8V2ViQ29yZS9HU3RyZWFtZXJDb21t b24uaD4KKyNlbmRpZgorCiAjaW5jbHVkZSA8d3RmL0ZpbGVTeXN0ZW0uaD4KICNpbmNsdWRlIDx3 dGYvZ2xpYi9HVW5pcXVlUHRyLmg+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvV2ViUHJv Y2Vzcy9nbGliL1dlYlByb2Nlc3NHTGliLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9n bGliL1dlYlByb2Nlc3NHTGliLmNwcAppbmRleCBlYTBmMTAyODA4MjgzNDlhOWZmZmNiNGZlOGM0 Y2Q4OTcyOTc3MTFiLi41ZWFmOGZjYTg4ZGJmNWZlNTFiNzFjM2MzZGIyNWJhNmZmNzNkYTQwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvZ2xpYi9XZWJQcm9jZXNzR0xpYi5j cHAKKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2dsaWIvV2ViUHJvY2Vzc0dMaWIuY3Bw CkBAIC0yOCw3ICsyOCwxMSBAQAogI2luY2x1ZGUgIldlYlByb2Nlc3MuaCIKIAogI2luY2x1ZGUg IldlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuaCIKKworI2lmIFVTRShHU1RSRUFNRVIpCiAj aW5jbHVkZSA8V2ViQ29yZS9HU3RyZWFtZXJDb21tb24uaD4KKyNlbmRpZgorCiAjaW5jbHVkZSA8 V2ViQ29yZS9NZW1vcnlDYWNoZS5oPgogCiAjaWYgUExBVEZPUk0oV0FZTEFORCkK