198083 2019-05-21 13:52:32 -0700 Mark WKUIDelegate webView:shouldPreviewElement: and webView:previewingViewControllerForElement:defaultActions: as deprecated 2019-05-21 15:03:31 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen commit-queue dino ggaren webkit-bug-importer oldest_to_newest 1537977 0 achristensen 2019-05-21 13:52:32 -0700 Mark WKUIDelegate webView:shouldPreviewElement: and webView:previewingViewControllerForElement:defaultActions: as deprecated 1537978 1 370339 achristensen 2019-05-21 13:55:19 -0700 Created attachment 370339 Patch 1537982 2 370339 ggaren 2019-05-21 14:14:03 -0700 Comment on attachment 370339 Patch r=me 1538000 3 370339 commit-queue 2019-05-21 15:02:59 -0700 Comment on attachment 370339 Patch Clearing flags on attachment: 370339 Committed r245597: <https://trac.webkit.org/changeset/245597> 1538001 4 commit-queue 2019-05-21 15:03:01 -0700 All reviewed patches have been landed. Closing bug. 1538002 5 webkit-bug-importer 2019-05-21 15:03:31 -0700 <rdar://problem/51002260> 370339 2019-05-21 13:55:19 -0700 2019-05-21 15:02:59 -0700 Patch bug-198083-20190521135518.patch text/plain 4047 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyNDU1OTQpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE5LTA1LTIxICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFyayBXS1VJRGVs ZWdhdGUgd2ViVmlldzpzaG91bGRQcmV2aWV3RWxlbWVudDogYW5kIHdlYlZpZXc6cHJldmlld2lu Z1ZpZXdDb250cm9sbGVyRm9yRWxlbWVudDpkZWZhdWx0QWN0aW9uczogYXMgZGVwcmVjYXRlZAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTk4MDgzCisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS81MDczNTY4Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVn YXRlLmg6CisKIDIwMTktMDUtMjEgIEppZXdlbiBUYW4gIDxqaWV3ZW5fdGFuQGFwcGxlLmNvbT4K IAogICAgICAgICBbV2ViQXV0aE5dIE1ha2UgV2ViQXV0aE4gZGVmYXVsdCBvbiBvbmx5IG9uIG1h Y09TCkluZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvV0tVSURlbGVnYXRl LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLVUlE ZWxlZ2F0ZS5oCShyZXZpc2lvbiAyNDU1NDUpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9B UEkvQ29jb2EvV0tVSURlbGVnYXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyOSw3ICsxMjksNyBA QCBOU19BU1NVTUVfTk9OTlVMTF9CRUdJTgogIFRoaXMgbWV0aG9kIHdpbGwgb25seSBiZSBpbnZv a2VkIGZvciBlbGVtZW50cyB0aGF0IGhhdmUgZGVmYXVsdCBwcmV2aWV3IGluIFdlYktpdCwgd2hp Y2ggaXMKICBsaW1pdGVkIHRvIGxpbmtzLiBJbiB0aGUgZnV0dXJlLCBpdCBjb3VsZCBiZSBpbnZv a2VkIGZvciBhZGRpdGlvbmFsIGVsZW1lbnRzLgogICovCi0tIChCT09MKXdlYlZpZXc6KFdLV2Vi VmlldyAqKXdlYlZpZXcgc2hvdWxkUHJldmlld0VsZW1lbnQ6KFdLUHJldmlld0VsZW1lbnRJbmZv ICopZWxlbWVudEluZm8gV0tfQVBJX0FWQUlMQUJMRShpb3MoMTAuMCkpOworLSAoQk9PTCl3ZWJW aWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3IHNob3VsZFByZXZpZXdFbGVtZW50OihXS1ByZXZpZXdF bGVtZW50SW5mbyAqKWVsZW1lbnRJbmZvIFdLX0FQSV9ERVBSRUNBVEVEKCJUaGlzIEFQSSB3aWxs IGJlIHJlcGxhY2VkIiwgaW9zKDEwLjAsIFdLX0lPU19UQkEpKTsKIAogLyohIEBhYnN0cmFjdCBB bGxvd3MgeW91ciBhcHAgdG8gcHJvdmlkZSBhIGN1c3RvbSB2aWV3IGNvbnRyb2xsZXIgdG8gc2hv dyB3aGVuIHRoZSBnaXZlbiBlbGVtZW50IGlzIHBlZWtlZC4KICBAcGFyYW0gd2ViVmlldyBUaGUg d2ViIHZpZXcgaW52b2tpbmcgdGhlIGRlbGVnYXRlIG1ldGhvZC4KQEAgLTE0NCw3ICsxNDQsNyBA QCBOU19BU1NVTUVfTk9OTlVMTF9CRUdJTgogIFJldHVybmluZyBuaWwgd2lsbCByZXN1bHQgaW4g V2ViS2l0J3MgZGVmYXVsdCBwcmV2aWV3IGJlaGF2aW9yLiB3ZWJWaWV3OmNvbW1pdFByZXZpZXdp bmdWaWV3Q29udHJvbGxlcjogd2lsbCBvbmx5IGJlIGludm9rZWQKICBpZiBhIG5vbi1uaWwgdmll dyBjb250cm9sbGVyIHdhcyByZXR1cm5lZC4KICAqLwotLSAobnVsbGFibGUgVUlWaWV3Q29udHJv bGxlciAqKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgcHJldmlld2luZ1ZpZXdDb250cm9s bGVyRm9yRWxlbWVudDooV0tQcmV2aWV3RWxlbWVudEluZm8gKillbGVtZW50SW5mbyBkZWZhdWx0 QWN0aW9uczooTlNBcnJheTxpZCA8V0tQcmV2aWV3QWN0aW9uSXRlbT4+ICopcHJldmlld0FjdGlv bnMgV0tfQVBJX0FWQUlMQUJMRShpb3MoMTAuMCkpOworLSAobnVsbGFibGUgVUlWaWV3Q29udHJv bGxlciAqKXdlYlZpZXc6KFdLV2ViVmlldyAqKXdlYlZpZXcgcHJldmlld2luZ1ZpZXdDb250cm9s bGVyRm9yRWxlbWVudDooV0tQcmV2aWV3RWxlbWVudEluZm8gKillbGVtZW50SW5mbyBkZWZhdWx0 QWN0aW9uczooTlNBcnJheTxpZCA8V0tQcmV2aWV3QWN0aW9uSXRlbT4+ICopcHJldmlld0FjdGlv bnMgV0tfQVBJX0RFUFJFQ0FURUQoIlRoaXMgQVBJIHdpbGwgYmUgcmVwbGFjZWQiLCBpb3MoMTAu MCwgV0tfSU9TX1RCQSkpOwogCiAvKiEgQGFic3RyYWN0IEFsbG93cyB5b3VyIGFwcCB0byBwb3Ag dG8gdGhlIHZpZXcgY29udHJvbGxlciBpdCBjcmVhdGVkLgogIEBwYXJhbSB3ZWJWaWV3IFRoZSB3 ZWIgdmlldyBpbnZva2luZyB0aGUgZGVsZWdhdGUgbWV0aG9kLgpJbmRleDogU291cmNlL1dlYktp dC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t CShyZXZpc2lvbiAyNDU1NDUpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250 ZW50Vmlld0ludGVyYWN0aW9uLm1tCSh3b3JraW5nIGNvcHkpCkBAIC03MzE1LDcgKzczMTUsOSBA QCAtIChCT09MKV9pbnRlcmFjdGlvblNob3VsZEJlZ2luRnJvbVByZXZpCiAgICAgICAgIGlkIDxX S1VJRGVsZWdhdGVQcml2YXRlPiB1aURlbGVnYXRlID0gc3RhdGljX2Nhc3Q8aWQgPFdLVUlEZWxl Z2F0ZVByaXZhdGU+PihbX3dlYlZpZXcgVUlEZWxlZ2F0ZV0pOwogICAgICAgICBpZiAoW3VpRGVs ZWdhdGUgcmVzcG9uZHNUb1NlbGVjdG9yOkBzZWxlY3Rvcih3ZWJWaWV3OnNob3VsZFByZXZpZXdF bGVtZW50OildKSB7CiAgICAgICAgICAgICBhdXRvIHByZXZpZXdFbGVtZW50SW5mbyA9IGFkb3B0 TlMoW1tXS1ByZXZpZXdFbGVtZW50SW5mbyBhbGxvY10gX2luaXRXaXRoTGlua1VSTDooTlNVUkwg KilsaW5rVVJMXSk7CitBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19CRUdJTgogICAgICAg ICAgICAgcmV0dXJuIFt1aURlbGVnYXRlIHdlYlZpZXc6X3dlYlZpZXcgc2hvdWxkUHJldmlld0Vs ZW1lbnQ6cHJldmlld0VsZW1lbnRJbmZvLmdldCgpXTsKK0FMTE9XX0RFUFJFQ0FURURfREVDTEFS QVRJT05TX0VORAogICAgICAgICB9CiAgICAgICAgIGlmIChsaW5rVVJMLmlzRW1wdHkoKSkKICAg ICAgICAgICAgIHJldHVybiBOTzsKQEAgLTc0NjQsOCArNzQ2NiwxMCBAQCAtIChVSVZpZXdDb250 cm9sbGVyICopX3ByZXNlbnRlZFZpZXdDb250CiAgICAgICAgICAgICAgICAgW3ByZXZpZXdBY3Rp b25zIGFkZE9iamVjdDpwcmV2aWV3QWN0aW9uXTsKICAgICAgICAgICAgIH0KICAgICAgICAgICAg IGF1dG8gcHJldmlld0VsZW1lbnRJbmZvID0gYWRvcHROUyhbW1dLUHJldmlld0VsZW1lbnRJbmZv IGFsbG9jXSBfaW5pdFdpdGhMaW5rVVJMOnRhcmdldFVSTF0pOworQUxMT1dfREVQUkVDQVRFRF9E RUNMQVJBVElPTlNfQkVHSU4KICAgICAgICAgICAgIGlmIChVSVZpZXdDb250cm9sbGVyICpjb250 cm9sbGVyID0gW3VpRGVsZWdhdGUgd2ViVmlldzpfd2ViVmlldyBwcmV2aWV3aW5nVmlld0NvbnRy b2xsZXJGb3JFbGVtZW50OnByZXZpZXdFbGVtZW50SW5mby5nZXQoKSBkZWZhdWx0QWN0aW9uczpw cmV2aWV3QWN0aW9ucy5nZXQoKV0pCiAgICAgICAgICAgICAgICAgcmV0dXJuIGNvbnRyb2xsZXI7 CitBTExPV19ERVBSRUNBVEVEX0RFQ0xBUkFUSU9OU19FTkQKICAgICAgICAgfQogCiAgICAgICAg IGlmIChbdWlEZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3OnBy ZXZpZXdWaWV3Q29udHJvbGxlckZvclVSTDpkZWZhdWx0QWN0aW9uczplbGVtZW50SW5mbzopXSkK